5855 Commits

Author SHA1 Message Date
Zyres
09567e8201 Missing changes for Cata 2023-07-24 10:52:54 +02:00
Zyres
0f8f3a9bca Use RAII for initialisation
* minor changes to pointer storage
2023-07-24 01:50:21 +02:00
Zyres
8564f305f8 Finalized refactor of ObjectMgr files 2023-07-23 18:34:26 +02:00
Zyres
a1326e6106 Run a-style on AchievementMgr files 2023-07-23 12:13:11 +02:00
Zyres
c0b2873b93 Replace "getAllCompleteAchievements" with "isInCompletedAchievements"
* keep the logic of iterating through data where the data belongs.
* Fix worldcrash while log in
2023-07-23 09:27:44 +02:00
Zyres
5816f12fc4 Replace rawptr with shared_ptr in ObjectMgr for LevelInfo/Map 2023-07-23 09:05:31 +02:00
Zyres
364aaf9c70 Replace rawptr with shared_ptr in ObjectMgr for Group
* general cleanup
2023-07-22 15:06:15 +02:00
Zyres
5b5a144be0 More cleanup in ObjectMgr 2023-07-22 12:31:51 +02:00
Zyres
28cfbc35a6 Resvolve compilation for version bc and classic 2023-07-22 08:06:21 +02:00
Zyres
e5e2942aa4 Cleanup ObjectMgr misc functions 2023-07-22 00:17:31 +02:00
Zyres
95996c5885 Achievement stuff in ObjectMgr grouped an tweaked
* we have an AchievementMgr, why does the ObjectMgr do stuff for it? Move it as soo as possible.
2023-07-21 22:36:52 +02:00
Zyres
7004ca570a Resolved missing update for cata/mop 2023-07-21 17:45:30 +02:00
Zyres
9ba9a838c4 Replace rawptr with shared_ptr for class CachedCharacterInfo
* refactor objmgr functions
* remove duplicate storage
* use ranged lock
2023-07-21 16:50:03 +02:00
Zyres
b05eb0ed63 Replace rawptr with shared_ptr for class Corpse
* refactor objmgr corpse functions
* make members private
* use ranged lock
2023-07-21 12:22:53 +02:00
Zyres
3266601f13 Sort misc functions 2023-07-21 09:41:38 +02:00
Zyres
bd9d4db8c0 Replace rawptr with shared_ptr for class Charter
* refactor class files Charter
* refactor objmgr charter functions
* cleanup some duplicate code
2023-07-21 02:40:59 +02:00
Zyres
8ef6fbc122 Replace rawptr with shared_ptr for Class ArenaTeam
* refactor ArenaTeam objmgr function
* declare private members
* general code cleanup
2023-07-20 23:06:05 +02:00
Zyres
f6e9bbaa1b Replace rawptr with shared_ptr for Class Channel
* new and delete gets handled by refCount.
2023-07-20 20:53:19 +02:00
Zyres
e1ef50d67e Revert "Fix no PCH on MSVC"
This reverts commit 6f52a2400d.
2023-07-19 22:36:22 +02:00
Zyres
6f52a2400d Fix no PCH on MSVC 2023-07-19 22:17:27 +02:00
Zyres
a2ab7037a6 Merge branch 'develop' of https://github.com/AscEmu/AscEmu into develop 2023-07-15 11:17:12 +02:00
Zyres
17c168a2cc Fixed wrong msg type for quest 'A Humble Task'
Thanks to @cressidagp
2023-07-15 11:17:06 +02:00
schnek
df31162871 fix clang. (#1119)
* fix clang.

* Update TaxiHandler.cpp
2023-07-14 17:19:18 +02:00
Zyres
2ce69cb0df Update gcc.cmake 2023-07-14 07:00:07 +02:00
Zyres
31feaec51b Change pchWorld.hpp to include local files based on relative location since these files are included relative too
Related to #1111
2023-07-12 08:01:33 +02:00
Zyres
32c2635967 Update pchWorld.hpp 2023-07-12 07:27:03 +02:00
Zyres
b7e2f1b643 Expand pch for world with "latest" additions
Related to #1111
2023-07-12 07:21:13 +02:00
aaron02
f657f0025e Icc Trashmobs (#1118)
* Icc Trash

Improved AI Handling
Targeting Bugfix

* fix build

* Update WorldMap.cpp
2023-07-12 06:46:40 +02:00
Zyres
620cd3f4f3 Move hardcoded aiscripts to database for map 542
Related to #1113
2023-07-11 19:57:26 +02:00
Zyres
3ca9437106 Update README.md 2023-07-11 17:41:04 +02:00
aaron02
7f04b33520 Creature AI Scripts cleanup and added onTaunt (#1116)
* addOnTaunt

* fix aiscripts not casting
2023-07-11 17:22:56 +02:00
Zyres
bcc8537c96 V808 'players' object of 'vector' type was created but was not utilized. Magtheridon.cpp 234
V808 'players' object of 'vector' type was created but was not utilized. LordMarrowgar.cpp 585
V808 'players' object of 'vector' type was created but was not utilized. Saurfang.cpp 1230
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: portalLocation. Portal_Intro.cpp
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: portalLocation. Portal_Elite.cpp 1212
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: portalLocation. Portal_Common.cpp 11
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: mbossId. AzureSaboteur.cpp 13
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: coldflameTarget. LordMarrowgar.cpp 12
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: nextVengefulShadeTargetGUID, waveCounter. LadyDeathwhisper.cpp 12
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: m_ConeOfFireSpell. NazanAndVazruden.cpp 103
2023-07-11 00:03:31 +02:00
Zyres
7793951d37 Move hardcoded aiscripts to database for map 585
Related to #1113
2023-07-10 22:25:57 +02:00
aaron02
e4a5c365e3 Fix Taxi for Cata and above, Fix Pathgenerator for all Versions (#1114)
* Fix Taxi for Cata and above, Fix Pathgenerator for all Versions, Add Flightmovement Generator

* mop build
2023-07-10 18:21:50 +02:00
Zyres
af2017742e Move hardcoded aiscripts to database for map 534
Related to #1113
2023-07-09 11:48:57 +02:00
Zyres
a671a0eb9d Move hardcoded aiscripts to database for map 565
@aaron02  there are some scripts left, check it out maybe we can move them too.
Related to #1113
2023-07-09 10:44:50 +02:00
Zyres
01c34cf071 Move hardcoded aiscripts to database for map 564
@aaron02 can you check pls
2023-07-09 09:47:10 +02:00
Zyres
aee0d46dc3 V547 Expression 'm_deathState != CORPSE' is always false. Creature.cpp 668
V595 The 'itemproto' pointer was utilized before it was verified against nullptr. Check lines: 590, 598. LootMgr.cpp 590
V595 The 'm_WorldMap' pointer was utilized before it was verified against nullptr. Check lines: 2006, 2030. Creature.cpp 2006
V595 The 'unitOwner' pointer was utilized before it was verified against nullptr. Check lines: 429, 459. Summon.cpp 429
2023-07-09 00:11:28 +02:00
Zyres
e0573bfae9 V522 There might be dereferencing of a potential null pointer 'gameobject'. Player.cpp 8912
V522 There might be dereferencing of a potential null pointer 'unit'. Player.cpp 11456
V560 A part of conditional expression is always true: qst_giver. Player.cpp 8676
V560 A part of conditional expression is always true: player. Player.cpp 10034
2023-07-08 19:57:44 +02:00
Zyres
d4ca6cc8fb V522 Dereferencing of the null pointer 'm_duelPlayer' might take place. Player.cpp 11929
V595 The 'm_Unit->getWorldMap()' pointer was utilized before it was verified against nullptr. Check lines: 2963, 2988. AIInterface.cpp 2963
2023-07-08 19:50:53 +02:00
Zyres
4645858346 V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting third argument of the function sendChatMessage. AIInterface.cpp 1532
V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting third argument of the function sendChatMessage. AIInterface.cpp 3746
V811 Decreased performance. Excessive type casting: string -> char * -> string. Consider inspecting third argument of the function sendChatMessage. AIInterface.cpp 3849
V823 Decreased performance. Object may be created in-place in the 'm_specs[s].talents' container. Consider replacing methods: 'insert' -> 'emplace'. Player.cpp 14462
V823 Decreased performance. Object may be created in-place in the 'mAISpellEmote' container. Consider replacing methods: 'push_back' -> 'emplace_back'. AIInterface.cpp 3736
V836 Expression's value is copied at the 'wayPoint' variable declaration. The variable is never modified. Consider declaring it as a reference. AIInterface.cpp 3381
V836 Expression's value is copied at the 'wayPoint' variable declaration. The variable is never modified. Consider declaring it as a reference. AIInterface.cpp 3429
V836 Expression's value is copied at the 'cd' variable declaration. The variable is never modified. Consider declaring it as a reference. SmsgInitialSpells.h 100
2023-07-08 19:42:38 +02:00
Zyres
174a14ccde V1037 Two or more case-branches perform the same actions. Check lines: 379, 400 Pet.cpp 379
V1037 Two or more case-branches perform the same actions. Check lines: 145, 388 Pet.cpp 145 @Appled
V1037 Two or more case-branches perform the same actions. Check lines: 308, 370 Pet.cpp 308
V1037 Two or more case-branches perform the same actions. Check lines: 1723, 1734, 1740 Pet.cpp 1723
V1037 Two or more case-branches perform the same actions. Check lines: 1731, 1737 Pet.cpp 1731
V560 A part of conditional expression is always true: unitMapMgr. AIInterface.cpp 3019
V560 A part of conditional expression is always true: ssvrow. Player.cpp 6711
2023-07-08 19:37:35 +02:00
Zyres
e41385d6b1 V547 Expression 'm_deathState != CORPSE' is always false. Creature.cpp 668
V730 Not all members of a class are initialized inside the constructor. Consider inspecting: isStatic. ObjectMgr.h 95
V595 The 'target' pointer was utilized before it was verified against nullptr. Check lines: 2097, 2114. AIInterface.cpp 2097
V523 The 'then' statement is equivalent to the 'else' statement. AIInterface.cpp 2438 @aaron02
V547 Expression 'm_deathState != CORPSE' is always false. Pet.cpp 613
V781 The value of the 'faction' variable is checked after it was used. Perhaps there is a mistake in program logic. Check lines: 11412, 11416. Player.cpp 11412
2023-07-08 19:02:03 +02:00
Zyres
afc5e9072f Check and defaults for min/maxdamage
Related to #1104
2023-07-08 16:21:57 +02:00
Zyres
cd5015c912 Changed attacktime in creature_properties for 0 - default now 2000
Related to #1105
change failure to debug flags.
2023-07-08 16:15:07 +02:00
Zyres
761ef69c43 Update config.yml 2023-07-08 15:46:41 +02:00
schnek
5ead53a1ed Fix SRC_TBC_SHADOWLABYRINTH_SCRIPTS_FILES (not added) (#1110)
* Fix SRC_TBC_SHADOWLABYRINTH_SCRIPTS_FILES (not added)

fix Installing ./libmysql.lib
Delete USE_PCH_INCLUDES
Revert unset()
language version must be global 😉

* Update CheckSystem.cmake
2023-07-08 15:14:06 +02:00
Zyres
40939e5c75 Merge pull request #1109 from schnek/fix_cmake
Fix cmake // Fix: #1108
2023-06-01 18:39:08 +02:00
schnek
296b3f03cd Cleanup/Refactor of CMake - enabled #include
Slight Cleanup/Refactor of CMake Setup
Fix error: invalid argument '-std=c++2a' not allowed with 'C'
Fix https://github.com/AscEmu/AscEmu/issues/1108
Fix github build
2023-05-30 09:34:26 +03:00
Zyres
8e8020fef5 Merge pull request #1107 from aaron02/fixprofessions
Fix Crash on Learning from Trainers
2023-05-23 18:24:48 +02:00