Shauren
cf62d7b776
Core/Items: Implemented spell penetration stat on items and use it from enchantments, original patch by zergtmn
2010-12-31 22:59:36 +01:00
Machiavelli
8ab453b465
Missing changes from 72a115f242
2010-12-31 18:24:35 +01:00
QAston
42d3130a56
Core/Auras:
...
Fix a crash with spell 33499 - BIG thanks to Shauren for finding the reason of this crash
Corrections in managing stacked auras which change unit model.
2010-12-31 18:12:20 +01:00
QAston
1b18a0ac65
Core/Auras: Fix aura positivity check after rev bb4bd46d21.
2010-12-31 16:12:29 +01:00
QAston
dd5a77bebc
Core/Auras: Recheck aura presence on target after calling linked events in charm and vehicle aura effect handlers.
2010-12-31 15:37:44 +01:00
QAston
c220fbbc45
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2010-12-31 12:52:37 +01:00
QAston
bb4bd46d21
Core/Auras: Do not recheck aura positivity every aura effect apply/remove.
2010-12-31 12:50:17 +01:00
j4r0d
2cb1987a0a
Core/Spells: Fix Sacred Shield proccing on attacker
...
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com >
2010-12-31 00:10:49 +01:00
Machiavelli
9c7c62cc5e
Core/Vehicles: Send transport X,Y,Z offsets as floats instead of uint32, fixes a possible client crash.
...
Thanks to j4r0d
2010-12-30 23:40:20 +01:00
QAston
6c56f9e1b7
Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
2010-12-30 19:47:28 +01:00
QAston
3fc69f8619
Core/Spells: Remove some incanter's absorbtion code forgotten in previous rev.
2010-12-30 19:44:13 +01:00
Machiavelli
fe8c893273
Merge branch 'master' of github.com:TrinityCore/TrinityCore
2010-12-30 19:11:36 +01:00
Machiavelli
948a2136c4
Core/Vehicles: - Redefine VEHICLE_SEAT_FLAG_USABLE as VEHICLE_SEAT_FLAG_CAN_ENTER_OR_EXIT. This flag determines whether or not the player has control over entering/exiting a vehicleseat. Thanks to linencloth for help with research.
...
- Implement VEHICLE_SEAT_FLAG_CAN_ENTER_OR_EXIT exit restriction
- Remove MOVEMENTFLAG_ROOT on vehicle exit
2010-12-30 19:10:46 +01:00
QAston
8cd2c73e45
Core/ScriptSystem: Add OnEffectManaShield and AfterEffectManaShield hooks to AuraScript class. Usage of these is the same as similar Absorb hooks.
...
Scripts: Move Incanter's Absorbtion script from Unit::CalcAbsorbResist to AuraScript.
2010-12-30 19:05:19 +01:00
QAston
c8adcc95f9
Core/Unit: Move spell specific code from Unit::CalcAbsorbResist to AuraScripts.
2010-12-30 02:03:46 +01:00
Machiavelli
1f7e888465
Core/Units: Units shouldn't be able to dodge while casting
2010-12-29 14:37:55 +01:00
Machiavelli
68c6189201
Core/Vehicles:
...
- Set MovementFlagsExtra (2) correctly depending on vehicle 'template' flags. This makes certain vehicles such as demolishers unable to jump/strafe (as intended)
- Fix SMSG_MONSTER_MOVE_TRANSPORT stucture, prevents a client crash when entering certain vehicles, as well as *properly* broadcast position relative to the vehicle.
- Send SMSG_BREAK_TARGET to player when entering vehicle.
- Set MOVEMENTFLAG_ROOT on passenger when entering vehicle
- Cleanup in affected code
2010-12-29 05:45:38 +01:00
Shauren
52620db629
Core/Auras: Fixed enchant proc stack rules
...
Closes issue #5222 .
--HG--
branch : trunk
2010-12-27 22:27:11 +01:00
QAston
ef968f4b15
Core/Unit: Big cleanup in Unit::CalcAbsorbResist
...
Core/AuraScript:
Fix compile time check for AuraScript functions
Remove AuraApplication from hook functions parameter list, use GetTarget() and GetTargetApplication() instead
Add OnEffectAbsorb hook
Scripts: move handlers of Spell Deflection, Savage Defense, Primal Tenacity, Nerves of Steel, Astral shift from core to scripts.
--HG--
branch : trunk
2010-12-27 20:14:54 +01:00
Machiavelli
dd745ef326
Core/Vehicles: Some research on VehicleSeatFlagsB.
...
It is assumed that VehicleSeatFlagsB & 322 means the seat can be used indirectly (ie. by aura 236 (SPELL_AURA_CONTROL_VEHICLE)) even though !(VehicleSeatFlags & VEHICLE_SEAT_FLAG_USABLE).
More research to be done Soon (tm).
--HG--
branch : trunk
2010-12-27 16:55:17 +01:00
click
29d5e4e4d5
Core: Remove a useless log-error in Unit::BuildMovementPacket()
...
--HG--
branch : trunk
2010-12-26 00:38:01 +01:00
QAston
f4e46db38a
Core/Auras: Add some asserions to hunt down reason of a crash in Aura::UpdateTargetMap. Thanks to Shauren for inspiration.
...
--HG--
branch : trunk
2010-12-26 00:14:13 +01:00
Machiavelli
70ec4a8f9b
Fix build
...
--HG--
branch : trunk
2010-12-25 20:12:31 +01:00
Machiavelli
06d014f04d
Core/Spells: Remove double initialization of ¨GetAuraEffectsByType(SPELL_AURA_MOD_DAMAGE_PERCENT_DONE)¨ in Unit::MeleeDamageBonus
...
Patch by gianni.elio@hotmail.it
Fixes issue #5269
--HG--
branch : trunk
2010-12-25 20:04:12 +01:00
QAston
bce9b081ec
Core/Unit: Fix crashes in Unit::CalcAbsorbResist and Unit::DealDamage caused by unsafe iteration over Unit::AuraEffectList - copy the list instead of using oryginal one.
...
--HG--
branch : trunk
2010-12-25 16:12:31 +01:00
click
b181ba21d9
Core: Fix a few warnings here and there.
...
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
click
088ed9404b
Core/Entities: Fix a minor disrepancy in the handling of weapon specializations introduced in revision a83f26ef71 - patch by Dr.Tenma
...
Fixes issue 5059.
Fixes issue 5265.
--HG--
branch : trunk
2010-12-25 04:03:04 +01:00
Shauren
928443d899
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
...
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
click
ca78881c63
Core/Spells: Fix a warning in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE (explicitly define which parts to check for)
...
--HG--
branch : trunk
2010-12-23 18:35:43 +01:00
Machiavelli
0cdc4153d8
Core/Spells: Fix Glyph of Death Grip
...
Fixes issue #4608
--HG--
branch : trunk
2010-12-23 17:38:31 +01:00
Machiavelli
392a312c6b
Core/Spells: Fix SPELL_AURA_MOD_DAMAGE_PERCENT_DONE(79) to affect proper spellschools based on EffectMiscValue.
...
Author: Dr.Tenma
Fixes issue #4019
Fixes issue #5059
--HG--
branch : trunk
2010-12-23 16:22:30 +01:00
click
b1ded4bd98
Core/Unit: Check if NPC is on a transport before sending StopMoving() -packet (normally shipped when trying to speak to moving NPCs) - fixes creatures falling off boats etc.
...
Thanks to Socolin for hunting down and patching this annoying bug.
--HG--
branch : trunk
2010-12-22 21:31:52 +01:00
Shauren
0f3b9019a8
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
...
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
Shauren
7b4e1c6387
Core/ObjectMgr: Static members are no longer accessed through singleton
...
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
Shauren
5809c1fa3b
Core/Auras: Fixed auras incorrectly stacking with different item casters introduced in r19f21916a940
...
Closes issue #5218 .
--HG--
branch : trunk
2010-12-21 11:40:20 +01:00
Shauren
e3e77aceab
Scripts/Temple of Anh'Qiraj: Fixed possible crash in mob_anubisath_sentinel
...
--HG--
branch : trunk
2010-12-20 11:39:12 +01:00
Shauren
756ee5832b
Core/Auras: Allow stacking of auras proced from different items
...
Closes issue #2296 .
--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
Machiavelli
33808ab567
Core/Spells: Fix Improved Spirit Tap proc from Mind Flay crits.
...
Author: Dr.Tenma
Fixes issue #2786
--HG--
branch : trunk
2010-12-20 01:58:15 +01:00
linencloth
59da698189
Core: Rename spell attributes, use more general names
...
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
Shauren
7196b880d6
Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
...
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor
Closes issue #5132 .
Closes issue #5134 .
--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
Machiavelli
57132e35b8
Core/Spells: Fix spells 59915 and 59906 / Discerning Eye of the Beast and Swift Hand of Justice (Heirloom trinkets)
...
Fixes issue #2435
Fixes issue #2529
--HG--
branch : trunk
2010-12-18 12:27:40 +01:00
Machiavelli
32d94ed52a
Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies.
...
Author: Iskander
Fixes issue #3897
--HG--
branch : trunk
2010-12-17 20:31:46 +01:00
click
0785ad465b
Core/Pets: Clean up logic/codedesign slightly for XP/levelup-handling, and also fix a possible overflow in the pet level-tests
...
(Thanks to Vladimir for the discussion regarding the possible overflow!)
--HG--
branch : trunk
2010-12-17 20:08:27 +01:00
Shauren
b11e5bbf81
Core/Achievements: Prevent ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates at login
...
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL_AT_AREA
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_TEAM_RATING
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_REACH_TEAM_RATING
Core/Achievements: Implemented map id requirement for achievement criterias
Closes issue #4479 .
Closes issue #4478 .
Closes issue #4473 .
Closes issue #4472 .
Closes issue #4471 .
Closes issue #4480 .
Closes issue #2284 .
Closes issue #4481 .
--HG--
branch : trunk
2010-12-17 18:12:46 +01:00
Shauren
82f45966fc
Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
...
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)
--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
click
a6df53bbe2
Core/Spells: Fix erraneous behaviour on hunter spell Lock and Load (disable charge-drop) - thanks to Dr. Tenma
...
Closes issue 3307
--HG--
branch : trunk
2010-12-17 04:52:17 +01:00
click
2642894342
Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
...
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.
--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
azazel
d2d62eab50
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
...
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.
--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
click
81db111ffd
Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma
...
Fixes issue 2715.
Closes issue 3770.
--HG--
branch : trunk
2010-12-11 12:00:57 +01:00
azazel
e7eb4e22e2
Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
...
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00