Commit Graph

778 Commits

Author SHA1 Message Date
Vincent-Michael
6f38fb1011 Core: Fix some code style 2012-09-07 02:21:38 +02:00
cyberbrest
aed0ecd2e4 Core/Conditions: Allow multiple condition for spellclick source type
Currently unused in 335 but required for some 434 spellclicks
2012-09-06 20:03:21 +01:00
Vincent-Michael
9f09713b3e Core/Spells: fix extra damage from crits for talents and equipment effects Closes #6647 2012-09-06 11:14:37 -04:00
kaelima
7c971be3c5 Core/Misc: Fix some warnings and logic mistakes found by static code analysis 2012-09-05 17:18:05 +02:00
Shocker
ed6b58b17d Core/Spells: Avoid unnecessary code execution for SPELL_ATTR3_NO_DONE_BONUS 2012-09-05 00:13:43 +03:00
Vincent-Michael
de15f70501 Core: Fix build 2012-09-04 22:39:04 +02:00
Nay
b4bc78e24b Corrections to previous merged in PR 2012-09-04 19:48:29 +01:00
e
1695f78c9f Fix codestyle per Vincent-Michael 2012-09-04 13:04:30 -04:00
e
1e2ee2d680 [Unit::SetCharm] Restore original walking state when removing charm. Fixes mind control + walk bug. 2012-09-04 13:00:08 -04:00
Kandera
a1e3758484 Core/Reputation: fix forced reputation auras with neutral. closes #5790 2012-09-04 11:11:15 -04:00
Myran2
4bc983d7b7 Core/Commands: Fix .cheat kill and add instakill immunity to it
Closes #7586
2012-09-01 00:36:26 +01:00
Nay
e3d9768a50 Core: Fix many "errors"/warnings and coding style (3)
Game

Errors were found using Cppcheck, open-source static analysis tool
2012-08-30 22:44:33 +01:00
Kandera
b9f60fe56c Core/Wintergrasp: finish implementation for battlefields. this is highly experimental enable at you're own risk. will almost definatly cause issues with the wintergrasp patch floating around 2012-08-20 16:23:24 -04:00
Manuel Carrasco
d7a7a9800b Battlefield: Make sBattlefieldMgr a pointer. By Subv. 2012-08-20 13:48:47 -04:00
Spp
55ce180f28 Core/Logging: Add Asyncronous logging with Loggers ("What to log") and Appenders ("Where to log") system. Will allow to select to full log some parts of core while others are not even logged.
- Logging System is asyncronous to improve performance.
- Each msg and Logger has a Log Type and Log Level assigned. Each msg is assigned the Logger of same Log Type or "root" Logger is selected if there is no Logger configured for the given Log Type
- Loggers have a list of Appenders to send the msg to. The Msg in the Logger is not sent to Appenders if the msg LogLevel is lower than Logger LogLevel.
- There are three (at the moment) types of Appenders: Console, File or DB (this is WIP, not working ATM). Msg is not written to the resource if msg LogLevel is lower than Appender LogLevel.
- Appender and Console Log levels can be changed while server is active with command '.set loglevel (a/l) name level'

Explanation of use with Sample config:

Appender.Console.Type=1       (1 = Console)
Appender.Console.Level=2      (2 = Debug)

Appender.Server.Type=2        (2 = File)
Appender.Server.Level=3       (3 = Info)
Appender.Server.File=Server.log

Appender.SQL.Type=2           (2 = File)
Appender.SQL.Level=1          (1 = Trace)
Appender.SQL.File=sql.log

Appenders=Console Server      (NOTE: SQL has not been included here... that will make core ignore the config for "SQL" as it's not in this list)

Logger.root.Type=0            (0 = Default - if it's not created by config, server will create it with LogLevel = DISABLED)
Logger.root.Level=5           (5 = Error)
Logger.root.Appenders=Console

Logger.SQL.Type=26            (26 = SQL)
Logger.SQL.Level=3            (2 = Debug)
Logger.SQL.Appenders=Console Server SQL

Logger.SomeRandomName.Type=24 (24 = Guild)
Logger.SomeRandomName.Level=5 (5 = Error)
Loggers=root SQL SomeRandomName

* At loading Appender SQL will be ignored, as it's not present on "Appenders"

* sLog->outDebug(LOG_FILTER_GUILD, "Some log msg related to Guilds")
  - Msg is sent to Logger of Type LOG_FILTER_GUILD (24). Logger with name SomeRandomName is found but it's LogLevel = 5 and Msg LogLevel=2... Msg is not logged

* sLog->outError(LOG_FILTER_GUILD, "Some error log msg related to Guilds")
  - Msg is sent to Logger of Type LOG_FILTER_GUILD (24). Logger with name SomeRandomeName is found with proper LogLevel but Logger does not have any Appenders assigned to that logger... Msg is not logged

* sLog->outDebug(LOG_FILTER_SQL, "Some msg related to SQLs")
  - Msg is sent to Logger SQL (matches type), as it matches LogLevel the msg is sent to Appenders Console, Server and SQL
    - Appender Console has lower Log Level: Msg is logged to Console
    - Appender Server has higher Log Level: Msg is not logged to file
    - Appender SQL has lower Log Level: Msg is logged to file sql.log

* sLog->outDebug(LOG_FILTER_BATTLEGROUND, "Some msg related to Battelgrounds")
  - Msg is sent to Logger root (Type 0) as no Logger was found with Type LOG_FILTER_BATTLEGROUND (13). As Logger has higher LogLevel msg is not sent to any appender

* sLog->outError(LOG_FILTER_BATTLEGROUND, "Some error msg related to Battelgrounds")
  - Msg is sent to Logger root (Type 0) as no Logger was found with Type LOG_FILTER_BATTLEGROUND (13). Msg has lower LogLevel and is sent to Appender Console
    - Appender Console has lower LogLevel: Msg is logged to Console
2012-08-03 14:20:18 +02:00
Nay
94e6f9c58c Merge pull request #7115 from Vincent-Michael/BaubleOfTrueBlood
Core/Spells: Fix Bauble of True Blood crit heal
Closes #6151
2012-07-29 09:06:52 -07:00
Shauren
1fd37ac61b Core/Object: Use updatefield flags extracted from client to determine whether to send or not a field value instead of sending all data to client for non-player objects 2012-07-22 14:20:26 +02:00
kandera
061439d112 Core/Spells: fix typo from king of the jungle 2012-07-17 13:55:50 -03:00
Vincent-Michael
8f6619ff9c Core/Spells: Fix Bauble of True Blood crit heal 2012-07-17 12:49:06 +02:00
Kandera
1036b0863b Core/Spells: fix proc for king of the jungle talent. closes #5983 2012-07-13 10:48:06 -04:00
Kandera
fc62678a45 Core/Spells: correct sanctified wrath damage calculations. 2012-07-09 09:18:51 -04:00
Shauren
96014a70cb Core/Units: Fixed crash added in 7f960fed73 2012-07-03 11:45:19 +02:00
Subv
d28f348caf Core/Spells: Removed some old code that was breaking Grounding Totem.
Please report feedback
2012-07-02 18:53:14 -05:00
Subv
1292b732f7 Core/Spells: Fixed Evasive Maneuvers and Stop Time, spells from the Oculus drakes.
Closes #6670
Closes #6675
2012-07-02 16:41:25 -05:00
Kandera
c49bc934b8 Core/Spells: correctly get magnet target. (subv fixed it) Closes #6674 2012-07-02 15:01:39 -04:00
Kandera
93cec76cdb Core/Spells: small change for previous commit. fixes typos 2012-07-02 11:33:12 -04:00
Kandera
7f960fed73 Core/Spells: fix damage bonus calculations for sanctified wrath talent. 2012-07-02 10:09:41 -04:00
Subv
8eba4aebfb Core/Units: Removed deprecated code 2012-07-01 18:29:59 -05:00
Elron103
dfdbc91e90 Core/Spells: Fix spell casting time reduce / increase effects for players and creatures 2012-06-29 00:11:05 +02:00
Vincent-Michael
ef4d9dd4ae Core/Spells:
* Fix bloodthirst Heal
* Move bloodthirst damage calculation in Spell script
* Fix some codestyle
2012-06-20 18:06:29 +02:00
Discover-
e190a202ca Core/CreatureAI: Implement an OnSpellClick hook instead of the ugly way that uses DoAction with EVENT_SPELLCLICK.
Core/SmartAI: Implement SMART_EVENT_ON_SPELLCLICK. Parameter is the clicker.

If someone could update the wiki accordingly for SAI I would appreciate that. Thanks to @Shauren for some help!
2012-06-19 00:07:20 +02:00
QAston
a9b6a0c103 Merge pull request #6827 from drskull/master
Core/Spells: Small fix IsImmunedToSpell
2012-06-17 15:20:38 -07:00
dr.skull
b5a072855e Fix added check for IsImmunedToSpell
Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-06-17 23:19:32 +02:00
dr.skull
3f8efb21cd add IsEffect() check to correct IsImmunedToSpell
Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-06-17 02:23:47 +02:00
Elron103
3164ba627b Core/Combat: Fix CanAIAttack implementation 2012-06-16 20:55:07 +02:00
QAston
e53b44b6ba Merge pull request #6491
Core/Spells: convert some spell effects to SpellScripts
Closes #6491
2012-06-14 19:12:03 +02:00
dr.skull
63dd625154 Fix wrong magnet aura takeCharges when spell hit not magnet unit
This will fix issue 3151 second problem

Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-06-14 00:40:33 +02:00
Kandera
5daa540d3a Core/Spells: handle SPELL_AURA_MOD_DEBUFF_RESISTANCE only for auras. fixes sacred cleansing causing the whole spell to be resisted. 2012-06-13 12:34:59 -04:00
kandera
41d2de2ca3 Core/Spells: fix addition of unit_state_casting. thx vincent-michael 2012-06-10 16:10:43 -03:00
Kandera
643b68926e Core/Spells: codestyle and fix logic for adding unit state casting. (thx Moriquendu) 2012-06-08 08:56:56 -04:00
Kandera
f92ae93806 Core/Spells: fix crash introduced in d719730929 (thx vincent-michael) 2012-06-07 14:48:43 -04:00
Kandera
d719730929 Core/Spells: do not apply unit_state_casting for instant cast spells. 2012-06-07 12:02:06 -04:00
Shauren
2c153b8a43 Core/Movement: Fixed Unit::SetFacingTo 2012-06-07 15:02:51 +02:00
Shauren
810f21efbc Core/Movement
* Moved enter/exit vehicle packets to spline.
* Fixed spline movement on transports such as elevators (for which we do not keep track of its exact position) - path will be using normal coordinates (not transport offsets)
2012-06-06 20:36:34 +02:00
Vincent-Michael
79e00cfcbe Core/Movement: Add missing SplineFlags / SplineTypes to enums 2012-06-02 19:14:19 +02:00
Shauren
f5ab1a3a5c Core/Movement: Fixed Unit::StopMoving() 2012-05-31 23:04:09 +02:00
Shauren
425eeb8280 Core/Movement
* Implemented creature movement on transports
* Set minimum speed for creature allowed to start movement (too low speed leads to overflows in movement time calculations which in turn leads to crashes)
2012-05-31 19:45:11 +02:00
joschiwald
cd7ab6f3a5 Merge branch 'master' of github.com:joschiwald/TrinityCore into spellscripts
Conflicts:
	src/server/game/Entities/Unit/Unit.cpp
	src/server/game/Spells/Auras/SpellAuraEffects.cpp
	src/server/game/Spells/Spell.cpp
	src/server/game/Spells/SpellEffects.cpp
	src/server/scripts/Spells/spell_paladin.cpp
2012-05-28 04:27:51 +02:00
joschiwald
ca07f30d03 Core/Spells: convert some spell effects to SpellScripts 2012-05-28 04:07:51 +02:00
kaelima
f424052f82 Core/Spells: Make spellclick spells non triggered 2012-05-23 14:28:38 +02:00