Fix cert bundle/chain version checks for 1.14.x and 3.4.2 or later

This commit is contained in:
Fabian
2023-05-21 16:15:37 +00:00
parent 221438ce2d
commit 8794a0c512
2 changed files with 6 additions and 5 deletions

View File

@@ -8,11 +8,12 @@ A game launcher for World of Warcraft that allows you to connect to custom serve
Please see our Open Source project [Documentation Repo](https://github.com/Arctium/Documentation)
### IMPORTANT NOTE FOR LOCAL DEVELOPMENT & SERVER CONNECTIONS
#### Applies to: 3.4.2 or later, 10.1.5 or later
* LOCAL HOSTNAME & IP: `USE` the `--dev` command line parameter to to avoid issues with invalid certificate chains.
* EXTERNAL HOSTNAME:
* `DO NOT` use the `--dev` command line parameter.
* `USE` a valid certificate matching your authentication/bnet server host name.
* That certificate needs to be loaded by the authentication/bnet server too.
* `DO NOT` use the `--dev` command line parameter.
* `USE` a valid certificate matching your authentication/bnet server host name.
* That certificate needs to be loaded by the authentication/bnet server too.
* EXTERNAL IP: `NOT SUPPORTED`
### Binary Releases

View File

@@ -139,7 +139,7 @@ static class Launcher
// We need to cache this here since we are using our RSA modulus as auth seed.
var modulusOffset = memory.Data.FindPattern(Patterns.Common.SignatureModulus);
if (clientVersion is (9, 2, 7, _) or (3, _, _, _) or (10, <= 1, _, _) and not (10, 1, 5, _))
if (clientVersion is (1, >= 14, _, _) or (3, 4, <= 1, _) or (9, _, _, _) or (10, <= 1, _, _) and not (10, 1, 5, _))
{
Task.WaitAll(new[]
{
@@ -169,7 +169,7 @@ static class Launcher
WaitForUnpack(ref processInfo, memory, ref mbi, gameAppData);
#if x64
if (clientVersion is (9, 2, 7, _) or (3, _, _, _) or (10, <= 1, _, _) and not (10, 1, 5, _))
if (clientVersion is (1, >= 14, _, _) or (3, 4, <= 1, _) or (9, _, _, _) or (10, <= 1, _, _) and not (10, 1, 5, _))
{
Task.WaitAll(new[]
{