Commit Graph

511 Commits

Author SHA1 Message Date
Spp-
3fac9914be Core: Code cleanup (here and there) 2011-09-05 14:01:50 +02:00
hacknowledge
9d85446e30 Core/Spells: Fixed misdirection ability of hunters to end 4 seconds after first damage proc - fixes #114 2011-09-03 18:26:39 +02:00
sarjuuk
b40bf69319 [Core/Threat] SpellThreat-Calculation revamped
short:
  - Threat is now distributed blizzlike (almost)

long:
  - Percent- and AP-Modifieres got add
  - Threat is now propperly distributed through multiple enemies
  - Most spells will cause initial threat in an amount equal to their SpellLevel
  - Energize-Effects will now be treated like healing (threat-wise)
  - Tanks got their missing +43% passive threat tacked on
  - Paladins are still missing 'Salvation' and will not only cause half threat with healing (essentially 25% of the amount healed)
2011-09-03 17:42:44 +02:00
QAston
ac9701afa7 Merge pull request #2762 from Kapoeira/master
Core/Spells: Prevent deterrance from parrying spells that require the attacker to be behind the hunter, like Shred or Ambush.
2011-08-31 11:24:45 -07:00
Spp-
aa85553bfd Core: Crash fix (TemporarySummon), remove some warnings and some other minor changes
- "const uint64" and "uint64 const" --> uint64
 - Add some info in LFGDungeonEntry
 - Move some definitions from ".h" files and move to ".cpp"
2011-08-30 13:46:36 +02:00
Shauren
240534ba2f Scripts/Icecrown Citadel: Removed crashing script for Expunged Gas and moved it to where it belongs - proc system 2011-08-29 13:17:08 +02:00
Cron
04d1bdf69c Core/Spells: Prevent deterrance from parrying spells that require the attacker to be behind the hunter, like Shred or Ambush. 2011-08-26 10:33:41 -03:00
QAston
2ee88d76da Core/Spells: remove one obsolete spell proc target check. 2011-08-26 12:48:12 +02:00
QAston
8e392440cf Core/Spells: Fix a regression of 7f30ac5a95 - spells with TARGET_SELECT_CATEGORY_CHANNEL target type (like mind sear) should be triggered by triggering spell caster 2011-08-26 12:39:50 +02:00
Spp-
85164d2876 Core: Some cosmetic changes and minor optimizations 2011-08-26 09:41:33 +02:00
QAston
c0f3122b9c Fix build after revert. 2011-08-25 08:01:56 +02:00
QAston
62d913bb35 Revert "Core/Spells: Also Death Runes itself should be able to turn into a Death Rune. They should not turn back into their original rune when using a spell that turns the used runes into Death Runes." - it is causing crashes.
This reverts commit 17b89ea8ab.
2011-08-25 06:40:56 +02:00
QAston
b69330676d Merge pull request #2588 from hacknowledge/fix_2488
Crashfix. Added missing check for NULL of victim parameter
2011-08-24 10:02:26 -07:00
QAston
0365feb069 Core/Entities: Make dead units not targetable for attack again (after fc5e924138). 2011-08-23 14:47:26 +02:00
QAston
8e8fa083b2 Merge pull request #2636 from LihO/master
Core/Auras: Check amount of total ticks to avoid division by zero (and crash) in Unit::GetRemainingPeriodicAmount.
2011-08-21 00:58:55 -07:00
Chaplain
4b56226619 Core/Spell: case TOTAL_PCT\BASE_PCT should be processed by multiplicative function not additive.
Also get ride of hack in Player::HandleBaseModValue now it's unnecessary.
Fixes: #855, multiplicative % count for normal school for aura 79 and may be others.
2011-08-20 13:38:20 +03:00
QAston
e2d8faea09 Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts. 2011-08-20 00:30:38 +02:00
tobmaps
e1e91bacbe Core/Spells: Prevent apply spell power coefficients at bonus given by some "taken" damage mods
Closes #1991
2011-08-20 03:06:15 +07:00
QAston
fc5e924138 Core/Spells: Implement recently discovered target check attributes and move most of target checks to SpellInfo::CheckTarget function. 2011-08-19 14:54:15 +02:00
LihO
171049bf4a Core/Auras: Crash fix.
Check amount of total ticks to avoid division by zero.
2011-08-18 18:18:44 +02:00
Ramus
cfef963092 Fix Item - Shaman T10 Restoration 4P Bonus 2011-08-18 13:27:22 +07:00
Chaplain
2233018f52 Core/Spells: Fixed exploit found in 9936921206.
When we count twice multipliar for spells with SPELL_SCHOOL_MASK_NORMAL.
Also now it will show correct data in character info like damage reduction % from defence stance in warrior case.
Also fixed some minor logic issues.
2011-08-17 16:11:38 +03:00
QAston
d4b90d1f86 Core/Spells: Remove OriginalVictim parameter from Unit::CastSpell(x,y,z) - setting unit target was enough for all spells which used it, there's never a need to cast with both unit and dest target on retail (in such cases unit target + DEST_TARGET target types are used). 2011-08-16 16:53:29 +02:00
QAston
73bbc3aca8 Core/Spells: Update some targeting related attribute definitions to make them more clear and consistent. 2011-08-16 16:06:21 +02:00
hacknowledge
c0326e3170 Crashfix. Added missing check for NULL of victim parameter 2011-08-14 21:51:52 +02:00
hacknowledge
0c500486f3 Core/Spells: Fixed weapon dependent damage mods for players as well as autohit damage mods for NPCs and pets. This fixes also meta sockel effects. Also fixed displaying the correct values in the char info. I also took care of applying and unapplying the weapon based damage mods when the player is being disarmed and equips/unequips his weapon.
Fixes #178, #418, #1276, #259 and possible a few other issues.
2011-08-13 23:26:16 +02:00
idostyle@zoit
8c411ffa42 Spell: Mark of the Fallen Champion
Forcing gcc to use the right overloaded function here.
2011-08-12 05:01:31 +02:00
tobmaps
4ce345a9f9 DB/Loot: Fix max count of items from Titanium Ore prospecting loot 2011-08-09 06:14:07 +07:00
Machiavelli
beaca1bd34 Fix build 2011-08-07 21:58:35 +02:00
Machiavelli
2d3f51e6e5 Core/Spells: Fix Shaman talent Nature's Guardian and rewrite fix for fc52f08. Fixes some spells not triggering. 2011-08-07 21:19:27 +02:00
Machiavelli
3109d9c0ae Core/Spells: Spells that can be spellstolen that have a permanent duration should respect the 2 minute spellsteal buff duration limit. 2011-08-07 17:49:02 +02:00
Spp
1c882084f3 Core: Cosmetic changes in Threat related code (per request) and remove of extra call to SpellMgr singleton inside that singleton 2011-08-04 13:16:09 +02:00
Spp
e7327e7e94 Core: Fix compile without PCH and fix some warnings 2011-08-03 11:23:08 +02:00
Liberate
17b89ea8ab Core/Spells: Also Death Runes itself should be able to turn into a Death Rune. They should not turn back into their original rune when using a spell that turns the used runes into Death Runes. 2011-08-02 18:07:43 +02:00
Silinoron
6348c7331b Some codestyle cleanup 2011-08-01 17:37:55 -07:00
Machiavelli
ff3c988ee7 Core/Entities: Allow Shaman totems to crit with spells, and add a temp workaround to make Fire Elemental Totem spawn crit with spells also.
Closes #252
Closes #1846
2011-08-01 18:30:00 +02:00
Machiavelli
f26edf09d3 Fix gcc build and remove redundant check from 0afc3c 2011-07-31 22:27:57 +02:00
Machiavelli
58f10c74f7 Core/Spells: Change low level bool triggered with bitmask TriggerCastFlags to better manipulate the behaviour of certain triggered spells. 2011-07-31 21:58:25 +02:00
QAston
db28ae55c9 Core/Spells: Add missing braces to possession spell check - fixes problems with being unable to cast target's spells while possesing. 2011-07-31 11:13:41 +02:00
Machiavelli
b2d37062a0 Core/Vehicles: Allow damaging NPC passengers.
+ Forgotten change from 2effb7
2011-07-30 21:55:06 +02:00
QAston
fe913bf66c Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura) - this time without additional changes (argh!) 2011-07-28 23:45:57 +02:00
QAston
495ead5f7f Revert "Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura)"
This reverts commit 07badd7385.
2011-07-28 23:44:39 +02:00
QAston
07badd7385 Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura) 2011-07-28 23:41:29 +02:00
QAston
045dec19fa CoreSpells: Typofixes: fix area auras autocast and usage of items in combat. 2011-07-28 13:21:31 +02:00
Shauren
3e5aa2d1ff Core/Movement: Implemented methods to animate creatures landing and takeoff and use them in Sindragosa script 2011-07-27 12:40:14 +02:00
Spp-
b2a84d9f1e Core/ObjectMgr: Remove GetPlayer function (Remove double use of singletons) 2011-07-27 12:14:27 +02:00
Spp-
fa50c0a464 Fix some warnings here and there 2011-07-27 11:00:39 +02:00
QAston
b0fe236265 Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
*SpellEntry is now SpellInfo
*GetSpellProto is now GetSpellInfo
*SpellEntry::Effect*[effIndex] is now avalible under SpellInfo.Effects[effIndex].*
*sSpellStore.LookupEntry is no longer valid, use sSpellMgr->GetSpellInfo()
*SpellFunctions from SpellMgr.h like DoSpellStuff(spellId) are now: spellInfo->DoStuff()
*SpellMgr::CalculateEffectValue and similar functions are now avalible in SpellEffectInfo class.
*GET_SPELL macro is removed, code which used it is moved to SpellMgr::LoadDbcDataCorrections
*code which affected dbc data in SpellMgr::LoadSpellCustomAttr is now moved to LoadDbcDataCorrections
2011-07-26 23:09:28 +02:00
insider42
17c2c122da Core/Spells: Fix Glyph of Shadow Word: Death 2011-07-25 01:50:46 +07:00
tobmaps
55b0e550b9 Core/Spells: Properly fix Ignite 2011-07-24 19:37:57 +07:00