Commit Graph

21135 Commits

Author SHA1 Message Date
Trisjdc eae18d8ed0 Core/Utils: Move EventMap to Util.h 2014-06-06 11:14:32 +01:00
blub 700baded7a Merge pull request #12215 from Trisjdc/warning_fix
Warning fix
2014-06-04 20:14:29 +02:00
Trisjdc 2a6d3fa67c Warning fix 2014-06-04 19:12:02 +01:00
jackpoz bd45a0bba9 Core/Tickets: Don't try to save the same sub-survey more than once 2014-06-04 19:56:13 +02:00
Shauren 84d0094ffa Core/Tickets: Sprinkled some transaction magic on HandleGMSurveySubmit 2014-06-03 23:24:00 +02:00
Gacko 79f01de094 DB/Creature: Remove phaseMask hack of Shadowmoon Tuber Nodes
Related to 26370223a0
2014-06-03 10:04:03 +02:00
Sebastian Valle Herrera 409a19e623 Merge pull request #12201 from Unholychick/patch-2
Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
2014-06-02 18:23:17 -05:00
Sebastian Valle Herrera d41779f8fa Merge pull request #12135 from Trisjdc/event_map_extension
Core/Util: A couple useful new functions for EventMap
2014-06-02 18:10:08 -05:00
Trisjdc 8db02c52ac Core/Util: A couple useful new functions for EventMap, as well as getting rid of some old junk 2014-06-02 23:59:35 +01:00
Sebastian Valle Herrera d097a5ec97 Merge pull request #12182 from Xter/rbac
Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_G...
2014-06-02 17:47:40 -05:00
Sebastian Valle Herrera f5e6292b48 Merge pull request #12032 from Trisjdc/haste_formula
Core/Players: Fix haste rating formulas
2014-06-02 17:23:16 -05:00
jackpoz 0c1ddc970d Core/Misc: Kick player in case of multiple CMSG_PLAYER_LOGIN
Kick player in addition to logging an error in case of multiple CMSG_PLAYER_LOGIN.
2014-06-02 17:03:31 +02:00
Lucas 82cefb661d Core/Spells: Implement SPELL_ATTR4_FIXED_DAMAGE
Spells with this attribute will ignore damage taken auras except for mechanic damage taken (trauma, etc) and will ignore resilience because the damage caused by those spells is based off another spell' damage
2014-06-02 15:41:02 +02:00
Gacko 26370223a0 Script/Shadowmoon Valley: Remove hack in npc_shadowmoon_tuber_node.
This script will be converted to SAI (if possible) later.
2014-06-01 19:39:57 +02:00
Gacko 8ef34535a4 Scripts: Remove unused variables (kept as comment) 2014-06-01 19:34:34 +02:00
Shauren 9fcd607e78 Core/Misc: Added utility method for checking is two sorted containers have a common element 2014-06-01 19:20:49 +02:00
jackpoz 282a7cad7d Core/Misc: Code cleanup
Remove old unused opcode handler WorldSession::HandlePageQuerySkippedOpcode() for CMSG_PAGE_TEXT_QUERY since it's already handled by WorldSession::HandlePageTextQueryOpcode()
2014-06-01 16:15:27 +02:00
jackpoz 70bd70080d Core/QuestPOI: Mitigate possible DoS with CMSG_QUEST_POI_QUERY
Avoid sending POIs for same quest if the client somehow sent duplicates quest id in same CMSG_QUEST_POI_QUERY packet. This also reduce the effects of possible DoS and increases the difficulty to cause it.
Fix a typo which caused no quest POIs to be sent at all if the client queried data for 25 quests.
2014-06-01 13:33:46 +02:00
jackpoz 6a54ed88c6 Core/NetworkIO: Fix performance loss when handling bad packets
Revert f9cb4280bd which retrieved the callstack each time a ByteBufferPositionException or a ByteBufferSourceException occurred, for example with bad packet structure.
2014-06-01 00:29:33 +02:00
xter 19c56cbc0e Core/RBAC: fix RBAC_PERM_COMMANDS_BE_ASSIGNED_TICKET and RBAC_PERM_LOG_GM_TRADE permissions 2014-05-31 14:04:37 +02:00
Filip 3ceabf962d Martek the Exiled's prerequisite quests
Fix by @untaught
2014-05-30 22:11:03 +02:00
Warpten 7b49038454 Merge pull request #12171 from Ankso/player_update_zone
Core/Players: Update the player's zone and area only after the player's position is updated server-side.
2014-05-30 19:53:47 +02:00
Ankso ab62fe30bc Core/Players: Update the player's zone and area after update the player's
position server side.
2014-05-30 17:18:52 +02:00
jackpoz 8d539ee6c0 Merge pull request #12162 from Trisjdc/aura_split_damage_breaking
Core/Spells: Break 'Fear' and similar auras on damage sharing of SPELL_AURA_SPLIT_DAMAGE_PCT
2014-05-29 21:21:39 +02:00
jackpoz 65917f52ea CoreCore/NetworkIO: Fix disconnect when canceling character creation
Remove the filter on CMSG_CHAR_ENUM added in 59b4c34924 since the same opcode is already throttled in the new improved system. DoS attacks using this opcode are still mitigated with same effect of before.
Fixes #10915
2014-05-29 21:11:41 +02:00
jackpoz b92e1046be Merge pull request #12007 from Trisjdc/spell_pushback
Core/Spells: Define and implement SPELL_ATTR7_NO_PUSHBACK_ON_DAMAGE
2014-05-29 19:54:39 +02:00
jackpoz fabceddacb Merge pull request #12160 from Trisjdc/petai
Core/PetAI: Pin should not be interrupted if the victim has a breakable aura
2014-05-29 19:45:48 +02:00
jackpoz 1b47f3270e Core/NetworkIO: Adjust more packet throttling values
Adjust more packet throttling values and add Player name to log to help investigate false positives.
2014-05-29 19:43:09 +02:00
Trisjdc 1301ad800b Core/Spells: Break 'Fear' and similar auras on damage sharing of SPELL_AURA_SPLIT_DAMAGE_PCT 2014-05-28 22:22:54 +01:00
Trisjdc 9f50dd3bd6 Core/PetAI: Pin should not be interrupted if the victim has a breakable aura 2014-05-28 21:52:01 +01:00
jackpoz f312b86941 Core/NetworkIO: Adjust more packet throttling values 2014-05-27 21:19:19 +02:00
joschiwald acc9f1575a Merge pull request #12146 from Trisjdc/spell_hymn
Core/Spells: Missing target conditions for Divine Hymn/Hymn of Hope's second effect
2014-05-27 02:32:49 +02:00
Trisjdc 0e32789cd2 Core/Spells: Missing target conditions for Divine Hymn/Hymn of Hope's second effect 2014-05-26 20:42:53 +01:00
jackpoz b5b64a2cdd Core/NetworkIO: Adjust more packet throttling values 2014-05-26 20:13:04 +02:00
jackpoz c06dc7d37a Core/NetworkIO: Adjust more packet throttling values
Adjust some more packet throttling values.
Revert b35f831f2b since it's no longer needed.
Modify the AntiDoS log to specify in a more readable way which opcode triggered the system and how many packets have been received.
2014-05-25 20:14:59 +02:00
Sebastian Valle Herrera c06a263f96 Merge pull request #12129 from Trisjdc/go_collision
Core/Collision: Solve collision issues with non spawned GOs
2014-05-25 11:15:17 -05:00
Sebastian Valle Herrera 1a48967cdf Merge pull request #12130 from Trisjdc/go_collision_2
Core/Collision: Solve collision issues with GAMEOBJECT_TYPE_DOOR GOs
Closes #6303
Closes #7628
2014-05-25 11:12:06 -05:00
Shauren d6414bd9a5 Merge pull request #12131 from Trisjdc/resting
Core/Players: Implement resting for areas with AREA_FLAG_REST_ZONE_ALLIANCE or AREA_FLAG_REST_ZONE_HORDE
2014-05-25 16:17:58 +02:00
Trisjdc fd753a6105 Core/Players: Implement resting for areas with AREA_FLAG_REST_ZONE_ALLIANCE or AREA_FLAG_REST_ZONE_HORDE 2014-05-25 15:05:15 +01:00
jackpoz b4327bfc69 Core/Misc: Fix no-pch build 2014-05-25 15:48:06 +02:00
jackpoz 2f0f8f8018 Core/NetworkIO: Adjust packet throttling values
Adjust packet throttling values to avoid false positive. In case you are experiencing random kicks change the PacketSpoof.Policy setting in worldserver configs and report which packets are triggering the anti-dos system.
2014-05-25 15:26:49 +02:00
jackpoz 5e66253de2 Core/Misc: Throw an exception if client sends invalid float/double data
Throw a ByteBufferException if client sends 1.#INF0000, 1.#QNAN000, 1.#IND0000 or other invalid float/double values.
Handle this invalid values in StaticMapTree::isInLineOfSight() to avoid triggering an assert.
Fixes #12126
2014-05-25 15:18:55 +02:00
Trisjdc 0ce6824a86 Core/Collision: Solve collision issues with GAMEOBJECT_TYPE_DOOR GOs 2014-05-25 11:35:51 +01:00
Trisjdc 45fcc2ff9d Core/Collision: Solve collision issues with non spawned GOs 2014-05-25 11:34:26 +01:00
jackpoz 01b33a6772 Merge pull request #12084 from Trisjdc/pet_combat_2
Core/Spells: Players with active pets count as if they were players in combat against spells with SPELL_ATTR1_CANT_TARGET_IN_COMBAT
2014-05-25 11:25:04 +02:00
jackpoz c4497e26f3 Merge pull request #12119 from Trisjdc/sniper_training
Core/Spells: Sniper Training should refresh every 6 seconds if all conditions are met
2014-05-25 00:35:35 +02:00
jackpoz 1f78ff541a Merge pull request #12120 from Trisjdc/aura_exploit
Core/Auras: Solve exploit involving SPELL_AURA_MOD_DAMAGE_DONE and weapon swapping
2014-05-25 00:32:37 +02:00
jackpoz a4ba54fbdb Core/NetworkIO: Improve packet spam solution
Implement an improved packet Anti-DoS by counting how many times the same opcode has been sent in the last second and applying the policy specified in the configs if the amount of packets exceeds a reasonable amount.
Credits to the original author who decided to share this with TrinityCore team.
2014-05-24 22:34:06 +02:00
Trisjdc 51b782a91e Core/Auras: Solve exploit involving SPELL_AURA_MOD_DAMAGE_DONE and weapon swapping 2014-05-24 19:01:05 +01:00
Trisjdc ea1c4a355c Core/Spells: Sniper Training should refresh every 6 seconds if all conditions are met 2014-05-24 18:57:26 +01:00