Commit Graph

1581 Commits

Author SHA1 Message Date
Machiavelli e636531da3 Core/Movement: Fix pushback issues and client freeze. 2012-04-08 17:03:44 +02:00
Shocker cce6424337 Merge pull request #6001 from Tasssadar/master
Code style: Give field pointers in Player::DeleteFromDB() more appropriate name
2012-04-07 19:14:48 -07:00
kaelima a5a123197b Core/Item: Fix possible exploit stacking critical strike when switching weapons during disarm. Closes #3532 2012-04-08 03:12:40 +02:00
Subv f17b990f68 Core/Spells: Fixed rogue T10 2P and 4P bonuses
Closes #422

Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-07 16:58:56 -05:00
Nay 945566e84e Scripts/SM: Fix dead anymation of Fairbanks
Patch by DennisRassmann (25/10/2010)
Closes #4998
2012-04-07 22:29:19 +01:00
kaelima cadf311ac6 Core/Players: Reward XP to dead players inside battlegrounds
(29/05/2010)
2012-04-07 21:42:49 +01:00
Subv e94a5dd16f Core/Visibility: Pets should be always visible for group mates.
Patch by zarocks
Closes #55
2012-04-07 13:31:53 -05:00
MrSmite b843688fa8 PeAI update
* Better handle target selection for defensive pets. Adds triggers for when owner is damaged or begins attacking something.

* Defensive pets no longer run off as soon as a mob aggros the owner but rather at first damage to owner or owner first attack

* Pets on stay will continue to attack unless target unreachable
2012-04-06 12:26:45 -04:00
Shauren b5dc7bc45b Core/SmartScript: Fixed crashes with stored target lists
Closes #5786
2012-04-05 22:13:20 +02:00
Subv 3d6da262dc Core/Spells: Blade Barrier should not proc from autoattacks
Closes #6028

Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-04 20:51:49 -05:00
Vojtěch Boček cea3930610 Core: Give field pointers in Player::DeleteFromDB() more appropriate name 2012-04-04 19:07:22 +03:00
click 0447ddacef Core: Fix a crash in Player::DeleteFromDB due to loading wrong fields 2012-04-04 17:42:45 +02:00
click 98fcadae46 Core: Fix Group::SetGroupMemberFlag and Pet::resetTalentsForAllPetsOf prepared statement parameters (thanks Saring) 2012-04-04 01:23:09 +02:00
click 9074102702 Core: Fix Item::SaveRefundDataToDB prepared statement parameters 2012-04-04 00:29:22 +02:00
Nay b7f7e3118c Core/DBLayer: More type fixes
Thanks to Vasago for the help in spotting the errors
Thanks to Subv as well (so he doesn't feel lonely)
2012-04-01 22:41:47 +01:00
click ad569ce649 Core: Only clear motionmaster flags if the respective entity exists in world.
Original patch by kewarr and Mrsmite, additional commenting by Machiavelli removing the pet-specific checks applied.
Fixes #5400.
2012-04-01 19:54:33 +02:00
Subv 8bd228179d Core/Spells: Fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT on several types of spell effects
closes #5961
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-04-01 11:02:44 -05:00
Nay 1bc99cd5af DB/Spawns: Fix previous commit (512aa8897b) 2012-04-01 14:55:19 +01:00
Nay 377c5ce36e Core/DBLayer: Fix another wrong type in mail related code 2012-04-01 03:09:01 +01:00
click 280f88db6b Merge pull request #5649 from Elron103/pull-requests2
Core/Movement: Fix random position finding near edges, avoid big z-coordinate differences
2012-03-30 18:14:58 -07:00
Shocker b292437989 Merge pull request #5933 from GyxTom/master
Core/Misc: Code style and remove unused define
2012-03-30 14:49:44 -07:00
Shauren 5843851559 Core/DBLayer: More prepared statement corrections 2012-03-29 23:22:10 +02:00
Kandera 4a0085ad2c Core/DBLayer: more type fixes 2012-03-29 12:21:38 -04:00
leak 5e58905aa0 Core/DBLayer: More types fixes 2012-03-29 17:43:23 +02:00
Nay 92d3548f0b Core/DBLayer: Even more types fixes... 2012-03-29 15:08:17 +01:00
Gyx 5b7493fc66 Core/Misc: Code style and remove unused define.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 14:43:34 +08:00
Gyx 360014856d Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-29 13:42:04 +08:00
Shocker a08cb234c0 Merge pull request #5918 from GyxTom/master
Core/Misc: Various cleanups
2012-03-28 18:00:42 -07:00
click 6237ddac34 Partially revert a36a0a77ef.
Cleaning databases for old/deprecated and expired quests should never be a
developers choice specifically. This should be done by admins, not developers,
through the use of the already existing paramters found in the worldserver config :
CleanCharacterDB / PersistentCharacterCleanFlags

An adjustment to the respective questloader prepared statement has been done to
accomodate for the earlier change (by not loading such quests into memory at all).

Documentation for how this cleanup-procedures work already exists in the core :
doc/CharacterDBCleanup.txt.
2012-03-28 19:31:06 +02:00
Gyx 1544b208da Core/Game: Code style again.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 20:00:29 +08:00
Gyx 72cdcbfced Core/Game: Code style.
Signed-off-by: Gyx <2359980687@qq.com>
2012-03-28 19:11:50 +08:00
Machiavelli 91228d2711 Core/Player: Similarly initialize m_SeasonalQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7C42: Player::_SaveSeasonalQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19375)
==8111==    by 0xFB56BA: Player::SaveToDB(bool) (Player.cpp:18898)
2012-03-28 13:07:37 +03:00
Machiavelli c3db19b80b Core/Player: Initialize m_WeeklyQuestChanged
Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7AD2: Player::_SaveWeeklyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19352)
2012-03-28 13:06:02 +03:00
kaelima 820f45c424 Core/Protocol:
- Correct and rename response message from creating/updating a ticket
- Prevent some trailing data in CMSG_GMTICKET_CREATE and add comment on stuff missing from its structure.
- Random cleanup
2012-03-28 03:59:03 +02:00
Shauren 697fda7d27 Core/Players: Fixed copy paste mistake 2012-03-28 00:03:11 +02:00
Nay ead019b061 Core/DBLayer: Correct few more wrong read types (No. 3)
DB/World: Some consistency in the ints "length" field (not really a length)

From A to G world tables verified; missing all the others
2012-03-27 19:26:58 +01:00
Shauren 38deaa5dba Core/Players: Fixed saving glyphs to database
Closes #5909
2012-03-27 19:00:41 +02:00
click 13757731b7 Merge pull request #5811 from Elron103/pull-requests3
Core/Units: Fix issues with threat management on phase changes
This is the cleaner version of the two suggested on pull-requests, and handles the threatlist correctly as well.
2012-03-27 07:08:03 -07:00
Nay a92820b51c Core/DBLayer: Correct few more wrong read types (No. 1)
DB/World: Some consistency in the ints "length" field (not really a length)

From A to D world tables verified; missing all the others

int(11) -> int32
unsigned int(10) -> uint32
mediumint(8) -> int32
unsigned mediumint(8) -> uint32
smallint(6) -> int16
unsigned smallint(5) -> uint16
tinyint(4) -> int8
unsigned tinyint(3) -> uint8
2012-03-27 00:43:56 +01:00
leak 89f31f3cba Core/DBLayer: Typo from prev. commit 2012-03-26 19:05:51 +02:00
leak 830a7fb08b Core/DBLayer: Restore pet loading
closes #5878
2012-03-26 18:58:24 +02:00
Kandera da540d5584 Core/Spells: Fix Necrotic Touch proc closes #538 2012-03-26 12:05:27 -04:00
Kandera 7b357a5028 Core/Spells: Fix Misdirection (thx to elron) closes #5869, #4343 2012-03-26 11:37:03 -04:00
leak b1ca1ee5ec Core/DBLayer: Convert PAppend() queries to prepared statements No.4 NOTE:
Most of the cores queries have been converted to prepared statements now. If your code contains queries, please either use the exiting or implement new statements.
The only exclusions are one-time queries (e.g. for core startup) and queries that can't be prepared due to limitations.
2012-03-26 15:47:37 +02:00
kaelima 786c226b74 Core/CombatLog:
- Send more proper hitinfo values in SMSG_ATTACKERSTATEUPDATE (still lot of research todo)
- Some renaming and commenting

- Minor cleanup in Player::UpdateZone
2012-03-26 02:16:19 +02:00
Shocker 48dc9313b9 Core/Misc: Fix logic for owner check in Unit::RemoveGameObject 2012-03-26 02:50:08 +03:00
Shauren 9ec61089be Core/Player: Fixed accessing possibly deallocated memory 2012-03-25 22:24:11 +02:00
Subv 04099402cd Core/Players: Use correct size in variables 2012-03-25 13:05:13 -05:00
Subv 19747fb95e Core/DBLayer: Use correct Get method in some DB fields 2012-03-25 12:59:18 -05:00
leak 71c02fb54d Core/DBLayer: Convert PAppend() queries to prepared statements No.2 2012-03-25 18:32:26 +02:00