Commit Graph

31750 Commits

Author SHA1 Message Date
Giacomo Pozzoni ca8953a0ec Core/Misc: Fix static analysis issues
Fix static analysis issues reported by Coverity
2019-09-27 14:12:10 +02:00
ForesterDev 176f51d1e8 DB/Creature: Remove wrong SAI from guards
Closes #23824
2019-09-26 17:43:26 +02:00
Aokromes 2e1a85d8c9 DB/Locales: Fix locales for 4 items
By Jildor
Closes #23822
Closes #23823
2019-09-26 11:35:56 +02:00
Aokromes df0b0c2494 DB/World: Wrong characters in item_template_locale
By Jildor, closes #23821
2019-09-26 11:27:41 +02:00
Keader 746a1d89b3 Scripts/Tempest Keep: Fixed a typo in Nethermancer Sepethrea
Closes #23828 
Ty Rizztazz
2019-09-25 16:56:03 -03:00
Giacomo Pozzoni ed08754663 Core/Misc: Fix static analysis issue
Fix static analysis issue
2019-09-25 11:44:08 +02:00
tarwyn c8dc9fdc41 Fix inconsistent NPC aggro on spell miss (#23816) 2019-09-23 08:01:28 +02:00
Ovah cf3277c641 Core/Movement: provide an extra spline path vertex for taxi pathings … (#23817)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.

* Update FlightPathMovementGenerator.cpp
2019-09-22 17:12:59 +02:00
Killyana 8e3862cfbd Instance/Script: Gorkun Ironskull & Martin Victus 2019-09-21 21:52:33 +02:00
jackpoz f9d6c57006 Core/Quest: Fix quests not being shareable 2019-09-21 18:26:55 +02:00
jackpoz 42ab6010f8 Core/Map: Move a log from ERROR to WARN
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive
2019-09-21 18:05:19 +02:00
Killyana acedd840fa DB/Creature: Avatar of Sathal
Closes  #23805
2019-09-21 13:33:11 +02:00
Gildor a392216d20 Scripts/Icecrown Citadel: Remove duplicated Spell enum (#23810) 2019-09-21 13:17:45 +02:00
Giacomo Pozzoni fb059722fd Core/Calendar: Add some additional validation when creating events (#23797)
* Core/Calendar: Add some additional validation when creating events

Allow only 30 player events and 100 guild events to be created.
Don't allow to create guild events if player is not in guild.
Send some more error messages to the client (not blizzlike errors but better than nothing).

* Core/Calendar: Add some additional validation/checks

Add guild id check in GetPlayerEvents().
Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past.

* Core/Calendar: Add some additional validation/checks

Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3.

* Core/Calendar: Add some additional validation/checks

Implement 5 seconds cooldown between the creation of calendar events

* Core/Calendar: Add some additional validation/checks

Don't allow to copy events of a different player/guild

* Core/Calendar: Implement automatic deletion of old events

Implement automatic deletion of events older than 1 month (30 days).
Fix debug assertion triggered when deleting a character with calendar events.
Avoid double std::set lookup when deleting events when deleting a character.

NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits.
2019-09-17 09:11:56 +02:00
Kelno 6fc7ab3448 Core/Commands: Fixed wrong permissions for .lookup map commands (#23800) 2019-09-16 17:41:55 +02:00
TDB Release 9f66158ae5 TDB 335.19091 - 2019/09/15 TDB335.19091 2019-09-15 09:23:26 +00:00
Shauren 9f7cc32c6e Core/Build: Fix build with boost 1.71 2019-09-14 14:25:33 +02:00
jackpoz 215a6cee24 Core/Movement: Fix LoS issue of NPCs chasing targets
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target.

Fix re-implements 8927a04253 after 2a84562dc8 partially removed it.

Fix #23724
2019-09-13 21:06:28 +02:00
Killyana 537c4d1208 DB/Creature: Fix some flags 2019-09-12 18:53:54 +02:00
Killyana c9aeff3bf9 DB/Creature: Gorkun Ironskull & Martin Victus 2019-09-12 17:28:32 +02:00
TerrorBringer b6c2baf5f6 DB/Creature: O'Mally's Instrument Bunny
Closes #23790
2019-09-12 15:47:16 +02:00
Gildor b98f858cd2 Spells/DK: Fix wrong class name in Rime AuraScript (#23783)
(Introduced in this commit: 2ff855054f)
2019-09-10 16:29:38 +02:00
Killyana e300eed3d7 DB/Creature: Vision Guide Kill Credit Trigger
Closes #23784
2019-09-10 15:23:51 +02:00
Killyana 546bd0f6fb DB/Quest: Forge Camp: Annihilated
Closes #23778
2019-09-09 19:52:40 +02:00
Killyana cd09733383 DB/Gameobject: Add Missing templates 2019-09-09 19:49:10 +02:00
Killyana e8ab60955d DB/Conditions: Remove wrong condition related to Sal'salabim gossip text
Closes #23780
2019-09-09 14:08:48 +02:00
Giacomo Pozzoni 18cc36bc67 Build/CMake: Set some policies to NEW (#23779)
* Build/CMake: Set CMP0005 to NEW

See https://cmake.org/cmake/help/v3.2/policy/CMP0005.html

* Build/CMake: Set CMP0043 to NEW

See https://cmake.org/cmake/help/v3.2/policy/CMP0043.html

* Build/CMake: Set CMP0074 to NEW

See https://cmake.org/cmake/help/v3.12/policy/CMP0074.html
2019-09-09 08:17:27 +02:00
genion18 5b7b8f868f DB/Quest: Garments of the Moon
Closes #23777
2019-09-08 17:20:08 +02:00
genion18 56a219de20 DB/Quest: Tainted Parchment
Closes #23776
2019-09-08 17:15:29 +02:00
jackpoz 7c0b31b8b5 Core/MovementGenerator: 680e1cbd6c follow-up 2019-09-08 15:48:06 +02:00
Killyana 0918e7eb13 DB: Missing change in the last commit (The Ring of Blood: The Blue Brothers on quest taken text) 2019-09-07 23:10:26 +02:00
Killyana c907ab4381 DB/SAI: Fix Texts related to The Ring of Blood
Closes #23774
2019-09-07 23:01:03 +02:00
illfated e2e62aa774 DB/Quest: Slaves to Saronite RewardText
Closes #23707
2019-09-07 20:23:51 +02:00
Killyana eb9d27660b DB/Creature: Torek
Closes #23742
2019-09-07 18:32:32 +02:00
jackpoz 680e1cbd6c Core/MovementGenerator: Fix crash in taxi paths
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground.
2019-09-07 18:22:26 +02:00
Killyana c892f867d5 DB/Quest: Fix chaining an DB errors 2019-09-07 14:17:51 +02:00
Gildor f8d7b26047 Core/Misc: Fix parry-haste mechanic. (#23773)
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03e )

Closes #23754
2019-09-07 12:57:02 +02:00
Artamedes 8ecc45cd1a Scripts/Pet: Fix npc_pet_gen_soul_trader not following owner (#23772) 2019-09-06 22:14:09 -03:00
Artamedes 88e74ac385 Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage (#23768) 2019-09-06 21:47:34 +02:00
Artamedes a17c83bde8 Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick (#23767) 2019-09-06 21:47:10 +02:00
Artamedes 876a848730 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos
2019-09-06 20:09:47 +02:00
Artamedes 832c95fa4f Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter

* qq

* qq 2

* tryfix circleci build

* review suggestions
2019-09-06 20:08:47 +02:00
Artamedes 1b095811b8 Scripts/Outland: Change auto to TempSummon* (#23764) 2019-09-05 16:57:34 +02:00
Artamedes 0b3a9e2a2b Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons

* fix nopch
2019-09-05 08:37:44 +02:00
Artamedes 6ebe1afeec Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload and the pet bar disappears (#23762) 2019-09-04 08:41:18 +02:00
jackpoz 4074cb0f01 Core/Creature: Fix another pet assert
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell
2019-09-01 19:05:29 +02:00
Shauren dab66cb8d0 Core/SAI: Reserve action ids 2019-08-31 13:58:55 +02:00
Killyana 6e2e55bc38 DB/Creature: Professor Putricide
Updates #23727
2019-08-30 12:32:06 +02:00
Treeston 23fd193e4e Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727. 2019-08-30 01:04:11 +02:00
AlιAѕѕaѕѕιN 92d83c3c2e [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d
2019-08-28 08:03:41 +02:00