joschiwald
ca07f30d03
Core/Spells: convert some spell effects to SpellScripts
2012-05-28 04:07:51 +02:00
Vincent-Michael
e8bfcb686f
Core/Spell: Fix not using Disengage while rooted
2012-04-28 02:56:29 +02:00
MrSmite
e9fd6d1979
Fix pets attacking on non-harmful spells
2012-04-20 20:22:40 -04:00
Subv
3d8aaabaf3
Core/Spells: Do not proc spells with PROC_FLAG_DONE_SPELL_MAGIC_DMG_CLASS_(NEG|POS) if there is no target, reimplemented Storm, Earth and Fire talent in another way
...
Closes #3367
Closes #2424
If you find more spells that are broken because of this, please notify us
Signed-off-by: Subv <s.v.h21@hotmail.com >
2012-04-14 20:08:16 -05:00
Subv
397ee8ceb5
Core/Spells: Execute spell procs after the healing effects of a spell
...
Closes #216
Signed-off-by: Subv <s.v.h21@hotmail.com >
2012-04-11 17:41:36 -05:00
Subv
38d5fbac0e
Core/Spells: You should be able to revive pets from anywhere without summoning them first
...
Closes #1090
Signed-off-by: Subv <s.v.h21@hotmail.com >
2012-04-08 16:22:19 -05:00
Machiavelli
bc96df1aae
Core/Shared: Move container functions to shared project under Trinity::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.
...
Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.
2012-04-08 17:40:05 +02:00
Subv
7ce33ca0a6
Core/Spells: Fixes the rune cooldown when a hit mises the target
...
Closes #412
Signed-off-by: Subv <s.v.h21@hotmail.com >
2012-04-07 16:36:43 -05:00
MrSmite
cc03f2db36
Fix coding style
2012-04-06 12:33:34 -04:00
MrSmite
b843688fa8
PeAI update
...
* Better handle target selection for defensive pets. Adds triggers for when owner is damaged or begins attacking something.
* Defensive pets no longer run off as soon as a mob aggros the owner but rather at first damage to owner or owner first attack
* Pets on stay will continue to attack unless target unreachable
2012-04-06 12:26:45 -04:00
Liberate
926f02f792
Core/Spells: Implement SPELL_ATTR4_PROC_ONLY_ON_CASTER properly. Closes #5204
2012-04-05 20:09:20 +02:00
Subv
5468e8eeb5
Core/Spells: The first target of a chained spell should be explicit.
...
Closes #5643
2012-04-04 17:06:50 -05:00
Gyx
360014856d
Core/Game: Code style.
...
Signed-off-by: Gyx <2359980687@qq.com >
2012-03-29 13:42:04 +08:00
Gyx
1544b208da
Core/Game: Code style again.
...
Signed-off-by: Gyx <2359980687@qq.com >
2012-03-28 20:00:29 +08:00
Gyx
72cdcbfced
Core/Game: Code style.
...
Signed-off-by: Gyx <2359980687@qq.com >
2012-03-28 19:11:50 +08:00
kandera
def4643896
Core/Spells: correctly fix the issue with dispel over time auras. thx shauren
2012-03-27 14:46:19 -03:00
Kandera
0550f1dc05
Core/Spells: fix the issue with dispel auras. (thx warpten) closes #5902
2012-03-27 08:42:54 -04:00
kaelima
c38bf4498a
Fix compile and fix a possible crash for mob_kiljaeden_controller
2012-03-26 03:12:56 +02:00
Shocker
fab1944ae4
Core/Spells: Don't remove summoned gameobjects for non-channeled spells when spell cast was canceled
...
Fixes issues like Demonic Circle: Summon removing the last summoned circle when the new cast was canceled
2012-03-26 03:03:32 +03:00
Machiavelli
41cc704bf8
Core/Movement:
...
- Don't abort relocation if movementflag restrictions were violated. There might be lag between client and server and even different parts of the core that made this approach improper.
- MOVEMENTFLAG_ROOT cannot be used in conjunction with MOVEMENTFLAG_MASK_MOVING, but it's a valid flag to receive from client.
- Fix falling to ground when unapplying fly/waterwalk aura. NOTE: This is a client-side initiated fall, in the future this should be initiated and updated by the server. (Working on it)
- Rename MOVEMENTFLAG_FALLING to MOVEMENTFLAG_FALLING_FAR
- Rename MOVEMENTFLAG_JUMPING to MOVEMENTFLAG_FALLING
Closes #5751
2012-03-17 20:36:12 +01:00
Kandera
aad4e41ca5
Core/Spells: finish fixing dispel functionality. closes #5745
2012-03-16 17:59:10 -04:00
Kandera
bea8fcfbfa
Core/Spells: fix shield slam giving nothing to dispel error.
2012-03-16 09:08:46 -04:00
kaelima
ef53bde176
Core/Spell: Add some missing cast results which require additional data when sent. And rename two researched castflags (thanks TOMRUS)
2012-03-16 08:59:18 +01:00
Kandera
b23ff228a4
Core/Spells: Used correct implementation for checking if a spell effect targets an area.
2012-03-15 14:14:42 -04:00
Kandera
5406a0fd93
Core/Spells: Fix bugged mass dispel after previous commits
2012-03-15 14:12:40 -04:00
Kandera
fe46cf9796
Core/Spells: Fix being unable to use spells due hasDispellableAura being false if no spell effects were SPELL_EFFECT_DISPEL
2012-03-15 12:41:16 -04:00
Kandera
5e25791bff
whitespace cleanup
2012-03-15 11:08:45 -04:00
Kandera
01bc6c483b
Core/Spells: add correct checking for dispeling errors. Fixes spammable cleanse.
2012-03-15 10:56:56 -04:00
Shauren
84891377b5
Core/Spells: Fixed copy paste mistake that caused all area spells to search targets starting from caster's coordinates instead of targeted destination
2012-03-15 13:15:25 +01:00
leak
2a5caef4a6
Revert "Core: more more cleanup" - Build test anyone?
...
This reverts commit 20cd4c71ee .
2012-03-14 18:51:51 +01:00
thomas33
20cd4c71ee
Core: more more cleanup
2012-03-14 17:51:11 +01:00
Machiavelli
b1a8570a30
Core/Spells: Fix item target selection in Spell:SelectImplicitTargetObjectTargets. Typo spotted by zwerg
2012-03-11 14:52:11 +01:00
Subv
7c42cd76e4
Core/Conditions: Prevent crash at Spell::CheckCast if Condition::Meets returned prematurely
2012-03-09 17:15:22 -05:00
click
a153e0ca06
Core: Remove some whitespace and tabs
2012-03-07 00:05:34 +01:00
QAston
a08fe16d69
Core/Spells: Allow spell effects to have multiple destinations. Spells like: 49814, 10869 and similar are now properly selecting destination targets.
2012-03-03 00:19:48 +01:00
QAston
e1b544d129
Core/Spells: Remove some obsolete code
2012-03-02 17:57:26 +01:00
Spp
d38bc3a178
Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there
2012-02-27 14:58:47 +01:00
QAston
a0de042efe
Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore.
2012-02-25 14:07:07 +01:00
QAston
b7b37dca29
Core/Spells: send spell error messages on spell cast condition checks.
2012-02-25 11:54:12 +01:00
Shauren
dc28b92415
Core: Random cleanup + compile fix
2012-02-23 13:01:16 +01:00
QAston
fb5d05c198
Core/Spells: Prevent assertion failure in Spell::SelectImplicitDestDestTargets by setting dest to caster if no dest provided.
2012-02-22 21:06:29 +01:00
Machiavelli
fa546d1428
Core/Spells: Change logic in assertion in Spell::SelectImplicitTargetObjectTargets.
...
Not sure if this a step in the right direction for the intended design, but following the logic of the function there should be OR unit target OR gameobject target OR item target pointers available. If Item target doesn't belong there then the already present AddItemTarget call should be removed.
2012-02-22 19:16:47 +01:00
QAston
7a261ff9b8
Core/Spells: Use right function for obtaining spell target type. Fixes assertion failures.
2012-02-22 10:34:08 +01:00
QAston
2a1ffc1cd9
Core/Spells: Fix a typo in f09b5a6bea - call right function for target dest case.
...
Closes #5357
2012-02-22 10:21:02 +01:00
Spp
1e246cb66c
Fix build (gcc) and fix warnings
2012-02-22 09:15:57 +01:00
QAston
f09b5a6bea
Core/Db/Conditions:
...
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required
Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
QAston
9abc47736f
Core/Spells: Changes in code related to spell explicit target redirection (cleanups, added target validation, prevent unexpected behaviour in some cases)
2012-02-19 00:40:55 +01:00
kaelima
7ce7853606
Core/Spells: Revert part of 65d269f6de. Solves some recent instant spell casting issues.
2012-02-16 20:38:48 +01:00
Spp
03c34ee507
Fix a lot of warnings
2012-02-16 13:56:28 +01:00
Shauren
65d269f6de
Core/Spells: Allow dead players as valid objects for RaiseDeadObjectCheck (enables Raise Dead on players that have not yet released spirit)
...
TODO: Allow all corpses
2012-02-15 00:46:08 +01:00