f6e176b7d7
Instance/Script: Gorkun Ironskull & Martin Victus
...
(cherry picked from commit 8e3862cfbd
2021-12-18 22:21:41 +01:00
6c239a8612
Scripts/Icecrown Citadel: Remove duplicated Spell enum ( #23810 )
...
(cherry picked from commit a392216d20
2021-12-18 22:19:35 +01:00
e3cb89c168
Scripts/PitOfSaron: Make sure ick stops moving when casting Explosive Barrage ( #23768 )
...
(cherry picked from commit 88e74ac385
2021-12-18 21:45:15 +01:00
a2e792f0bc
Scripts/PitOfSaron: Fix Krick sometimes stuck in combat after finish kill Ick ( #23767 )
...
(cherry picked from commit a17c83bde8
2021-12-18 21:45:06 +01:00
8fbaab7337
Scripts/Ulduar: Fix Stormcaller Brundir walking into walls ( #23755 )
...
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls
* Cleanup and fix logic + review
* Review: remove autos
(cherry picked from commit 876a848730
2021-12-18 21:44:43 +01:00
0bffed380d
Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727 .
...
(cherry picked from commit 23fd193e4e
2021-12-18 21:31:31 +01:00
9d3dd3db84
nopch fix
...
(cherry picked from commit 10f6e38185
2021-12-18 21:18:56 +01:00
f2e03dc9e5
Core/Scripts: Proper fix Gal'Darah Puncture remove
...
(cherry picked from commit cbc01f35b6
2021-12-18 21:18:44 +01:00
b7503b6c76
Fix nopch build
...
(cherry picked from commit 1886507e7f
2021-12-18 21:16:51 +01:00
2d0d0a3e58
Scripts/Gundrak: Fixed Puncture when Gal'darah die
...
(cherry picked from commit 130a3859ec
2021-12-18 21:16:40 +01:00
7c2665bdca
Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
...
Noob Keader, Shame !
(cherry picked from commit 61ad87d106
2021-12-18 21:15:40 +01:00
51fbda4223
Core/Pooling: Quest pooling rewrite: (PR#23627)
...
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests
(cherry picked from commit a5e73e41c0
2021-12-18 15:28:45 +01:00
14c38a1c52
Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff.
...
(cherry picked from commit 4a219eda07
2021-12-18 11:36:50 +01:00
a58881d6da
Core/Unit: rename more methods
...
Workaround prework till actual facing system rework arrives
(cherry picked from commit 85ad0befc5
2021-12-18 00:29:38 +01:00
be4ed9152c
Core/Unit: rename IsFocusing method
...
Workaround prework till actual facing system rework arrives
(cherry picked from commit ec9f15a5ff
2021-12-18 00:25:14 +01:00
917d9b7621
Scripts/ICC: Prevent Professor Putricide from displaying weird behavior during the Rotface/Festergut encounters as a result of his boss boundary
...
(cherry picked from commit 7fa990edc6
2021-12-17 22:46:06 +01:00
529ca2dd5d
Scripts/Defines: cleanup some magic numbers in factions ( #23631 )
...
(cherry picked from commit 0c317498a5
2021-12-17 20:48:31 +01:00
c13d83796f
Core/AI: Finally move the "is creature engaged" flag to be a property of the creature AI, where it honestly always belonged. Fixes #17981 and #23602 for real this time.
...
(cherry picked from commit 0e7c66cb4c
2021-12-17 00:23:33 +01:00
96bca1fe2b
Script/BoreanTundra: move Pile of Fake Furs' script (related to quest Unfit for Death) from ItemScript to SpellScript.
...
Closes #21890 .
(cherry picked from commit e7cf24d263
2021-12-16 21:20:39 +01:00
eee950cdd7
Core/Misc: Various dynspawn cleanup and refactors split off from pooling rewrite:
...
- Map::RemoveRespawnTime(SpawnObjectType, LowType, doRespawn) split into Map::Respawn and Map::RemoveRespawnTime, without the extra boolean
- Map::RemoveRespawnTime(RespawnInfo*) merged into Map::DeleteRespawnInfo(RespawnInfo*) and is now private
- Map::DeleteRespawnInfo(void) renamed to Map::UnloadAllRespawnInfos to properly describe what it does
- Map::ProcessRespawns now actually saves the delayed respawn time to DB if the respawn was delayed
- Map::AddRespawnInfo now takes const reference, and returns success as a boolean
- Map::AddRespawnInfo no longer offers an unused "replace" parameter
- Map::DeleteRespawnInfo no longer offers a variety of unused private overloads
- Map::SaveRespawnTime no longer offers a tantalizing writeDB parameter. Parameter is now called "startup" to properly describe what it does.
- Map::SaveRespawnInfoDB now takes RespawnInfo reference instead of all the various fields. Still public because compatibility mode. QQ.
- Map::GetWorldObjectBySpawnId sanitized
- Map::GetXRespawnTime methods sanitized to all go through Map::GetRespawnTime
(cherry picked from commit d60082ae86
2021-12-16 01:33:09 +01:00
fc9908d163
warning fix f2cd721 follow-up
...
(cherry picked from commit be96d8242c
2021-12-15 00:17:32 +01:00
9491650401
Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026 .
...
(cherry picked from commit f2cd721d53
2021-12-15 00:17:32 +01:00
569660a933
Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
...
Closes #19452 .
(cherry picked from commit 37862942ce
2021-12-14 22:13:56 +01:00
e0f3255f90
Scripts/Icecrown Citadel: Ensure Deathbringer Saurfang cast Frenzy ( #23559 )
...
(cherry picked from commit a0a64b10b5
2021-12-14 00:07:14 +01:00
9cfa2ed71e
Script/HallsOfLightning: fix mistake related to Shattering Stomp in Volkhan's script, introduced in 3bb0abcd52.
...
Closes #23337 .
(cherry picked from commit a8b8a43b8d
2021-12-13 00:42:20 +01:00
2e4f38d949
Scripts/ICC: cleanup ReadSaveDataMore definition
...
(cherry picked from commit 4c398743b9
2021-12-13 00:42:19 +01:00
3bc4fc65b9
Scripts/ICC: 3dbf3fe followup
...
repeat timer typo
(cherry picked from commit b19a23a5c6
2021-12-13 00:42:19 +01:00
8be1927d31
Scripts/ICC: base support for Ymirjar Vrykuls AI
...
(cherry picked from commit 3dbf3fed7c
2021-12-13 00:42:19 +01:00
9d84b56df1
Scripts/ICC: 1eb2aef followup
...
(cherry picked from commit 3e9b553618
2021-12-13 00:42:19 +01:00
bb321ccb02
Scripts/ICC: move Sister Svalna to her own file
...
I've almost guttered her, so lets try it more gently this time
(cherry picked from commit 1eb2aef179
2021-12-13 00:42:19 +01:00
5e3ba5e96f
Scripts/ICC: 94b60ff followup
...
(cherry picked from commit eb6ea57e7f
2021-12-13 00:42:19 +01:00
70fd6e7398
Core/Instances: improve DoRemoveAurasDueToSpellOnPlayers & DoCastSpellOnPlayers handling
...
(cherry picked from commit 22b3b21ae3
2021-12-13 00:42:18 +01:00
cadbf42ea4
Misc: some corrections after recent merges
...
(cherry picked from commit 626a24822b
2021-12-13 00:42:18 +01:00
7b08125c23
Scripts/Spells: Remove Collapsing Cave Aura ( #23533 )
...
* Scripts/Spells: Remove Collapsing Cave Aura
* Rename 9999_99_99_99_world.sql to 2019_06_29_00_world.sql
(cherry picked from commit 8d1a5fa126
2021-12-13 00:42:18 +01:00
841630fcc3
Core/Misc: Fix static analysis issues reported by Coverity Scan
...
(cherry picked from commit de88691e25
2021-12-13 00:42:18 +01:00
88457030cc
Scripts/Spells: Deathbolt ( #23531 )
...
* Scripts/Spells: Deathbolt
* Rename 9999_99_99_99_world.sql to 2019_06_28_01_world.sql
(cherry picked from commit 62b2c379b3
2021-12-13 00:42:18 +01:00
adc16ffbdc
Script/FoS: prevent Wailing Souls from becoming desynched in the Devourer of Souls encounter.
...
(cherry picked from commit 079b77b5fc
2021-12-13 00:42:17 +01:00
9951b53808
Core/Misc: Fixed some gcc warnings
2021-12-12 19:19:15 +01:00
a4da12119e
Scripts/Misc: couple corrections to the recent PRs
...
(cherry picked from commit 4a8736b829
2021-12-12 02:16:01 +01:00
38d7c1530a
Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490 .
...
(cherry picked from commit 1158f267df
2021-12-12 02:09:15 +01:00
aa407adf3e
Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster ( #23456 )
...
* Scripts/Spells: Ultra-Advanced Proto-Typical Shortening Blaster
* Fix NoPCH
* Correct header
* fixup! Clean up
* Rename 9999_99_99_99_world.sql to 2019_06_22_00_world.sql
(cherry picked from commit 40b09e3df1
2021-12-11 22:58:16 +01:00
ba606753bd
Scripts/Icecrown Citadel: Fixed some bugs on Blood Orb object and trash mobs around him
...
Followup: 394b1196643b0743ea67f9a366628a
2021-12-11 21:37:53 +01:00
b3493935b6
Core/Scripts: Fixed a reference error introduced in 394b119664
...
(cherry picked from commit 70cbedd75d
2021-12-11 14:56:14 +01:00
f749b3a2e9
Scripts/Icecrown Citadel: Fixed Blood Orb Game Object ( #23397 )
...
Close #18005 and Update #18529
(cherry picked from commit 394b119664
2021-12-11 14:55:18 +01:00
42ad1b86a1
Core/Misc: Implemented Icecrown Citadel buff disable ( #23394 )
...
Closes #8576
Closes #7940
(cherry picked from commit 94b60ff0ef
2021-12-11 11:59:54 +01:00
79d4a0f8aa
Scripts/Icecrown Citadel: Fixed Heroic Attempts logic ( #23379 )
...
(cherry picked from commit 136964769d
2021-12-11 01:27:48 +01:00
88d5b91c05
Script/Dalaran: don't allow Dalaran faction guards to teleport a player that has the Trespasser! debuff. ( #23373 )
...
(cherry picked from commit 5016f588d5
2021-12-10 22:47:33 +01:00
db6fdef3d7
Script/Quest: implement event for the quest Orabus the Helmsman ( #23346 )
...
* Script/Quest: implement event for the quest Orabus the Helmsman.
Thanks Wyreth for the original script.
* Fix coordinates that I inverted by mistake.
* Rename 9999_99_99_99_world.sql to 2019_06_04_04_world.sql
(cherry picked from commit b5e04c8920
2021-12-10 21:38:27 +01:00
b6d28b5497
Script/GunDrak: fix order for yell and altar texts on death for two bosses ( #23357 )
...
(cherry picked from commit 65aea13c25
2021-12-10 21:16:10 +01:00
647893597c
Script/Creature: implement spell effect for the item Prototype Neural Needler used on Imprisoned Beryl Sorcerer ( #23349 )
...
* Script/Creature: implement spell effect for the item Prototype Neural Needler used on Imprisoned Beryl Sorcerer.
* Rename 9999_99_99_99_world.sql to 2019_06_03_02_world.sql
(cherry picked from commit eb5d1d3248
2021-12-10 21:15:56 +01:00
Killyana