398299084e
Corrected some logic in my recent commits.
...
- ff2dbfc3816ccf95af4c
2011-12-22 18:48:06 +01:00
ff2dbfc381
Core/Spells: Fix two signed / unsigned warnings from f8a13b401d
2011-12-22 13:22:18 +01:00
f8a13b401d
Core/Spells:
...
- Fix channeling spells with infinite duration (-1)
- Allowed SPELL_FAILED_EQUIPPED_ITEM_CLASS_MAINHAND and SPELL_FAILED_EQUIPPED_ITEM_CLASS_OFFHAND in SendCastResult (more reasons todo)
2011-12-22 00:38:01 +01:00
471c9dd621
Core/Spells: stop channeling bar when interrupted also for creature
2011-12-10 01:46:06 +01:00
358b33239a
Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit
2011-11-23 19:17:33 +01:00
b3fef1e280
Fix build.
2011-11-23 12:42:11 -05:00
638693e78f
Core: Fixed more warnings (C6246: Local declaration of 'x' hides declaration of the same name in outer scope.)
2011-11-23 17:55:16 +01:00
f75ec5ba2b
Core: Codestyle clean-up
...
"plr"->player
Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
68601bb286
Core/Spells: Use correct dbc flag to check if spell can be interrupted
2011-11-03 16:53:29 +07:00
dfeb4a746b
Fix a crash caused by spell with CAST_FLAG_RUNE_LIST casted by a creature mover. Thanks to Vasago.
2011-10-31 09:56:04 -04:00
5514523a7c
use effectMask to calculate mechanicMask in ModSpellDuration
2011-10-20 18:28:37 +02:00
a658d0b592
Core/Spells: Define and implement SPELL_ATTR4_PROC_ONLY_ON_DUMMY.
...
Fixes #2685
Fixes #2573
2011-10-19 22:08:54 +02:00
be0b2fcf97
Core/Grid:
...
- Simplified CellArea calculation (Original author: SilverIce)
- Removed unused code in Cell class (Original author: SilverIce)
- Improve some Visit functions.
2011-10-19 17:40:44 +01:00
8f8949fcf0
Core/Spells: Spells with the self-cast range should not have a range check. This range used for many triggered spells.
...
Fixes #3358
2011-10-19 00:24:43 +02:00
c29ff41001
Rename some classes in grid system.
...
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
00f5366029
Fix the bug that CC AOE spells do not remove stealth aura if the target is behind the caster.
2011-10-10 12:56:14 -04:00
9b218315b8
Core/Spells: Chain spells shouldn't hit critters
2011-10-07 23:33:08 +03:00
96d7a1e970
REPO: code-style clean-up
...
* Fixed pGuild->guild
* Fixed pGroup->group
* Fixed pOwner->owner
2011-10-07 10:54:53 -05:00
26c76bf388
Core/Spells: Implemented SPELL_AURA_BLOCK_SPELL_FAMILY
2011-10-02 16:23:52 +02:00
b16d2245bb
Cosmetic: Multiple cosmetic changes
...
- Added missing space to 'if', 'for', 'while' and 'switch' when it's followed by '('
- Added missing space after a comma and remove space before comma (with some exceptions)
- Remove trailing spaces
- Convert tab to spaces
Note: Only affects files with extension "cpp" and "h" under /src/server
2011-09-29 12:43:05 +02:00
cc06c41887
Core: Move FormationMgr to namespace
...
Also...
- Warning fixes
- Make Singleton constructors private
2011-09-28 11:11:38 +02:00
7fa2a64290
Merge branch 'master' of https://github.com/Chaplain/TrinityCore
2011-09-27 19:19:25 +02:00
224bb96deb
Core/Spells: Fix talent Sword Specialization.
2011-09-25 16:42:12 +03:00
e949ad3adb
Core/Spells: spell effect handling improvements
...
* Call spell effect handlers in 4 modes:
- SPELL_EFFECT_HANDLE_LAUNCH - called when spell is launched (cast just finished)
- SPELL_EFFECT_HANDLE_LAUNCH_TARGET - called when spell is launched for each target in spell target map
- SPELL_EFFECT_HANDLE_HIT - called when spell hits its destination
- SPELL_EFFECT_HANDLE_HIT_TARGET - called when spell hits it's target from spell target map
*Correctly implement SPELL_EFFECT_TRIGGER_SPELL, SPELL_EFFECT_TRIGGER_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL_WITH_VALUE, SPELL_EFFECT_TRIGGER_MISSILE_SPELL
*Remove spell system hacks which became obsolete with this commit
Core/SpellScripts:
add OnEffectLaunch, OnEffectLaunchTarget, OnEffectHit, OnEffectHitTarget hooks for new effect handle modes and remove OnEffect hook.
A generic rule of thumb how to update your scripts (will work for nearly all cases) for spell system noobs:
if your spell script used GetHitXXXX function, you need to use OnEffectHitTarget, otherwise use
OnEffectHit
2011-09-25 13:29:50 +02:00
da0229da8f
Core/Scripts: Implemented 2 new target selectors, one specialized for spells, checking auras, range and attributes; and the other is a very simple non-tank selection what is sufficient for most cases
2011-09-24 19:40:57 +02:00
d01a761f53
Core/Spells: Drop EFFECT_IMPLICIT_TARGET_PET and use EFFECT_IMPLICIT_TARGET_EXPLICIT instead.
2011-09-24 02:02:39 +02:00
13a1d90130
Core/Spells: Improvements in selecting default targets based on effect type.
2011-09-23 11:58:40 +02:00
fe25ce4fa3
Core/AI: Replace many Unit::IsHostileTo with Unit::IsValidAttackTarget or Creature::canCreatureAttack.
2011-09-17 00:56:59 +02:00
9bbb4ef583
Core/Spells: Use Unit::IsValidAttack/AssistTarget functions to validate spell explicit targets.
2011-09-16 22:17:49 +02:00
f356f65fa6
Core/Spell: Remove obsolete check, its already handled in a better way using SpellScript
2011-09-16 12:32:09 +02:00
732e27f1e8
Core/Spells: Spells having the same effect types on multiple effects will now select them at the same time (except targets selected by entry) to ensure correct behavior with MaxAffectedTargets use
2011-09-16 11:40:53 +02:00
6c943bfb08
Core: Cleanup in MiscHandler::SendAreaTriggerMessage and warning fixes
2011-09-16 10:53:24 +02:00
af05915b9e
[Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions)
2011-09-15 14:12:57 +02:00
b7f6416ee3
Core/Spells: Fixed summoning to instances
2011-09-15 00:02:45 +02:00
1d38ccaca6
Core/Spells: Remove redundant explicit target checks from Spell::cast
2011-09-11 22:42:29 +02:00
7c85617847
Core/Spells: Don't check cast requirements twice for instant cast spells.
2011-09-11 22:27:21 +02:00
45af1238cf
Conditions/DisableMgr: converted from singleton to namespace with free functions.
2011-09-09 14:27:23 +02:00
94126e0369
Core/Spells: Fix some talents with incorrect target entries in dbcs. This is an alternative fix for #2848 . Closes #2846 Closes #2848 .
2011-09-06 11:21:40 +02:00
3fac9914be
Core: Code cleanup (here and there)
2011-09-05 14:01:50 +02:00
dca0e737de
Core/Quests: Fix quests with RepObjective2 set. Closes #2901 .
...
Misc: Correct a file name, move a spell error to error log and a small typo in trinity_string
2011-09-04 23:44:01 +01:00
5a526d6d7f
Core/Spells: Fix Shadowflame and others from spell_linked_spell with + + 1 db setting.
2011-09-03 20:38:23 +02:00
ddacd0de94
Core/Spells: Fix pick lock - thanks to cyberbrest for pointing the reason of this issue.
2011-09-03 20:16:15 +02:00
b40bf69319
[Core/Threat] SpellThreat-Calculation revamped
...
short:
- Threat is now distributed blizzlike (almost)
long:
- Percent- and AP-Modifieres got add
- Threat is now propperly distributed through multiple enemies
- Most spells will cause initial threat in an amount equal to their SpellLevel
- Energize-Effects will now be treated like healing (threat-wise)
- Tanks got their missing +43% passive threat tacked on
- Paladins are still missing 'Salvation' and will not only cause half threat with healing (essentially 25% of the amount healed)
2011-09-03 17:42:44 +02:00
d23b03271d
Merge pull request #2777 from KoffeinKaio/fishing
...
Core/Spells: Fixed fishing bobber landing angle.
2011-09-03 07:52:47 -07:00
414f048bd5
Merge pull request #2735 from hacknowledge/fix_2734
...
Core/Spells: Fixes ammo consumption for Hunter's Volley
2011-09-03 07:29:31 -07:00
aa85553bfd
Core: Crash fix (TemporarySummon), remove some warnings and some other minor changes
...
- "const uint64" and "uint64 const" --> uint64
- Add some info in LFGDungeonEntry
- Move some definitions from ".h" files and move to ".cpp"
2011-08-30 13:46:36 +02:00
d863562507
Core/Spells: Make core be a little less strict about some spell attributes SPELL_ATTR0_CASTABLE_WHILE_DEAD and SPELL_ATTR2_CAN_TARGET_NOT_IN_LOS checks.
2011-08-30 00:13:53 +02:00
eba169e5f1
Fixed fishing bobber landing angle.
2011-08-27 14:34:56 +00:00
8754166071
Core/Spells: Send expected type of spell implicit target to client.
2011-08-27 12:59:57 +02:00
751cbaf307
Core/Spells: Fix a typo (!GetDst() instead of !HasDst()) which prevented from automatical lconverion of spell unit target to destination target (this is only used in script casts). Closes #2761 .
2011-08-26 16:30:56 +02:00
kaelima