1f7e888465
Core/Units: Units shouldn't be able to dodge while casting
2010-12-29 14:37:55 +01:00
68c6189201
Core/Vehicles:
...
- Set MovementFlagsExtra (2) correctly depending on vehicle 'template' flags. This makes certain vehicles such as demolishers unable to jump/strafe (as intended)
- Fix SMSG_MONSTER_MOVE_TRANSPORT stucture, prevents a client crash when entering certain vehicles, as well as *properly* broadcast position relative to the vehicle.
- Send SMSG_BREAK_TARGET to player when entering vehicle.
- Set MOVEMENTFLAG_ROOT on passenger when entering vehicle
- Cleanup in affected code
2010-12-29 05:45:38 +01:00
52620db629
Core/Auras: Fixed enchant proc stack rules
...
Closes issue #5222 .
--HG--
branch : trunk
2010-12-27 22:27:11 +01:00
ef968f4b15
Core/Unit: Big cleanup in Unit::CalcAbsorbResist
...
Core/AuraScript:
Fix compile time check for AuraScript functions
Remove AuraApplication from hook functions parameter list, use GetTarget() and GetTargetApplication() instead
Add OnEffectAbsorb hook
Scripts: move handlers of Spell Deflection, Savage Defense, Primal Tenacity, Nerves of Steel, Astral shift from core to scripts.
--HG--
branch : trunk
2010-12-27 20:14:54 +01:00
dd745ef326
Core/Vehicles: Some research on VehicleSeatFlagsB.
...
It is assumed that VehicleSeatFlagsB & 322 means the seat can be used indirectly (ie. by aura 236 (SPELL_AURA_CONTROL_VEHICLE)) even though !(VehicleSeatFlags & VEHICLE_SEAT_FLAG_USABLE).
More research to be done Soon (tm).
--HG--
branch : trunk
2010-12-27 16:55:17 +01:00
29d5e4e4d5
Core: Remove a useless log-error in Unit::BuildMovementPacket()
...
--HG--
branch : trunk
2010-12-26 00:38:01 +01:00
f4e46db38a
Core/Auras: Add some asserions to hunt down reason of a crash in Aura::UpdateTargetMap. Thanks to Shauren for inspiration.
...
--HG--
branch : trunk
2010-12-26 00:14:13 +01:00
70ec4a8f9b
Fix build
...
--HG--
branch : trunk
2010-12-25 20:12:31 +01:00
06d014f04d
Core/Spells: Remove double initialization of ¨GetAuraEffectsByType(SPELL_AURA_MOD_DAMAGE_PERCENT_DONE)¨ in Unit::MeleeDamageBonus
...
Patch by gianni.elio@hotmail.it
Fixes issue #5269
--HG--
branch : trunk
2010-12-25 20:04:12 +01:00
bce9b081ec
Core/Unit: Fix crashes in Unit::CalcAbsorbResist and Unit::DealDamage caused by unsafe iteration over Unit::AuraEffectList - copy the list instead of using oryginal one.
...
--HG--
branch : trunk
2010-12-25 16:12:31 +01:00
b181ba21d9
Core: Fix a few warnings here and there.
...
--HG--
branch : trunk
2010-12-25 06:28:38 +01:00
088ed9404b
Core/Entities: Fix a minor disrepancy in the handling of weapon specializations introduced in revision a83f26ef71 - patch by Dr.Tenma
...
Fixes issue 5059.
Fixes issue 5265.
--HG--
branch : trunk
2010-12-25 04:03:04 +01:00
928443d899
Core: Removed more operator workarounds for ACE_Singleton (missed previously because of inconsistent naming)
...
--HG--
branch : trunk
2010-12-23 23:25:44 +01:00
ca78881c63
Core/Spells: Fix a warning in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE (explicitly define which parts to check for)
...
--HG--
branch : trunk
2010-12-23 18:35:43 +01:00
0cdc4153d8
Core/Spells: Fix Glyph of Death Grip
...
Fixes issue #4608
--HG--
branch : trunk
2010-12-23 17:38:31 +01:00
392a312c6b
Core/Spells: Fix SPELL_AURA_MOD_DAMAGE_PERCENT_DONE(79) to affect proper spellschools based on EffectMiscValue.
...
Author: Dr.Tenma
Fixes issue #4019
Fixes issue #5059
--HG--
branch : trunk
2010-12-23 16:22:30 +01:00
b1ded4bd98
Core/Unit: Check if NPC is on a transport before sending StopMoving() -packet (normally shipped when trying to speak to moving NPCs) - fixes creatures falling off boats etc.
...
Thanks to Socolin for hunting down and patching this annoying bug.
--HG--
branch : trunk
2010-12-22 21:31:52 +01:00
0f3b9019a8
Core: Get rid of dirty operator workaround for ACE_Singleton class implementation
...
--HG--
branch : trunk
2010-12-22 21:25:23 +01:00
7b4e1c6387
Core/ObjectMgr: Static members are no longer accessed through singleton
...
--HG--
branch : trunk
2010-12-22 20:23:47 +01:00
5809c1fa3b
Core/Auras: Fixed auras incorrectly stacking with different item casters introduced in r19f21916a940
...
Closes issue #5218 .
--HG--
branch : trunk
2010-12-21 11:40:20 +01:00
e3e77aceab
Scripts/Temple of Anh'Qiraj: Fixed possible crash in mob_anubisath_sentinel
...
--HG--
branch : trunk
2010-12-20 11:39:12 +01:00
756ee5832b
Core/Auras: Allow stacking of auras proced from different items
...
Closes issue #2296 .
--HG--
branch : trunk
2010-12-20 11:04:48 +01:00
33808ab567
Core/Spells: Fix Improved Spirit Tap proc from Mind Flay crits.
...
Author: Dr.Tenma
Fixes issue #2786
--HG--
branch : trunk
2010-12-20 01:58:15 +01:00
59da698189
Core: Rename spell attributes, use more general names
...
--HG--
branch : trunk
2010-12-19 05:15:47 +01:00
7196b880d6
Core/Spells: Fixed possible crashes in Shadow's Fate proc (71169) introduced in r91073dc6ace3
...
Core/AuctionHouse: Removed "using namespace std" and fixed crash in AuctionHouseMgr destructor
Closes issue #5132 .
Closes issue #5134 .
--HG--
branch : trunk
2010-12-18 23:16:55 +01:00
57132e35b8
Core/Spells: Fix spells 59915 and 59906 / Discerning Eye of the Beast and Swift Hand of Justice (Heirloom trinkets)
...
Fixes issue #2435
Fixes issue #2529
--HG--
branch : trunk
2010-12-18 12:27:40 +01:00
32d94ed52a
Core/Units: Aura´s of type SPELL_AURA_MOD_RESISTANCE_EXCLUSIVE (143) should stack with eachother in the way that only the strongest aura of each magical school applies.
...
Author: Iskander
Fixes issue #3897
--HG--
branch : trunk
2010-12-17 20:31:46 +01:00
0785ad465b
Core/Pets: Clean up logic/codedesign slightly for XP/levelup-handling, and also fix a possible overflow in the pet level-tests
...
(Thanks to Vladimir for the discussion regarding the possible overflow!)
--HG--
branch : trunk
2010-12-17 20:08:27 +01:00
b11e5bbf81
Core/Achievements: Prevent ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates at login
...
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HONORABLE_KILL_AT_AREA
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_TEAM_RATING
Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_REACH_TEAM_RATING
Core/Achievements: Implemented map id requirement for achievement criterias
Closes issue #4479 .
Closes issue #4478 .
Closes issue #4473 .
Closes issue #4472 .
Closes issue #4471 .
Closes issue #4480 .
Closes issue #2284 .
Closes issue #4481 .
--HG--
branch : trunk
2010-12-17 18:12:46 +01:00
82f45966fc
Core/Unit: Renamed addUnitState/hasUnitState/clearUnitState to AddUnitState/HasUnitState/ClearUnitState
...
Core/Vehicles: Allow the vehicle to always damage the passenger (removed unneded dbc hacks from scripts)
--HG--
branch : trunk
2010-12-17 13:43:24 +01:00
a6df53bbe2
Core/Spells: Fix erraneous behaviour on hunter spell Lock and Load (disable charge-drop) - thanks to Dr. Tenma
...
Closes issue 3307
--HG--
branch : trunk
2010-12-17 04:52:17 +01:00
2642894342
Core: Add new system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Patch by Ambal.
...
(And clean up tabs and whitespace while rummaging around in there)
Closes issue 5084.
--HG--
branch : trunk
2010-12-13 22:37:56 +01:00
d2d62eab50
Cleanup: implemented helper methods for manipulating percentage calculation and used it where appropriate (plus fixed some other warnings).
...
NOTE: Initially I just wanted to fix some warnings, but noticed that there is no common method for percentage calculation and various formulas are used many time in the code making it difficult to read and understand what the code actually does. So, I introduced several template methods for calculating percent values and adding those values to the original base. I replaced all the raw calculations throughout the code where found, but I could have missed something or could have made a mistake. So, please report any strange behaviour after this commit.
If you ask me why I did it: for the sake of consistency and exact understanding what code means. If you see CalculatePct method, you clearly understand, that it find the value of x percent of y. And you can easily express, for example, spell behviour "reduces smth by x%" by the means of a method instead of recalling school maths.
--HG--
branch : trunk
2010-12-11 20:37:38 +06:00
81db111ffd
Core/Spells: Fix mage talent Frost Warding (and a little cleanup on CalcAbsorbResist) - patch by DrTenma
...
Fixes issue 2715.
Closes issue 3770.
--HG--
branch : trunk
2010-12-11 12:00:57 +01:00
e7eb4e22e2
Core/Mechanics: cleanup shapeshift form code (by VladimirMangos)
...
--HG--
branch : trunk
2010-12-09 17:03:42 +06:00
8c2ce7f86d
Core/Auras: fix AuraType 138 to not affect ranged haste, and rename to SPELL_AURA_MOD_MELEE_HASTE (by michalpolko)
...
--HG--
branch : trunk
2010-12-09 14:40:59 +06:00
703835ee94
Core/Quests: Fixed Unholy Infusion (24749), Blood Infusion (24756) and added partial support for Frost Infusion (24757)
...
--HG--
branch : trunk
2010-12-06 22:54:19 +01:00
3661ed8231
Core/Auras: Fix wrong durations on certain reflected spells.
...
Patch by dr.tenma.
Fixes issue #3611 .
--HG--
branch : trunk
2010-12-04 10:51:46 -08:00
ada9c4ae98
Core/CreatureAI: Implemented SummonedCreatureDies function for scripting, it is called when the summoner's summon dies.
...
--HG--
branch : trunk
2010-12-03 14:23:49 -03:00
e0c992a8ba
Scripts/Icecrown Citadel: Added script for Blood Queen Lana'Thel
...
Scripts/Icecrown Citadel: Fixed Invocation of Blood announcement emote for Blood Prince Council
Scripts/Icecrown Citadel: Fixed intro for Lady Deathwhisper
Scripts/Icecrown Citadel: Fixed Bone Spike for Lord Marrowgar
--HG--
branch : trunk
2010-12-03 17:47:33 +01:00
46d39f17b4
Fix typo from revision 3f0577c8e6
...
--HG--
branch : trunk
2010-11-26 02:37:56 +01:00
025d070752
Core/Unit: Fix pets aggromode - do not set player in combat untill pet has actually done damage to target (fix by Kaelima)
...
Closes issue 4894.
--HG--
branch : trunk
2010-11-26 02:02:05 +01:00
87d723405e
Core/Scripts: return const modifier to Player methods back (should restore compilation for those with custom scripts).
...
NOTE: The main idea of original change is to allow scripts change content of message so that calling method sends modified message to client.
For example, moderating script which cuts illegal words from message.
--HG--
branch : trunk
2010-11-18 10:26:34 +06:00
2e68705e22
Core/Spells: Use ShapeshiftForm model IDs from DBC instead of as hardcoded values - fix by Kaelima
...
(Some shapeshifts need overrides due to missing DBC data, and needs hardcoding - already handled)
Closes issue 4832.
--HG--
branch : trunk
2010-11-17 18:15:49 +01:00
4fb572015a
Core/Scripts: pass message parameter by reference in OnChat methods to make it possible to be modified inside the script.
...
--HG--
branch : trunk
2010-11-17 18:14:35 +06:00
addd762c4d
Core: Fix warnings
...
--HG--
branch : trunk
2010-11-16 14:08:12 +01:00
0dc3d771e1
Core/Unit: Add missing/update old shapeshifting modelforms for Shapeshifting - Fix by Kaelima
...
Closes issue 4804
--HG--
branch : trunk
2010-11-16 14:04:15 +01:00
8fae0c176d
Core/Units: Rename and change Get/SetVisibility to use a bool value instead of an unnecessary enum
...
Also replace some SetVisibility hacks to directly call UpdateObjectVisibility
--HG--
branch : trunk
2010-11-16 01:13:04 +01:00
48d90fab32
Misc: Some engrish fixes, thanks to ZxBiohazardZx, closes issue 4740
...
--HG--
branch : trunk
2010-11-14 23:46:34 +02:00
880ef0c398
Core/Spells: Fix spelleffect sanctuary
...
- No longer removes every attacker, but updates the visibility
- Using that effect won't remove attackers that can still see through the stealth of the caster based on distance
- Ignores spells that were casted before or at the same time of that effect
- Trigger other needed spells when casting Shadowmeld
--HG--
branch : trunk
2010-11-13 18:04:56 +01:00
Machiavelli