Commit Graph

10590 Commits

Author SHA1 Message Date
Carbenium 1438c841ed Core/Player: Move TradeData to its own file
(cherry picked from commit 2d7d6f505c)

Conflicts:
	src/server/game/Entities/Item/Item.cpp
	src/server/game/Entities/Player/Player.cpp
	src/server/game/Entities/Player/Player.h
	src/server/game/Handlers/TradeHandler.cpp
	src/server/game/Spells/Spell.cpp
2015-11-14 13:40:32 +01:00
tkrokli 95d6f09243 Scripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)
Coverity scan defects CID 1339315, 1339316 and 1339317:
- CID 1339315: boss_thaddius.cpp: 542
- CID 1339316: boss_thaddius.cpp: 811
- CID 1339317: boss_thaddius.cpp: 398

Added missing break; statements.
2015-11-14 05:12:25 +01:00
Vincent-Michael d0c28c66eb Core: Fix warning 2015-11-14 01:23:28 +01:00
Vincent-Michael d188960216 Core/Condition: Fix issue reported by static analysis
Coverity defect ID: 1339314
2015-11-14 00:56:44 +01:00
Vincent-Michael 2ee01a7b3d Core: Fix non pch build 2015-11-13 20:19:16 +01:00
Shauren 536365a70f Fix build for mysql versions older than 5.7
(cherry picked from commit 5604aed5f1)
2015-11-13 09:28:14 +01:00
MitchesD e14e291ef6 Merge pull request #15523 from Treeston/3.3.5-thaddius
Scripts/Naxxramas: Thaddius: Complete rewrite
2015-11-12 19:46:46 +01:00
MitchesD a1150ce20f Merge pull request #15732 from ShinDarth/reset-health-mana
Scripts/Duel: implement duel reset of health and mana and improve duel reset
2015-11-12 19:40:26 +01:00
Shauren 9bc5088a81 Core/DBLayer: Ensure that MySQL version used when compiling is the same as libmysql.dll version used for running the server.
Ref #15848

(cherry picked from commit 0a27f8bce2)
2015-11-12 17:55:10 +01:00
Carbenium c5f635b689 Core/Creature: Remove duplicate call to LoadCreatureAddons in Creature::Create
* Add error log for duplicated aura entries in creature_(template_)addon
2015-11-11 00:13:43 +01:00
jackpoz abd4e2e0f1 Core/Commands: Fix NULL dereference crash
Closes #15833
2015-11-10 21:14:18 +01:00
Carbenium 52692c3f9d Merge pull request #15835 from ariel-/entry
Creature Addon should be updated when entry is changed.
2015-11-10 04:21:14 +01:00
Carbenium 2a36b00907 Core/Player: Improve a log message
(cherry picked from commit 7eb314fcd1)
2015-11-10 00:50:15 +01:00
Carbenium 52394eb93c Core/ObjectMgr: Disable not linked graveyard error log for zoneId == 0 2015-11-09 23:34:50 +01:00
ariel- ee161a0bfa Reload creature addons on UpdateEntry. 2015-11-08 15:13:07 -03:00
Killyana 90c4304f1e Merge pull request #15022 from robinsch/GOdespawn
SmartAI: Possibility to despawn object with SMART_ACTION_FORCE_DESPAWN
2015-11-08 16:54:58 +01:00
treeston 29feae5901 Scripts/Naxxramas: Complete rewrite of the Thaddius encounter. 2015-11-08 14:57:01 +01:00
ShinDarth 3b1db7a514 Scripts/DuelReset:
- do not reset when duel is fled
- minor improvement to SpellHistory::RestoreCooldonStateAfter duel method
2015-11-07 21:16:18 +01:00
Vincent-Michael 7d5e7102cd Core: Whitespace cleanup 2015-11-07 20:01:53 +01:00
Vincent-Michael ff9001ce1d Updated url for tc wiki
(cherry picked from commit 6d01960448)
2015-11-07 19:35:24 +01:00
Golrag 7593e861de Core/CreatureGroups: Don't set positionZ to ground for flying creatures.
(cherry picked from commit df4c856360)
2015-11-07 14:53:20 +01:00
Naios 97dd18cb78 Core/ScriptMgr: Improve commit 155a289f05
(cherry picked from commit 30c421bf57)
2015-11-07 13:10:21 +01:00
Naios d81784194c Core/ScriptMgr: Fix "conditional expression is constant" warning.
* introduced in commit 12d1993994

(cherry picked from commit 155a289f05)
2015-11-07 13:10:04 +01:00
Naios 3a3a6bbfd2 Core/Globals: Use std::string rather than char* to pass script names around.
(cherry picked from commit b7b49fe35f)

Conflicts:
	src/server/game/Battlegrounds/BattlegroundMgr.cpp
	src/server/game/Globals/ObjectMgr.cpp
2015-11-07 13:09:10 +01:00
Naios 23153c8bf1 Core/ScriptMgr: Replace IsDatabaseBound() methods through traits.
(cherry picked from commit 12d1993994)
2015-11-07 12:34:15 +01:00
Shauren 910fb00130 Core/Corpses: Fixed a possible crash adding bones to grid
Closes #15808

(cherry picked from commit ec1583df67)
2015-11-06 21:30:41 +01:00
Shauren d6c52ba28c Core/Commands: Added assertion checking if command name is not null
(cherry picked from commit 5695969725)
2015-11-05 21:30:29 +01:00
Shauren a17c27aaeb Core/Accounts: Fixed ban check after 517a30d7c1 2015-11-05 21:25:51 +01:00
jackpoz ea9c112b30 Merge pull request #15804 from Tonghost/3.3.5
Core/Misc: Remove unneeded files
2015-11-03 22:52:35 +01:00
Carbenium 12ae32a9b6 Merge pull request #15720 from Tonghost/3.3.5
Core/Items: Fix a trading spoof exploit.
2015-11-03 17:48:01 +01:00
sirikfoll 22f1d26986 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480
2015-11-03 17:01:25 +01:00
ShinDarth 7ab1d1b7d0 Core/Ticket improved ticket system
- Safely close ticket before character deletion
- Allow to keep trace of delete characters tickets (configurable)
- Closes #15655

Closes #15699
2015-11-03 16:07:30 +01:00
Incorrect d98037a75d Core/Misc: Remove unneeded files
These 3 BlackRock Mountain scripts can be removed from source:

- boss_anubshiah.cpp
- boss_gorosh_the_dervish.cpp
- boss_grizzle.cpp

They already removed from the creatures in DB, and are currently causing
DBErrors.
2015-11-02 02:11:52 +02:00
treeston 91de0322bb Scripts/Naxxramas: Anub'rekhan encounter cleanup.
- Cleaned up events behavior to use phases instead of weird checks for auras.
- Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death.
- Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script.
- Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset.
- Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss.
- Added missing boss emotes.
- Code style cleanup.
2015-11-01 22:31:48 +01:00
MitchesD c82311897a Merge pull request #15681 from Treeston/3.3.5-faerlina
Scripts/Naxxramas: Faerlina cleanup
2015-11-01 20:49:10 +01:00
jackpoz da0671f4fe Scripts/Naxxramax: Fix clang warning 2015-11-01 18:40:35 +01:00
Shauren 965d29484b Core/Items: Corrected all spellid checks from item_template to also check -1
Closes #15797
2015-11-01 16:29:29 +01:00
Naios 570e6baa09 Core/AI: Cleanup in CreatureAISelector
(cherry picked from commit 6fa4588191)
2015-11-01 15:05:16 +01:00
Naios 105f624763 Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version.
(cherry picked from commit 0b6f784591)
2015-11-01 15:03:02 +01:00
Shauren e8909de8de Core/Accounts: Check active column when determining if account is banned or not 2015-11-01 13:16:29 +01:00
Vincent-Michael 98cd477149 Core/Misc: Update game creature template locale in simple system
(cherry picked from commit 8aa55a0b57)
2015-10-31 20:54:59 +01:00
Shauren 14d382f185 Core/Conditions: Optimizations part 3 changed ConditionStore to a simple array
(cherry picked from commit db0c48c17f)
2015-10-31 20:26:40 +01:00
Shauren cba122ad94 Core/Conditions: Optimizations part 3 removed copying condition containers all over the place
(cherry picked from commit b09e63e9de)
2015-10-31 20:26:40 +01:00
Shauren 57c4b3d42c Core/Conditions: Add const to methods not modifying ConditionMgr
(cherry picked from commit 2cce998e90)
2015-10-31 20:26:40 +01:00
Shauren 6ab90cc57d Core/Conditions: Optimizations part 2 removed unneeded code
(cherry picked from commit e5c1e7d71c)
2015-10-31 20:26:40 +01:00
Shauren 3158605603 Core/Conditions: Optimizations part 1 - use containers more suited for their role
(cherry picked from commit 9fa938f3e0)
2015-10-31 20:26:40 +01:00
Shauren dc74454356 Core/Conditions: Type renaming
(cherry picked from commit 5e0cee85dd)
2015-10-31 20:26:40 +01:00
joschiwald 36a205ec00 Core: fixed warning introduced in last commit
(cherry picked from commit fe0c07a6fe)
2015-10-31 19:13:05 +01:00
joschiwald df88c7f278 Core/Misc: removed some useless map checks
(cherry picked from commit cf1e80e3d0)
2015-10-31 19:11:41 +01:00
Shauren 635dc9c02a Core/Players: Fixed automatic learning skills gained from learning spells when leveling
Closes #15391

(cherry picked from commit 3fceabfa11)
2015-10-31 18:57:59 +01:00