Lucas
065207b1b8
Core/Spells: Correct a mistake in HOT aura procs
...
A crash fix was added in 3e0d2e4944
but the usage of spellProcEvent itself was incorrect, we should instead use spellProto of aura to be procced
2014-05-03 02:28:49 +02:00
Vincent-Michael
5caf6aad98
Core/Texts:
...
* Fix creautre text with gender female
* Small cleanUp
* ObjectMgr.cpp/ObjectMgr.h part from joschi
2014-04-30 22:15:28 +02:00
Vincent-Michael
ba8959b733
Core/MSVC: Remove double warning disables
2014-04-28 22:44:56 +02:00
Vincent-Michael
57cf043aec
Core/Creature: Missed changes in c536305e3a
2014-04-28 09:19:37 +02:00
Kinzcool
c536305e3a
Core: Droped faction_H field -- only one faction table is necessary
2014-04-27 18:13:55 -04:00
jackpoz
2585e799f9
Core/Misc: Change how Position struct is retrieved
...
Update Position::GetPosition() and similar methods signatures to reflect 2a4c9bcaf9 changes by return a Position object instead of accepting a Position parameter by reference.
2014-04-25 21:19:30 +02:00
ZackTsuna
518190ee88
Core/Units: Don't set new power type if old power type is the same
2014-04-20 21:22:21 +02:00
jackpoz
8ca6371793
Core/Misc: Ensure GetVictim() returns a valid reference when expected
...
Add a new method EnsureVictim() which asserts a valid not NULL reference will be returned to the caller. Use this whenever the GetVictim() would be dereferenced .
2014-04-19 21:48:22 +02:00
Unholychick
574fa30ea6
Core/Spells: Convert Avenging Wrath to spellscript
...
Closes #11896
Closes #3464
2014-04-18 20:21:05 +02:00
Shauren
e51976e17a
Core/Spells: Fixed players being able to mount with all transform auras
...
Closes #11852
2014-04-13 01:06:46 +02:00
Unholychick
7a0c2fc4f7
Fix SPELL_DAMAGE_CLASS_NONE unable to crit
...
Corrected logic mistake where switch fallthrough was intended (or should have been).
Fixes the following.
// Earth Shield
// Lifebloom Final Bloom
// Divine Hymn
// Item - Bauble of True Blood 10m
// Item - Bauble of True Blood 25m
2014-04-08 14:32:31 +02:00
Unholychick
7b55dcf0f8
Fix SPELL_AURA_MOD_AOE_AVOIDANCE
...
There is not a single spell using this aura, but now it works :)
2014-04-07 09:50:05 +02:00
Shauren
3fd6dd6175
Core/Loot
...
* Master Looter cannot freely loot items under threshold
* Update round robin looter only if loot is not empty
* Fixed loot bag icon appearing in raid frames when loot method was not Master Looter
* Fixed changing loot method reseting current round robin looter
2014-03-29 13:29:22 +01:00
jackpoz
5570e32d0e
Core/Misc: Fix assertion triggered
...
Change an assertion added in 6dcd8c8545 with a NULL check, properly handling the case of a NULL parameter.
Fixes #11771
2014-03-24 20:13:55 +01:00
jackpoz
6dcd8c8545
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior
Please ensure EventMap is never used with event id set to 0 or those events will never execute.
2014-03-22 14:54:32 +01:00
Shauren
ada0598bb0
Core/Transports: Fixed creatures micro movement on transport when attacking something (fixes interrupting melee animation)
2014-03-21 21:11:20 +01:00
Shauren
0d51fd55a1
Core/Auras: Implemented SPELL_AURA_MOD_COOLDOWN
...
Closes #9671
2014-02-05 13:00:42 +01:00
jackpoz
8f29fb9aee
Core/Spell: Handle SPELL_AURA_FORCE_REACTION missing cases
...
Always check forced reputation ranks before any other faction check to get the reaction between 2 units.
Fixes #5790
2014-02-01 21:21:47 +01:00
Vincent_Michael
955fb907c5
Core: Fix warnings
2014-01-26 03:48:33 +01:00
joschiwald
96060bf007
Core/Spells: move some spells so spellscripts
2014-01-26 01:02:20 +01:00
Zabustak
cde9717bd1
Core/Spell: Retaliation no longer does anything while the warrior is stunned.
...
Closes #11481
2014-01-20 20:10:13 +01:00
joschiwald
940e52236b
Core/Entities: bg vehicle will also have charmer's faction (save faction before charm and restore old faction after charm)
2014-01-17 01:07:37 +01:00
Elron103
88ecc9533a
Core/Entities: Fix combat state setting when FFA PvP flag is set
...
Description:
Currently there is an issue, when you are in FFA areas, but you dont have PvP flag activated.
You should get the PvP-In-Combat delay timer, but instead you just get the usual timer as if you would not fight in PvP.
Reproduction:
1) Get two players in FFA area Gurubashi arena down in the battle area (.tele Gurubashi)
2) Fight each other
3) When stopping combat, the combat state will switch off immediately. But it is supposed to switch off after some delay, because it was a PvP fight.
Closes #11103
Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com >
2014-01-13 17:03:43 +00:00
Shauren
15cbe5858c
Core/Movement: Fixed vehicle passengers disappearing clientside
...
Closes #11411
2014-01-06 13:51:40 +01:00
joschiwald
cd76d32907
Core/Entities: correct creature damage, offhand damage should work too
...
* todo: some creatures need dmg_multiplier update in creature_template
2014-01-04 18:22:06 +01:00
Vincent_Michael
20004050bc
Update copyright note for 2014.
...
Happy new year.
2014-01-01 00:07:53 +01:00
Nawuko
6d21d33aac
Core: user defined literals need a space in front
2013-12-30 20:35:37 +01:00
Malcrom
fe95371d9a
Core/Scripting: Replace casted with cast as casted is not a word.
2013-12-25 14:16:55 -03:30
jackpoz
b3c810a0fb
Core/Misc: Fix warning
...
Partially revert f0a742a8c4 to fix a warning about unhandled switch case (the same case that Coverity reported as dead code) .
2013-12-16 19:52:50 +01:00
Malcrom
a2e7191b26
Core/Unit: prevent COMMAND_ATTACK being added for Trained Rock Falcon.
...
Also added spells for Trained Rock Falcon to db.
2013-12-15 13:43:18 -03:30
jackpoz
f0a742a8c4
Core/Misc: Remove unused code
...
Remove unused debugging code added in MaNGOS r5067.
Remove dead code from a switch found by Coverity.
2013-12-15 13:37:49 +01:00
w1sht0l1v3
89ee8cbac1
Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries.
2013-12-15 14:09:49 +02:00
jackpoz
1c0903e286
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
2013-12-14 18:41:26 +01:00
Shauren
54fd53f7e3
Core/Movement: Fixed possible invalid memory access
2013-12-12 09:50:52 +01:00
trickerer
91ebea4a77
Don't allow units to enter combat upon death
2013-12-11 09:38:24 +07:00
jackpoz
f418f4cf94
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values in scripts.
Add spell id validation in Unit::SpellNonMeleeDamageLog() .
2013-12-08 22:04:30 +01:00
Malcrom
5c15e88da9
Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries.
2013-12-08 11:55:28 -03:30
joschiwald
9a0bb93b33
Scripts: fix warning and cleanup npc_apprentice_mirveda
2013-11-24 21:49:51 +01:00
Shauren
1966a78b9f
Core/Movement: Backported spline stop fix from 4.3.4 branch - use Stop spline type for stopping movement instead of starting movement that ends in creature's current position
2013-11-10 18:52:20 +01:00
Spp
94e2b9332a
Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
2013-11-08 10:50:51 +01:00
leguybrush
0a308144a8
Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.
2013-10-28 14:36:07 -04:00
Shauren
b81bf7d025
Core/Spells: Implemented additional conditions for spells that start cooldown after an event instead of after cast
2013-10-26 14:39:00 +02:00
Shauren
06f5011071
Core/Auras: Added serverside checking for UNIT_FLAG_PACIFIED when attempting to start melee attack
...
Closes #8623
2013-10-22 17:09:41 +02:00
Discover-
1a6157985c
Core/Misc: Get rid of some useless code
2013-10-21 09:15:17 +02:00
Shauren
b6db622b52
Core/Transports: Fixed crashes happening when passenger is removed from transport during teleport
...
Closes #11067
2013-10-20 14:27:17 +02:00
Shauren
ce55647c41
Core/Transports
...
* Rewritten path generation, now uses splines - timers are a lot more accurate now
* Implemented stopping transports
* Implemented spawning transports in instances
* Implemented spawning gameobjects as transport passengers
* Transport passengers are now stored in creature/gameobject table using gameobject_template.data6 from transport's template as map id
2013-10-16 18:37:29 +02:00
Discover-
82eda3244a
Core/Misc: Ugh.. Fix recent commit that broke the OnHeal hook 😥
2013-10-14 16:56:09 +02:00
Discover-
db848f2045
Core/Misc: Fix build after 731b3670fe (again..)
2013-10-12 13:41:00 +02:00
Shauren
1d3e3fac89
Build fix
2013-10-06 12:09:05 +02:00
Shauren
9d19e4d0ac
Core/Commands: Restored old functionality of getSelectedPlayer in chat commands
...
Also fixed build
2013-10-06 11:28:25 +02:00