araxiaonline/TrinityCore
3
0
Fork 0
mirror of https://github.com/araxiaonline/TrinityCore.git synced 2026-06-13 03:32:28 -04:00
Code Issues Packages Projects Releases Wiki Activity

Core/Misc: Remove outdated TODO comment

Browse Source
This commit is contained in:
Shauren
2026-03-12 11:16:22 +01:00
parent a3d50e0796
commit bdceccd571
2 changed files with 55 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
src/server/game/Server/Packets/CharacterPackets.cpp
View File

@@ -544,6 +544,38 @@ void CharCustomize::Read()
SortCustomizations(CustomizeInfo->Customizations);
}
CharCustomizeSuccess::CharCustomizeSuccess(CharCustomizeInfo const* info)
: ServerPacket(SMSG_CHAR_CUSTOMIZE_SUCCESS, 16 + 1 + 1 + 1 + 1 + 1 + 1 + 1), Customizations(info->Customizations)
{
CharGUID = info->CharGUID;
SexID = info->SexID;
CharName = info->CharName;
}
WorldPacket const* CharCustomizeSuccess::Write()
{
_worldPacket << CharGUID;
_worldPacket << uint8(SexID);
_worldPacket << Size<uint32>(Customizations);
for (ChrCustomizationChoice customization : Customizations)
_worldPacket << customization;
_worldPacket << SizedString::BitsSize<6>(CharName);
_worldPacket.FlushBits();
_worldPacket << SizedString::Data(CharName);
return &_worldPacket;
}
WorldPacket const* CharCustomizeFailure::Write()
{
_worldPacket << uint32(Result);
_worldPacket << CharGUID;
return &_worldPacket;
}
void CharRaceOrFactionChange::Read()
{
RaceOrFactionChangeInfo = std::make_shared<CharRaceOrFactionChangeInfo>();
@@ -826,38 +858,6 @@ WorldPacket const* SetFactionVisible::Write()
return &_worldPacket;
}
CharCustomizeSuccess::CharCustomizeSuccess(CharCustomizeInfo const* info)
: ServerPacket(SMSG_CHAR_CUSTOMIZE_SUCCESS, 16 + 1 + 1 + 1 + 1 + 1 + 1 + 1), Customizations(info->Customizations)
{
CharGUID = info->CharGUID;
SexID = info->SexID;
CharName = info->CharName;
}
WorldPacket const* CharCustomizeSuccess::Write()
{
_worldPacket << CharGUID;
_worldPacket << uint8(SexID);
_worldPacket << Size<uint32>(Customizations);
for (ChrCustomizationChoice customization : Customizations)
_worldPacket << customization;
_worldPacket << SizedString::BitsSize<6>(CharName);
_worldPacket.FlushBits();
_worldPacket << SizedString::Data(CharName);
return &_worldPacket;
}
WorldPacket const* CharCustomizeFailure::Write()
{
_worldPacket << uint32(Result);
_worldPacket << CharGUID;
return &_worldPacket;
}
void SetPlayerDeclinedNames::Read()
{
_worldPacket >> Player;

48
src/server/game/Server/Packets/CharacterPackets.h
View File

@@ -417,7 +417,29 @@ namespace WorldPackets
std::shared_ptr<CharCustomizeInfo> CustomizeInfo;
};
/// @todo: CharCustomizeResult
class CharCustomizeSuccess final : public ServerPacket
{
public:
explicit CharCustomizeSuccess(CharCustomizeInfo const* customizeInfo);
WorldPacket const* Write() override;
ObjectGuid CharGUID;
std::string CharName;
uint8 SexID = 0;
Array<ChrCustomizationChoice, 250> const& Customizations;
};
class CharCustomizeFailure final : public ServerPacket
{
public:
explicit CharCustomizeFailure() : ServerPacket(SMSG_CHAR_CUSTOMIZE_FAILURE, 1 + 16) { }
WorldPacket const* Write() override;
uint32 Result = 0;
ObjectGuid CharGUID;
};
class CharRaceOrFactionChange final : public ClientPacket
{
@@ -839,30 +861,6 @@ namespace WorldPackets
uint32 FactionIndex = 0;
};
class CharCustomizeSuccess final : public ServerPacket
{
public:
explicit CharCustomizeSuccess(CharCustomizeInfo const* customizeInfo);
WorldPacket const* Write() override;
ObjectGuid CharGUID;
std::string CharName;
uint8 SexID = 0;
Array<ChrCustomizationChoice, 250> const& Customizations;
};
class CharCustomizeFailure final : public ServerPacket
{
public:
explicit CharCustomizeFailure() : ServerPacket(SMSG_CHAR_CUSTOMIZE_FAILURE, 1 + 16) { }
WorldPacket const* Write() override;
uint32 Result = 0;
ObjectGuid CharGUID;
};
class SetPlayerDeclinedNames final : public ClientPacket
{
public: