Common/Containers: Eliminate a edge case that could potentially lead to object invalidation.

(cherry picked from commit 64a61e03ab)
2026-06-20 15:01:38 -04:00 · 2018-07-19 11:59:36 +02:00
parent b638f37788
commit 839d30e93b
1 changed files with 2 additions and 1 deletions
@@ -68,7 +68,8 @@ namespace Trinity
                // this element has chance (elementsToKeep / elementsToProcess) of being kept
                if (urand(1, elementsToProcess) <= elementsToKeep)
                {
-                    *keepIt = std::move(*curIt);
+                    if (keepIt != curIt)
+                        *keepIt = std::move(*curIt);
                    ++keepIt;
                    --elementsToKeep;
                }