Commit Graph

373 Commits

Author SHA1 Message Date
Kandera b23ff228a4 Core/Spells: Used correct implementation for checking if a spell effect targets an area. 2012-03-15 14:14:42 -04:00
Kandera 5406a0fd93 Core/Spells: Fix bugged mass dispel after previous commits 2012-03-15 14:12:40 -04:00
Kandera fe46cf9796 Core/Spells: Fix being unable to use spells due hasDispellableAura being false if no spell effects were SPELL_EFFECT_DISPEL 2012-03-15 12:41:16 -04:00
Kandera 5e25791bff whitespace cleanup 2012-03-15 11:08:45 -04:00
Kandera 01bc6c483b Core/Spells: add correct checking for dispeling errors. Fixes spammable cleanse. 2012-03-15 10:56:56 -04:00
Shauren 84891377b5 Core/Spells: Fixed copy paste mistake that caused all area spells to search targets starting from caster's coordinates instead of targeted destination 2012-03-15 13:15:25 +01:00
leak 2a5caef4a6 Revert "Core: more more cleanup" - Build test anyone?
This reverts commit 20cd4c71ee.
2012-03-14 18:51:51 +01:00
thomas33 20cd4c71ee Core: more more cleanup 2012-03-14 17:51:11 +01:00
Machiavelli b1a8570a30 Core/Spells: Fix item target selection in Spell:SelectImplicitTargetObjectTargets. Typo spotted by zwerg 2012-03-11 14:52:11 +01:00
Subv 7c42cd76e4 Core/Conditions: Prevent crash at Spell::CheckCast if Condition::Meets returned prematurely 2012-03-09 17:15:22 -05:00
click a153e0ca06 Core: Remove some whitespace and tabs 2012-03-07 00:05:34 +01:00
QAston a08fe16d69 Core/Spells: Allow spell effects to have multiple destinations. Spells like: 49814, 10869 and similar are now properly selecting destination targets. 2012-03-03 00:19:48 +01:00
QAston e1b544d129 Core/Spells: Remove some obsolete code 2012-03-02 17:57:26 +01:00
Spp d38bc3a178 Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there 2012-02-27 14:58:47 +01:00
QAston a0de042efe Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore. 2012-02-25 14:07:07 +01:00
QAston b7b37dca29 Core/Spells: send spell error messages on spell cast condition checks. 2012-02-25 11:54:12 +01:00
Shauren dc28b92415 Core: Random cleanup + compile fix 2012-02-23 13:01:16 +01:00
QAston fb5d05c198 Core/Spells: Prevent assertion failure in Spell::SelectImplicitDestDestTargets by setting dest to caster if no dest provided. 2012-02-22 21:06:29 +01:00
Machiavelli fa546d1428 Core/Spells: Change logic in assertion in Spell::SelectImplicitTargetObjectTargets.
Not sure if this a step in the right direction for the intended design, but following the logic of the function there should be OR unit target OR gameobject target OR item target pointers available. If Item target doesn't belong there then the already present AddItemTarget call should be removed.
2012-02-22 19:16:47 +01:00
QAston 7a261ff9b8 Core/Spells: Use right function for obtaining spell target type. Fixes assertion failures. 2012-02-22 10:34:08 +01:00
QAston 2a1ffc1cd9 Core/Spells: Fix a typo in f09b5a6bea - call right function for target dest case.
Closes #5357
2012-02-22 10:21:02 +01:00
Spp 1e246cb66c Fix build (gcc) and fix warnings 2012-02-22 09:15:57 +01:00
QAston f09b5a6bea Core/Db/Conditions:
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required

Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
QAston 9abc47736f Core/Spells: Changes in code related to spell explicit target redirection (cleanups, added target validation, prevent unexpected behaviour in some cases) 2012-02-19 00:40:55 +01:00
kaelima 7ce7853606 Core/Spells: Revert part of 65d269f6de. Solves some recent instant spell casting issues. 2012-02-16 20:38:48 +01:00
Spp 03c34ee507 Fix a lot of warnings 2012-02-16 13:56:28 +01:00
Shauren 65d269f6de Core/Spells: Allow dead players as valid objects for RaiseDeadObjectCheck (enables Raise Dead on players that have not yet released spirit)
TODO: Allow all corpses
2012-02-15 00:46:08 +01:00
Subv 7d30b061f0 More compiler error fixes 2012-02-14 14:06:31 -05:00
Subv d55126aacb Core/Spells: Revert erroneous interruption added in 5ea49613d2 - more research required 2012-02-14 13:14:51 -05:00
Subv 8a72aede16 Codestyle: Renamed some variables to fit codestyle, corrected order in structure/class fields to match alignment (they use slightly less memory now)
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-14 12:46:26 -05:00
Subv 5ea49613d2 Core/Spells: Spell casts should be interrupted if the target goes out of LoS.
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-12 15:30:16 -05:00
QAston ce4a4ffe50 Core/Db/Conditions: Add ContidionTarget column which allows selection of objects which will be checked by condition, depending on SourceTypeOrReferenceId.
So far usable only with CONDITION_SOURCE_TYPE_SPELL:
ContidionTarget = 0 - check caster
ContidionTarget = 1 - check explicit target
2012-02-10 23:42:08 +01:00
QAston 8713b44ee7 Core/Db/Conditions: Prepare conditions system to work on objects of different type than players.
Warning: API has changed a bit:
ConditionScript::OnConditionCheck(Condition* condition, Player* player, Unit* invoker) is now
ConditionScript::OnConditionCheck(Condition* condition, WorldObject* object, WorldObject* invoker)
2012-02-10 14:18:59 +01:00
Subv 9791bb599a Merge pull request #5160 from TrinityCore/dynamic_vmaps
Added Dynamic Vmaps, RE-EXTRACT YOUR VMAPS
2012-02-09 11:17:05 -08:00
Subv2112 93d199f043 Core/Collision: Ported dynamic line of sight patch by Silverice from MaNGOS and
added lots of improvements
Please re-extract vmaps
2012-02-09 13:58:22 -05:00
Shocker 4623db0abe Merge pull request #5052 from devilcoredev/fix_003
Core/Spells: Check line of sight for AoE targeted spells
2012-02-09 10:29:45 -08:00
QAston b4022acdf3 Core/Spell: move conditions check to Spell::CheckCast. 2012-02-09 18:35:52 +01:00
QAston 22bd06fc57 Typofix. Sorry for that :( 2012-02-04 18:28:56 +01:00
QAston 9d185c5d66 Core/Spells: Fix immunity checks on apply aura - original patch by devilcoredev, changed a bit so immunity checks are grouped together instead of being spread. 2012-02-04 15:27:47 +01:00
QAston 7e99e5f094 Core/Spells:
- rename SpellInfo::IsAOE to SpellInfo::IsTargetingArea due to ambiguity of old name.
- add IsAffectingArea function to check whenever spell or it's effects are affecting objects in area and use new function to fix problems with hunter flares.
Closes #3310. Thanks to Kaelima and Warpten for research.
2012-02-03 22:24:03 +01:00
Shocker 08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
Giuseppe Montesanto 16300d0914 Check line of sight for spell with dest 2012-02-02 19:06:28 +01:00
Subv2112 9b524b43fa Core/Spells: Spells with SPELL_AURA_PERIODIC_MANA_LEECH should skip unit target checking if the Targets are area targets, they are filled/validated later
Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-31 20:27:22 -05:00
Chaplain a535e451a8 Core/Spells: Fix issue in CAST_FLAG_ADJUST_MISSILE handling. Thx rsa (R2) for pointing. 2012-01-13 19:18:13 +03:00
Chaplain 67808ba453 Core/Spells: Fix CAST_FLAG_UNKNOWN_18.
*rename CAST_FLAG_UNKNOWN_18 -> CAST_FLAG_ADJUST_MISSILE
*implement handling in Spell::SendSpellGo()
2012-01-08 18:50:25 +03:00
Shocker 08bcbc89b0 Merge pull request #4229 from devilcoredev/fix_002
Core/Spells: Fix the spell immunity system to be effect-dependent
2012-01-04 13:41:51 -08:00
kiper 8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
QAston afc18461d7 Core/SpellScripts: Add BeforeCast, OnCast and AfterCast hooks to SpellScripts. 2011-12-31 13:11:12 +01:00
Shocker f283a7b116 Merge pull request #4475 from Svannon/fix-fishingcone
Core/Fishing: Reduce the fishing cast cone to 35 degrees from each side of the facing instead of 70. Make the overall cone 70 degrees instead of 140
2011-12-25 12:16:10 -08:00
Svannon 3405e0811d [Fishing] Reduce the Fishing cast cone to 35 degrees from each side of the facing instead of 70. Make the overall cone 70 degrees instead of 140. 2011-12-24 12:41:22 -07:00