Commit Graph

564 Commits

Author SHA1 Message Date
Machiavelli a36a0a77ef Core/Player: Quests with status QUEST_STATUS_NONE(0) shouldn't be loaded into player's queststatus storage. These should be removed since they are remnants from the old queststatus storage system. 2012-03-01 14:43:32 +01:00
Shauren 56536a6af5 Core: Fixed build warning 2012-02-29 18:45:31 +01:00
kaelima eb1a2a3672 Core/Object:
- Corrected the flag and use of UPDATEFLAG_LOWGUID.
- Send proper positions for objects on transports.
- Rename UPDATEFLAG_HAS_POSITION -> UPDATEFLAG_STATIONARY_POSITION
- Added some comments
2012-02-29 12:43:59 +01:00
Spp d38bc3a178 Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there 2012-02-27 14:58:47 +01:00
Shocker f0d0d95cf9 Core/Spells: Fix spellmod restore on failed cast for auras that have multiple mods for different spells (by lost-illusion) 2012-02-25 22:51:06 +02:00
Shauren 63ebdcda5b Core/Player: Fixed feral AP applying for non-scaling items 2012-02-25 20:23:14 +01:00
Shauren a934abbbb7 Core/Calendar
* Added sending SMSG_CALENDAR_RAID_LOCKOUT_REMOVED when instance save is removed
* Refactored sending SMSG_CALENDAR_RAID_LOCKOUT_ADDED/REMOVED into separate method
2012-02-24 19:31:40 +01:00
Shauren 9c3357c1de Core/Calendar
* Fixed raid resets display in calendar
* Active instance locks will now be added to calendar as soon as they are created (not after login)
2012-02-24 19:06:53 +01:00
Shauren dc28b92415 Core: Random cleanup + compile fix 2012-02-23 13:01:16 +01:00
Machiavelli 44195689b9 Core/Units: Use spellclick conditions in Player::canSeeSpellClickOn 2012-02-21 10:17:32 +01:00
Manuel Carrasco 4e8218025e Fixed compile error, thanks to AliveShiro. 2012-02-21 01:31:06 -03:00
Machiavelli 16818d7548 Core/Conditions: Convert npc_spellclick_spells data to condition system. This implements CONDITION_SOURCE_TYPE_SPELL_CLICK_EVENT (previous CONDITION_SOURCE_TYPE_UNUSED_18). Wiki needs to be updated accordingly. 2012-02-20 23:25:59 +01:00
Nay 0a0233b215 Core/Packets: Use a single method to send SMSG_ACTIVATETAXIREPLY
Also fix a typo introduced in 703ad4889
2012-02-18 23:03:41 +00:00
click 5411e1ce52 Core: Clean up whitespace and tabs in the base sourcetree 2012-02-18 16:52:08 +01:00
Spp 03c34ee507 Fix a lot of warnings 2012-02-16 13:56:28 +01:00
QAston de706b3211 Core/Db/Conditions: Add new condition targets for:
- CONDITION_SOURCE_TYPE_CREATURE_TEMPLATE_VEHICLE ConditionTarget = 1 - check vehicle
- CONDITION_SOURCE_TYPE_VEHICLE_SPELL ConditionTarget = 1 - check vehicle
- CONDITION_SOURCE_TYPE_GOSSIP_MENU = 1 - check gossip provider
- CONDITION_SOURCE_TYPE_GOSSIP_MENU_OPTION = 1 - check gossip provider
2012-02-15 22:13:27 +01:00
Subv 8a72aede16 Codestyle: Renamed some variables to fit codestyle, corrected order in structure/class fields to match alignment (they use slightly less memory now)
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-14 12:46:26 -05:00
Kandera 3d9ff95177 fix issue with seasonal quests 2012-02-14 09:03:34 -05:00
Subv d790adefe0 Codestyle: Renamed some variables to fit codestyle
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-12 20:10:09 -05:00
QAston ce4a4ffe50 Core/Db/Conditions: Add ContidionTarget column which allows selection of objects which will be checked by condition, depending on SourceTypeOrReferenceId.
So far usable only with CONDITION_SOURCE_TYPE_SPELL:
ContidionTarget = 0 - check caster
ContidionTarget = 1 - check explicit target
2012-02-10 23:42:08 +01:00
Shocker 8c2526e7d0 Core/Misc: Avoid some redundant checks in Player::ResetTalents 2012-02-10 22:08:13 +02:00
QAston 8713b44ee7 Core/Db/Conditions: Prepare conditions system to work on objects of different type than players.
Warning: API has changed a bit:
ConditionScript::OnConditionCheck(Condition* condition, Player* player, Unit* invoker) is now
ConditionScript::OnConditionCheck(Condition* condition, WorldObject* object, WorldObject* invoker)
2012-02-10 14:18:59 +01:00
Subv2112 1975291a98 Core/Achievements: ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM should only be counted once for each new item you receive
closes #5065

Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-03 20:04:26 -05:00
QAston c7ea952a47 Core/Entities: Rename UNIT_FLAG_OOC_NOT_ATTACKABLE and UNIT_FLAG_PASSIVE to UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC respectively. New names tell much more about what those flags do. 2012-02-03 18:46:05 +01:00
Shocker 08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
kaelima e602619912 Core/Player: Remove spell used to unlearn talents and replace with a direct packet send. Spell is not found casted in 3.3.5a sniffs. Thanks Malcrom for the hint. 2012-02-03 14:56:29 +01:00
Subv2112 2786ea1f5e Core/Quests: Fixed a crash caused when trying to add a quest to a player who does not have any free slot in his quest log. fixes #4572
Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-31 16:45:36 -05:00
Subv2112 bdae78ac9d Core/LFD: Fixed possible multithreading crash, thanks LihO 2012-01-31 14:38:14 -05:00
Subv2112 1bc370aaf8 Core/Achievements: Fixed achievements with ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM, they were not accumulating the amount 2012-01-31 10:01:29 -05:00
click e6d5b21778 Core: Fix non-PCH build and remove a few warnings. 2012-01-24 00:24:39 +01:00
Subv2112 3d4f55723c Core/SAI: Linked events should be executed after the event that linked them is executed.
Core/SAI: Allow SMART_EVENT_GO_STATE_CHANGED to use ActionInvoker target

Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-22 20:36:01 -05:00
Machiavelli e652d9043b Missing unsaved changes for previous commit... 2012-01-18 19:00:52 +01:00
Machiavelli 46dda033c8 Core/Items: Blizzlike fix for the recent trade exploit fix 2012-01-18 18:57:21 +01:00
Machiavelli abd94e324b Core/Items: Fix crash and updated documentation in SplitItem 2012-01-18 13:14:06 +01:00
SignFinder cc88681dc5 Core/Items: Really fix a trading spoof exploit.
Thanks Alexsot for fix.
2012-01-18 11:56:34 +04:00
kaelima 819da8af4d Core/Items: Attempt to fix crash in Player::SplitItem caused by 6a44399852.
And some random cleanup
2012-01-18 06:07:30 +01:00
Machiavelli 6a44399852 Core/Items: Fix a trading spoof exploit.
Closes #4713
2012-01-17 18:51:04 +01:00
Shauren 894c27af52 Core/Groups: Need restrictions in need before greed loot method should apply only to LFG dungeons 2012-01-14 18:42:23 +01:00
Subv2112 f4075f0f94 Core/LFG:
Fix priority of the player when its added to the lfg group
        Better implementation of the Dungeon Deserter debuff
        Rewrite the NeedBeforeGreed loot
        Fixed players being shown as Unknown Entity when entering the lfg group
        Some incremental optimizations after original patch
Thanks to Retriman and Paecman for base implementation

Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2012-01-14 17:37:28 +01:00
Machiavelli dbbac0bdaa Core/Movement: Implement spline movement subsystem.
Spline movement controls movements of server-side controlled units (monster movement, taxi movement, etc).
Proper implementation of effects such as charge, jump, cyclic movement will rely on it.
However, need improve our states system before.

Technical changes:

* Added linear, catmullrom and bezier3 splines which based on client's algorthims. They can be reused for proper transport position interpolation.
* Precission increased. There are no more position desync issues since client's position calculation formulas used.
* Now possible to move by paths with multiple points, send whole path to client.

--
Original author of research and implementation: SilverIce. Massive kudos.
Original port for Trinity (ref #4629) Chaplain and Venugh
With the following incremental fixes during my review:

- Restore flightmaster end grid pre-loading
- Fix uninitialized Creature::m_path_id
- Add missing trinity_string entries for .movegens command
- Fix a bug in WaypointMovementGenerator that would trigger unexpected pausing at waypoints for various amounts of time

Known issues:
- Errors like WaypointMovementGenerator::LoadPath creature XXX (Entry: YYYYY GUID: ZZZZZZ) doesn't have waypoint path id: 0.
This is caused by bad DB data. This commit didn't "break" it.

Do not forget to re-run CMake before compiling.
2012-01-14 15:36:07 +01:00
Subv2112 d02c781241 Core/Gossips: Fixed questgiver GOs that also have gossip menus, fixed gossip option selecting on GOs
Signed-off-by: Subv2112 <s.v.h21@hotmail.com>
2012-01-09 09:29:45 -05:00
Subv2112 5584354444 Core/Players: Fix crash in LoadFromDB
Closes #4724
Closes #4673
2012-01-08 18:37:16 +00:00
Machiavelli 1dc6f6a2da Merge pull request #4646 from elecyb/crash1
Core/PacketIO: Fix crash and exploit caused when client sends tampered m...
2012-01-07 03:58:42 -08:00
Shauren 1a8bf13cb6 Core/Events: Last part of seasonal quest loading/saving fixes (should all be one commit) 2012-01-06 15:08:21 +01:00
Shauren 5ae622678a Core/Events: Fixed saving seasonal quest status 2012-01-06 15:01:30 +01:00
Shauren 2bef633e1f Core/Events: Corrected column type when loading seasonal quest status 2012-01-06 14:58:55 +01:00
Shauren 0c2dd2dc7f Core/Events: Fixed crash when loading character_queststatus_seasonal 2012-01-06 14:57:01 +01:00
elecyb 7d7bb8363d Core/PacketIO: Fix crash and exploit caused when client sends tampered mover guids
Closes: #4056
2012-01-05 18:34:56 -03:00
Shauren 01900b5829 Core/Events
* Changed how quests are linked to events (no longer in Quest class)
* Added quest validation when loading game_event_seasonal_questrelation
* Renamed fields in new table to be consistent with game_event* tables
* Corrected db data (some entries had -1 as event id)
2012-01-05 13:27:17 +01:00
Shocker b1129499a2 Merge pull request #4587 from wilds/fix_reenter_bg
Core/Battleground: Fix re-entering battlegrounds after disconnect
Closes #90
2012-01-04 13:18:05 -08:00