Commit Graph

564 Commits

Author SHA1 Message Date
tobmaps
8fd7720318 Core/Misc: Rename Spell::CalcCastTime to Spell::GetCastTime as it does not calculate anything 2011-11-05 05:33:52 +07:00
megamage
1b8d9ec7b4 Clean up summon/remove gameobject code. 2011-10-31 10:46:39 -04:00
kaelima
e16e18da23 Core/Spells: Added safe-checks for places where caster/victim can be null.
And some random cleanup
2011-10-31 01:54:44 +01:00
kaelima
d5ece59acd Core/Spells: Fixed possible crash for Decimation
Closes #3750
2011-10-30 23:52:38 +01:00
megamage
0ac431f52d Fix a crash caused by spell 49065. Close #3646. 2011-10-24 16:54:52 -04:00
Shocker
10bca6c268 Merge pull request #3596 from ille/master
use effectMask to calculate mechanicMask in ModSpellDuration

Closes #1599
2011-10-24 10:43:47 -07:00
Machiavelli
70c2f9e796 Merge pull request #3575 from bytewarrior/master
Core/Mechanic: Fixed wrong target level at resist chance calculation.
2011-10-23 04:22:18 -07:00
ille
5514523a7c use effectMask to calculate mechanicMask in ModSpellDuration 2011-10-20 18:28:37 +02:00
Liberate
6d12deb5b5 And a forgotten change. Sorry for this, I guess it's a welcome back present for me... Thanks tobmaps for pointing this out. 2011-10-18 23:49:46 +02:00
Liberate
8cc13ff838 And I forgot to turn on tabs to spaces. Also fixed... 2011-10-18 23:38:55 +02:00
Liberate
89bae3b51c Core/Spells: Add a new stack rule for spellgroups: SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT
This stack rule makes the effects of the spells in the spellgroup non-stackable, but the spells/auras itself are stackable.
a spell should be in only 1 group with this stack rule.
Fixes #2243
2011-10-18 23:27:39 +02:00
bytewarrior
496c2da6f3 Core/Mechanic: Fixed wrong caster level at resist chance calculation. 2011-10-18 10:52:33 +03:00
kaelima
27e1a5d7b6 Core/Mechanic: Fix spell penetration from items. 2011-10-17 15:54:19 +01:00
Fredi Machado
97142102e0 Core/Misc: Added 'f' after float values 2011-10-17 07:38:27 -03:00
Shauren
2ccf6ae297 Core/Auras: Fixed another proc crash
Closes #3537
2011-10-16 14:33:48 +02:00
megamage
bcc55489f8 More cleanup of CanSeeOrDetect 2011-10-13 14:02:07 -04:00
Chaplain
3e9611578c Core/Spells: SPELL_AURA_MOD_INCREASE_ENERGY_PERCENT improvement
*Now it'll correctly increase\decrease % of power
*Added helper function for modify power with percent ammount
2011-10-12 01:11:52 +03:00
megamage
3569121d80 Remove/Add creature from/to map when it changes map.
Note: creatures was never supposed to change map, but now the core allows them to move with transports...
2011-10-10 17:59:52 -04:00
megamage
d156e066cf Rename "SetPosition" to "UpdatePosition".
Replace CreatureRelocation in scripts with new Creature::SetPosition.
2011-10-10 17:08:01 -04:00
Shauren
72fc756bff Scripts/Icecrown Citadel
* Minor corrections to Sister Svalna event
* Removed unneeded workarounds for Deathbringer Saurfang procs
* Changed GM check to use account level (makes no sense to check isGameMaster as that does not allow entering combat at all)
2011-10-08 17:39:03 +02:00
Bootz
5b4c7783c2 REPO: Code-style clean-ups
* Fixed pMap->map
* Fixed pInstance->instance
* Fixed pInsta->instance
* Fixed pQuest->quest
* Fixed pWho->who
* Fixed pTarget->target
* Fixed pGo->go

~DEVNOTES: Handlers/QuestHandler.cpp still needs to be cleaned...
2011-10-07 19:45:43 -05:00
root
0acd9a9503 Core/Misc: Correct file rights for Unit.cpp 2011-10-07 19:52:40 +03:00
Bootz
81c0a3a847 REPO: code-style clean-up
* Fixed pPlayer->player
* Fixed pCreature->creature

~DevNote: codestyle for Player should be (*player), not *plr or *p...
same goes for Creatures (*creature)... more cleaning needed.
We've way too many codestyles happening here.
2011-10-07 11:08:09 -05:00
Bootz
96d7a1e970 REPO: code-style clean-up
* Fixed pGuild->guild
* Fixed pGroup->group
* Fixed pOwner->owner
2011-10-07 10:54:53 -05:00
Shauren
2a34c5e4c8 Core/Auras: Fixed crashes in Infusion of Light and Frozen Power proc handlers
Closes #3271 & #3272
2011-09-30 18:45:49 +02:00
Shauren
da54fb92d5 Core/Movement: Fixed knockback visibility for other players (no more "teleport") and knockback strength from creature spells (this does not fix knocking creatures back) 2011-09-30 18:24:12 +02:00
Spp
b16d2245bb Cosmetic: Multiple cosmetic changes
- Added missing space to 'if', 'for', 'while' and 'switch' when it's followed by '('
- Added missing space after a comma and remove space before comma (with some exceptions)
- Remove trailing spaces
- Convert tab to spaces

Note: Only affects files with extension "cpp" and "h" under /src/server
2011-09-29 12:43:05 +02:00
Spp
cc06c41887 Core: Move FormationMgr to namespace
Also...
- Warning fixes
- Make Singleton constructors private
2011-09-28 11:11:38 +02:00
QAston
5f043e6291 Core/Spells: Bring back workaround removed in cd7060c65a - it's needed for compatibility with some scripts. 2011-09-27 22:04:26 +02:00
QAston
7fa2a64290 Merge branch 'master' of https://github.com/Chaplain/TrinityCore 2011-09-27 19:19:25 +02:00
QAston
23ba776767 Core/Entities: use Unit::GetReactionTo in Unit::IsFriendlyTo and Unit::IsHostileTo 2011-09-27 01:29:20 +02:00
QAston
75aeb15e90 Core/Spells: Allow AOE spells to hit stealthed targets. 2011-09-27 01:13:32 +02:00
Machiavelli
f4ec95c752 Fixed a typo in pull request. (Edit via Github) 2011-09-26 21:05:16 +03:00
Cron
8622bedeac Core/Spells: Fixed glyph of Fire Blast. 2011-09-25 15:53:31 -03:00
Chaplain
224bb96deb Core/Spells: Fix talent Sword Specialization. 2011-09-25 16:42:12 +03:00
Chaplain
877579d386 Revert "Core/Spells: Fix talent Sword Specialization for melee abilities"
This reverts commit cdd4160157.
2011-09-25 14:20:41 +03:00
Shauren
da0229da8f Core/Scripts: Implemented 2 new target selectors, one specialized for spells, checking auras, range and attributes; and the other is a very simple non-tank selection what is sufficient for most cases 2011-09-24 19:40:57 +02:00
QAston
cd7060c65a Core/Spells: Add more generic overload for Unit::CastSpell function and make all cast functions use it as a base. 2011-09-24 16:41:50 +02:00
QAston
29fef71137 Merge pull request #2915 from idostyle/armorPen
Core/Mechanics: Cap armorPen to maxArmorPen - prevents having armor penetration rating greater than 100%.
2011-09-22 02:03:14 -07:00
QAston
8c2e58d036 Core/Entities: Allow 2 side parties to work. 2011-09-17 13:45:07 +02:00
QAston
a2d9aabbb3 Core/Entities: Allow creatures to attack players while in sanctuary. 2011-09-17 01:50:53 +02:00
QAston
580264b5a5 Core/Entities: Remove obsolete function Unit::canAttack. 2011-09-16 23:51:01 +02:00
QAston
c0b1823524 Core/Entities: Replace Unit::canAttack usage with more accurate Unit::IsValidAttackTarget 2011-09-16 23:49:31 +02:00
QAston
3a3f2d927f Core/Misc: Whitespace and a minor typo fix (thanks Kapoeira) 2011-09-16 22:37:49 +02:00
QAston
31e755c291 Core/Entities: Add Unit::IsValidAssistTarget and Unit::IsValidAttackTarget functions for proper serverside checks of related entity flags. 2011-09-16 22:17:48 +02:00
Shocker
7afb179185 Misc/Util: Add a template function for returning a random element from any container 2011-09-15 21:28:40 +03:00
QAston
e07535c3e3 Core/Entities: Add new functions: Unit::GetReactionTo and Unit::GetFactionReactionTo for more direct reaction checks than Unit::IsFriendly/HostileTo (those functions have many duplicated code and have many checks unrelated to unit reaction). 2011-09-15 17:44:03 +02:00
Spp
af05915b9e [Cosmetic] Apply codestyle "XXX * " and "XXX *" changed to "XXX* " (with some exceptions) 2011-09-15 14:12:57 +02:00
Chaplain
cd06a696cf Core/Auras: Improvements in SPELL_AURA_MOD_DAMAGE_PERCENT_DONE handling:
*prevent apply mods from weapon specific case to non weapon specific spells
2011-09-11 00:27:40 +03:00
Chaplain
dcc3b2e341 Core/Mechanic: Remove unneeded(now) argument. 2011-09-07 11:04:20 +03:00