Commit Graph

626 Commits

Author SHA1 Message Date
Subv2112 31615bdc86 Core/Spells: Add a new parameter to Unit::SelectNearbyTarget to allow excluding a certain unit.
closes #4989
2012-02-04 21:21:51 -05:00
QAston 6b12f39b35 Merge pull request #4821 from devilcoredev/fix_001
Core/AuraScript: Add OnDispel and AfterDispel hook to AuraScript
2012-02-04 06:09:57 -08:00
Giuseppe Montesanto 271feb587f Add hook on AuraScript called when an aura is dispelled 2012-02-04 13:32:40 +01:00
QAston 92ad375864 Core/Entities: clarify comment added in c7ea952a47 2012-02-03 22:56:42 +01:00
QAston 7e99e5f094 Core/Spells:
- rename SpellInfo::IsAOE to SpellInfo::IsTargetingArea due to ambiguity of old name.
- add IsAffectingArea function to check whenever spell or it's effects are affecting objects in area and use new function to fix problems with hunter flares.
Closes #3310. Thanks to Kaelima and Warpten for research.
2012-02-03 22:24:03 +01:00
QAston aae833a759 Core/Spells: fix GameObject spell cast on enemies, original patch by Svannon, thanks to horn for research. 2012-02-03 20:07:57 +01:00
QAston c7ea952a47 Core/Entities: Rename UNIT_FLAG_OOC_NOT_ATTACKABLE and UNIT_FLAG_PASSIVE to UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC respectively. New names tell much more about what those flags do. 2012-02-03 18:46:05 +01:00
Shocker 08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
Souler eef0c61bbf Script/Spells: Solve problems with argent tournament spells
- Including cleanup in spell_generic
2012-02-01 16:02:58 +01:00
Souler 75992143c1 Scripts/Spells: Fix Argent Tournament mount spells:
* Break-Shield
 * Charge
 * Defend (visual)
 * Mounted duel
 * Faction Pennants when riding argent tournament mounts
Closes #4917.
2012-01-30 00:21:42 +01:00
Vlad 0f383e9cdd Core/Movement: properly set mover for possess/vehicles 2012-01-20 05:11:52 +03:00
Kaelima afc0d72761 Merge pull request #4789 from drskull/master
Spirit Hunt
2012-01-17 21:41:47 -08:00
kaelima 819da8af4d Core/Items: Attempt to fix crash in Player::SplitItem caused by 6a44399852.
And some random cleanup
2012-01-18 06:07:30 +01:00
Machiavelli dbbac0bdaa Core/Movement: Implement spline movement subsystem.
Spline movement controls movements of server-side controlled units (monster movement, taxi movement, etc).
Proper implementation of effects such as charge, jump, cyclic movement will rely on it.
However, need improve our states system before.

Technical changes:

* Added linear, catmullrom and bezier3 splines which based on client's algorthims. They can be reused for proper transport position interpolation.
* Precission increased. There are no more position desync issues since client's position calculation formulas used.
* Now possible to move by paths with multiple points, send whole path to client.

--
Original author of research and implementation: SilverIce. Massive kudos.
Original port for Trinity (ref #4629) Chaplain and Venugh
With the following incremental fixes during my review:

- Restore flightmaster end grid pre-loading
- Fix uninitialized Creature::m_path_id
- Add missing trinity_string entries for .movegens command
- Fix a bug in WaypointMovementGenerator that would trigger unexpected pausing at waypoints for various amounts of time

Known issues:
- Errors like WaypointMovementGenerator::LoadPath creature XXX (Entry: YYYYY GUID: ZZZZZZ) doesn't have waypoint path id: 0.
This is caused by bad DB data. This commit didn't "break" it.

Do not forget to re-run CMake before compiling.
2012-01-14 15:36:07 +01:00
dr.skull 1abb447243 Fix Feral Spirit passive spell Spirit Hunt
Now will heal wolfs too.

Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-01-12 13:16:04 +01:00
Giuseppe Montesanto 885e9fda34 Fix the 'Trueshot Aura' on pet 2012-01-11 12:15:44 +01:00
dr.skull d6ff717b74 Fix Shaman T10 Enhancement 4P Bonus
Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-01-09 14:31:15 +01:00
Shocker 08bcbc89b0 Merge pull request #4229 from devilcoredev/fix_002
Core/Spells: Fix the spell immunity system to be effect-dependent
2012-01-04 13:41:51 -08:00
Shocker 91d51d9474 Merge pull request #4244 from Warpten/master
Core/Spells: Fix Earthen Power
2012-01-04 13:31:45 -08:00
Shocker ecb1bdd7c3 Merge pull request #4489 from devilcoredev/fix_001
Core/Achievemens: Fix 'The Undying' and 'The Immortal' achievements
2012-01-04 13:27:43 -08:00
Shocker 0a17ab2e4c Merge pull request #4314 from drskull/master
Core/Spells: Windfury and Flametongue should proc from abilities
2012-01-04 13:25:43 -08:00
Odyssey 1ad6a5fd00 Core/Misc: Remove some engrish from Unit.cpp log messages 2012-01-04 16:35:57 +01:00
Giuseppe Montesanto bf73409f49 Fix 'The Undying' and 'The Immortal' achievements. 2012-01-01 04:34:14 +01:00
kiper 8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
megamage e6a3dc679f Fix a crash caused by 0ac431f52d. Close #4418. 2011-12-23 11:09:09 -05:00
megamage 8cf2062c1f Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while). 2011-12-20 17:07:09 -05:00
Machiavelli 6c03bf9535 Core/Misc: Some random meaningless Engrish to English conversion in a method name because Discovered is too lazy to do it himself. 2011-12-19 22:06:29 +01:00
Shocker d1bb5b21af Merge pull request #4356 from kandera/fix_TotT
Core/Spells: Fix correct targeting for Tricks of the Trade
2011-12-16 10:38:33 -08:00
kandera c961d3fdb5 Core/Spells: Fix correct targeting for Tricks of the Trade 2011-12-16 11:56:02 -05:00
Gigatotem bd90edc806 Core/Items: Deathbringer's Will and Deathbringer's Will (HC) should proc Haste for a Druid not attack power. 2011-12-16 15:24:14 +00:00
Spp ee8ed0247c Fix typo from previous commit 2011-12-15 16:07:06 +01:00
Spp d59c5e627f Fix warnings 2011-12-15 11:12:15 +01:00
Giuseppe Montesanto 72e48ef8b3 Fix immunity system for many spells. 2011-12-14 16:13:10 +01:00
dr.skull d6ebfa993b Core/Spells: issue/3744
Windfury and Flametongue should proc from abilities

Signed-off-by: dr.skull <dr.skull@centrum.sk>
2011-12-13 19:20:51 +01:00
Machiavelli 957cb005f5 Merge pull request #4294 from Warpten/warrior
Core/Spells: Fix Warrior's T10 4P DPS Bonus.
2011-12-12 12:05:05 -08:00
Kapoeira cb5ad13906 Core/Spells: Fix Warrior's T10 4P DPS Bonus. 2011-12-12 14:54:19 -05:00
Kaelima e34eda37c7 Merge pull request #4257 from Warpten/bleed
Core/Spells: Rake's initial damage is a bleeding effect, it should thus ignore armor.
2011-12-12 11:21:00 -08:00
Kapoeira 761c5c9e2f Core/Spells: Rake's initial damage is a bleeding effect, it should thus ignore armor.
So far this is the only example of such a mechanic (3.3.5), so this does not break anything.
2011-12-10 14:50:37 -05:00
kaelima 11fb0beaf0 Core/Misc: Fixed some duplicate checks for player typeid in Unit::Kill and Spell::EffectSummonDeadPet. Also some random cleanup 2011-12-10 13:48:41 +01:00
Kapoeira 5d7003a28b Core/Spells: Fix Earthen Power. 2011-12-10 00:35:33 -05:00
Shocker b05317650b Core/Misc: Small changes after recent pulls 2011-12-08 19:56:50 +02:00
Shocker b59e5079be Merge pull request #4195 from kandera/fix_GlyphsofSuccubus
Core/Spells: Fix Glyph of Succubus (wasn't working at all before)
2011-12-08 09:54:56 -08:00
kandera 18aaeaa6be Core/Spells: Tricks of the Trade (fix entier spell. aggro now removed after buff dissapears, correct buffs are placed on both the rogue and the target, both 15% buff and the second threat modifier buff are working as intended) 2011-12-05 13:56:08 -05:00
kandera 2e116cf217 Core/Spells: Fix Glyph of Succubus (wasn't working at all before) 2011-12-05 06:18:25 -05:00
Chaplain 4d65c1e729 Core/Mechanics: Armor penetration improvement. Revamp calculation of SPELL_AURA_MOD_TARGET_ARMOR_PCT 2011-11-26 21:05:27 +02:00
Shocker 01d44a83e3 Merge pull request #4041 from PKX/remove_obsolete
Remove obsolete code and spell_groups
2011-11-26 10:37:22 -08:00
Shauren 358b33239a Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit 2011-11-23 19:17:33 +01:00
PKX 47b7e75149 Core/Spells: Removed some obsolete code
This removes some unused and obsolete code:
- "Test of Faith" now doesn't increase crit anymore;
- same goes for "Renewed Hope" (in addition that code isn't working);
- "Ebon Plague" part was deleted from Unit::SpellDamageBonus but not from Unit::MeleeDamageBonus (in addition this code is not working anymore)
- "Blessing of Sanctuary" was working only on melee damage, plus this is not the way it should be fixed

Signed-off-by: PKX <pkx.icehell@gmail.com>
2011-11-23 15:48:01 +01:00
Machiavelli 8444532746 Core/Units: Second part of SMSG_MOVE_SET_COLLISION_HGT implementation: compute proper collision height according to client formulae and send this to the client when mounting up. 2011-11-22 20:28:10 +01:00
megamage 23186b24e2 Merge pull request #3421 from Chipsi/master
Core/Items: Added case for Darkmoon Card: Madness trinket
2011-11-21 14:12:46 -08:00