Commit Graph

724 Commits

Author SHA1 Message Date
Aokromes 30cec73c61 Coding standards (#23514)
* Coding standards

* revert part

(cherry picked from commit fe744977c9)
2021-12-13 00:42:17 +01:00
Treeston 38d7c1530a Combat/Threat: Split ThreatManager::NotifyDisengaged off from ThreatManager::ClearAllThreat. NotifyDisengaged signifies intent to clear the engagement flag, and should only be called from AI. Fixes #23490.
(cherry picked from commit 1158f267df)
2021-12-12 02:09:15 +01:00
Killyana 0993b491dd DB/Quest: A Visit With The Ancestors
Closes #23284

(cherry picked from commit a3dec9068b)
2021-12-11 16:32:05 +01:00
Wyrserth 9d865f7536 Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura (#23319)
* Core/Misc: don't allow players to use/activate/loot non-allowed gameobjects while under the effect of a damage immunity aura.

* Forgot to change this in last-second rename.

* Apply suggested changes, thanks Shauren!

(cherry picked from commit 8bc5451864)
2021-12-09 00:13:59 +01:00
Killyana 8f1020ec78 DB/Creature: Hydross the unstable npc triggers
Update the correct channel spell SPELL_BLUE_BEAM and spawn triggers used to cast it

(cherry picked from commit 2829f5fb9c)
2021-12-08 20:36:43 +01:00
Giacomo Pozzoni 5f545f5402 3.3.5 gameobject summoner (#23289)
* Scripts/Misc: Change IsSummonedBy(Unit*) to IsSummonedBy(WorldObject*)

* Scripts/Misc: Fix build

* Core/TempSummons: Rename GetSummoner() to GetSummonerUnit()

* Core/TempSummons: Add support to TempSummons::GetSummoner() to return GameObject too

* Fix build

* Core/TempSummons: Allow GameObject to be owner of TempSummon

* Core/TempSummons: Add support to SAI for GameObject owner of TempSummon

* Scripts/Misc: Fix no-pch build

* Core/TempSummons: Implement PR comments

(cherry picked from commit 797fba98e9)
2021-12-07 00:02:03 +01:00
Killyana cb9a1c38f1 Instance/Script: Blood Furnace
Ref #23285

(cherry picked from commit 9435caa8d1)
2021-12-05 18:39:09 +01:00
jackpoz 43a41caafb Core/Misc: Fix GCC 8 warnings
(cherry picked from commit 1d04a3b216)
2021-11-24 23:40:15 +01:00
Sorikoff 956158d299 Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing

(cherry picked from commit dbadb6369c)
2021-11-24 20:34:54 +01:00
Sorikoff b3f75852c2 Allow walk when chasing (#23069)
(cherry picked from commit c2f2db08aa)
2021-11-24 00:02:13 +01:00
Keader dba7e2507f Scripts/Illidan: Fixed Parasitic shadowfiends reproducing like rabbits
(cherry picked from commit a617cc4097)
2021-11-23 23:16:43 +01:00
Keader 4af2894626 Scripts/Black Temple: Mother Shahraz fatal attraction need be random
Higher distance showed in my sniffs is 48 yards (rounding 50 yards). If someone find more then that, please let me know.
Ty killerwife

(cherry picked from commit fd69c133b1)
2021-11-22 23:57:54 +01:00
Keader c3210798f0 Scripts/Black Temple: Fixed some issues in Illidari Council
Ty killerwife for all help :)

(cherry picked from commit ef6240312c)
2021-11-22 23:57:19 +01:00
Giacomo Pozzoni fff0d174aa Scripts/Misc: Fix LoadMinionData() dynamic analysis issues
Fix issues reported by Address Sanitizer about LoadMinionData() calls on arrays that don't end with a {0, 0} pair.

(cherry picked from commit 08dcee0cf9)
2021-11-18 22:53:21 +01:00
Keader c4eed6561c Scripts/The Steamvault: Fixed Chambers Access Panel and Main Chambers Door
Closes #21067
Ty Kittnz, killerwife, Aokromes (sniffs)

(cherry picked from commit b283565d8a)
2021-11-18 22:41:55 +01:00
Giacomo Pozzoni 4177030dcf Scripts/Nagrand: Fix crash added in PR #22806 (#22878)
Fix crash added in PR #22806 happening in quest "Ruthless Cunning and Returning the Favor"

(cherry picked from commit cb13638721)
2021-11-16 21:04:05 +01:00
PolarCookie f377dc23f3 Quest: Ruthless Cunning and Returning the Favor (#22806)
* Ruthless Cunning and Returning the Favor

* no more magic numbers

* now with scripted ai and condition

* travis

* more travis

* jackpoz

* now with no banner spellscripts

* typo

* Rename 9999_99_99_99_world.sql to 2018_12_03_00_word.sql

(cherry picked from commit 9d93504f34)
2021-11-16 00:51:51 +01:00
Gildor 4a775c01e9 Core/Scripts - The Eye: Fix Kael'thas Sunstrider Mind Control, limit MaxAffectedTargets to 3 (#22828)
Closes: #22826
(cherry picked from commit 0ee8a77dce)
2021-11-16 00:07:15 +01:00
Keader fe4da71f1d Scripts/Illidari Council: Changed urand to SelectRandomContainerElement
(cherry picked from commit 6cb754ca4e)
2021-11-15 00:15:39 +01:00
Keader f69c8c2e60 Scripts/Black Temple: Fixed a crash on Illidari Council (#22652)
Ty Sirikfoll :)

(cherry picked from commit 9a443306fb)
2021-11-15 00:15:16 +01:00
Shauren f2456ff319 Scripts/Areatriggers: Fixed all areatrigger scripts triggering both on enter and exit instead of only on enter 2021-11-10 00:01:50 +01:00
DanVS 28cb2af1c5 Core/Scripts: Unify Chrono Literals (#22420)
* Unify Chrono Literals

* Retire IN_MILLISECONDS

* Build fix

* Build fix (sequel)

* Retire urand()

* Edge cases

* Build

* Whitespaces

* More edge cases

* Additional cases

(cherry picked from commit 5b0f4009df)
2021-11-09 00:26:59 +01:00
ModoX 437fb2aaba Core/CreatureTexts: Added new field SoundPlayType to enable usage of ObjectSounds within creature_text (#27136)
* Also adjusted Vigilant Quoram texts to use ObjectSounds
2021-10-23 13:10:32 +02:00
Keader 37c9553372 Scripts/Black Temple: Fixed some issues on Illidan
(cherry picked from commit 0ebb315d6c)
2021-10-23 00:22:53 +02:00
Treeston e4e8c1c59c Core/AI: Clean up charm AI handling, we now have two unique_ptr instead of a crapton of booleans
(cherry picked from commit 042f5515e4)
2021-10-22 23:47:51 +02:00
Treeston 3418a33a87 Misc: Pass std::chrono types by value everywhere.
(cherry picked from commit 2ef9d301f0)
2021-10-14 19:39:42 +02:00
Keader f78c1bed5d Scripts/Black Temple: Removing double hook call in Spiritual Vengeance
(i realy dont remember why i did it lol)

(cherry picked from commit c9b09fc2cb)
2021-10-14 18:59:24 +02:00
illfated 550513ba65 Creature/Script: remove obsolete script npc_skywing (#22147)
- replaced with SAI script for the same quest and creature (Skywing)

Ref. https://github.com/TrinityCore/TrinityCore/issues/22078#issuecomment-399760597

(cherry picked from commit 0004531081)
2021-10-14 00:09:17 +02:00
Meji 5c287929b2 Core/Gossip: Update GossipOptionIcon enum (#26906) 2021-10-03 16:24:07 +02:00
Shauren 3af9be830d Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes 2021-10-03 14:58:35 +02:00
Shauren 3bf6698116 Core/Misc: Fix appleclang 12 warnings 2021-10-01 11:18:29 +02:00
sirikfoll f507737ecf Scripts/TheSlavePens: Boss Ahune fixes and updates
Fixes some visual problems
Fixes encounter start
Updated codestyle

Closes #22071

(cherry picked from commit 35ba5aa138)
2021-09-29 21:01:25 +02:00
Gildor b3f3dbc663 TheSlavePens/Ahune: Fix crash (#22070)
Closes: #22069
(cherry picked from commit eb6e240fd1)
2021-09-29 20:55:23 +02:00
ZenoX92 ecf2a0ef9f DB/Quest: Escaping the Tomb
Closes #22033

(cherry picked from commit 5f69a8de70)
2021-09-29 16:05:49 +02:00
ccrs 426f9f2f92 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).

(cherry picked from commit 982643cd96)
2021-09-28 00:15:13 +02:00
Keader b91398fd28 Scripts/Magtheridon Lair: Fixed a case when channelers get hit kill and not start fight
It's needed for cataclysm+

(cherry picked from commit 65bad41144)
2021-09-26 23:04:18 +02:00
Treeston f69d12504c Core/Object: Bump hover delta handling on nearpoints downstack into GetNearPoint2D (from movement generators); functionality should be unchanged
(cherry picked from commit ebc96af6bb)
2021-09-23 22:28:06 +02:00
Treeston bc89e1cdb0 Core/Position: Refactor GetAngle -> GetAbsoluteAngle because code clarity is good.
(cherry picked from commit 4692e10ca2)
2021-09-23 22:21:29 +02:00
Keader c1641642cb Scripts/Magtheridon: Fixed Magtheridon inaccessible
Closes #21693

(cherry picked from commit 99993a7f62)
2021-09-22 23:29:33 +02:00
Shauren 8a4e1119ac Core/Spells: Unify spell effect access api in both branches 2021-09-04 15:13:15 +02:00
Shauren 8cc418460f Core/Misc: Fix gcc warnings 2021-08-28 16:08:33 +02:00
Treeston 994121e671 Core/CreatureAI: CheckBoundary -> IsInBoundary, better reflects what it does. Also moved to public so spellscript can use it.
(cherry picked from commit df639d85e4)
2021-08-23 23:28:48 +02:00
Wyreth 8713a62328 Core/Entities: remove grid-wide visibility from setActive and implement another method for it (#20725)
(cherry picked from commit 56874b44f0)
2021-08-08 21:21:34 +02:00
Keader cb8ea03175 Core/Scripts: Fixed some delayed enrage
Closes #15367

(cherry picked from commit 63c436f5fb)
2021-06-21 00:06:41 +02:00
Keader 9b7f3bff9f Core/Scripts: Fixed tabs issues introduced in 5bef3e426a
(cherry picked from commit 31ad6358fb)
2021-06-19 23:33:24 +02:00
Keader ad5b0fa9cd Core/Scripts: Fixed possible crashs related with JustDied
(cherry picked from commit 5bef3e426a)
2021-06-19 23:33:24 +02:00
ariel- c77925da4a Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version
Closes #12108 (again)

(cherry picked from commit 7c9722a4ae)
2021-06-16 21:03:06 +02:00
Kittnz cd3425f6a6 Scripts/Outland: Fix logical error in Hellfire event in Honor Hold
(cherry picked from commit 8f64612cb1)
2021-06-16 14:32:07 +02:00
ariel- 85ffcd9826 Core/Scripts: fix wrong uses of SetHitDamage hook.
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.

- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power

Closes #9560

(cherry picked from commit 9f5d1e2b10)
2021-06-16 14:26:09 +02:00
ariel- 62c571076e Core/Scripts: added nullptr checks to DamageTaken hooks
Since cb9e72e521 attacker may not be in world when hook is called

(cherry picked from commit 0db5c2df3f)
2021-06-16 12:02:14 +02:00