fb5d05c198
Core/Spells: Prevent assertion failure in Spell::SelectImplicitDestDestTargets by setting dest to caster if no dest provided.
2012-02-22 21:06:29 +01:00
fa546d1428
Core/Spells: Change logic in assertion in Spell::SelectImplicitTargetObjectTargets.
...
Not sure if this a step in the right direction for the intended design, but following the logic of the function there should be OR unit target OR gameobject target OR item target pointers available. If Item target doesn't belong there then the already present AddItemTarget call should be removed.
2012-02-22 19:16:47 +01:00
7a261ff9b8
Core/Spells: Use right function for obtaining spell target type. Fixes assertion failures.
2012-02-22 10:34:08 +01:00
2a1ffc1cd9
Core/Spells: Fix a typo in f09b5a6bea - call right function for target dest case.
...
Closes #5357
2012-02-22 10:21:02 +01:00
1e246cb66c
Fix build (gcc) and fix warnings
2012-02-22 09:15:57 +01:00
f09b5a6bea
Core/Db/Conditions:
...
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required
Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
9abc47736f
Core/Spells: Changes in code related to spell explicit target redirection (cleanups, added target validation, prevent unexpected behaviour in some cases)
2012-02-19 00:40:55 +01:00
7ce7853606
Core/Spells: Revert part of 65d269f6de. Solves some recent instant spell casting issues.
2012-02-16 20:38:48 +01:00
03c34ee507
Fix a lot of warnings
2012-02-16 13:56:28 +01:00
65d269f6de
Core/Spells: Allow dead players as valid objects for RaiseDeadObjectCheck (enables Raise Dead on players that have not yet released spirit)
...
TODO: Allow all corpses
2012-02-15 00:46:08 +01:00
7d30b061f0
More compiler error fixes
2012-02-14 14:06:31 -05:00
d55126aacb
Core/Spells: Revert erroneous interruption added in 5ea49613d2 - more research required
2012-02-14 13:14:51 -05:00
8a72aede16
Codestyle: Renamed some variables to fit codestyle, corrected order in structure/class fields to match alignment (they use slightly less memory now)
...
Signed-off-by: Subv <s.v.h21@hotmail.com >
2012-02-14 12:46:26 -05:00
5ea49613d2
Core/Spells: Spell casts should be interrupted if the target goes out of LoS.
...
Signed-off-by: Subv <s.v.h21@hotmail.com >
2012-02-12 15:30:16 -05:00
ce4a4ffe50
Core/Db/Conditions: Add ContidionTarget column which allows selection of objects which will be checked by condition, depending on SourceTypeOrReferenceId.
...
So far usable only with CONDITION_SOURCE_TYPE_SPELL:
ContidionTarget = 0 - check caster
ContidionTarget = 1 - check explicit target
2012-02-10 23:42:08 +01:00
8713b44ee7
Core/Db/Conditions: Prepare conditions system to work on objects of different type than players.
...
Warning: API has changed a bit:
ConditionScript::OnConditionCheck(Condition* condition, Player* player, Unit* invoker) is now
ConditionScript::OnConditionCheck(Condition* condition, WorldObject* object, WorldObject* invoker)
2012-02-10 14:18:59 +01:00
9791bb599a
Merge pull request #5160 from TrinityCore/dynamic_vmaps
...
Added Dynamic Vmaps, RE-EXTRACT YOUR VMAPS
2012-02-09 11:17:05 -08:00
93d199f043
Core/Collision: Ported dynamic line of sight patch by Silverice from MaNGOS and
...
added lots of improvements
Please re-extract vmaps
2012-02-09 13:58:22 -05:00
4623db0abe
Merge pull request #5052 from devilcoredev/fix_003
...
Core/Spells: Check line of sight for AoE targeted spells
2012-02-09 10:29:45 -08:00
b4022acdf3
Core/Spell: move conditions check to Spell::CheckCast.
2012-02-09 18:35:52 +01:00
22bd06fc57
Typofix. Sorry for that :(
2012-02-04 18:28:56 +01:00
9d185c5d66
Core/Spells: Fix immunity checks on apply aura - original patch by devilcoredev, changed a bit so immunity checks are grouped together instead of being spread.
2012-02-04 15:27:47 +01:00
7e99e5f094
Core/Spells:
...
- rename SpellInfo::IsAOE to SpellInfo::IsTargetingArea due to ambiguity of old name.
- add IsAffectingArea function to check whenever spell or it's effects are affecting objects in area and use new function to fix problems with hunter flares.
Closes #3310 . Thanks to Kaelima and Warpten for research.
2012-02-03 22:24:03 +01:00
08be716ef8
Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_*
2012-02-03 19:02:17 +02:00
16300d0914
Check line of sight for spell with dest
2012-02-02 19:06:28 +01:00
9b524b43fa
Core/Spells: Spells with SPELL_AURA_PERIODIC_MANA_LEECH should skip unit target checking if the Targets are area targets, they are filled/validated later
...
Signed-off-by: Subv2112 <s.v.h21@hotmail.com >
2012-01-31 20:27:22 -05:00
a535e451a8
Core/Spells: Fix issue in CAST_FLAG_ADJUST_MISSILE handling. Thx rsa (R2) for pointing.
2012-01-13 19:18:13 +03:00
67808ba453
Core/Spells: Fix CAST_FLAG_UNKNOWN_18.
...
*rename CAST_FLAG_UNKNOWN_18 -> CAST_FLAG_ADJUST_MISSILE
*implement handling in Spell::SendSpellGo()
2012-01-08 18:50:25 +03:00
08bcbc89b0
Merge pull request #4229 from devilcoredev/fix_002
...
Core/Spells: Fix the spell immunity system to be effect-dependent
2012-01-04 13:41:51 -08:00
8299627ed9
Update headers for 2012. HAPPY NEW YEAR!!!
2012-01-01 00:32:13 +01:00
afc18461d7
Core/SpellScripts: Add BeforeCast, OnCast and AfterCast hooks to SpellScripts.
2011-12-31 13:11:12 +01:00
f283a7b116
Merge pull request #4475 from Svannon/fix-fishingcone
...
Core/Fishing: Reduce the fishing cast cone to 35 degrees from each side of the facing instead of 70. Make the overall cone 70 degrees instead of 140
2011-12-25 12:16:10 -08:00
3405e0811d
[Fishing] Reduce the Fishing cast cone to 35 degrees from each side of the facing instead of 70. Make the overall cone 70 degrees instead of 140.
2011-12-24 12:41:22 -07:00
15bd8f3cd5
Core/Spells: Fix logic in AnyDeadUnitSpellTargetInRangeCheck - spells using this should now correctly check target requirements. This is an alternative fix to #4112 .
2011-12-24 08:40:30 +01:00
398299084e
Corrected some logic in my recent commits.
...
- ff2dbfc3816ccf95af4c
2011-12-22 18:48:06 +01:00
ff2dbfc381
Core/Spells: Fix two signed / unsigned warnings from f8a13b401d
2011-12-22 13:22:18 +01:00
f8a13b401d
Core/Spells:
...
- Fix channeling spells with infinite duration (-1)
- Allowed SPELL_FAILED_EQUIPPED_ITEM_CLASS_MAINHAND and SPELL_FAILED_EQUIPPED_ITEM_CLASS_OFFHAND in SendCastResult (more reasons todo)
2011-12-22 00:38:01 +01:00
72e48ef8b3
Fix immunity system for many spells.
2011-12-14 16:13:10 +01:00
471c9dd621
Core/Spells: stop channeling bar when interrupted also for creature
2011-12-10 01:46:06 +01:00
358b33239a
Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit
2011-11-23 19:17:33 +01:00
b3fef1e280
Fix build.
2011-11-23 12:42:11 -05:00
638693e78f
Core: Fixed more warnings (C6246: Local declaration of 'x' hides declaration of the same name in outer scope.)
2011-11-23 17:55:16 +01:00
f75ec5ba2b
Core: Codestyle clean-up
...
"plr"->player
Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
68601bb286
Core/Spells: Use correct dbc flag to check if spell can be interrupted
2011-11-03 16:53:29 +07:00
dfeb4a746b
Fix a crash caused by spell with CAST_FLAG_RUNE_LIST casted by a creature mover. Thanks to Vasago.
2011-10-31 09:56:04 -04:00
5514523a7c
use effectMask to calculate mechanicMask in ModSpellDuration
2011-10-20 18:28:37 +02:00
a658d0b592
Core/Spells: Define and implement SPELL_ATTR4_PROC_ONLY_ON_DUMMY.
...
Fixes #2685
Fixes #2573
2011-10-19 22:08:54 +02:00
be0b2fcf97
Core/Grid:
...
- Simplified CellArea calculation (Original author: SilverIce)
- Removed unused code in Cell class (Original author: SilverIce)
- Improve some Visit functions.
2011-10-19 17:40:44 +01:00
8f8949fcf0
Core/Spells: Spells with the self-cast range should not have a range check. This range used for many triggered spells.
...
Fixes #3358
2011-10-19 00:24:43 +02:00
c29ff41001
Rename some classes in grid system.
...
Note: The naming of classes is still confusing. "cell" usually refers to class "Grid", and "grid" usually refers to class "NGrid". But it requires a lot of changes to clean this up.
2011-10-18 10:53:34 -04:00
QAston