fa50c0a464
Fix some warnings here and there
2011-07-27 11:00:39 +02:00
b0fe236265
Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
...
*SpellEntry is now SpellInfo
*GetSpellProto is now GetSpellInfo
*SpellEntry::Effect*[effIndex] is now avalible under SpellInfo.Effects[effIndex].*
*sSpellStore.LookupEntry is no longer valid, use sSpellMgr->GetSpellInfo()
*SpellFunctions from SpellMgr.h like DoSpellStuff(spellId) are now: spellInfo->DoStuff()
*SpellMgr::CalculateEffectValue and similar functions are now avalible in SpellEffectInfo class.
*GET_SPELL macro is removed, code which used it is moved to SpellMgr::LoadDbcDataCorrections
*code which affected dbc data in SpellMgr::LoadSpellCustomAttr is now moved to LoadDbcDataCorrections
2011-07-26 23:09:28 +02:00
5a370392d4
Core/Chat: Prevent turning whispers on, receive spam about AFK or DND in case of whispering with addon message
2011-07-24 03:14:28 +07:00
a0f1a5c789
Core/Spells: Removed remaining part of old global cooldown handler
2011-07-23 03:30:43 +07:00
72ea9c9fa8
Core/Spells: Add a base for brand new proc system, this is a WIP and doesn't affect currently working code.
2011-07-10 13:13:02 +02:00
48e47a9245
Core/Achievements: Simplify handling of achievements for GMs: Do not allow achievements when GM-mode is enabled, allow when disabled
2011-07-02 02:14:49 +02:00
bb921ae78c
Core: Do not use STL container size method to check if container is empty
2011-07-01 14:58:44 +02:00
e9aa72cc7b
Cosmetic: rename function escape_string to EscapeString
2011-06-30 14:52:44 +02:00
fb9719c653
Core/Spells: Define SPELL_ATTR0_ABILITY (old SPELL_ATTR0_UNK4)
2011-06-30 01:47:09 +02:00
609efde598
Core/Corpses: Fix a crash in ConvertCorpseForPlayer
2011-06-29 16:08:23 +02:00
f19f0a19f2
Core/Players: Fix possible (exploitable) data desynchronisation that would lead to repeating the same quest while already having received the rewards.
2011-06-28 21:36:21 +02:00
1eff27f57c
Core/Quests: Fixed adding autoaccept quests many times to log when started from items
...
Closes #2106
2011-06-28 20:16:15 +02:00
142943d4c1
This reverts commit f580cddc09.
2011-06-28 13:05:15 +02:00
f580cddc09
Core: Add wintergrasp-patch to wintergrasp_cleanup branch - resurrected from an old work-repository, now over as a branch to work on.
...
Original patch by socolin, cand a ton of contributors :
mathman, joda, spp, silinoron, josh, malcrom, shauren, machiavelli, click, rat, leak, tobmaps, _manuel_, the tcfr team (via socolin), and tons of others for chiming in.
NOTE: THIS IS A WORKING-BRANCH, AND _NOT_ MENT FOR PUBLIC USE OR EVEN CONSIDERED STABLE!
2011-06-28 00:56:29 +02:00
e8b4d1fab7
Core/Spells: Fix side effects from 33f3397 (issues related to Mangle for druids not being re-learned on talent switch). Original fix done alternatively.
2011-06-27 02:01:20 +02:00
33f3397976
Core/Spells: Completely remove spells which were taught by SPELL_EFFECT_LEARN_SPELL on talent reset or talent spec switch - instead of keeping them stored as disabled. Reason for this is that if the primary spell with effect SPELL_EFFECT_LEARN_SPELL is learnt again, a 'new' secondary spell will be taught while the old one was still around. The latter was the reason for primary key violations in character_spell that led to transaction failures and thus character rollbacks.
...
Closes #1231
Closes #480
2011-06-23 02:39:36 +02:00
fe8cb75bf1
Core/DBLayer: Make database interaction after create character packet completely asynchronous. This is more performant and fixes a DoS loophole and possible data desynchronisation caused by spamming this packet.
...
Closes #584
Closes #2089
2011-06-22 14:22:08 +02:00
c4818f1892
Core/Auras: Fix refresh of auras with spellmodifiers applied to currently cast spell.
2011-06-21 19:59:17 +02:00
f4047ff7dc
Core/Alcohol: Drunk players will now properly see drunk-visible units.
2011-06-21 16:09:07 +02:00
62908812cb
Core/Gossip: Ditch gossip_scripts as it is no longer used. SAI is a better option
2011-06-19 15:24:59 +01:00
19ede8fa72
Core/Quests: Fixed destroying of quest items which start a quest and are also needed for completing this quest
2011-06-18 21:08:14 +02:00
1abdb65f5a
Core/Misc: Cleanups, code style and typo fixes
2011-06-16 20:08:28 +07:00
fb44a609ff
Core/Gossip: Fixed incorrect gossip menu texts introduced after dropping npc_gossip table
2011-06-15 18:53:55 +02:00
e1f7f9e5b1
Core/Players: Fix average item level calculation: omit shirt shot, not chest armor slot. Thanks to AreYouSiries for pointing out.
...
See issue #894
2011-06-12 03:06:33 +02:00
b9e8694540
Core: Continued cleanup
...
If and for whitespaces.
2011-06-12 02:30:32 +02:00
f16df538ee
Core: More codestyle cleanups
2011-06-12 01:47:45 +02:00
158966dc79
Core: Codestyle cleanup
2011-06-11 22:35:29 +02:00
9ef8bd3072
Core/Misc: Fix compile, revert part of a73c7f506e, these should actually be errors.
2011-06-11 19:20:49 +02:00
a73c7f506e
Core/Misc:
...
- Changed some error messages for changing spec to be displayed as debug messages.
- Fixed compile warnings.
2011-06-11 19:05:47 +02:00
9b79df7074
Core/Spells: Implemented SPELL_ATTR7_IS_CHEAT_SPELL serverside checks and allow GMs to cast these spells
2011-06-11 13:02:54 +02:00
a4a57ab096
Core/Player: Allow hp5 bonus from items to regenerate also in combat
2011-06-10 20:40:23 +07:00
60470e4bd8
Core/Misc: Some random cleanups
2011-06-09 19:41:13 +07:00
0c3e99c450
Core/Auras: Move repeating code for aura packet creation to separate function. Fixes usage of SPELL_ATTR5_HIDE_DURATION attribute.
2011-06-08 10:41:32 +02:00
0575dddbb3
Core/Auras: Fix visibility aura effect handlers to work correctly on amount change
2011-06-08 09:19:34 +02:00
6c5f68e8fc
Core/Auras: Do not use spellmod system to drop auras with spell proc event entry.
2011-06-07 19:09:20 +02:00
b9e8e6d3b4
Core/Auras: Add functions for common actions on aura charges.
2011-06-07 17:26:27 +02:00
97a5db68c2
Core/Auras:
...
* Fixed loading aura charges when they would exceed count set in SpellEntry while still remaining a valid value due to spell modifiers (that might not yet be active)
* Fixed refreshing aura charges when recasting the spell
Closes #1803
Closes #1786
Closes #1805
2011-06-03 21:30:50 +02:00
d1307ee47b
Core: use UNIT_DYNFLAG_NONE instead of 0-value. Also fixed typo in reset UNIT_DYNAMIC_FLAGS at player death
...
Signed-off-by: click <clickvd@gonnamakeyou.com >
2011-05-31 01:18:50 +02:00
4a0290c17b
Core/Quests: Fix quests that require player to be dead
...
Closes #1441
2011-05-30 02:59:37 +07:00
42fc72447b
Core/Dungeon Finder: Fix instances unlock after level change
2011-05-29 22:49:05 +07:00
0bde74eff6
Core/Gossip: Removed hardcoded costs for dual spec and fixed handling of gossip menus with box_money
2011-05-29 12:06:16 +02:00
48b0570f53
Core/Vehicles:
...
- Temporarily unsummon pets when entering vehicle and resummon them when exiting. Also fixes missing pet cast bars on exit.
- Correct SMSG_PET_SPELLS packet for vehicle spell initialize
2011-05-27 17:31:31 +02:00
889cdda614
Core/Gossip: Fixed remaining issues with gossip menu items
2011-05-27 14:22:36 +02:00
6e009d9bd1
Core/Gossip: Fix typo in 0ad14aeafd breaking gossip options.
2011-05-27 01:54:29 +02:00
78692e1246
Core/Area: Updated AreaFlags documentation to match 3.3.5 dbcs.
2011-05-27 00:58:18 +02:00
0ad14aeafd
Core/Gossip: Gossip menu items will now have constant index, allowing to properly define scripts relying on that index when mixed with conditions. Script-created menus via ADD_GOSSIP_ITEM will still have the index generated dynamically
2011-05-26 23:57:17 +02:00
f91136b949
Core/Vehicles: Corrected vehicle spell bar packet, now empty slots will remain empty and spells will not be "packed" together anymore
2011-05-26 23:51:34 +02:00
0ea721e25a
Core/Players: Allow GMs to have their player flags correctly loaded from DB
2011-05-25 16:35:35 +03:00
0b557f02b2
Core/Spells: Fix warrior stances save after death/logout
2011-05-25 20:29:06 +07:00
6acd954bf5
Core/Misc: Some random cleanups
2011-05-25 19:54:17 +07:00
Spp-