* Core/Player: add helper methods GetNativeGender/SetNativeGender/SetGender and fix some cases, where we should get player gender, instead of modified by display gender
* fix merge
* Add virtual methods for Unit class
(cherry picked from commit b47bb59e2a)
Core/Spell: The giant CastSpell unclusterfucking (that's a word now) of this generation.
- CastSpell now always takes three arguments - target, spellId, and a struct containing extra arguments
- This struct (CastSpellExtraArgs, see SpellDefines.h) serves as a conglomerate of every previous combination of the 20 billion different CastSpell overloads, all merged into one
- It has some great utility constructors - check them out! All of these can be used to implicitly construct the ExtraArgs object.
- A gajillion refactors to make everything behave the way it always has
(cherry picked from commit d507a7e338)
Closes#6876
Fixed achievement Burning Hot Pole Dance
Update scripts for quest Torch Tossing, using all correct spells and timers
Updated script register model
(cherry picked from commit 6e7e43172e)
Event/Midsummer: improve pole ribbon functionality:
- Bunny creature should hover, which puts it in the intended position.
- Use correct visual and internal spells to handle cosmetics and timers.
(cherry picked from commit 03b15d968b)
Rename 9999_99_99_99_world.sql to 2016_07_05_03_world.sql
(cherry picked from commit 8edc1caf32)
* Scripts/Midsummer: Burning hot pole dance
By zwerg, closes#6876
(cherry picked from commit b0e5f6de47)
Rename 2016_99_99_99_world_.sql to 2016_06_26_01_world_.sql
(cherry picked from commit 184e64fa33)
Rename 2016_06_26_01_world_.sql to 2016_06_26_01_world.sql
(cherry picked from commit 4cc88b5f09)
Add all 6 spells available from item 20557,
Hallow's End Pumpkin Treat:
- Hallow's End Candy, Orange Giant (24924)
- Hallow's End Candy, Skeleton (24925)
- Hallow's End Candy, Pirate (24926)
- Hallow's End Candy, Ghost (24927)
- Hallow's End Candy, Female Defias Pirate (44742)
- Hallow's End Candy, Male Defias Pirate (44743)
Thanks @Keader for creating the new spell scripts & SQL,
saved me a lot of time! :-)
(cherry picked from commit cee1c0789a)
Hallowed Wand items should cast a transformation on party members.
by @DevRival, closes #3574
Before this patch, the following spells do not have any effect at all:
- 24717, Pirate Costume
- 24718, Ninja Costume
- 24719, Leper Gnome Costume
- 24720, Random Costume
- 24737, Ghost Costume
Details from testing on the current 3.3.5 branch (commit ecbbcc8):
- 24724 (Skeleton Costume) seems to work as intended
- 24733 (Bat Costume) only lasts 10 seconds instead of 60 minutes
- 24741 (Wisp Costume) also seems to work as intended
All the spells listed above are included in this PR.
(cherry picked from commit 3fdbcf18ae)
Merge pull request #14776 from sirikfoll/SpellMidsummer
Core/Spells Add support for quest Torch Tossing/More Torch Tossing
(cherry picked from commit 8197467c87)
by sirikfoll
---
Rename 2015_08_29_00_world.sql to 2015_06_23_01_world.sql
(cherry picked from commit 352703e89b)
by MitchesD
---
Scripts/Spells: fix codestyle
thanks @whoami
(cherry picked from commit 0cba5558cf)
by MitchesD
- Fix Quest "There and Back Again" (only Horde-side)
- Fix Quest "Now This is Ram Racing... Almost." (only Horde-side)
- Fix more spell mechanics for racing ram
To/Do: Fix gossips and some optimize
Visual studio does not support constexpr
Made semicolon after "Prepare*Script" mandatory - workaround for dumb IDEs inserting extra indentation level after newline
-Fix warnings from -Woverflow on implicit constant conversion.
-Fix warnings from -pedantic.
-Fix warnings from -pedantic.
-Fix warnings from -Wformat.
Two minor changes in addition :
-Replace a defined value equal to 2^31 - 1 by std::numeric_limits<int>::max().
-Remove useless null-check on pointer returned by new. New doesn't returns nullptr on failure, it throws std::bad_alloc.
