Commit Graph

25656 Commits

Author SHA1 Message Date
Meji
de4eaa0de9 Core/BattlePets: Misc fixes (#26964)
* Define BattlePetSpeciesFlags enum class.
* Define BattlePetDbFlags enum class.
* Added check to prevent the pet from being caged if its species has flag BattlePetSpeciesFlags::NotTradable.
* Added check to prevent the pet from being caged if it's in battle pet slots.
* Added check to prevent the pet from being caged if its health is below maximum health.
* Only add pet if the species has flag BattlePetSpeciesFlags::WellKnown.
* Added function to check flag BattlePetSpeciesFlags::LegacyAccountUnique to avoid learning copies of unique pets.
* Implemented CMSG_BATTLE_PET_CLEAR_FANFARE.
2021-09-29 22:26:25 +02:00
sirikfoll
f507737ecf Scripts/TheSlavePens: Boss Ahune fixes and updates
Fixes some visual problems
Fixes encounter start
Updated codestyle

Closes #22071

(cherry picked from commit 35ba5aa138)
2021-09-29 21:01:25 +02:00
Gildor
b3f3dbc663 TheSlavePens/Ahune: Fix crash (#22070)
Closes: #22069
(cherry picked from commit eb6e240fd1)
2021-09-29 20:55:23 +02:00
ZenoX92
ecf2a0ef9f DB/Quest: Escaping the Tomb
Closes #22033

(cherry picked from commit 5f69a8de70)
2021-09-29 16:05:49 +02:00
Shauren
75909f9232 Core/Bnet: Updated protobuf messages and services 2021-09-29 10:32:04 +02:00
ccrs
6d9e544c20 Core/Movement: shield ChaseMovementGenerator against a potential crash
Since GenericMovementGenerator can be built with any MOTION_TYPE

(cherry picked from commit 98fd8d4c74)
2021-09-29 00:01:23 +02:00
ccrs
4487933bd0 Core/Movement: adjust deactivation/reset logic inside GenericMovementGenerator
Deactivated GMGenerators will now Initialize if they never did.
Mimiron's script needs still some movement love.

closes #22037

(cherry picked from commit 24a9598e2c)
2021-09-29 00:00:57 +02:00
ccrs
30583be025 Core/Movement: prevent double initialization calls if the generator was deactivated before being initialized
ref #22037

(cherry picked from commit 825c5f5ec4)
2021-09-29 00:00:26 +02:00
Андрей
4c6e89942f Core/Spells: Make some spells negative (#21696)
Closes #21634

(cherry picked from commit 5fa783bd34)
2021-09-28 20:58:14 +02:00
Keader
1d00e4eccb Scripts/Ruby Sanctum: Fixed Baltharus target amount of Enervating Brand part 2
(I forgot the clones, ty Gildor)

(cherry picked from commit 3102a6c903)
2021-09-28 15:32:32 +02:00
Keader
a046ef8604 Scripts/Ruby Sanctum: Fixed Baltharus target amount of Enervating Brand
(cherry picked from commit 8a312046b2)
2021-09-28 15:32:00 +02:00
Keader
d4be86d835 Kill a whitespace
(cherry picked from commit ee7c0c16f1)
2021-09-28 15:31:34 +02:00
DanVS
71e27f540d Core/Spells: Reset Mangle cooldown in Berserk (#22000)
(cherry picked from commit 3bd9337d9f)
2021-09-28 15:26:42 +02:00
Keader
4aaf3d67a3 Scripts/Pit of Saron: Fixed Ick not updading victim
Closes #22001

(cherry picked from commit 6cf8bd5ae7)
2021-09-28 00:15:42 +02:00
ccrs
426f9f2f92 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).

(cherry picked from commit 982643cd96)
2021-09-28 00:15:13 +02:00
Maxwelllmj
bd91674e66 Scripts/Karazhan: make Barnes properly start the Opera Event (#21970)
Close: #21881
(cherry picked from commit 4fe5a167d2)
2021-09-26 23:23:26 +02:00
Keader
b91398fd28 Scripts/Magtheridon Lair: Fixed a case when channelers get hit kill and not start fight
It's needed for cataclysm+

(cherry picked from commit 65bad41144)
2021-09-26 23:04:18 +02:00
Gooyeth
2757235956 Core/Battleground: Fixed a problem that did not let Arenas queue if it was in queue of Random Battleground (#21963)
(cherry picked from commit 5871c36750)
2021-09-26 21:36:48 +02:00
Treeston
5f0f530c08 re-enable CreatureAI::MovementInform for Chase/FollowMovementGenerator - didn't realize any AI used this
(cherry picked from commit 56a056a8a5)
2021-09-26 21:17:40 +02:00
jackpoz
289be4d97c Core/Misc: Fix FreezeDetector triggered on startup
Fix FreezeDetector triggering the assert on startup if scripts took more than a few seconds to initialize.

(cherry picked from commit 7b7dc1b508)
2021-09-26 20:51:09 +02:00
jackpoz
376defd085 Scripts/Icecrown Citadel: Fix "intended" crash
Change an assert (that can happen easily using ".npc add") to a sanity check

(cherry picked from commit 953640d563)
2021-09-26 16:21:33 +02:00
jackpoz
330881518a Core/Quest: Fix crash caused by disabled quests
Fix crash happening when a disabled quest was added and rewarded (through a GM command). Disabled quests are not validated on startup and they can reference invalid spells.

(cherry picked from commit 5f6af8c6cb)
2021-09-26 16:21:11 +02:00
ccrs
ab740026b3 Core/Movement: crashfix workaround
untested
ref #18471

(cherry picked from commit 76667e45a9)
2021-09-26 16:16:16 +02:00
jackpoz
3f659ce5ff Core/Thread: Fix crash added in fd33b1cd02
Fix crash caused by dereferencing uninitialized field.

(cherry picked from commit 623bc6483a)
2021-09-26 16:15:52 +02:00
Treeston
9f06cb63d2 Core/Threat: My dictionary informs me that "fixtate" is not, in fact, a word. Corrected to "fixate".
fd33b1c follow-up

(cherry picked from commit 1d27f83bda)
2021-09-26 16:13:15 +02:00
Shauren
58043c8d90 Core/Movement: Removed unneccessary z position adjustment
Closes #21872

(cherry picked from commit d9a2177e9c)
2021-09-26 16:12:52 +02:00
Treeston
16eb5032ad Core/Threat: Re-add fixtate system. I am being told Netherspite needs it.
(cherry picked from commit fd33b1cd02)
2021-09-26 16:12:33 +02:00
Treeston
c926e2fc94 1b7ec4b follow-up
(cherry picked from commit 7fe59c95d8)
2021-09-26 16:11:59 +02:00
Treeston
4634cfaa9f Core/Threat: Fix taunt behavior in some edge cases
(cherry picked from commit 1b7ec4bc84)
2021-09-26 16:07:40 +02:00
Treeston
f1ac141f25 Core/Unit: UNIT_FLAG renames
[UNIT_FLAG_PLAYER_CONTROLLED -> UNIT_FLAG_POSSESSED]
[UNIT_FLAG_PVP_ATTACKABLE -> UNIT_FLAG_PLAYER_CONTROLLED]
Signed off by: Shauren, Warlockbugs.

(cherry picked from commit 081eab3cf5)
2021-09-26 16:07:09 +02:00
Jorge Turrado Ferrero
a9b97939a8 Scripts/Ulduar: Fixed Vehicles when flame leviathan die(#21897)
(cherry picked from commit f13de80834)
2021-09-26 15:49:18 +02:00
Keader
962833d86f Core/Handlers: Fixed Equipament Manager (for real this time)
(cherry picked from commit 26a444719b)
2021-09-26 15:47:34 +02:00
Gooyeth
80d4bde77a Core/Player: Skip the cinematic of the first login if the character is teleported before. (#21776)
(cherry picked from commit 8cec3ffe43)
2021-09-26 15:45:44 +02:00
Keader
d8e57b1ddc Core/Handlers: Fixed a Equipament Manager typo
(cherry picked from commit 5a22467912)
2021-09-26 15:43:00 +02:00
Keader
1fcabb4092 Core/Handlers: Fixed equipament manager with empty slots. Yes kids, dont use drugs !
Followup: 42be04898c
(cherry picked from commit dec75903cf)
2021-09-26 15:42:24 +02:00
Shauren
9709643f50 Core/Misc: Fix copyright headers 2021-09-26 14:22:52 +02:00
ccrs
0b6049fe0b Core/Movement: use helpers for validation
(cherry picked from commit 7118806231)
2021-09-26 14:21:14 +02:00
ccrs
d59a6af9c6 Core/Movement: move MoveSplineInit (#21857)
The number of edge cases in which weirdness is seen on "effect movements" will be kinda reduced, plus consistency, plus movementInform on custom movement spline initalizations.

(cherry picked from commit 2a45418032)
2021-09-26 14:19:36 +02:00
Shauren
334b02e1da Core/SAI: Fixed crashes when SAI targets pets that use sai if not tamed
Closes #21870

(cherry picked from commit beb333738d)
2021-09-26 12:43:18 +02:00
ccrs
d376058dcc Core/Movement: crashfix
New movement -> Mutate -> Finish current for that slot that happens to be the same type, Follow -> Finish method on the removed movement -> UpdateSpeed call -> search for top -> crash

Closes #21861

(cherry picked from commit bcab5bc4e7)
2021-09-26 01:43:24 +02:00
Shauren
068b340b69 Core/Transports: Force transport passengers into legacy spawn group
Ref #21641

(cherry picked from commit a5df77a9d6)
2021-09-26 01:42:54 +02:00
Shauren
5274f7af17 Core/PacketIO: Added missing move assignment operator to ByteBuffer
(cherry picked from commit fcb1e3e642)
2021-09-26 01:27:59 +02:00
ccrs
4793b073ee Core/Misc: movement header cleanup
(cherry picked from commit f9914caefc)
2021-09-26 01:22:17 +02:00
Nitair
4f0aa11c6e Scripts/Stratholme: Baroness Anastari rework (PR #21687)
(cherry picked from commit dc28889151)
2021-09-25 22:45:56 +02:00
Gooyeth
a9e7464e0d Core/Battleground: allow Random battleground and arena queues same time. (#21730)
- It also restricts queuing to arenas if it is in queue of dungeon finder

(cherry picked from commit 8aad6f828e)
2021-09-25 21:36:11 +02:00
Shauren
e598cfe28d Core/SAI: Fixed silence logic in 1e8227eda7
(cherry picked from commit 668df7fd01)
2021-09-25 20:46:13 +02:00
Killyana
c0cb8fc1fe Core/SAI: Allow movements for creature using castflag 64 when silenced
Closes #20222

(cherry picked from commit 1e8227eda7)
2021-09-25 20:45:27 +02:00
Killyana
e7f93ca96d Core/SmartAI: Remove PauseMovement on AttackStart
Closes #21144

(cherry picked from commit e27a745c58)
2021-09-25 20:43:39 +02:00
Shauren
52de393f10 Core/Players: Greatly simplifiy fdb2b90685
(cherry picked from commit 9617778336)
2021-09-25 15:36:50 +02:00
Shauren
47630708f0 Core/Players: Prevent creating characters with duplicate name by reserving name early in the process
Closes #21656
Closes #21809

(cherry picked from commit fdb2b90685)
2021-09-25 15:34:20 +02:00