Commit Graph

4531 Commits

Author SHA1 Message Date
Treeston dcc3cd21e8 Scripts/AzjolNerub: Fix some duplicate summons after JustAppeared changes. Closes #20183. 2017-08-24 18:02:27 +02:00
ccrs 91c0d49c18 Core/Creature: regenerate health
There are three possible scenarios regarding regenerating health
- db lock and curhealth set to > 0
- db lock and curhealth set to 0
- dynamic lock (set in scripts and such) overriding db lock
2017-08-21 20:28:18 +02:00
Treeston cac99beffd Scripts/Commands: .npc delete and .gobj delete now work while the specified guid is despawned. Fixes #20145. 2017-08-21 17:07:53 +02:00
Treeston 165bc02889 Scripts/Auchindoun: Fix a super edge case crash bug with GM far teleports during Blackheart's charm phase. Follow-up to d80d7c6. 2017-08-21 16:44:33 +02:00
Keader 76fc9ed635 Core/Scripts: Updated Razorscale to new registers model
* More codestyle fixes
* Ty sirikfoll :)
2017-08-20 22:23:32 -03:00
Keader 203c5f7058 Core/Razorscale: Codestyle Updates
* Removing spelldifficulty_dbc to make portable to master
* Updated to new Spell/Aurascript model
2017-08-20 17:38:47 -03:00
Foereaper 6f4492bc61 Scripts/Naxxramas: Fix Heigan the Unclean eruption event (#20129)
By scheduling the eruption event without cancelling the previously registered eruption events, Heigan's eruption (or dance) would overlap and cause a runaway scenario, where eruptions would not follow a proper timer.

By using Reschedule and not locking the Eruption event to the fighting phase, the dance now works as intended.
2017-08-20 18:16:23 +02:00
Gustavo 22a7956069 Core/Scripts: More fixes in boss Lich King (#20147)
* Core/Scripts: More fixes in boss Lich King

Fix Valkyr charge spell, they will no longer ignore Z position and become unreachable.
Correct height of Spirit Bomb and added the 3 seconds delay on his explosion.
Set the Trigger inside frostmourne room as active, to avoid problems with reseting the room, e.g: Spirit Bombs not despawning and Wicked Spirits stuck in evade.
Use correct InhabitType for Wicked and Vile Spirits, this avoid a situation where they could spawn falling.
2017-08-17 12:03:56 -03:00
sirikfoll e2565c2597 Core/Misc: Remove Whitespaces 2017-08-11 23:06:37 -03:00
ccrs 7fff83d675 Core/Movement: waypoint movement (#20121)
Following the work done in #19361 this is the cleanup and improvement of the related logic of waypoint management.

Ref 28050f3 #18020
(taking the good parts and ignoring the incomplete work)
2017-08-12 01:40:25 +02:00
Gustavo e9cd7af2df Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau) (#19897)
* Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau)

Scripted all spells
Corrected behavior of Spectral Blast and Curse of Boundless Agony
Removed wrong wipe behavior
Fix problem where bosses would be stuck with banish
Added Boundaries
Corrected texts
Removed old hacks
Other minor fixes
2017-08-08 22:36:40 -03:00
Demonid 9fa68855d7 Scripts/ICC: Minor Fixes for Lich King (#20120)
- Fixed Shadow Trap and Defile Targets
- Fixed Shadow Trap Summon Delay and Duration
- Fixed Berserk Timer (15 Minutes)
- Fixed Shadow Trap Despawn when Snowstorm starts
2017-08-08 11:36:46 -03:00
Keader d825a06830 Core/Scripts: Razorscale Rewrite (#19828)
#MakeUlduarGreatAgain
2017-08-07 21:36:19 -03:00
Treeston 184c45cfe0 Core/Scripts: dynamic_spawning follow-up, I had forgotten JustRespawned existed.
- Rename JustRespawned to JustAppeared, which better matches its behavior anyway.
- Properly invoke JustAppeared for new (re-)spawns - fixes #20111.
- Fix Thaddius script to work with dynamic_spawning (mostly unrelated to the above) - Feugen/Stalagg should really be a summon group, but I don't have time to fix that right now.
- Fix default value for DynamicEscortNPC to match worldserver.conf.dist.
2017-08-06 16:07:30 +02:00
Treeston 759357049c Scripts/Commands: Fix some quirkiness and potential crashes with live DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway.
Fixes #20104.
2017-08-02 22:05:40 +02:00
Treeston c70b328eda more unneeded checks (follow-up 3b02029) 2017-08-01 18:14:55 +02:00
Treeston 3b02029cb6 remove an unused variable (follow-up fcd6fe0) 2017-08-01 17:58:17 +02:00
Treeston fcd6fe0aac Scripts/Commands: New utility command: .list spawnpoints.
(I just needed it for dynspawn follow-up work, really.)
2017-08-01 03:42:11 +02:00
Aokromes 41721642f7 NoPCH Build fix 2017-07-31 22:56:21 +02:00
r00ty-tc 59db2eeea0 Dynamic Creature/Go spawning:
- True blizzlike creature spawn/respawn behavior - new creature = new object
 - Toggleable spawn groups (with C++/SAI/command options to use them)
 - Custom feature: dynamic spawn rate scaling. Accelerates respawn rate based on players in the zone.
 - Backward compatibility mode (set via group and for summons)
   to support creatures/gos that currently don't work well with this
   (this should be removed once the exceptions are fixed)

Fixes and closes #2858
Tags #8661 as fixable.
Fixes and closes #13787
Fixes #15222.
2017-07-31 21:21:04 +02:00
Treeston 7cbb6c101e Scripts/IcecrownCitadel: Prevent players from becoming inaccessible when killed by Lord Marrowgar's Impale spell (the initial damage, not the DoT). Also fix the underlying bug in vehicle logic. 2017-07-25 02:01:32 +02:00
Treeston 331e463de8 Core/PlayerAI: Some adjustments:
- Add a 2 second delay before the AI begins using spells. This should provide opportunity for counterplay before that rogue activates cloak and goes on an unstoppable rampage among your healers. (Sorry, guys.)
- Stopped the AI from attacking invalid targets under some conditions. It should now properly leash back and follow the charmer if we try to select an invalid target.
- Stopped the AI from constantly re-creating the follow movement generator (and thus spamming movesplines).
2017-07-21 23:00:14 +02:00
Treeston c7896f3102 Core/Unit: For convenience, explicitly redirect CastSpell with nullptr as first argument to the Unit* overloads. No more ->CastSpell((Unit*)nullptr, ...) all over the place! 2017-07-21 18:02:48 +02:00
Treeston 42c993f8ad nopch fix 2017-07-21 17:36:04 +02:00
Treeston d80d7c6685 Scripts/Auchindoun: Last one, hopefully. Remove reliance on large grid searchers by integrating with instance script. 2017-07-21 17:29:06 +02:00
Treeston 04dc47e7e2 Scripts/Auchindoun: Blackheart the Inciter fully fixed now. I had way too much fun with this one.
Two points of note:
1) Spawning 5 invisible triggers with 5 distinct factions which then MC one target each? Biggest. Hack. Ever. Best part? It's blizzlike.
2) For over ten years, I thought it was spelled "Auchinodoun". It's not. It's spelled "Auchindoun". TIL.
2017-07-21 16:07:27 +02:00
Treeston 068254d6b9 nopch fix 2 2017-07-21 05:29:39 +02:00
Treeston 777befaaa9 nopch fix 2017-07-21 05:27:39 +02:00
Treeston a38141fd6c Scripts/Auchindoun: Replace the Blackheart the Inciter hack-filled script with a slightly less hack-filled script that actually mostly works. This should at least make the boss encounter possible to complete. No claims to correctness, of course. 2017-07-21 05:22:26 +02:00
Treeston 49aa8a2e59 Scripts/Spell: Port spell_generic.cpp to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 2017-07-20 16:43:45 +02:00
Treeston 37f59f8850 Scripts/Item: Port spell_item.cpp scripts to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up) 2017-07-20 01:26:15 +02:00
treeston fb87ac8e8d Core/Scripts: Implement generic script loaders (and script registry macros) to greatly reduce code duplication (#19526) (cherry-picked from commit a9174d5). 2017-07-20 00:27:20 +02:00
treeston 02b1d8bb48 Scripts/Item: Change Nitro -> Boosts <- to use the correct knockup effect for their backfire. Also, script that knockup effect to work properly ("usually" deploy a rescue parachute). 2017-07-18 18:32:56 +02:00
treeston 125127ea73 Scripits/Item: Nitro. BOOSTS. 2017-07-18 14:11:12 +02:00
treeston f953d85960 Scripts/Item: Fix Nitro Boosts to only fail in flyable areas. Also, it's called nitro _boosts_. Not _boots_. Nitro _boosts_. 2017-07-18 14:08:10 +02:00
treeston e0194e4a2c Revert "Scripts/Commands: Fix a potential crash when summoning players that are just logging on." - the check was unnecessary (already done in extractPlayerTarget).
This reverts commit 05cdcdb230.
2017-07-17 23:23:54 +02:00
treeston 05cdcdb230 Scripts/Commands: Fix a potential crash when summoning players that are just logging on. 2017-07-17 23:00:46 +02:00
jackpoz 9cf4dd7345 Core/Misc: Fix static analysis issues 2017-07-16 18:20:29 +02:00
jackpoz 7d3291e804 Core/Misc: Fix static analysis issues 2017-07-15 16:31:07 +02:00
jackpoz b2a341df6e Core/Misc: Fix static analysis issues 2017-07-15 16:22:32 +02:00
Regigicas d9c83a6c01 Scripts/Commands: Fix a crash on summon when no group is avaible (#20029)
Closes #20027
2017-07-15 12:43:03 +01:00
treeston 3f8c0cb446 Some more script adjustments ported from #19930. 2017-07-11 12:52:53 +02:00
treeston 74af880217 Hi, I'm Treeston, and welcome to Combat PR Prep Refactors.
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;
2017-07-09 02:07:29 +02:00
Keader 3aadb72eaa Build fix 2017-07-08 13:13:01 -03:00
Keader e254ebebbe Core/Custom: Fixed SPELLMOD_COOLDOWN exploit on Duel Reset system
Followup 0048d4b618
Closes #17419
2017-07-08 13:08:50 -03:00
Nyeriah 746fce30d9 Scripts/Karazhan: Fix Attumen and Midnight not moving towards each other on phase transition after latest changes 2017-07-08 12:37:03 -03:00
treeston 2739a5c5f5 Some more refactoring prep for combat/threat (#19930). 2017-07-03 17:33:34 +02:00
Keader 0048d4b618 Core/Custom: Fixed Duel Reset Exploits
Close #17419
*Fixed exploit with SPELLMOD_COOLDOWN
*Fixed exploit with some items (like Sylvanas' Music Box)
*Little cleanup
2017-07-01 16:56:30 -03:00
Shauren c8480f171a Nopch fix 5 and should be last 2017-07-01 21:47:00 +02:00
Shauren 235194bf54 typo fix 2017-07-01 21:37:07 +02:00