Commit Graph

2416 Commits

Author SHA1 Message Date
Shauren
d7302ffd14 Core/Scenes: Implemented spell created SceneObjects 2021-10-11 12:59:19 +02:00
Shauren
6d93f0a5f7 Core/Scenes: Delay scenes sent when not in world until adding to map 2021-10-05 15:10:33 +02:00
Meji
bedc050357 Core/Vendors: Support for vendors with empty inventory list (#26895) 2021-10-03 21:50:21 +02:00
Shauren
3af9be830d Core/Spells: Removed CastSpellExtraArgs constructors accepting ObjectGuid, they would become ambiguous with future changes 2021-10-03 14:58:35 +02:00
Shauren
d54edfeb8b Core/Players: Implemented selecting Exile's Reach during character creation 2021-10-02 21:45:04 +02:00
Shauren
2bf8110032 Core/Players: Do not show zone on character list before first login 2021-10-02 21:46:58 +02:00
Shauren
696be301d3 Core/Players: Save homebind location on creation instead of delaying it to first login 2021-10-02 21:38:21 +02:00
Shauren
11762273c6 Core/Players: Store player creation timestamp and type (normal/npe) 2021-10-02 21:28:11 +02:00
Shauren
1440586be8 Core/Players: Fixed value saved in characters.lastLoginBuild 2021-10-02 20:01:29 +02:00
Shauren
f6f2de76c7 Core/Commands: Remove the option to teleport to "startzone" with .unstuck command 2021-10-02 19:57:37 +02:00
Shauren
46004d4fca Core/Players: Relocate players to their homebind location instead of starting zone when login at saved location fails 2021-10-02 18:43:09 +02:00
Ovah
753d5a5d5f Core/Player: fix periodic eating and drinking emotes (#21280)
Closes: #12567
(cherry picked from commit 0dcc318e37)
2021-09-29 22:27:11 +02:00
ccrs
426f9f2f92 Core/Movement: MotionMaster reimplementation (#21888)
Internal structure and handling changes, nothing behavioural (or thats the intention at least).

(cherry picked from commit 982643cd96)
2021-09-28 00:15:13 +02:00
jackpoz
330881518a Core/Quest: Fix crash caused by disabled quests
Fix crash happening when a disabled quest was added and rewarded (through a GM command). Disabled quests are not validated on startup and they can reference invalid spells.

(cherry picked from commit 5f6af8c6cb)
2021-09-26 16:21:11 +02:00
Treeston
f1ac141f25 Core/Unit: UNIT_FLAG renames
[UNIT_FLAG_PLAYER_CONTROLLED -> UNIT_FLAG_POSSESSED]
[UNIT_FLAG_PVP_ATTACKABLE -> UNIT_FLAG_PLAYER_CONTROLLED]
Signed off by: Shauren, Warlockbugs.

(cherry picked from commit 081eab3cf5)
2021-09-26 16:07:09 +02:00
Gooyeth
a9e7464e0d Core/Battleground: allow Random battleground and arena queues same time. (#21730)
- It also restricts queuing to arenas if it is in queue of dungeon finder

(cherry picked from commit 8aad6f828e)
2021-09-25 21:36:11 +02:00
ariel-
3d1da4957c Core/Player: partial revert of m_items handling as it's cause of a exploit
Closes #21760

(cherry picked from commit a413e7dee9)
2021-09-23 23:53:04 +02:00
Shauren
c34e0f80a0 Core/Items: Disable effects on items marked as legacy 2021-09-22 00:01:47 +02:00
Meji
0a83f74876 Core/Achievements: Update CriteriaType enum (#26856) 2021-09-08 22:07:01 +02:00
ariel-
4a386b97d2 Core/Player: properly clear m_items array when unequipping items from the bag
- Also cleanup weapon damage ap mult when direct destroying a equipped weapon

(cherry picked from commit 9cc109fe3e)
2021-09-06 20:55:06 +02:00
ariel-
bf7a624a34 Core/Entities: cleanup of weapon damage
- AP multiplier wasn't correctly reflected after unequipping a weapon
- Correctly set base damages at unequip

Closes #21610

(cherry picked from commit 8cf7eda8c1)
2021-09-06 20:54:19 +02:00
Shauren
8a4e1119ac Core/Spells: Unify spell effect access api in both branches 2021-09-04 15:13:15 +02:00
Shauren
b9647bdecc Core/Reputation: Fixed FriendshipReputationFlags::NoRepGainModifiers implementation 2021-08-28 18:03:30 +02:00
ariel-
962f6d7988 Core/Spells: rework part 5: GameObject casting
Closes #21330
Closes #18885
Ref #18752

(cherry picked from commit 45c5e1b9d6)
2021-08-28 15:59:11 +02:00
ariel-
65dca120d3 Core/Spells: rework part 4: iterate over effects first
Ref #18395

Implement far spell queue processing
Closes #7395

(cherry picked from commit 080d2c6cd4)
2021-08-28 15:59:11 +02:00
ariel-
f3548d45d0 Core/Spells: rework part 3: spells only handle at most one UnitAura and one DynObjAura during its lifetime
Closes #15088

(cherry picked from commit e8d5aa56cc)
2021-08-28 15:59:11 +02:00
Gooyeth
90b81a212e Core/Player: Do not remove auras from Gamemasters in arenas (#21568)
(cherry picked from commit 92b8a870bf)
2021-08-23 20:03:40 +02:00
Meji
bca465a569 Core/Achievements: Several criteria fixes (#26839) 2021-08-20 09:41:13 +02:00
Shauren
c0261468c5 Core/Quests: Fixed quests not working after relogging
Closes #26823
2021-08-16 16:33:43 +02:00
Shauren
03f09ea16a Core/Items: Implemented secondary shoulder transmog appearance 2021-08-11 22:32:14 +02:00
Treeston
e47e95b6dc Core/VMap: Add outdoor state to Map::GetFullTerrainStatusForPosition. Add WorldObject::IsOutdoors, basic member access.
Ref #21479.

(cherry picked from commit e79c595b69)
2021-08-08 21:21:34 +02:00
ariel-
67a1a1d29b Core/GameObject: implemented gameobject_overrides table to change faction and flags values on a per-spawn basis
Updates #20957
Closes #20958

(cherry picked from commit 34967e9c32)
2021-08-08 21:21:34 +02:00
ariel-
a1a00f823e Core/Entities: kill unused return value from Unit::HandleSpellClick
- AI hook will now receive the result by copy, as modifying it had no effect
- Some renaming: result->spellClickHandled, clickPair is actually clickBounds, the clickPair is the pair <creatureID, SpellClickInfo>

(cherry picked from commit 98d6258efd)
2021-08-08 21:21:34 +02:00
ariel-
70c26d53cb Core/Entities: unit states cleanup
- Added new UNIT_STATE_FOCUSING for creature focus system, this will stop creatures adding/clearing the UNIT_STATE_CANNOT_TURN mask (eg UNIT_STATE_STUNNED if stunned while focusing a spell)
- Added UNIT_STATE_CHARMED that gets set/removed on any charm type (UNIT_STATE_POSSESSED is only for possess as it's name suggests)
- The new states are checked against mask to know whenever client needs to regain character control

Closes and fixes #21460

(cherry picked from commit ba27711145)
2021-08-08 21:21:34 +02:00
ariel-
18780206bc Core/Spells: Do not apply SpellModOp::CritChance to spells that can't crit 2021-06-19 23:55:03 +02:00
Treeston
88c1739e3e Core/Movement: Creatures' idle movement generator can no longer override player mover control.
Tagging #20310, partial fix.

(cherry picked from commit d02f481d9a)
2021-06-19 23:33:38 +02:00
jackpoz
cb0672081e Core/Player: Add some asserts
Assert PlayerInfo for race/class pair in a few Player functions

(cherry picked from commit 3576a38f6c)
2021-06-19 23:33:38 +02:00
ariel-
905112b2a6 Core/Player: only call _ApplyWeaponDamage for actual weapons
Closes #21308

(cherry picked from commit 8e0af1b93b)
2021-06-16 21:32:53 +02:00
ariel-
d0a766f14f Core/Auras: Don't remove shield only dependant auras on disarm
Closes #19782

(cherry picked from commit b8c281f497)
2021-06-16 12:34:40 +02:00
sirikfoll
78577afa49 Core/Player: Pass correct Zone ID to HandlePlayerLeaveZone
This will fix some issues with Wintergrasp, like phasing auras getting stuck and missing group invites for the battle, among others

(cherry picked from commit ed9e220991)
2021-06-16 11:23:01 +02:00
ariel-
431a326e69 Core/Entities: Port some refactors from f1986c6aaf 2021-06-15 00:48:02 +02:00
ariel-
5fbddef85f Core/Spell: SpellValueOverrides encapsulation
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct

(cherry picked from commit 3b01cccd7e)
2021-06-14 00:19:50 +02:00
ariel-
fccf1a8c62 Core/Auras: removed caster dependency from core
- Decoupled Unit logic: split of spell critical chance into done (caster bonuses) and taken (target bonuses), this allows to precalculate caster bonuses on aura apply and then check victim's auras on damage/healing calc
- Made static a bunch of methods (they no longer have this pointer because they are now called from periodic handlers which may or may not have an active caster in world)
- Simplified all AuraEffect bonuses into AuraEffect::_amount, no more duplicated code
- Critical chance and whether or not caster is player owned unit (for resilience calcs) is now saved one level upper, on Aura itself (it's impossible as of 3.3.5 to have different effects with different critical chances)
- Minor cleanup of SPELL_DAMAGE_CLASS_NONE and Arcane Potency (#18813) crit handling

Closes #19876

(cherry picked from commit cb9e72e521)
2021-06-13 00:59:13 +02:00
Shauren
fa4e2d3935 Core/Quests: Fixed quests that should have objectives immediately marked as complete
Closes #26566
2021-06-08 00:02:58 +02:00
Shauren
d0be92ec0a Core/Achievements: Defined all modifier tree types and implemented many of them 2021-06-07 15:37:34 +02:00
Matan Shukry
626c8f5de1 Core/Player: Add helper function to determine if war mode can be enabled in area 2021-06-06 21:06:21 +02:00
Shauren
80a6347b7a Core/Reputation: Implemented "friendship reputation" 2021-06-04 19:27:26 +02:00
Shauren
0b2087ae41 Core/Criteria: Add all values of CriteriaStartEvent 2021-06-01 21:16:41 +02:00
Shauren
4b6ddfbbcc Core/Criteria: Add all values of CriteriaFailEvent 2021-06-01 21:04:22 +02:00
Shauren
6ecfe58cae Core/Maps & Extractors: Move copypasted map file headers into a single shared file and replace #defines with enums 2021-05-29 21:21:37 +02:00