Commit Graph

21760 Commits

Author SHA1 Message Date
ccrs d1dc0e2dc1 Scripts/DK: correctly handle Blood Tap 2019-07-13 17:57:07 +02:00
Treeston 8c16f318fe Core/Chat: Rewrite some custom channel handling. Channel creation now properly saves passwords. Closes #23589. 2019-07-13 17:44:41 +02:00
jackpoz 7f3d8c99bb Core/Calendar: Fix issue with invite status being set to the wrong invite
Consider the case of Player A inviting Player B to a Calendar Event. After Player B clicks on Accepts/Tentative/Reject, the calendar shows that status for Player A instead.
2019-07-13 12:10:32 +02:00
Wyrserth 5707019256 Core/Player: apply LevelReq.Trade only to the player initiating a trade, aligning it with the other LevelReq.* config options. 2019-07-13 01:08:16 +02:00
Wyrserth a54af39e29 Core/Player: prevent trade system from getting stuck in an invalid state when the LevelReq.Trade config is used. 2019-07-13 00:52:14 +02:00
ccrs 81475f709f Scripts/ScarletEnclave: 4ee84bb followup 2019-07-12 20:38:50 +02:00
ccrs fa9a4ee20d Scripts/ScarletEnclave: 4ee84bb followup 2019-07-12 20:30:52 +02:00
ccrs 294a3a2789 Core/Unit: movement related corrections prior to getting Charmed 2019-07-12 20:06:27 +02:00
Wyrserth 4ee84bbecb Script/ScarletEnclave: use spline movement for the lauch phase of the Eye of Acherus.
Closes #22802.
2019-07-12 19:19:45 +02:00
Treeston af082664ca Battleground/Arena: Properly check RBAC arena join permission before allowing queue. Closes #23000. 2019-07-12 14:14:01 +02:00
Treeston daf423a6c3 Scripts/Commands: .account ban no longer fails if an account containing the specified account name is already banned (f.ex. attempting to ban 'test' if 'test2' is already banned) - closes #22990 2019-07-12 13:37:27 +02:00
Treeston 7d6896b541 typo fix, duplicate assignment 2019-07-12 13:14:44 +02:00
Treeston 4423ca99e7 Entities/GO: FindNearestGameObject no longer incorrectly returns despawned gameobjects. Closes #23262. 2019-07-11 23:31:46 +02:00
Killyana 42abf69a27 DB/Quest: Seeds of the Blacksouled Keepers 2019-07-11 18:32:15 +02:00
ccrs 965ec9a571 Core/Weather: 6eecb68 followup
missing IntervalTimer::Update call
2019-07-10 23:16:58 +02:00
Giacomo Pozzoni e4c2bb4f14 Core/ChatCommands: Fix .wp reload crash 2019-07-10 16:02:18 +02:00
Wyrserth 7f63c504d5 DB/Quest: restore ExclusiveGroup data for breadcrumb quests, as they're mutually exclusive.
Also restore PrevQuestId/NextQuestId error logs involving breadcrumb quests. Special cases must be handled via conditions.
2019-07-10 02:58:30 +02:00
Wyrserth e6080116f9 Core/Quest: remove arbitrary error logs related to breadcrumb quest chaining.
There are complex cases where breadcrumb quests are mutually exclusive with other breadcrumbs leading to other quests, chaining them shouldn't generate log errors.
2019-07-09 22:48:04 +02:00
Shauren 7917704fd3 Scripts: Update boss_akilzon weather packet 2019-07-09 21:52:26 +02:00
Shauren 6eecb685ce Core/Weather: Fixed weather updates to be thread safe
(cherry picked from commit 6eb9973947)
2019-07-09 21:17:59 +02:00
Nayd 9a9af3cc5f Core/Packets: Update and enable SMSG_WEATHER
(cherry picked from commit 6f7d048765)
2019-07-09 21:17:59 +02:00
Treeston 0ae2afe307 Scripts/World: Rewrite air force trigger bots script, add hostility check along the way. Closes #23307. 2019-07-09 18:24:43 +02:00
ccrs bec52dba3d Core/Movement: add missing parenthesis on MotionMaster::Size
pretty sure this can cause unexpected behaviour
2019-07-09 15:25:25 +02:00
Treeston be96d8242c warning fix f2cd721 follow-up 2019-07-08 21:53:50 +02:00
Treeston a1fd404b64 Core/Quest: Do not allow quests to be turned in if the player no longer satisfies level/skill/reputation requirements. Fixes #226. Yes, you read that issue tag right. 2019-07-08 21:35:57 +02:00
Treeston f2cd721d53 Scripts/Naxxramas: Thaddius no longer evades on transition, and some general cleanup to that script. Fixes #23026. 2019-07-08 20:16:29 +02:00
Ianislav Vasilev c71e36acae Scripts/Blood Furnace: Broggok improvements (#23300)
* 23285 Fixed lever respawn and future encounters after it respawns.

* Removed unnecessary additional container.
Made lever not to despawn and respawn but rather change flags only.

* Made one conditional branch easier to debug.
2019-07-08 19:53:08 +02:00
Treeston a3c3526269 Scripts/Outland: Rewrite the Watch Commander Leonus event so it no longer starts exponentially more often if the grid remains loaded for over an hour. Closes #23348. 2019-07-08 16:04:32 +02:00
Sorikoff a64d7df662 Scripts/Spells: Brittle Armor & Mercurial Shield (#23576) 2019-07-08 15:42:35 +02:00
ForesterDev e71773140c Scripts/Commands: update .wp commands to use orientation field from DB (PR #23566)
Closes #23330
2019-07-08 14:16:10 +02:00
Treeston 671052575a Entities/Player: Properly restore PvP-enabled state on login 2019-07-08 14:09:57 +02:00
Aokromes 574a7c8d3d Core/Misc: More coding standards (#23519)
* Core/Misc: More coding standards

* revert part

* "void  " or more to "void "

* fix? reject

* remove more double whitespaces

* remove more double whitespaces

* more standards

* more coding standards

* More standards

* more coding

* more coding standards

* more coding standards

* And more standards
2019-07-08 12:51:42 +02:00
Treeston 84b7b2e08e Entities/Unit: Nuke Map::ForceRespawn from orbit, with the following implications:
- .npc respawn no longer causes stupid things to happen (Fixes #23014)
- ::DeleteFromDB methods on Creature and GameObject rewritten to be as sensible as such a colossally stupid method can ever be. They're static now.
- .npc delete and .gobj delete ported to new argument handling, and rewritten as per above. They can no longer crash the server when used in instances, too. Yay for that.
- Adjusted various dusty cobwebbed hacks around the core (why does waypoint visualization use permanent spawns *shudder*) to still work too.
2019-07-08 11:56:41 +02:00
ccrs ec1a77bca2 Build: fix linking error
/home/circleci/project/src/server/game/Movement/MovementGenerators/RandomMovementGenerator.cpp:50:9: fatal error: use of undeclared identifier 'AddFlag'
        AddFlag(MOVEMENTGENERATOR_FLAG_TIMED_PAUSED);
        ^
2019-07-07 19:25:27 +02:00
Treeston ded18a2690 Entities/Creature: Some asserts are now LOG_ERRORs that block spawning. Fix a group spawning bug exposed by the CoS merge. Improve some command output. 2019-07-07 19:18:32 +02:00
ccrs b8c0aeaf14 Core/Movement: handle Resume/Pause on RandomMovementGenerator 2019-07-07 18:07:58 +02:00
ccrs 4fa3c04b72 Core/Unit: f869c49 followup
Movement Pause/Clear is already handled in Unit::SetCharmedBy and Unit::RemoveCharmedBy, respectively

TODO: missing PAUSE handling in RandomMovementGenerator
2019-07-07 17:41:36 +02:00
Wyrserth f869c4969e Core/Vehicle: prevent creature vehicles from following their old movement generator when a player enters them in some cases.
Closes #21731 and #22368.
2019-07-07 17:12:22 +02:00
Wyrserth 9f6d3e93f9 Core/Quest: fix icon in gossip window for repeatable, non-autocomplete quests.
Closes #23572.
2019-07-07 15:43:02 +02:00
jackpoz 283ac3d374 Core/Misc: Fix no-pch build 2019-07-07 13:35:11 +02:00
Wyrserth 644910bdc1 DB/Trainer: remove required ability from Riding spells. The client should only show the required amount of skill.
Also comment out unused argument in previously committed script, thanks Aokromes for noticing!
2019-07-07 02:57:24 +02:00
Wyrserth 6199d458c3 Core/Misc: use Trinity's RandomShuffle() instead of soon-to-be-deprecated std::random_shuffle().
Thanks Riztazz for noticing!
2019-07-07 02:49:40 +02:00
Wyrserth 37862942ce Script/TheOculus: adapt Mage-Lord Urom's script to use EventMap, fix various issues with Teleport and Empowered Arcane Explosion, add missing heroic-mode spell Frost Buffet.
Closes #19452.
2019-07-07 02:32:53 +02:00
Wyrserth 1d1b77c3f0 Core/Spell: don't send duration for auras caused by dynobjects. 2019-07-07 00:06:49 +02:00
Wyrserth 6ef1b3e6c6 Script/BlackrockDepths: randomize timers for Ironhand Guardian's spell Gout of Flame. 2019-07-06 20:29:24 +02:00
Wyrserth b87350807d Core/Spell: do not allow auras from dynamic objects to stack if they come from the same spell cast by the same caster. 2019-07-06 19:55:36 +02:00
Wyrserth 1bdbede7e0 Misc/Config: set decay timer for unlooted normal creatures to 5 minutes.
Now that respawns do not care about the previous corpse's state, there's no reason to force a very frustrating faster despawn.
2019-07-06 16:15:45 +02:00
Gooyeth c30a27ef18 Core/Battleground: Implement previous opponent timer on Arena queue. (#21754) 2019-07-06 01:35:23 +02:00
Martin Topholm 4529a94e0d Script/BlackrockDepths: fix Ironhand Guardian's Gout of Flame spell cast. (#21816) 2019-07-05 23:46:55 +02:00
Wyrserth 8fcc82138f Script/Acherus: script out of combat event for Frost Death Knight trainer Amal'thazad. 2019-07-05 18:41:47 +02:00