Commit Graph

27363 Commits

Author SHA1 Message Date
jackpoz c2d2df96db Core/SAI: Fix SMART_EVENT_WAYPOINT_START not being called at every waypoint checking wrong path id parameter
Remove multiple calls to SMART_EVENT_WAYPOINT_START for the 1st waypoint.
Closes #24760

(cherry picked from commit b3694bf47b)
2022-02-05 13:31:00 +01:00
Treeston e0e3bae82c Core/Authserver: Removal of sha_pass_hash, compatibility fields, and everything that uses them (PR #25156)
(cherry picked from commit bcdbdd6f23)
2022-02-05 13:29:21 +01:00
Treeston 970cd097de Core/Combat: When entering a vehicle, transfer any current threat to that vehicle. Closes #1340.
(cherry picked from commit 47c7910036)
2022-02-05 13:08:46 +01:00
Giacomo Pozzoni b45277f1cf Core/Unit: Fix units on vehicles not dismounting on death (#25404)
* Core/Unit: Fix units on vehicles not dismounting on death

Closes #23095
Issue added in 982643cd96

* Remove leftovers from previous tries

(cherry picked from commit ff26027453)
2022-02-05 13:08:34 +01:00
jackpoz 341ef2c0dd Core/Arena: Fix Arena.ArenaStartPersonalRating setting not having effect if the player didn't do any arena match before next server restart
Ref #16609

(cherry picked from commit cc64762f06)
2022-02-05 13:08:08 +01:00
Shauren 04021a30ba Core/Players: Directly store PlayerSpell in m_spells, not as pointer
Closes #25402

(cherry picked from commit 1e446b021b)
2022-02-05 13:07:25 +01:00
jackpoz ae6f8bc4f5 Core/SAI: Do not allow SMART_EVENT_RESET to call SMART_ACTION_CALL_SCRIPT_RESET
There might be cases where this should be allowed (i.e. if the SMART_TARGET_* is another object) but for now we'll just never allow it.

(cherry picked from commit 28921f191d)
2022-02-05 12:08:58 +01:00
jackpoz d561a69122 Scripts/Obsidian Sanctum: Fix portals not being visible
Change NearestGameObjectEntryInObjectRangeCheck to allow returning GameObject not spawned.
Fixes other occurrences where a similar issue exists.

(cherry picked from commit ca2159bf40)
2022-02-05 12:04:35 +01:00
Giacomo Pozzoni 4dff5bd09b Core/SAI: Reduce the chance of infinite loops/stack overflows (#25398)
Fixes #24092

(cherry picked from commit a58aeb41f4)
2022-02-05 11:51:54 +01:00
Shauren 1a86bab4d8 Core/Misc: Allow all kinds of non-map containers in grid searchers
(cherry picked from commit a02d36f18c)
2022-02-05 11:51:10 +01:00
Shauren a0edc1fb1b Scripts/Icecrown Citadel: Finish script registration refactoring - RegisterSpellScriptWithArgs
(cherry picked from commit 600a6b5f68)
2022-02-05 11:50:57 +01:00
Shauren f3300899d8 Scripts/Icecrown Citadel: Fix scriptname conflict
(cherry picked from commit b63fa9c42f)
2022-02-05 11:42:54 +01:00
ForesterDev 2ac0960f3f Scripts/ICC: update Lich King scripts to new model (#25396)
* Scripts/ICC: update Lich King scripts to new model

* fix build

(cherry picked from commit d04bdd0316)
2022-02-05 11:42:35 +01:00
ForesterDev d250640c6b Scripts/ICC: update Sindragosa scripts to new model (#25395)
(cherry picked from commit deec517239)
2022-02-05 11:24:09 +01:00
ForesterDev ceec4ecf35 Scripts/ICC: update Professor Putricide scripts to new model (#25394)
* Scripts/ICC: update Professor Putricide scripts to new model

* fix build

(cherry picked from commit 0b0d5e9bea)
2022-02-05 11:10:39 +01:00
ForesterDev 1c22cd7d08 Scripts/ICC: update Lady Deathwhisper scripts to new model (#25393)
(cherry picked from commit aac3ae40f7)
2022-02-05 10:55:59 +01:00
ForesterDev e294f94617 Scripts/ICC: update Rotface scripts to new model (#25392)
(cherry picked from commit af78f4ffb5)
2022-02-05 01:10:06 +01:00
ForesterDev f03471c259 Scripts/ICC: update Festergut scripts to new model (#25391)
(cherry picked from commit 458867a2e1)
2022-02-05 01:04:31 +01:00
ForesterDev 2b4d353bff Scripts/ICC: update Valithria Dreamwalker scripts to new model (#25390)
(cherry picked from commit 71f33d5764)
2022-02-05 01:03:08 +01:00
ForesterDev 7241088faa Scripts/Icecrown Citadel: update Blood Council scripts to new model (#25389)
(cherry picked from commit aedb8b80f3)
2022-02-05 00:58:05 +01:00
Treeston 4d62cc70d6 Scripts/Commands: Convert argument parsing of .npc commands
(And I snuck some chat command cleanup in there, more de-cluttering!)

(cherry picked from commit 88d446dadf)
2022-02-05 00:43:55 +01:00
Treeston 6fded37e86 Scripts/Commands: Convert argument parsing of gameobject commands
(cherry picked from commit 35b3ba90b0)
2022-02-05 00:24:39 +01:00
Treeston da8a66a05e Common/Util: Trinity::StringTo<double> support (PR #25364)
(cherry picked from commit f45aa5cac1)
2022-02-04 23:50:25 +01:00
Treeston 0d54a5ecb4 Core/Misc: Add support for custom link colors. Clean-up hyperlink validation, no more long-ass defines. Remove UI.ShowQuestLevelsInDialogs.
(cherry picked from commit eaf8fa75a1)
2022-02-04 23:49:59 +01:00
robinsch f7c65960a5 Core/Player: Fixed incorrect prepared statement parameter types in Player::_SaveBGData
Merges #25379

(cherry picked from commit 6e8284a8da)
2022-02-04 23:46:43 +01:00
Houston 1f774873bf Core/Totem: Immune to all positive spells. (#25326)
* Core/Totem: Immune to all positive spells.

* Fix tabs

* Avoid using magic numbers

* Remove whitespace

Co-authored-by: Moki <moki.play@mail.ru>
(cherry picked from commit 8d0f52247f)
2022-02-04 23:41:43 +01:00
Treeston c4b287c7bf Core/Misc: DBC std::array refactors, and |Hachievement unit tests
(cherry picked from commit 3fbbe7cfbe)
2022-02-04 23:37:29 +01:00
Treeston c82b107b6b UnitTests: Add a first set of item hyperlink tests
(cherry picked from commit 5394b2ef0f)
2022-02-04 22:11:42 +01:00
Shauren 1a536365b5 Core/Chat: Add missing initialization to chat link data structures 2022-02-04 21:33:00 +01:00
Treeston 03fd9b038e Core/Chat: Correct Hyperlink validation for incomplete achievements.
(cherry picked from commit fdcb1c8b2e)
2022-02-04 21:27:25 +01:00
Treeston a65e7e0213 Scripts/Commands: Fix a crash in .help - closes #25360
(cherry picked from commit 944f49d613)
2022-02-04 21:21:40 +01:00
Treeston 45e9e94311 Core/ChatCommands: C++17 cleanup (again) (PR #25323)
(cherry picked from commit 2f7d2ef3e9)
2022-02-04 21:21:17 +01:00
Ovahlord 175fb7056b Core/AI: SortByDistance will now sort the referenced list instead of a copy of it. This fixes MinDistance and MaxDistance target selection
(cherry picked from commit c08180d9bc)
2022-02-04 13:05:36 +01:00
Shauren 7cd98cd7d2 Core/Config: Restore ability to load additional config files for custom scripts
(cherry picked from commit c1e4cfd07e)
2022-02-04 13:05:06 +01:00
Jinnaix 2e10a2de3b Core/Misc: Update Worldserver.conf for AhBot Pricing -make things more clear (#25341)
* AhBot Pricing: Make things more clear

* Change default value to BuyPrice and add some more information to how two sided AH works

* Sync c++ configs with .conf ones

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 812c2af4da)
2022-02-04 13:01:25 +01:00
Giacomo Pozzoni c66bcc4c0e Core/Spell: Fix name clashing between local variables and class member fields (#25352)
(cherry picked from commit 8a48ece573)
2022-02-04 13:00:08 +01:00
Jinnaix 6830d883ad Core/Unit: send npcs home after fear runs out (#25347)
* Core/Unit: send npcs home after fear runs out

* Whoops, wrong

(cherry picked from commit 7e6f17a701)
2022-02-04 12:19:36 +01:00
jackpoz 4051ccd1bd Core/AHBot: Warn about different AHBot behavior when AllowTwoSide.Interaction.Auction is enabled
Closes #18243

(cherry picked from commit 92f9abab06)
2022-02-04 12:19:15 +01:00
Giacomo Pozzoni 99ee958e0a Core/Misc: Fix issues reported by static analysis (#25351)
* Core/Misc: Fix issues reported by static analysis

* Core/Vmaps: Code cleanup after e777161888

(cherry picked from commit cfc8f7b442)
2022-02-04 12:18:15 +01:00
Treeston 1303ca0e7e Common/Utilities: Make StringTo<bool>'s signature match that of the other integral types, making for easier templating. Default behavior unchanged.
(cherry picked from commit f54cec4db7)
2022-02-04 12:06:26 +01:00
Maks Szokalski 663ec92794 Scripts: Minor loop refactors (#25325)
(cherry picked from commit dc9e0c1e86)
2022-02-04 12:06:01 +01:00
kvipka 5a20f14a99 Scripts/InstanceScript: Fix an issue where LoadAllGrids would load creatures before TeamInInstance was properly set (PR #25340)
(cherry picked from commit 5d2780c43c)
2022-02-04 12:05:36 +01:00
Shauren bb185a78fb Build: Put tests-extractor_common under correct folder when WITH_SOURCE_TREE is set to hierarchical-folders 2022-02-04 11:01:02 +01:00
Aokromes af7c211230 Script/Azuremyst_isle: Remove useless log
(cherry picked from commit bf8b34946d)
2022-02-04 10:58:44 +01:00
Shauren 53563c24c3 Warning fix 2022-02-04 10:04:38 +01:00
Treeston 9f97fdd31a Core/Common: Tokenizer -> Trinity::Tokenize (PR: #25327)
(cherry picked from commit 534a2388b7)
2022-02-04 00:27:14 +01:00
Treeston 6e45c371c4 Common/Utilities: Properly read std::from_chars documentation and check for out_of_range errors.
(cherry picked from commit 7478c2c65a)
2022-02-04 00:27:14 +01:00
Treeston be9dadc189 Common/Utilities: Centralize string -> T conversion in StringConvert.h (PR #25335)
(cherry picked from commit cd30e0b86c)
2022-02-04 00:27:13 +01:00
Treeston 7b88fd607e Core/Warden: Ensure Warden packets do not exceed 512 bytes. This should rectify random Warden timeouts.
(cherry picked from commit 7cc027401e)
2022-02-04 00:27:13 +01:00
Giacomo Pozzoni 902ed74c2a Core/SAI: Implement SMART_TARGET_ACTION_INVOKER in SMART_EVENT_FRIENDLY_HEALTH_PCT (#25318)
* Core/SAI: Implement SMART_TARGET_ACTION_INVOKER in SMART_EVENT_FRIENDLY_HEALTH_PCT

* Require radius (5th parameter) to be set

(cherry picked from commit cbed1039c4)
2022-02-04 00:27:13 +01:00