Commit Graph

160 Commits

Author SHA1 Message Date
Spp 74dd02d024 Remove LOTS of compile warnings
--HG--
branch : trunk
2010-04-19 09:26:37 +02:00
Trazom62 d9367da5f2 Fix script started twice for Gobber (GO type=10) with eventID.
Fixes issue #1589.
With help of Az@zel, thanks.

--HG--
branch : trunk
2010-04-11 23:49:00 +02:00
Spp 2454c290b8 Code Style (game + scripts only):
"==" --> " == " (when needed)

--HG--
branch : trunk
2010-04-07 23:25:02 +02:00
Spp 49d05ba9aa Code style (game + scripts only):
"( " --> "("
" )" --> ")"

--HG--
branch : trunk
2010-04-07 22:59:46 +02:00
Spp d19e127080 Code style (game + scripts only):
"if(" --> "if ("

--HG--
branch : trunk
2010-04-07 19:14:10 +02:00
Spp f490ad5ac2 Code Style: tab to spaces
--HG--
branch : trunk
2010-04-07 17:24:07 +02:00
Trazom62 917193eda5 Fix Fishing skill in low level zones, where the zone_skill is < 0. The formula was not correct for those cases.
Fixes isssue #1387.

Note: junk loot is still not yet implemented.

--HG--
branch : trunk
2010-04-04 00:30:11 +02:00
malcromdev@gmail.com> 7c4f2f520f Fix Go type 10 spell handling by QAston
--HG--
branch : trunk
2010-04-01 20:08:22 -02:30
Trazom62 ed8c5ef6ff Implement group loot for chest having GroupLootRules (go type=3, data15=1).
Implement round robin loot.
Implement round robin for underthreshold items (group loot and need befor greed).
Fix "all players pass" bug on creature.
Add SMSG_LOOT_LIST message to indicate looter (round robin or master).
And some other minor loot bugs.

Fixes issue #167.
Fixes issue #247.

--HG--
branch : trunk
2010-03-11 22:55:02 +01:00
raczman 91b8ee104e Added new type-safe cast functions.
This, when properly used, should get rid of most memory corruption issues,
currently, casting types C-style with no checks leads to some abstract crashing.
Functionality is same as with dynamic_cast<>, but with no RTTI check - so when
casting into invalid type you will receive NULL, and most probably crash.
At the same time, i took the liberty to convert most Player* casts to ToPlayer().
Still needs crapload of casts being moved to new facility.

--HG--
branch : trunk
2010-03-07 15:20:19 +01:00
Brian aea3151d7b * As of patch 3.3.2 there is no longer a maxlevel requirement for meeting
* stones.
* Credits Kaelima

--HG--
branch : trunk
2010-02-24 05:03:22 -07:00
Brian 486c00891b * Core switch to client 3.3.2 (11403)
* Credits (in no particular order) to:
* n0n4m3, raczman, manuel, Spp, Malcrom, Teacher, QAston, Tartalo,
* thenecromancer, Xanadu, Trazom, Zor, kiper
* Additional credits to:
* TOM_RUS and NoFantasy from MaNGOS
* Thanks for testing Aokromes and XTElite1
* SoTA still needs some work, but is very playable (huge thanks to raczman and
* kiper)
* To upgrade, you need to apply all SQL from sql/updates/3.2.2a_old from the
* last rev you are on
* and then apply all SQL from sql/updates/3.3.2_old to char / realmd / world
* DBs
* Known problem with guild banks.

--HG--
branch : trunk
2010-02-14 19:13:14 -07:00
silver1ce a307ba784c *Move object's field\visibility update functions to object from accessor
removed useless SendUpdateObjectToAllExcept - anyway fields will be updated, there is no sense to force update them

--HG--
branch : trunk
2010-02-03 16:53:40 +02:00
Brian cfa8ff7bd6 * Set the default spawntimesecs for creatures / gameobjects added in game to 5 minutes
* Was 25 seconds
* Thanks Paradox

--HG--
branch : trunk
2010-01-30 08:05:08 -07:00
XTZGZoReX 9f00ca3eb8 * Remove CellLock class and all cell-level thread locking.
** It was wasting CPU power as cell-level locking is not needed.
** Our multithreading is on map-level, not cell-level.
** CellLock was just a 'proxy' between Cell and CellPair and in some cases carried redundant data.
** Some minor cleanup in Cell::Visit/Map::Visit.

--HG--
branch : trunk
2010-01-23 22:24:41 +01:00
QAston 216d32e8a7 *Prevent assertion fail in Unit::_AddAura after creature add to remove list.
--HG--
branch : trunk
2010-01-22 20:03:47 +01:00
n0n4m3 99f66a6bc9 Updated copyright for new year.
--HG--
branch : trunk
2010-01-16 20:19:18 +03:00
n0n4m3 ed5152316f Rewrite parts of GameObject use for GO type 10, by NoFantasy.
--HG--
branch : trunk
2010-01-16 19:31:10 +03:00
Anubisss cff7923be1 Fix a meam leak in GameObject's destructor.
main part of my log:

==19804== 584 bytes in 73 blocks are definitely lost in loss record 107 of 298
==19804==    at 0x4C2626C: operator new(unsigned long) (vg_replace_malloc.c:230)
==19804==    by 0x930A2B: GameObject::GameObject() (GameObject.cpp:43)

--HG--
branch : trunk
2010-01-16 14:49:09 +01:00
Trazom62 4276bd87b9 fishing: send correct message when fish escape.
--HG--
branch : trunk
2010-01-07 20:16:16 +01:00
Brian 6cd8d1286f * Re-Fixed GO type 6 and type 8 to use radius for distance calculations instead
* of diameter. This will prevent things like people getting burned even though
* you aren't touching the fire.

--HG--
branch : trunk
2009-12-31 09:30:39 -07:00
n0n4m3 bb2b212e84 Fixed crash in lookup GO gossip
--HG--
branch : trunk
2009-12-26 17:16:11 +01:00
n0n4m3 2a97429a93 Fix typo in GO gossipID check for type 10. by NoFantasy
--HG--
branch : trunk
2009-12-25 16:05:18 +01:00
n0n4m3 250a00cc1c Temporary revert 6743 commit. I fix this patch across 1-2 days.
--HG--
branch : trunk
2009-12-24 10:20:15 +01:00
n0n4m3 3fe0bc5254 Replaced time(NULL) on sGameTime.GetGameTime() this is used for better performance.
Original Timer.h divided into 2 parts. Shared project has no need to know about GameTime Singleton.
2 Identical structures with different types are now replaced with one generic templated structure and 2 typedefs.

--HG--
branch : trunk
2009-12-23 08:04:10 +01:00
Rat 6fe36efe0f *apply trinity style to whole source
*comment out all mangos to trinity defines
*this will make merging a little harder, but code will be more clear

--HG--
branch : trunk
2009-12-20 15:20:04 +01:00
win32 7c9f6b4bc3 Merge MaNGOS, Gossip System. Autor NoFantasy.
* DB support required
* Closes #859

--HG--
branch : trunk
2009-12-20 13:35:08 +02:00
Brian 31c6b10a19 * Add support for the use of Gameobject type 10 (GOOBER) use when not on quest
* if data1=-1

--HG--
branch : trunk
2009-12-20 09:03:45 -07:00
win32 bf2c3fd8cf MaNGOS merge: Mail System.
* Store loot in mail_loot_template indexed by mail template ids.
* Implement proper creating mail text copy item from mail template based mail.
* Move send functions to new MailDraft class from WorldSession.
* Implement mails sending at player levelup.
* Autor VladimirMangos, converted by me.

--HG--
branch : trunk
2009-12-16 18:58:36 +02:00
Machiavelli f6d80f9da4 Fix some issues with fishing. Closes #421, patch by make_the_king
--HG--
branch : trunk
2009-11-30 16:54:33 +01:00
Kudlaty 9bd797d402 Apply #412.
Add support to gameobject type Transport (11) that should stop like Orgrimmar arena Elevators or pilars.
Patch by Spp and Opterman

--HG--
branch : trunk
2009-11-27 01:41:26 +01:00
maximius c767576d92 *Cleanup, more consistant HandleDummyAuraProc code (added basepoints1 and basepoints2 and edited some spell cases to use these instead of more hacky custom methods..)
--HG--
branch : trunk
2009-11-21 17:59:24 -08:00
maximius 1d7f2fc243 *Update WorldSession::HandleMovementOpcodes with some new information on how vehicles behave, and do a little bit of cleanup.
--HG--
branch : trunk
2009-11-03 22:28:04 -08:00
maximius b257a28fa9 *Cleanup, fix many cases of unoptimized loops, potential crashes, excessively large data types, unnecessary or wrong casts, non-standardized function calls, and so on..
*Proper Maexxna Web Spray locations (old locations sent players flying into the air)

--HG--
branch : trunk
2009-11-01 17:53:07 -08:00
maximius 12622ee1a2 *More precise method for determining whether or not a seat is occupied (disregarding object size).
--HG--
branch : trunk
2009-10-28 20:05:20 -07:00
maximius f4d76b8216 *Implement new LootMode system, and add some basic support in boss_sartharion.cpp. Requires database support.
--HG--
branch : trunk
2009-10-28 16:31:19 -07:00
maximius d5b8ad0080 *One player per slot on bench/chair, original patch by Trojan for TC1.
--HG--
branch : trunk
2009-10-28 15:59:45 -07:00
maximius d22768a6b5 *Cleanup
--HG--
branch : trunk
2009-10-18 18:38:46 -07:00
maximius 3f338cc1c3 *Massive cleanup redux.
--HG--
branch : trunk
2009-10-17 16:20:24 -07:00
maximius e585187b24 *Backed out changeset 3be01fb200a5
--HG--
branch : trunk
2009-10-17 15:51:44 -07:00
maximius 26b5e033ff *Massive cleanup (\n\n -> \n, *\n -> \n, cleanup for(...) to for (...), and some other cleanups by hand)
*Fix a possible crash in Spell::DoAllEffectOnTarget

--HG--
branch : trunk
2009-10-17 15:35:07 -07:00
Machiavelli a3de0f7ba0 * Fix bug that caused a 100% chance to increase fishing skill on fishing regardless of area.
--HG--
branch : trunk
2009-10-06 21:01:20 +02:00
Machiavelli 1bd3f9604c * Allow players to get fishing skillups from fishing in any area, no more "your fish got away" message. However still need core support to manipulate fishing loot based on fishing skill.
--HG--
branch : trunk
2009-10-06 00:52:09 +02:00
maximius f980dd9ac6 *Merge [8524] New cell search algorithm implemented. You can now choose different
visibility distances on continents, in BG/Arenas and instances. Author: Ambal
*Some warning cleanup

--HG--
branch : trunk
2009-09-27 02:24:25 -07:00
maximius 333f1c9d72 *[8475] fixed some gcc-warnings Author: balrok
*[8476] Revert some recent cleanup changes, some other fixes and cleanups. Author: VladimirMangos
*[8489] Fixed player visibility update in case view point different from player itself. Author: SilverIce
*[8493] Avoid unexpected multiply error messages at wrong `quest_template`.`RewSpell*` Author: VladimirMangos
*[8496] Resolve some #include cycles and unsafe code.
* Common.h -> Threading.h -> Errors.h -> Common.h
* Remove reduncdent #include "ByteBuffer.h" in headers
* Remove redundent #include "Auth/BigNumber.h" in headers
* Avoid multyply data copy at use some now dropped functions in BigNumber.
* Avoid copy fixed byte count from byte arrays with unknown real size created from BigNumber.
* Avoid possible problems for build mangos at different platform or compilers. Author: VladimirMangos.
*[8501] Apply code style and cleanups to some Player functions. Author: VladimirMangos.
*[8502] Disable quests related to specific game events at startup if event not active. Also rename member boolean variable. Author: NoFantasy
*[8506] Add check for IsAutoComplete() in SendPreparedQuest().
For cases where quest is repeatable but has Method!=0, QuestDetails must be sent instead of RequestItems.
Some additional code cleanup. Author: NoFantasy
*[8507] Check amount of spawned pools before decrement to avoid unexpected result. Also rename variable to more meaningful name. Signed-off-by: NoFantasy <nofantasy@nf.no>

Thanks to Stryker and onkelz28!

--HG--
branch : trunk
2009-09-18 14:10:37 -07:00
maximius 140ec674a0 Backed out changeset d3fe2d6d504a (please test your patches thoroughly before getting me to push them ogeraisi)
--HG--
branch : trunk
2009-09-14 16:49:23 -07:00
maximius b37f9b1e55 *Merged MaNGOS [8458], [8475], [8476] by ogeraisi, thanks to all authors :)
--HG--
branch : trunk
2009-09-14 16:02:13 -07:00
Kudlaty 8c255266e7 Fix some issues with game object create according to last patch. Thx to NoFantasy and DearScorpion
--HG--
branch : trunk
2009-09-04 05:11:27 +02:00
Kudlaty 2465ef00a2 Fix bug with going trough things on login. Thanks to Opterman and Nofantasy
--HG--
branch : trunk
2009-09-03 23:40:14 +02:00
megamage 5b9868f468 *Combine gobject::deleteobjectwithowner and delete
--HG--
branch : trunk
2009-09-02 14:52:52 -05:00