Commit Graph

2484 Commits

Author SHA1 Message Date
Shauren
b0fb2d20a8 Core/Objects: Fixup SMSG_UPDATE_OBJECT related refactors
* Object::BuildValuesUpdateWithFlag is actually unused
* Restore UF::UpdateFieldFlag::Owner for players (self packet)

(cherry picked from commit 963eb6b80c)
2024-11-01 07:54:35 +01:00
Shauren
c975bc2c65 Core/PacketIO: Move writing data sizes in SMSG_UPDATE_OBJECT to shared functions instead of spreading it in all overrides
(cherry picked from commit 067fa31d15)

# Conflicts:
#	src/server/game/Entities/Item/AzeriteItem/AzeriteEmpoweredItem.cpp
#	src/server/game/Entities/Item/AzeriteItem/AzeriteItem.cpp
2024-10-27 20:38:12 +01:00
Ovahlord
78671afa54 Revert "Core/Movement: Store adv flying speeds instead of hardcoding them in SMSG_UPDATE_OBJECT and enable packets modifying them"
This reverts commit 7c425b8970.
2024-10-12 23:56:39 +02:00
Jason Dove
d8c79337ed Core/Units: Fix melee attack victim level calculation (#30329)
(cherry picked from commit d93ca90d49)
2024-10-12 23:47:22 +02:00
Shauren
7c425b8970 Core/Movement: Store adv flying speeds instead of hardcoding them in SMSG_UPDATE_OBJECT and enable packets modifying them
(cherry picked from commit 43c7965d6b)

# Conflicts:
#	src/server/game/Server/Protocol/Opcodes.cpp
2024-10-12 23:47:21 +02:00
Ovahlord
b1eac5485b buildfix 2024-10-09 19:25:11 +02:00
Ovahlord
81f612369a Core/Player: updated block percent value for Cataclysm 2024-10-09 18:33:18 +02:00
Shauren
992f1851e2 Core/Spells: Protect against stack overflows in spell override handling
(cherry picked from commit 723e638a84)
2024-09-22 13:47:53 +02:00
Ovahlord
46e26179c8 Core/Auras: fixed a possible underflow when checking required powers for SPELL_AURA_TRIGGER_SPELL_ON_POWER_AMOUNT and SPELL_AURA_TRIGGER_SPELL_ON_POWER_PCT
(cherry picked from commit f26c942053)
2024-09-22 11:45:40 +02:00
Ovahlord
b73e4e1662 Core/Spells: implemented SPELL_AURA_MOD_SPELL_POWER_PCT 2024-09-08 22:15:47 +02:00
Shauren
27c9af1a5e Core/Players: Fixed nested spell overrides (priest Mind Spike)
(cherry picked from commit cdca59ca4d)
2024-09-03 19:54:50 +02:00
Jeremy
2624503e7e Spells/Auras: Implement SPELL_AURA_ACT_AS_CONTROL_ZONE (#30083)
(cherry picked from commit 66abfd1c53)

# Conflicts:
#	src/server/game/Spells/Auras/SpellAuraEffects.cpp
#	src/server/game/Spells/Auras/SpellAuraEffects.h
2024-08-17 14:02:00 +02:00
Ovahlord
fb0c4f640f Core/Units: fixed a logic mistake in crit supression mechanic that was falsely increasing the crit chance when attacking lower level targets 2024-08-06 12:08:41 +02:00
Ovahlord
577f6d1516 Core/Units: use the same misc value logic when calculating unit mods for SPELL_AURA_MOD_TOTAL_STAT_PERCENTAGE as the aura effect handler
*this fixes some total stat pct auras not correctly showing stat changes (such as Wizardry)
2024-08-06 12:00:21 +02:00
Ovahlord
4027c8a40c Core/Units: fixed stats buff mod calculation logic to correctly assign stat changes to their according update field 2024-08-04 13:15:05 +02:00
Ovahlord
7a9d27639a Core/Auras: implemented SPELL_AURA_MOD_DAMAGE_FROM_MANA 2024-08-02 03:34:02 +02:00
Ovahlord
2401e32c55 Core/Misc: update Combo Points handling to Cataclysm 2024-07-31 06:05:41 +02:00
Shauren
397f6c8128 Core/Auras: Defined and implemented new aura state
(cherry picked from commit d82a018b5b)
2024-07-25 23:26:37 +02:00
Ovahlord
17c35e5857 Core/Units: unify power regeneration handling (#30088)
* Core/Units: unify power regeneration handling

- Creatures, Players and Pets now all share the same power update and regeneration handling
- Removed all false power regeneration handlings for pets and creatures
- Removed a nowhere confirmed hack for delaying health regeneration after polymorphing a target
2024-07-22 23:45:44 +02:00
Ovahlord
5e3a42ee82 Revert "power regen update"
This reverts commit bf23db4daa.
2024-07-14 19:24:26 +02:00
Ovahlord
bf23db4daa power regen update 2024-07-14 19:02:22 +02:00
Ovahlord
20a8c46a72 Core/Players: turn rune cooldowns into floats and change their cooldown calculation to get closer to what the other power types do 2024-07-12 02:58:00 +02:00
Ovahlord
3751c13834 Core/Units: implement PowerTypeFlags::RegenAffectedByHaste 2024-07-12 01:23:49 +02:00
Shauren
4988e328d4 Core/Creatures: Allow adding summons to CreatureGroup (only adding, no formation movement of linked aggro yet)
(cherry picked from commit 16bfbe1a3a)
2024-07-11 19:06:57 +02:00
Ovahlord
c41e21db23 Core/Spells: implement support for energizing runes via SPELL_EFFECT_ENERGIZE 2024-07-11 17:59:13 +02:00
Shauren
7198c5223e Core/Creatures: Fixed memory leaks in creature formations
(cherry picked from commit 2e3920081f)
2024-07-08 13:13:06 +02:00
Shauren
23545f8182 Core/Units: Interrupt only spell in CURRENT_GENERIC_SPELL slot with damage taken InterruptFlags instead of all currently cast spells
(cherry picked from commit 7fdcae81d8)
2024-07-08 13:12:57 +02:00
Shauren
184d48cb65 Core/Spells: Implemented SPELL_ATTR9_CANNOT_KILL_TARGET
(cherry picked from commit b3bdb4efef)
2024-07-05 04:43:13 +02:00
Shauren
0885458cb3 Core/Spells: Implemented SPELL_ATTR9_IGNORE_CASTER_HEALING_MODIFIERS and SPELL_ATTR13_ALWAYS_ALLOW_NEGATIVE_HEALING_PERCENT_MODIFIERS
(cherry picked from commit 96bfc5f39b)
2024-07-05 04:42:52 +02:00
Shauren
315393f1ca Core/Spells: Implemented SPELL_ATTR9_ALLOW_CAST_WHILE_CHANNELING
(cherry picked from commit 3365e6a4b8)
2024-06-28 18:40:44 +02:00
Shauren
e79216ab9e Core/Spells: Implemented SPELL_ATTR11_IGNORE_SPELLCAST_OVERRIDE_SHAPESHIFT_REQUIREMENTS
(cherry picked from commit cb335c3274)
2024-06-28 18:39:50 +02:00
Shauren
a434917b3a Core/Spells: Spells cast through SPELL_AURA_OVERRIDE_ACTIONBAR_SPELLS_TRIGGERED aura should always be instant
(cherry picked from commit 4b4c52112d)
2024-06-28 18:39:42 +02:00
Ovahlord
dc67de6b1b Core/Items: dropped artifact weapon implementation 2024-06-25 18:08:28 +02:00
Shauren
bab83b91d9 Core/Movement: Allow setting position or object facing targets for jump movement
(cherry picked from commit ac73edc268)

# Conflicts:
#	src/server/scripts/Kalimdor/RagefireChasm/boss_lava_guard_gordoth.cpp
2024-06-23 23:48:49 +02:00
Shauren
f52d9b9916 Core/Spells: Fixed implementation of SPELL_ATTR1_IMMUNITY_TO_HOSTILE_AND_FRIENDLY_EFFECTS and removed banish special cases that were neccessary because that attribute wasn't correctly supported
(cherry picked from commit c968dedfee)
2024-06-20 01:22:04 +02:00
Golrag
c7374b620b Core/Players: Allow targeting a specific transport during teleports
(cherry picked from commit 5b130cfb42)
2024-06-20 00:53:56 +02:00
Ovahlord
618c5841ba Core/Units: updated spell crit damage bonus percentages for Cataclysm 2024-06-17 03:05:55 +02:00
Ovahlord
8d851e8576 Core/Spells: removed no longer used parameters from SpellEffectInfo::CalcValue and SpellEffectInfo::CalcBaseValue 2024-05-30 14:55:34 +02:00
Ovahlord
8dc00345bd Core/Spells: various spell scaling fixes and improvements
* removed redundant scaling multiplier code
* removed some dead code which is no longer relevant for classic
* scale healing spell power coefficients as well
* implemented mana cost scaling
2024-05-30 14:43:37 +02:00
Ovahlord
763e97577a Core/Units: subtract 10 intelligence when calculating base spellpower bonus values to match PaperDollFrame 2024-05-30 02:30:42 +02:00
Ovahlord
628b861c7c Core/Spells: initial work on updating base amount calculations and spell scaling for Cataclysm
* implemented the 'new' scaling fields which follow the same rules as they used to in build 15595
* implemented helper to retrieve spell scaling multipliers and use it to scale spell power coefficients
* restored die-sides handling
2024-05-30 02:21:20 +02:00
Shauren
27d1749e2f Core/Auras: Corrected implementation of dungeon encounter related interrupt flags
(cherry picked from commit e4e6eccdf5)
2024-05-28 17:12:18 +02:00
Shauren
89b0e5fa9b Core/Spells: Implemented SPELL_ATTR13_DO_NOT_ALLOW_DISABLE_MOVEMENT_INTERRUPT
(cherry picked from commit 48bc24697f)
2024-05-28 17:02:28 +02:00
Ovahlord
cbc6aed437 Core/Auras: Implemented OnHeartbeat AuraScript hook and refactored an aurascript to use it as example (#29945)
* Updated Amalgam's Seventh Spine dummy aura script to use the new AuraScript hook

(cherry picked from commit 55ce5b150f)
2024-05-28 16:45:30 +02:00
Ovahlord
4de6799403 Core/Units: moved Vignette updating into Heartbeat handling
(cherry picked from commit 253f306a41)
2024-05-28 16:45:26 +02:00
Ovahlord
42a5176190 Core/Auras: implemented PROC_FLAG_HEARTBEAT and moved food/drink emote mechanic into heartbeat handling (#29943)
* also fixed an false assumption that only one of the food emotes can be played. They can in fact be both done at the same time.

(cherry picked from commit d60b4e5b19)
2024-05-28 16:45:22 +02:00
Ovahlord
f7ea6f55dc Core/Units: moved cyclic spline synchronization mechanic heartbeat handling
(cherry picked from commit c2fedbb6cc)
2024-05-28 16:44:59 +02:00
ModoX
4a18194fc0 Core/Movement: Fixed data sent in cyclic spline related packets
(cherry picked from commit a28facb956)
2024-05-28 16:43:38 +02:00
Shauren
5c1021046a Core/Movement: Ensure land and takeoff animations even if gravity enabled/disabled state is not what spline generator expects
(cherry picked from commit be3ae90dc4)
2024-05-28 16:35:03 +02:00
Shauren
7c32484b79 Core/Pets: Removed overriding unit class for pets
(cherry picked from commit 2c702df4e3)
2024-05-28 16:31:56 +02:00