Commit Graph

19136 Commits

Author SHA1 Message Date
Shauren 75c34bda67 Core/Creatures: Exclude despawned creatures from being found by "nearest entry" searchers
Updates #11418
Closes #17706
2016-08-22 21:10:43 +02:00
jackpoz b7306f06f5 Core/Misc: Fix static analysis issues 2016-08-22 14:17:24 +02:00
ariel- f183ed3c50 Core/Unit: removed ancient workaround changing spell caster based on triggering aura.
Keep an eye out for those broken scripts!

Closes #17739
2016-08-21 18:02:36 -03:00
Shauren 4d5fee0489 Dynamic linking build fix 2016-08-21 18:51:11 +02:00
Shauren 39311e0ce8 Typo fix 2016-08-21 18:40:06 +02:00
Eilo 0a53d0b1fa Tools/mmaps_generator: Added estimated percentage progress to console output (#17798) 2016-08-21 11:44:22 +02:00
mik1893 6d07fbf07c Core/Spells: Fixed spells like Shadowform, Tricks of the Trade, Misdirection getting stuck in unusable state clientside if they failed earlier because of GCD
Closes #657
Closes #12913
Closes #17376
2016-08-21 11:32:42 +02:00
Treeston 6f85422f0b Core/Spells: Fix orientation- and targeting-related issues if the creature isn't currently engaged in combat. (#17120)
Also disable spell focus system for vehicle control auras.

Closes #16572
Closes #17016
2016-08-21 11:07:38 +02:00
Alan Deutscher 061b62a97d Scripts: UNIT_FLAG_REMOVE_CLIENT_CONTROL no longer used as a method for preventing a unit from moving
UNIT_FLAG_REMOVE_CLIENT_CONTROL (formerly UNIT_FLAG_DISABLE_MOVE) is a client-only feature that should not be used for NPC scripting. All applications of this flag in scripts/ have been replaced with applications/removals of the UNIT_STATE_ROOT state.

Closes #17311
2016-08-21 11:04:59 +02:00
ariel- 6d4eead3a9 Core/Entities: fix a crash that would happen whenever a player logged back in to an ended arena battle. Thanks Nawuko for the input
Closes #17825
2016-08-20 22:19:49 -03:00
ariel- 1deb7d2df1 Core/Battlefield: Cleanup of Wintergrasp script and battlefield system:
- Standards: Moved all statics to cpps where they belong.
- Changed spawn position container from fixed size array to std::vector (not all positions were used in every case)
- Removed unused parameter teamId from Battlefield::SpawnCreature
- Removed workaround for GO rotation, added in a69cbeb9d5776025452009733f13ff3a631315e8
- Added rotation parameter to Battlefield:SpawnGameObject
- Added sniffed rotation to existing script spawns.
- Implemented Archavon's Log (Closes #16880)
2016-08-20 21:40:43 -03:00
jackpoz eb9bf314c4 Core/Commands: Code cleanup
Remove commented out code
2016-08-20 20:53:08 +02:00
SnapperRy 0b4b0ea348 Core/SpellArea: only check against spell_area entries for the current quest when updating quest status
Closes #17804
2016-08-20 18:22:43 +02:00
Shauren 836fe5d1ed Core/Spells: Fixed possible null pointer dereference
Coverity CID 1357406

(cherry picked from commit cc07a491f6)
2016-08-20 15:51:15 +02:00
treeston 08b3833051 Core/Conditions: Add new CONDITION_TAXI (46). Does what it says on the tin. Tagging issue #15560. 2016-08-20 14:36:45 +02:00
jackpoz f67d1158d1 Core/Battleground: Fix crash happening when reporting afk a nonexistent player 2016-08-20 14:29:09 +02:00
treeston 78a44dd81e Core/Spells: Fix Spell::EffectJumpDest not to turn caster to zero orientation when ground targeting. 2016-08-20 13:08:09 +02:00
Treeston 8deda7ed7f Entities/Unit: Cleanup refactor. Changes: (#17819)
+ Unit::m_movedPlayer -> Unit::m_playerMovingMe
+ Player::m_mover -> Player::m_unitMovedByMe
+ Unit::GetMover() -> Unit::GetUnitBeingMoved()
+ Unit::GetPlayerMover() -> Unit::GetPlayerBeingMoved()
+ NEW: Unit::GetClientControllingPlayer()
2016-08-20 12:43:04 +02:00
treeston d3495da30b Core/ObjectMgr: I knew I missed something. 2016-08-20 11:08:56 +02:00
treeston 768d978bd2 Core/ObjectMgr: Follow up on 628792f to remove some superfluous warnings. 2016-08-20 11:00:56 +02:00
Chaouki Dhib 333a3e05f6 Core/Spells: Fixed extended spell range while moving Closes #17818 (#17824)
Cherry pick of https://github.com/TrinityCore/TrinityCore/commit/10e0f4ff8faa007b4c0c247a9368a746da7b7b0c
Closes https://github.com/TrinityCore/TrinityCore/issues/17818
2016-08-20 00:25:30 +01:00
treeston aeeae8d09c Merge remote-tracking branch 'Treeston/3.3.5-petaggro' into 3.3.5 (PR #17800) 2016-08-19 23:54:44 +02:00
treeston ba4d6f6393 AI/SmartScripts: SMART_ACTION_ADD_QUEST -> SMART_ACTION_OFFER_QUEST. Open quest offer instead of adding straight to log - old behavior can be requested using action_param2. Closes #17735. 2016-08-19 23:01:21 +02:00
jackpoz 4073cc510a Core/Packets: Port packet handling rework from 6.x branch (#17777)
* Core/Packets: Port packet handling rework from 6.x branch

Port packet handling reword from 6.x branch. Old handlers are still used at the moment, these changes allow to port old handlers to new packet-specifc ones.
2016-08-19 22:29:00 +02:00
ariel- 628792f960 Core/ObjectMgr: added some more sanity checks to creature templates
- Extra: throwed semicolons around
- Clarified meaning for a vehicleId check (what it said didn't correspond to what was actually checked)
2016-08-19 13:54:08 -03:00
treeston 9072e0221b AI/SmartScripts: Add param3 to SMART_ACTION_CAST and SMART_ACTION_INVOKER_CAST that allows specific triggered flags to be set (rather than all-or-nothing). Ignored if SMARTCAST_TRIGGERED is not set. 2016-08-19 15:23:19 +02:00
treeston 14b44af38d AI/SmartScripts: Add SMART_ACTION_DISABLE_EVADE (117). 2016-08-19 14:53:53 +02:00
treeston e2c915fb43 Core/SmartScripts: Add SMART_TARGET_LOOT_RECIPIENTS. Does what it says on the tin.
Use this new target type to fix The Rider of Blood, The Rider of Frost, The Rider of the Unholy. Closes #17817.
2016-08-19 14:25:23 +02:00
ariel- 3f9cf3fdb6 Core/Player: readd player to battleground after a login (but only after adding it to map, preventing a crash). Closes #16141 (again) 2016-08-18 13:31:04 -03:00
jackpoz d8623f92b2 Revert "Core/Battlegrounds: Properly readd player to Battleground containers after a login."
This reverts commit fbc521084c.
Fixes #17810
2016-08-18 16:25:25 +02:00
ariel- fbfcfe4c1d Core/Globals: delete another synch query using CharacterInfo map 2016-08-18 01:45:44 -03:00
ariel- c7b8f0f773 Core/World: short circuit setWorldState and avoid a db query in case there's nothing to update really 2016-08-18 01:35:42 -03:00
jackpoz 1d7013e0e2 Core/MMAPs: Update recast
Update recast to https://github.com/recastnavigation/recastnavigation/commit/64385e9ed0822427bca5814d03a3f4c4d7a6db9f
2016-08-17 22:00:35 +02:00
ariel- a893ecebf8 * Core/ObjectAccessor: optimize FindPlayerByName by saving a map of player names to Player* (#17797) 2016-08-17 21:32:47 +02:00
jackpoz 2585c62e6f Tools/MMapGenerator: Avoid saving uninitialized padding bytes to disk
Initialize padding bytes in MmapTileHeader struct to avoid saving uninitialized data to disk, causing issues when binary-comparing *.mmtile files.
2016-08-17 15:07:02 +02:00
treeston 8c690f9edc Pet/DK: Make Risen Ghoul and Bloodworms no longer suicidally charge into not-yet-engaged mob packs. 2016-08-17 11:38:31 +02:00
tkrokli 730680430d [3.3.5] Core/Scripts: move npc_loramus_thalipedes to DB
Another chapter in core script hardcoded text removal:
- remove core script `npc_loramus_thalipedes` from zone_azshara.cpp
- add gossip, SAI script and conditions to database
- remove redundant SD2 comments from file header
2016-08-17 05:12:04 +02:00
treeston c5549ac7e9 Revert "Creature/Loot: Fix a bug that prevented players from looting creatures that only had gold on them (no items)."
This reverts commit 63f577a7ef.

See discussion in commit comments.
2016-08-16 23:32:08 +02:00
treeston 63f577a7ef Creature/Loot: Fix a bug that prevented players from looting creatures that only had gold on them (no items). 2016-08-16 15:29:18 +02:00
ariel- 7f5756804e Core/PlayerDump: add missing character_queststatus_* columns to dump 2016-08-16 02:18:02 -03:00
ariel- fbc521084c Core/Battlegrounds: Properly readd player to Battleground containers after a login.
Closes #16141
2016-08-16 00:51:33 -03:00
ariel- 9cdbf903e2 Core/BattlegroundMgr: Update Battlegrounds each second instead of every tick (just like Battlefield).
There are some battleground scripts (like SOTA) performing object access every update, this should help throttle the cpu usage.
2016-08-16 00:44:31 -03:00
ariel- 82517ef462 Core/Player: Do not kick AFK player from BG if it's a GM 2016-08-16 00:41:34 -03:00
ariel- 1b44377cda Core/Scripts: allow ".debug arena" and ".debug battleground" commands to be issued in the console 2016-08-16 00:40:56 -03:00
Chaouki Dhib d7600f1126 Core/Units: Fixed melee range check (#17693)
* Split Spell::CheckRange() into 2 methods since that method had more than one responsibility.
* Moved melee range logic into its own function
* Moved melee range logic method GetMeleeRange from Spell to Unit class. Unit::IsWithinMeleeRange() and Spell::GetMinMaxRange() both use that method.
2016-08-15 18:17:07 +02:00
Gerhood 4a38773e3e Core/Auras: Increase number of auras sent to client except for group updates (#17604) 2016-08-15 14:37:55 +02:00
tkrokli 03bafe334c Core/Scripts: move Pet Trainer gossip to DB
SQL content based  on issue 14719 by Killyana,
conditions output from Malcrom's Condition Creator

- remove hardcoded #define gossip options
- enum gossip menu IDs from DB
- remove outdated SD comments at the top of the file

Closes #14719
2016-08-15 03:17:53 +02:00
robinsch dd67f4ed96 Core/Spell: Remove all raid auras on party leave (#17663)
Core/Spell: Remove all raid auras on party leave
2016-08-14 17:26:03 +02:00
tkrokli e2f395863a Core/Scripts: remove script npc_timothy_daniels (#17779)
The core script `npc_timothy_daniels` is no longer needed,
all the gossip handling is already present in the database.

- remove core script npc_timothy_daniels
- remove ScriptName from c_t entry in DB
2016-08-14 12:05:24 +02:00
tkrokli 0c6eeb3abc Core/Scripts: move npc_mortog_steamhead to DB
Move core script npc_mortog_steamhead to database
- script contains gossip handling + 1 condition
- both actions can be handled in DB settings
2016-08-14 09:50:28 +02:00