Commit Graph

1687 Commits

Author SHA1 Message Date
Shauren ad3fc81db9 Core/Misc: Add missing Containers.h include where neccessary 2023-08-12 17:56:16 +02:00
Shauren b7287e85e4 Core/Misc: Fixed deprecation warnings for c++20
(cherry picked from commit ba9bbbc9d0)
2023-08-12 14:24:24 +02:00
Shauren 47b1de526e Core/Units: Corrected AURA_INTERRUPT_FLAG_NOT_SEATED implementation to only interrupt when actually standing (flag not renamed but its correct name is SpellAuraInterruptFlags::Standing) 2023-05-13 18:35:54 +02:00
Shauren dd10ac27fe Core/Auras: Don't force sitting state from non-standing state when applying auras with SpellAuraInterruptFlags::Standing
Closes #28973
2023-05-12 22:26:16 +02:00
Shauren 2f4c412f4c Core/Units: Don't make force stand state on periodic damage taken
Closes #28950
2023-05-11 22:51:43 +02:00
Shauren d23c839998 Core/Auras: Remove channeled auras when caster and target are not on the same map
Closes #28777
Closes #28792
2023-02-09 19:04:23 +01:00
Shauren 835e291831 Core/Auras: Fully remove auras that had all of their effect suppressed with immunity 2023-01-19 18:16:02 +01:00
Shauren 593721ff1f Core/Auras: Fixed possible iterator invalidation crashes caused by calling UpdateTargetMap inside loops iterating m_appliedAuras
Closes #28609
2023-01-19 14:12:08 +01:00
Ovahlord 4a19892696 Core/Units: ensure that we use valid iterators when providing spell Ids in Unit::RemoveAppliedAuras and Unit::RemoveOwnedAuras 2022-11-23 21:14:45 +01:00
Ovah b47ef3ce90 Core/Spells: fixed up block mechanics (#28286)
* Ranged attacks can now be blocked
* Implement SPELL_ATTR3_COMPLETELY_BLOCKED
* Fixed a bug which was causing blocking to block entire spell effects regardless if the attribute was present or not
* Fixed a logic mistake which was causing blocks to roll twice (once for effect negation and once on hit)
* No longer send blocked miss conditions in spell_go packets when the spell is not completely blocked to match sniff data
2022-10-01 17:21:07 +02:00
Shauren a55a566602 Core/Auras: Fixed requireImmunityPurgesEffectAttribute logic for school immunities
Closes #28237
2022-09-09 21:48:35 +02:00
Shauren 3306a4d06c Core/Auras: Improve aura interactions with immunities on spell effect level
* Effects that target is immune to will be suppressed instead of completely removed

Closes #28096
2022-09-05 18:22:39 +02:00
offl b9450bcdd0 Core/SAI: Rename LeavingWorld to OnDespawn & use it in SAI (#28059) 2022-06-26 21:48:41 +03:00
Kaytotes eab6852b68 Core/Units: Removed incorrect facing movement packet sent with every creature autoattack (#28006) 2022-06-09 14:04:44 +02:00
Shauren 09204159f8 Core/Vehicles: Capture vehicle collision height for exit spline init function (prevent accessing no longer valid vehicle pointer) 2022-04-08 18:06:26 +02:00
Shauren b1a94bf94c Core/Movement: Delay creating MoveSplineInit objects used by GenericMovementGenerator to spline launch time
* This fixes inconsistent transport state detection for players exiting vehicles that are on transport (ICC gunship battle), fixes players being telerpoted to middle of nowhere on that fight
2022-04-03 22:36:49 +02:00
Shauren 653d5a68e6 Core/Units: Fixed incorrect attack power calculation after changing UNIT_FIELD_ATTACK_POWER_MODS to be treated as two separate int16 fields (positive/negative) 2022-04-01 20:23:29 +02:00
Shauren e334fdf3ad Core/Units: Reduce differences between branches part 1 - object class 2022-03-29 23:07:07 +02:00
Shauren d611925dc7 Core/Units: Reduce differences between branches part 1 - unit updatefield accessors 2022-03-29 11:30:49 +02:00
Shauren 62c2ceaff2 Core/Units: Rename AnimationTier to AnimTier for consistency with master branch 2022-03-24 20:38:55 +01:00
offl 3dca705acc Core/AI: OnSpellCast, OnSpellFailed, OnSpellStart hooks (#27704) 2022-02-18 19:14:44 +02:00
Shauren 645b41ebb9 Core/Units: Sync ProcessTerrainStatusUpdate code with master branch 2022-01-01 12:34:42 +01:00
Giacomo Pozzoni 19e99db821 Core/AI: Fix crashes caused by charmed Creatures having null AI for 1 map update tick (#27434)
Implement using ScheduledChangeAI instead of nullptr to signal a required AI change
2021-12-27 13:33:37 +01:00
Shauren 9174281b92 Core/Auras: Properly clean up partial charm applications
Ref #24876
2021-11-27 16:36:04 +01:00
Lucas Nascimento 0cc0b3f926 Core/Combat: Fixed combat after remove charm (#27248)
https://github.com/TrinityCore/TrinityCore/pull/27038#issuecomment-958784361
2021-11-06 10:24:32 -03:00
Keader 9b354c6beb Core/Unit: Fixed wrong combat stop when set charm 2021-10-30 11:08:56 -03:00
offl d7adc50daa Core/Scripting: Get rid of ModifyVehiclePassengerExitPos (#27126) 2021-10-20 01:04:02 +03:00
Lucas Nascimento fa3a62ae4e Entities/Unit: Fixed wrong combat stop when remove charm (#27038) 2021-10-17 17:02:38 -03:00
Lucas Nascimento 63c6f7bc26 Core/Unit: Fixed Deterrence stopping working for no reason (#26996) 2021-10-10 12:39:38 -03:00
trickerer 084f8f3ded Core/Combat Improve extra attacks handling (#26859)
* Core/Combat Improve extra attacks handling

* Remove unnecessary _lastDamagedTargetGuid check

* Add missing initialization of _lastExtraAttackSpell. Do not use hardcoded spell ids.

* Partially revert 9f90b835019b
2021-10-01 16:40:20 +02:00
Ovah e317beb449 Core/Units: removed an incorrect addition of SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER crit chance benefits (#26873)
This aura, as the name implies, should only affect the spells that it has listed in its class mask. Because the removed code was not doing so, it applied the crit chance on ALL melee and ranged spells. This fixes Stormstrike unintentionally increasing the crit chance for all melee attacks instead of the affected spells only
2021-10-01 16:38:29 +02:00
offl e4a82ee97a Core/Misc: Rename UNIT_FLAG_SWIMMING to UNIT_FLAG_CAN_SWIM
Ref #26912
2021-09-16 21:15:52 +03:00
offl c4741a131a Core/Misc: Rename UNIT_FLAG_NOT_SELECTABLE to UNIT_FLAG_UNINTERACTIBLE (#26913) 2021-09-15 01:04:03 +03:00
Shauren e50102178b Core/Spells: Spell effect info access refactoring part 3 - removed direct SpellInfo::Effects field access from game 2021-08-31 00:13:44 +02:00
Shauren 7440c9cf19 Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers 2021-08-30 23:51:37 +02:00
Gildor 0fad28e4ab Core/Unit: improve SPELL_AURA_MOD_IMMUNE_AURA_APPLY_SCHOOL immunities (#26849) 2021-08-30 11:19:32 +02:00
Shauren 6573395f24 Core/Spells: Spell effect info access refactoring part 2 - passing SpellEffectInfo as arguments directly instead of SpellInfo + effect index 2021-08-29 21:12:49 +02:00
Shauren 4c59532865 Core/Spells: Begin unifying spell effect access api with master branch
* Introduce SpellInfo::GetEffects and SpellInfo::GetEffect functoins
2021-08-28 23:42:25 +02:00
Giacomo Pozzoni 0800ab20a8 Core/AI: Add DamageEffectType and SpellInfo parameters to UnitAI::DamageTaken (#26787)
* Core/AI: Add DamageEffectType and SpellInfo parameters to UnitAI::DamageTaken

* Update scripts
2021-08-09 17:00:34 +02:00
offl 06b554c36e Core/Creature: rename CREATURE_FLAG_EXTRA_IGNORE_COMBAT into CREATURE_FLAG_EXTRA_CANNOT_ENTER_COMBAT (#26762)
Co-authored-by: offl <offl@users.noreply.github.com>
2021-07-30 09:36:38 +02:00
Gildor bd6de8eb61 Core/Spells: defined and implemented SPELL_ATTR7_CANT_DODGE, SPELL_ATTR7_CANT_PARRY and SPELL_ATTR7_CANT_MISS (#26742) 2021-07-24 14:48:57 +02:00
jackpoz 3f08c16749 Core/Unit: Add more logs for #26325
Add more logs to try spotting the cause of #26325 . It might be that a minion is added to a owner that is not in world.
Report any issue with minions/pets that contain the log.
2021-07-21 20:49:37 +02:00
jackpoz 40f4b141bd Core/Unit: Include m_Controlled in crashlogs 2021-07-11 11:55:23 +02:00
jackpoz 479c636612 Core/Movement: Include GetGameClientMovingMe() details in assert logs 2021-07-04 19:40:28 +02:00
Chaouki Dhib d337fb99ed Core/Movement: Implement proper player speed change (#26561) 2021-06-15 23:09:48 +02:00
Giacomo Pozzoni 9fe9dc087b Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH (#26549)
* Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH

Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH to keep movement generators even after death.

Fixes #23095
Could replace ff26027453

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Keep MoveJump movement generator after death

Co-authored-by: ccrs <ccrs@users.noreply.github.com>
2021-06-06 17:51:00 +02:00
jackpoz af815e991d Core/Player: Log more information when Player::StopCastingCharm() fails 2021-06-05 18:41:51 +02:00
Chaouki Dhib 19fa411431 Core/Movement: Hotfix the crashes that can occur in the movement handlers (#26538) 2021-05-22 14:54:58 +02:00
Chaouki Dhib 2d114ea560 Core/Movement: Improve client control logic (#26348) 2021-05-16 13:16:08 +02:00
Shauren 2f04c48919 Core/PacketIO: Reduce size of SMSG_UPDATE_OBJECT by trimming trailing zeros in values updatemask 2021-04-25 14:56:25 +02:00