Commit Graph

20235 Commits

Author SHA1 Message Date
Epicurus4 a860c62fed Core/Loot: Update and enable SMSG_LOOT_RESPONSE
Also correct SMSG_NOTIFICATION initializaiton.
2015-03-12 23:42:26 -04:00
Carbenium 5feee1e69b Merge pull request #14344 from DJScias/opcodes2
Core/Packets: Update & enable more opcodes (names inside)
2015-03-13 01:18:39 +01:00
DJScias 72e549be50 Core/Packets: updated and enabled SMSG_CANCEL_AUTO_REPEAT, SMSG_CANCEL_ORPHAN_SPELL_VISUAL, SMSG_CANCEL_SPELL_VISUAL, SMSG_COIN_REMOVED
Documentation used:
- Updated and enabled the before-mentioned opcodes.
- "SMSG_CANCEL_AUTO_REPEAT" also switched from PackedGuid to ObjectGuid as per @DDuarte's suggestion.
- Changed initial size of "SMSG_SELL_RESPONSE" packet and default initialized SellResult Reason. Thanks @Lordron.

Cleaning up latest commit.
2015-03-13 00:49:44 +01:00
Duarte Duarte 50be8a4f01 Merge pull request #14342 from DJScias/opcodes_emotes
Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_E...
2015-03-12 23:45:01 +00:00
Duarte Duarte ba2d06a71b Merge pull request #14333 from Naios/static1
Core/Log: Fix some issues detected by static analysis.
2015-03-12 23:43:22 +00:00
jackpoz 1275774646 Revert "Core/SupportMgr: Fix static analysis issue"
This reverts commit 04020e717c.

Initializing a std::string with nullptr is not allowed by C++11 standard
and trigger runtime exceptions.
2015-03-12 21:52:59 +01:00
Vincent-Michael 04020e717c Core/SupportMgr: Fix static analysis issue 2015-03-13 21:12:18 +01:00
DJScias 5dddfbdb7b Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_EMOTE, CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE
Documentation used:
- Enabled CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE to 6.1
- Changed CMSG_EMOTE from "0x0B2B" to "0x0B2C". It sends an empty packet but it's meant to stop the current emote as per @Zedron's sniffs.
- Updated structure and enabled CMSG_RANDOM_ROLL and SMSG_RANDOM_ROLL. Thanks @rocverde for providing sniffs.

Cleaning up last commit
2015-03-12 16:51:39 +01:00
Epicurus4 ef54ee52e2 Core/Formatting: White space clean-up. 2015-03-12 10:52:46 -04:00
Epicurus4 b306c7c6cf Core/Loot: Enable setting AcquireReason, correct LootMethod definition, fix structure to match sniffs of retail and correct threashold and reason definitions. 2015-03-12 10:39:33 -04:00
Carbenium ebc226cdac Merge pull request #14343 from DJScias/opcodes1
Core/Packets: updated and enabled SMSG_SELL_RESPONSE
2015-03-11 21:24:29 +01:00
jackpoz b35578bac3 Revert "Core/Server: Catch exceptions in int main()"
This reverts commit e68ca82d4d.

Closes #14329
2015-03-11 21:07:08 +01:00
DJScias 30bef643fd Core/Packets: updated and enabled SMSG_SELL_RESPONSE
A typo that slipped in, damnit
2015-03-11 20:54:27 +01:00
Carbenium 62e2d8e971 Merge pull request #14334 from Naios/static2
Core/Game: & Core/Scripts: Fix some issues detected by static analysis.
2015-03-11 20:22:46 +01:00
MitchesD c6718dc120 Core/PacketIO: updated and enabled SMSG_PLAY_MUSIC 2015-03-11 20:04:57 +01:00
Vincent-Michael 3439225f19 Core: Fix build 2015-03-12 19:44:01 +01:00
MitchesD 7b446a28cc Core/PacketIO: updated SMSG_ENVIRONMENTALDAMAGELOG and enabled some opcodes 2015-03-11 16:59:42 +01:00
Naios 1920e9c442 Scripts/Spells: Fix some issues detected by static analysis.
* Prefer prefix ++/-- operators for non-primitive types.
* Variable 'ownerBonus' is reassigned a value before the old one has been used.

* Fix a wrong type of ownerBonus, sometimes it is float sometimes uint32
2015-03-11 09:29:20 +01:00
Naios 9a61049f88 Core/Game: Fix some issues detected by static analysis.
* Possible inefficient checking for 'list' emptiness.

* Variable '_scheduledScripts' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Variable 'Text' is assigned in constructor body.
  Consider performing initialization in initialization list.

* Possible inefficient checking for 'm_loadedScripts' emptiness.
2015-03-11 08:53:13 +01:00
Carbenium 163bd334d0 Core/Packets: Fix packet structure for RideTicket 2015-03-11 08:29:50 +01:00
Naios 8882a6ca78 Core/Log: Fix some issues detected by static analysis.
* Either inefficient or wrong usage of string::find(). string::compare() will
  be faster if string::find's result is compared with 0, because it will not scan the whole string.
  If your intention is to check that there are no findings in the string,
  you should compare with std::string::npos.

* C-style pointer casting detected. C++ offers four different kinds of casts as replacements:
  static_cast, const_cast, dynamic_cast and reinterpret_cast.
2015-03-11 08:20:12 +01:00
Epicurus4 678c307db6 Core/PacketIO: Update a few opcode enums to better match TrinityCore naming conventions. 2015-03-10 22:30:49 -04:00
Carbenium 37a14bc2d5 Core/Support: Update the support/ticket system to 6.x
Core/Mail: fix a logic error introduced in 829e11b662
2015-03-10 21:09:21 +01:00
Shauren c8944d73b3 Core/Players: Set holy power decay timer to 20 seconds after leaving combat (also added OnCombatExit hook for stuff like this) 2015-03-10 20:53:29 +01:00
DJScias 7b9ec7101c Core/Packets: update & enabled CMSG_EMOTE
Documentation Used:
- Thank you @MitchesD for providing some extra information, much appreciated.

Core/Packets: Fix CMSG_EMOTE opcode handler

Documentation used:
- Thanks thumsoul from TC IRC for providing extra information.
2015-03-10 17:47:34 +01:00
MitchesD 47517b2128 Core/PacketIO: updated SMSG_CLEAR_TARGET and enabled some opcodes 2015-03-10 16:29:52 +01:00
Epicurus4 8a5edd1e13 Core/Enum: Fix typo 2015-03-10 10:38:49 -04:00
Carbenium f107d2999f Core/PacketIO: Sync with WPP 2015-03-10 08:21:22 +01:00
DJScias 8c4afd2bcc Core/PacketIO: enable CMSG_DESTROY_ITEM, CMSG_INSPECT, SMSG_INSPECT_RESULT
Documentation used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Each opcode checked and works positively, feel free to apply and check yourself.
2015-03-10 00:01:12 +01:00
DJScias a47d57d1db Core/Packets: update & enabled CMSG_SHOWING_CLOAK, CMSG_SHOWING_HELM
Documentation Used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Thank you very much @MitchesD, @DDuarte, @Carbenium and @Vincent-Michael (+ Trinity as a whole) for the help with my very first opcode structure update.
2015-03-09 22:57:49 +01:00
MitchesD 7754d4d23e Core/PacketIO: sync with WPP 2015-03-09 19:43:25 +01:00
Gacko d9d48ca0f1 Fix non pch build 2015-03-09 19:40:19 +01:00
leak c61548a17b CMake: Remove unused source reference 2015-03-09 14:55:20 +01:00
Shauren 153f3a264b Core/Logging: Fixed ObjectGuid::ToString to output full guid 2015-03-09 11:02:06 +01:00
Shauren 14c5e67a89 Core/Spells: Fixed level value scaling for spells with scaling class < -1
Closes #14133
2015-03-09 00:50:09 +01:00
Shauren e15ba34444 Core/Misc: Cleaned up data truncation warnings 2015-03-08 22:04:34 +01:00
Shauren 75f0cabde7 Core/Auras: Fixed applying more than 8 aura effects 2015-03-08 19:52:53 +01:00
Shauren c97a9e5607 Core/Spells: Implemented SPELLMOD_JUMP_DISTANCE 2015-03-08 17:39:20 +01:00
Shauren 75db12bf41 Core/Auras: Implemented SPELLMOD_EFFECT4 and SPELLMOD_EFFECT5 2015-03-08 17:36:44 +01:00
Shauren eb158e1847 Core/DataStores: Fixed a crash happening when TaxiNodes.db2 fails to load
Closes #14313
2015-03-08 16:29:13 +01:00
MitchesD 50b4a3a707 Core/Packets: updated structure of CMSG_PLAYED_TIME, SMSG_PLAYED_TIME 2015-03-08 16:23:00 +01:00
MitchesD 268e2a4b22 Merge pull request #14312 from DJScias/opcodes
Core/PacketIO: Update a response & /played opcodes to 6.1.0
2015-03-08 16:03:55 +01:00
Shauren 0ba2e0d5ee Core/Spells: Implemented multiple spell power costs 2015-03-08 13:31:57 +01:00
DJScias cbd429d79d Core/PacketIO: Update "SMSG_QUEST_QUERY_RESPONSE" & /played opcodes to 6.1.0
Documentation:
- Taken from https://github.com/TrinityCore/WowPacketParser/commit/92a9fe77b0e8365366d7720f206cff03d0045729.
- /played opcodes from sniffs provided by @rocverde through TC IRC.

Note: opcode handlers for "CMSG_PLAYED_TIME" & "SMSG_PLAYED_TIME" still need a proper structure change. CMSG is using _OLD and both are on _UNHANDLED.
2015-03-08 03:47:19 +01:00
Duarte Duarte e6e5c2b501 Merge pull request #14309 from Luzifix/opcode-1
Core/PacketIO: Update Vendor Opcode to  6.1.0
2015-03-08 01:50:57 +00:00
Shauren ce35bfe113 Core/DataStores: Fixed out of bounds array access during loading TaxiNodes.db2 and added ASSERT for TaxiMaskSize for future versions 2015-03-08 01:29:34 +01:00
Shauren 8cd1c9514f Core/Auras: Fixed possible crash in Aura::RefreshDuration - Aura::GetCaster can return NULL 2015-03-07 23:45:22 +01:00
Luzifix 0aa9619421 Core/PacketIO: Update Vendor Opcode to 6.1.0 2015-03-07 20:42:35 +01:00
Duarte Duarte 38ba7ab08e Merge pull request #14306 from DJScias/6.x
Core/PacketIO: Update more opcodes for 6.1.0 (3 commits in total)
2015-03-07 17:53:25 +00:00
DJScias 82832d97e3 Core/PacketIO: Update speed change opcodes for 6.1.0
Documentation used:
- Taken from https://github.com/TrinityCore/WowPacketParser/commit/1a96b789726fa786e476e8af53d43f24d73681e6.

Note: I only change opcodes.cpp status to what they were before they were all put back to 'STATUS_UNHANDLED' for update 6.1. The ones that were 'UNHANDLED' before I don't change the status of.
2015-03-07 18:51:12 +01:00