Commit Graph

12589 Commits

Author SHA1 Message Date
jackpoz a20905598d Core/PacketLog: Avoid unneeded calls with disabled packet logs
Avoid calling GetOpcodeNameForLogging() when packet logs are disabled.

(cherry picked from commit 5e7d4a44e0)

Conflicts:
	src/server/game/Server/WorldSocket.cpp
2015-03-18 00:13:05 +00:00
jackpoz 22d655451c Shared/Logs: Add support to .server set loglevel command after 003d67708b
Update the lowest log level when using ".server set loglevel" command.

(cherry picked from commit 43f74fd8cf)
2015-03-18 00:10:19 +00:00
jackpoz 064b6a4c84 Shared/Logs: Improve log performances
Improve Log::ShouldLog() performances by saving the lowest log level across all loggers and discarding any log with lower level than that.

(cherry picked from commit 003d67708b)
2015-03-18 00:10:02 +00:00
jackpoz 034dbe267d Core/Player: Optimize Player::HaveAtClient() performance
Change m_clientGUIDs from std::set to std::unordered_set to reduce by 2.7x times the cpu usage in Player::HaveAtClient()

(cherry picked from commit 49ececf038)
2015-03-18 00:09:32 +00:00
jackpoz f3f44c468d Core/Collision: Fix crash when loading invalid vmap data
Fix array overflow when loading Models from vmap tiles with wrong/outdated/bad data.
Try extracting again vmaps if you see this error.
Closes #14255

(cherry picked from commit 3035a4218b)
2015-03-18 00:09:07 +00:00
jackpoz 1a583703c5 Core/CrashHandler: Fix char[] without '\0' handling
Fix char[] without a NULL character '\0' in the array reading over the char[] bounds

(cherry picked from commit fd844e3d7e)
2015-03-18 00:08:49 +00:00
Nyeriah 8b7dabab21 Scripts/Undercity: Update Lady Sylvanas' script and also implement few missing things to Journey to Undercity's quest end event
Closes https://github.com/TrinityCore/TrinityCore/pull/14094
Thanks to @Killyana @Rushor @jaredjones and all others who helped with this

(cherry picked from commit a76722ccef)
2015-03-17 20:22:55 -03:00
Duarte Duarte c4499cf35d Merge pull request #14386 from Gigi1237/SpeedAck
Core/PacketIO: Updated and enabled _SPEED_CHANGE_ACK
2015-03-17 12:42:14 +00:00
Vincent-Michael 4ee22e3c5e Core/Packets: Enable opcode CMSG_BANKER_ACTIVATE / SMSG_SHOW_BANK 2015-03-16 20:39:01 +01:00
Luzifix 40809ebfec Core/PacketIO: update & enable CMSG_QUESTGIVER_HELLO 2015-03-16 19:22:08 +01:00
Gigi1237 5a8db92e62 Core/PacketIO: Updated and enabled _SPEED_CHANGE_ACK
Added packet structure for MovmentAck
2015-03-15 17:26:19 +01:00
Duarte Duarte bb1f61bb1f Merge pull request #14377 from DJScias/opcodes4
Core/Packets: update and enable SMSG_SUPPRESS_NPC_GREETINGS
2015-03-15 13:16:46 +00:00
Duarte Duarte e1129d0877 Merge pull request #14372 from DJScias/opcodes2
Core/Packets: update CMSG_QUESTLOG_REMOVE_QUEST and enabled some quest o...
2015-03-15 13:16:23 +00:00
Vincent-Michael fe971b9048 Core/Enums: Update TutorialAction for 6.1.0 2015-03-15 13:54:04 +01:00
Luzifix 41641eb907 Core/PacketIO: Update and enable delete character for 6.1 2015-03-15 13:30:10 +01:00
Vincent-Michael 6dd6fa04ef Core/Enums: Update ResponseCodes for 6.1.0 2015-03-15 13:06:09 +01:00
Vincent-Michael 8366ed5a72 Core/Packets: Fix typo 2015-03-15 06:12:52 +01:00
Vincent-Michael afaa487c6c Core/Packets: Update some opcodes and enable this 2015-03-15 05:59:55 +01:00
Vincent-Michael a99d7303cd Core/Packets: Update some opcodes and enable this 2015-03-15 05:01:15 +01:00
Vincent-Michael aa0feb41ae Fix typo in MovementStatus (read/write)
todo 6.x use this infos
2015-03-15 04:16:54 +01:00
Vincent-Michael fb8a169d46 Core/Packets: Added SMSG_TRANSFER_ABORTED / SMSG_TRANSFER_PENDING opcodes for 6.1.0 and enable this 2015-03-15 03:36:45 +01:00
Vincent-Michael f2cb963565 Core/Packets: Update some opcodes and enable this 2015-03-15 03:09:34 +01:00
Vincent-Michael d86298cde4 Core/Packets: Update some opcodes and enable this 2015-03-15 02:36:56 +01:00
Vincent-Michael ae76ee8eca Core/Packets: Enable CMSG_SET_ACTIONBAR_TOGGLES opcode for 6.1.0 2015-03-15 01:44:11 +01:00
DJScias 6fb2dba273 Core/Packets: update and enable SMSG_SUPPRESS_NPC_GREETINGS 2015-03-15 01:13:57 +01:00
DJScias e6ad1c46d3 Core/Packets: update and enable SMSG_HEALTH_UPDATE 2015-03-15 00:57:09 +01:00
DJScias 1f9855b739 Core/Packets: update CMSG_QUESTLOG_REMOVE_QUEST and enabled some quest opcodes
Documentation used:
- These were tested in-game, you can start/accept a quest and abandon them properly.
- The enables are due to fixes Shauren did in regards to sending quest data.
- I found CMSG_QUESTLOG_REMOVE_QUEST due to mashing my "Abandon" button, it checks out (tested).
2015-03-14 23:53:41 +01:00
Duarte Duarte 70364a6b0c Merge pull request #14368 from DJScias/opcodes
Core/Packets: updated and enabled CMSG_QUESTGIVER_ACCEPT_QUEST
2015-03-14 21:43:44 +00:00
Duarte Duarte 1ab186070f Merge pull request #14352 from Luzifix/opcode-2
Core/PacketIO: updated and enabled CMSG_SET_TITLE
2015-03-14 21:43:28 +00:00
DJScias 0d050bb112 Core/Packets: updated and enabled CMSG_QUESTGIVER_ACCEPT_QUEST 2015-03-14 22:17:57 +01:00
Shauren 62f0847ebb Core/Player: Updated sending completed quests data to client 2015-03-14 19:47:07 +01:00
Luzifix b3a8e13c1e Core/PacketIO: updated and enabled CMSG_SET_TITLE
Thx @DJScias for help
2015-03-14 15:09:44 +01:00
Vincent-Michael 291d23e5f5 Core/PacketIO: Enable some opcodes 2015-03-14 14:33:30 +01:00
Vincent-Michael d9e4942a75 Core/PacketIO: Sync with wpp 2015-03-15 01:13:46 +01:00
Carbenium c68449f49e Core/Emote: Fix an issue with EMOTE_STATE_READ, which persisted after closing the map 2015-03-13 22:44:23 +01:00
Vincent-Michael 04020e717c Core/SupportMgr: Fix static analysis issue 2015-03-13 21:12:18 +01:00
MitchesD 8c329aff72 Core/PacketIO: updated and enabled CMSG_CANCEL_CAST 2015-03-13 17:19:33 +01:00
Epicurus4 a860c62fed Core/Loot: Update and enable SMSG_LOOT_RESPONSE
Also correct SMSG_NOTIFICATION initializaiton.
2015-03-12 23:42:26 -04:00
Carbenium 5feee1e69b Merge pull request #14344 from DJScias/opcodes2
Core/Packets: Update & enable more opcodes (names inside)
2015-03-13 01:18:39 +01:00
DJScias 72e549be50 Core/Packets: updated and enabled SMSG_CANCEL_AUTO_REPEAT, SMSG_CANCEL_ORPHAN_SPELL_VISUAL, SMSG_CANCEL_SPELL_VISUAL, SMSG_COIN_REMOVED
Documentation used:
- Updated and enabled the before-mentioned opcodes.
- "SMSG_CANCEL_AUTO_REPEAT" also switched from PackedGuid to ObjectGuid as per @DDuarte's suggestion.
- Changed initial size of "SMSG_SELL_RESPONSE" packet and default initialized SellResult Reason. Thanks @Lordron.

Cleaning up latest commit.
2015-03-13 00:49:44 +01:00
Duarte Duarte 50be8a4f01 Merge pull request #14342 from DJScias/opcodes_emotes
Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_E...
2015-03-12 23:45:01 +00:00
Duarte Duarte ba2d06a71b Merge pull request #14333 from Naios/static1
Core/Log: Fix some issues detected by static analysis.
2015-03-12 23:43:22 +00:00
jackpoz 1275774646 Revert "Core/SupportMgr: Fix static analysis issue"
This reverts commit 04020e717c.

Initializing a std::string with nullptr is not allowed by C++11 standard
and trigger runtime exceptions.
2015-03-12 21:52:59 +01:00
DJScias 5dddfbdb7b Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_EMOTE, CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE
Documentation used:
- Enabled CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE to 6.1
- Changed CMSG_EMOTE from "0x0B2B" to "0x0B2C". It sends an empty packet but it's meant to stop the current emote as per @Zedron's sniffs.
- Updated structure and enabled CMSG_RANDOM_ROLL and SMSG_RANDOM_ROLL. Thanks @rocverde for providing sniffs.

Cleaning up last commit
2015-03-12 16:51:39 +01:00
Epicurus4 ef54ee52e2 Core/Formatting: White space clean-up. 2015-03-12 10:52:46 -04:00
Epicurus4 b306c7c6cf Core/Loot: Enable setting AcquireReason, correct LootMethod definition, fix structure to match sniffs of retail and correct threashold and reason definitions. 2015-03-12 10:39:33 -04:00
Carbenium ebc226cdac Merge pull request #14343 from DJScias/opcodes1
Core/Packets: updated and enabled SMSG_SELL_RESPONSE
2015-03-11 21:24:29 +01:00
jackpoz b35578bac3 Revert "Core/Server: Catch exceptions in int main()"
This reverts commit e68ca82d4d.

Closes #14329
2015-03-11 21:07:08 +01:00
DJScias 30bef643fd Core/Packets: updated and enabled SMSG_SELL_RESPONSE
A typo that slipped in, damnit
2015-03-11 20:54:27 +01:00
Carbenium 62e2d8e971 Merge pull request #14334 from Naios/static2
Core/Game: & Core/Scripts: Fix some issues detected by static analysis.
2015-03-11 20:22:46 +01:00