Commit Graph

26517 Commits

Author SHA1 Message Date
Artamedes 8fbaab7337 Scripts/Ulduar: Fix Stormcaller Brundir walking into walls (#23755)
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls

* Cleanup and fix logic + review

* Review: remove autos

(cherry picked from commit 876a848730)
2021-12-18 21:44:43 +01:00
Artamedes 0b43b43566 Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter (#23761)
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter

* qq

* qq 2

* tryfix circleci build

* review suggestions

(cherry picked from commit 832c95fa4f)
2021-12-18 21:41:10 +01:00
Artamedes e4607725dd Scripts/Outland: Change auto to TempSummon* (#23764)
(cherry picked from commit 1b095811b8)
2021-12-18 21:37:15 +01:00
Artamedes 913f0903a3 Scripts/Outland: Fix npc_ancestral_wolf not starting waypoint (#23763)
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons

* fix nopch

(cherry picked from commit 0b3a9e2a2b)
2021-12-18 21:37:02 +01:00
Artamedes 00ba5df52b Core/Handlers: Handle CMSG_REQUEST_PET_INFO - this fixes when you /reload and the pet bar disappears (#23762)
(cherry picked from commit 6ebe1afeec)
2021-12-18 21:35:41 +01:00
jackpoz 18d1f0c964 Core/Creature: Fix another pet assert
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell

(cherry picked from commit 4074cb0f01)
2021-12-18 21:32:51 +01:00
Treeston 0bffed380d Scripts/ICC: Professor Putricide no longer tries to add threat on units it cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727.
(cherry picked from commit 23fd193e4e)
2021-12-18 21:31:31 +01:00
AlιAѕѕaѕѕιN e1598fa1d6 [3.3.5] Fix spell_area not checking for zoneID for quests (#23719)
* Fix spell_area not checking for zoneID for quests

* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8

* Fix spell_area handle same spell with the same quests

Also fix not checking for quest_end at all.

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7

* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d

(cherry picked from commit 92d83c3c2e)
2021-12-18 21:31:17 +01:00
Keader 9d3dd3db84 nopch fix
(cherry picked from commit 10f6e38185)
2021-12-18 21:18:56 +01:00
Keader f2e03dc9e5 Core/Scripts: Proper fix Gal'Darah Puncture remove
(cherry picked from commit cbc01f35b6)
2021-12-18 21:18:44 +01:00
Keader b7503b6c76 Fix nopch build
(cherry picked from commit 1886507e7f)
2021-12-18 21:16:51 +01:00
Keader 2d0d0a3e58 Scripts/Gundrak: Fixed Puncture when Gal'darah die
(cherry picked from commit 130a3859ec)
2021-12-18 21:16:40 +01:00
Keader 7c2665bdca Scripts/Gundrak: Added a missing entry in Gal Darah Stampede Charge script
Noob Keader, Shame !

(cherry picked from commit 61ad87d106)
2021-12-18 21:15:40 +01:00
Sorikoff 374db51bae Scripts/Spells: Code style adjustments for druid scripts (#23725)
(cherry picked from commit 63bbf4a4be)
2021-12-18 21:14:53 +01:00
Sorikoff 568e60ef51 Scripts/Spells: Port druid scripts to new script registration syntax (2 of 3) (#23696)
* Scripts/Spells: Port Druid Scripts to New Script Registration

* Revert

* Revert 2

* Revert 3

* Revert 4

(cherry picked from commit 9a8a01925a)
2021-12-18 21:11:58 +01:00
Shauren a995e5fda4 Tools/Misc: Document strange array access indexing
Closes #23723

(cherry picked from commit aa0d468e04)
2021-12-18 21:00:21 +01:00
jackpoz 6989141e71 Core/Misc: Fix linux build
(cherry picked from commit c4cce31a13)
2021-12-18 20:58:07 +01:00
jackpoz bea0e48531 Core/MMaps: Fix mobs evading when target is out of MMap meshes
Fix mobs evading when target is out of MMap meshes causes by an overzealous check added in c602220e02 when trying to fix an infinite loop in Recast.
If the target is outside of the MMap mesh (for example very close to a wall which is an un-walkable area with current TrinityCore settings and that might be changed in the future) Detour will not be able to find the height of the poly and getPolyHeight() will return DT_FAILURE | DT_INVALID_PARAM . Most of the time this is ok and can be ignored and it's still better than having the Unit evade.
Fix #23613

(cherry picked from commit 5a98022649)
2021-12-18 20:57:57 +01:00
Shauren 8f3904f8fd Core/Map: Kill zoneId from RespawnInfo, all it did was significantly slow down startup to make one gm command faster
(cherry picked from commit 3a4216fd97)
2021-12-18 20:57:38 +01:00
Keader 47659e219a Core/Spells: Fixed some issues with Drain Soul
Issue 1: Drain soul was always negative, but effect2 need be positive.
Issue 2: Drain soul was interrupted if someone in your group die. Caused by negative effects proccing in creature.
Issue 3: Since effect2 is positive, it was down-ranking in low level targets and should never happens (fixed before by ariel, transforming everything in negative in 2c8a6fb771 but it's wrong)

(cherry picked from commit 43c08b1761)
2021-12-18 20:43:05 +01:00
Sorikoff 6cf301d4f6 Scripts/Spells: Port druid scripts to new script registration syntax (3 of 3) (#23714)
(cherry picked from commit f7793e7800)
2021-12-18 20:42:13 +01:00
Keader 24281a5323 Core/Spells: Fixed SPELL_EFFECT_DISPEL when target has 2 spells with same ID (#23710)
Ty sirikfoll for all help :)

(cherry picked from commit 95284b23d1)
2021-12-18 20:32:42 +01:00
Treeston 97bf9278a8 Entities/Creature: Fix an edge case assertion failure with pets dying in specific situations while casting spells.
(cherry picked from commit 6590a0bfce)
2021-12-18 20:31:57 +01:00
Aokromes fc7ea18039 Core/Spells: Survey Sinkholes will now have a bigger range to be able…
… to hit all trigger npcs

By Ovahlord

(cherry picked from commit 028db8432e)
2021-12-18 20:31:45 +01:00
Treeston e0e1978b08 Entities/Player: ReacquireSpellFocusTarget is now private. It should've been private all along.
(cherry picked from commit 1c2b1cbba8)
2021-12-18 20:29:29 +01:00
Treeston 4b588694ca Core/Creature: Fix an issue that sometimes prevented spellcast focus targets from being reacquired.
(cherry picked from commit fcce90508d)
2021-12-18 20:29:05 +01:00
Shauren c5244d4e66 Core/Bnetserver: Added --update-databases-only console argument to bnetserver 2021-12-18 20:26:44 +01:00
Treeston 0b61c3b7b1 [3.3.5] Core/Authserver: TOTP rewrite: (PR #23633)
- Proper management commands (.account 2fa)
- Secrets can now be encrypted (set TOTPTokenSecret in .conf)
- Secret now stored in binary
- Argon2 and AES primitives
- Base32/64 support

(cherry picked from commit 4211645834)
2021-12-18 20:24:50 +01:00
Treeston f434241305 Core/Channels: Fix a bug that would cause channel settings to disappear in certain settings. Fix a bug that would cause channels to not be saved on .server shutdown without delay. Closes #23699.
(cherry picked from commit 464b0b059b)
2021-12-18 19:16:47 +01:00
Sorikoff 66f5275d26 Scripts/Spells: Runic Healing Injector (#23690)
* Scripts/Spells: Runic Healing Injector

* Rename 9999_99_99_99_world.sql to 2019_08_08_00_world.sql

(cherry picked from commit 382f563571)
2021-12-18 19:15:11 +01:00
Sorikoff 26f0c1182a Scripts/Spells: Port Part of Druid Scripts to New Script Registration (#23691)
(cherry picked from commit 996d4f7cc4)
2021-12-18 19:11:34 +01:00
Treeston 7704d8fc7a Scripts/Commands: Add .go boss, and do a usability pass over .go instance to match it.
(cherry picked from commit 57b36dfdc6)
2021-12-18 16:13:24 +01:00
Treeston c7e7c52c1a Scripts/Commands: Cleanup some output from .go instance
(cherry picked from commit 4320a021e9)
2021-12-18 16:00:20 +01:00
Treeston dcf9854e6a coverity
(cherry picked from commit 268384d2af)
2021-12-18 15:49:44 +01:00
Treeston a8ceed265a typo fix in comment
(cherry picked from commit 4fcb322010)
2021-12-18 15:47:18 +01:00
ccrs 31bf529667 Core/Creature: 4a219ed codestyle followup, for real this time
(cherry picked from commit 30f4aabf64)
2021-12-18 15:39:58 +01:00
Sorikoff cd0fb6edbf Scripts/Blackrock Depths: Use DB Texts for Doom'rel (#23681)
* Scripts/Blackrock Depths: Use DB Texts for Doom'rel

* Quick Fix

(cherry picked from commit 33807a065a)
2021-12-18 15:36:00 +01:00
Treeston 28942db431 Common/Util: Sorry about that unexpected downtime at 3AM last night, everyone. (We call them happy little features.)
(cherry picked from commit a4d5b24874)
2021-12-18 15:33:44 +01:00
Treeston 51fbda4223 Core/Pooling: Quest pooling rewrite: (PR#23627)
- Split quest pooling from PoolMgr (into QuestPoolMgr)
- Proper saving/restoring on server restart
- No more hacking into sObjectMgr to insert/remove available quests

(cherry picked from commit a5e73e41c0)
2021-12-18 15:28:45 +01:00
Giacomo Pozzoni 6d5086da17 Core/Vehicle: Change vehicle accessories' phase according to the player on the vehicle (#23646)
* Core/Vehicle: Change vehicle accessories' phase according to the player on the vehicle

* Get the root vehicle to set the phase to all accessories. Attempt to get the accessories to stay mounted on the vehicle.

* Fix the accessories to stay mounted on the vehicle

(cherry picked from commit 15e85f882f)
2021-12-18 14:08:25 +01:00
Treeston a90073dadd no idea what happened there (4a219ed follow-up)
(cherry picked from commit b159921099)
2021-12-18 11:37:33 +01:00
Treeston a18268156a Core/Chat: Always save channel info to database on shutdown if persistence is enabled.
(cherry picked from commit 2d74652b5b)
2021-12-18 11:37:14 +01:00
Treeston 14c38a1c52 Core/Unit: Spell focusing now no longer nonsensical. HasSpellFocus always const. Error logs for various stuff.
(cherry picked from commit 4a219eda07)
2021-12-18 11:36:50 +01:00
Treeston 82d62a3d4c This is not the critical chat system bug fix you were looking for. No sir. (Oops.)
(cherry picked from commit 6a330214a1)
2021-12-18 11:27:02 +01:00
Treeston 87c2d247d9 Core/Misc: Rewrite some old name handling functions that use raw buffers to no longer be old name handling functions that use raw buffers.
(cherry picked from commit 309851ea24)
2021-12-18 11:25:59 +01:00
aquadeus da8d6b5180 Scripts/Spells: Fix Incanters Flow (#27395) 2021-12-18 11:24:10 +01:00
ccrs 44e9572a77 Core/Creature: add a const spell-focus-check method and remove a nasty const_cast from IsMovementPreventedByCasting()
closes #23670
maybe #22857 ?

(cherry picked from commit 8e88f4501d)
2021-12-18 00:35:14 +01:00
ccrs 4db13853f7 Core/Unit: rename more things
Workaround prework till actual facing system rework arrives

(cherry picked from commit 3a4021be50)
2021-12-18 00:34:15 +01:00
ccrs a58881d6da Core/Unit: rename more methods
Workaround prework till actual facing system rework arrives

(cherry picked from commit 85ad0befc5)
2021-12-18 00:29:38 +01:00
ccrs be4ed9152c Core/Unit: rename IsFocusing method
Workaround prework till actual facing system rework arrives

(cherry picked from commit ec9f15a5ff)
2021-12-18 00:25:14 +01:00