Commit Graph

1668 Commits

Author SHA1 Message Date
Shauren
62c2ceaff2 Core/Units: Rename AnimationTier to AnimTier for consistency with master branch 2022-03-24 20:38:55 +01:00
offl
3dca705acc Core/AI: OnSpellCast, OnSpellFailed, OnSpellStart hooks (#27704) 2022-02-18 19:14:44 +02:00
Shauren
645b41ebb9 Core/Units: Sync ProcessTerrainStatusUpdate code with master branch 2022-01-01 12:34:42 +01:00
Giacomo Pozzoni
19e99db821 Core/AI: Fix crashes caused by charmed Creatures having null AI for 1 map update tick (#27434)
Implement using ScheduledChangeAI instead of nullptr to signal a required AI change
2021-12-27 13:33:37 +01:00
Shauren
9174281b92 Core/Auras: Properly clean up partial charm applications
Ref #24876
2021-11-27 16:36:04 +01:00
Lucas Nascimento
0cc0b3f926 Core/Combat: Fixed combat after remove charm (#27248)
https://github.com/TrinityCore/TrinityCore/pull/27038#issuecomment-958784361
2021-11-06 10:24:32 -03:00
Keader
9b354c6beb Core/Unit: Fixed wrong combat stop when set charm 2021-10-30 11:08:56 -03:00
offl
d7adc50daa Core/Scripting: Get rid of ModifyVehiclePassengerExitPos (#27126) 2021-10-20 01:04:02 +03:00
Lucas Nascimento
fa3a62ae4e Entities/Unit: Fixed wrong combat stop when remove charm (#27038) 2021-10-17 17:02:38 -03:00
Lucas Nascimento
63c6f7bc26 Core/Unit: Fixed Deterrence stopping working for no reason (#26996) 2021-10-10 12:39:38 -03:00
trickerer
084f8f3ded Core/Combat Improve extra attacks handling (#26859)
* Core/Combat Improve extra attacks handling

* Remove unnecessary _lastDamagedTargetGuid check

* Add missing initialization of _lastExtraAttackSpell. Do not use hardcoded spell ids.

* Partially revert 9f90b835019b
2021-10-01 16:40:20 +02:00
Ovah
e317beb449 Core/Units: removed an incorrect addition of SPELL_AURA_MOD_CRIT_CHANCE_FOR_CASTER crit chance benefits (#26873)
This aura, as the name implies, should only affect the spells that it has listed in its class mask. Because the removed code was not doing so, it applied the crit chance on ALL melee and ranged spells. This fixes Stormstrike unintentionally increasing the crit chance for all melee attacks instead of the affected spells only
2021-10-01 16:38:29 +02:00
offl
e4a82ee97a Core/Misc: Rename UNIT_FLAG_SWIMMING to UNIT_FLAG_CAN_SWIM
Ref #26912
2021-09-16 21:15:52 +03:00
offl
c4741a131a Core/Misc: Rename UNIT_FLAG_NOT_SELECTABLE to UNIT_FLAG_UNINTERACTIBLE (#26913) 2021-09-15 01:04:03 +03:00
Shauren
e50102178b Core/Spells: Spell effect info access refactoring part 3 - removed direct SpellInfo::Effects field access from game 2021-08-31 00:13:44 +02:00
Shauren
7440c9cf19 Core/Spells: Removed SpellEffIndex effIndex argument from spell effect handlers 2021-08-30 23:51:37 +02:00
Gildor
0fad28e4ab Core/Unit: improve SPELL_AURA_MOD_IMMUNE_AURA_APPLY_SCHOOL immunities (#26849) 2021-08-30 11:19:32 +02:00
Shauren
6573395f24 Core/Spells: Spell effect info access refactoring part 2 - passing SpellEffectInfo as arguments directly instead of SpellInfo + effect index 2021-08-29 21:12:49 +02:00
Shauren
4c59532865 Core/Spells: Begin unifying spell effect access api with master branch
* Introduce SpellInfo::GetEffects and SpellInfo::GetEffect functoins
2021-08-28 23:42:25 +02:00
Giacomo Pozzoni
0800ab20a8 Core/AI: Add DamageEffectType and SpellInfo parameters to UnitAI::DamageTaken (#26787)
* Core/AI: Add DamageEffectType and SpellInfo parameters to UnitAI::DamageTaken

* Update scripts
2021-08-09 17:00:34 +02:00
offl
06b554c36e Core/Creature: rename CREATURE_FLAG_EXTRA_IGNORE_COMBAT into CREATURE_FLAG_EXTRA_CANNOT_ENTER_COMBAT (#26762)
Co-authored-by: offl <offl@users.noreply.github.com>
2021-07-30 09:36:38 +02:00
Gildor
bd6de8eb61 Core/Spells: defined and implemented SPELL_ATTR7_CANT_DODGE, SPELL_ATTR7_CANT_PARRY and SPELL_ATTR7_CANT_MISS (#26742) 2021-07-24 14:48:57 +02:00
jackpoz
3f08c16749 Core/Unit: Add more logs for #26325
Add more logs to try spotting the cause of #26325 . It might be that a minion is added to a owner that is not in world.
Report any issue with minions/pets that contain the log.
2021-07-21 20:49:37 +02:00
jackpoz
40f4b141bd Core/Unit: Include m_Controlled in crashlogs 2021-07-11 11:55:23 +02:00
jackpoz
479c636612 Core/Movement: Include GetGameClientMovingMe() details in assert logs 2021-07-04 19:40:28 +02:00
Chaouki Dhib
d337fb99ed Core/Movement: Implement proper player speed change (#26561) 2021-06-15 23:09:48 +02:00
Giacomo Pozzoni
9fe9dc087b Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH (#26549)
* Core/Movement: Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH

Add new flag MOVEMENTGENERATOR_FLAG_PERSIST_ON_DEATH to keep movement generators even after death.

Fixes #23095
Could replace ff26027453

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Core/Movement: reorder new method MotionMaster::StopOnDeath

* Keep MoveJump movement generator after death

Co-authored-by: ccrs <ccrs@users.noreply.github.com>
2021-06-06 17:51:00 +02:00
jackpoz
af815e991d Core/Player: Log more information when Player::StopCastingCharm() fails 2021-06-05 18:41:51 +02:00
Chaouki Dhib
19fa411431 Core/Movement: Hotfix the crashes that can occur in the movement handlers (#26538) 2021-05-22 14:54:58 +02:00
Chaouki Dhib
2d114ea560 Core/Movement: Improve client control logic (#26348) 2021-05-16 13:16:08 +02:00
Shauren
2f04c48919 Core/PacketIO: Reduce size of SMSG_UPDATE_OBJECT by trimming trailing zeros in values updatemask 2021-04-25 14:56:25 +02:00
offl
e6d9d9ead9 Core/Misc: Define / rename attributes and flags (#26315)
Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
2021-04-08 19:28:02 +03:00
Metalaka
69916138bd Core/Unit: Fix glancing blow calculation (#26120)
* Fix glancing blow calculation

* Comment readability improvement

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/game/Entities/Unit/Unit.cpp

Co-authored-by: Metalaka <Metalaka@users.noreply.github.com>

* Tabs to spaces

Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2021-02-21 17:28:47 +01:00
jackpoz
8014fa1a2f Revert "Core/Unit: Improve Glancing Blow calculation (#26100)"
This reverts commit c3165dce31.
2021-02-20 15:21:38 +01:00
Metalaka
c3165dce31 Core/Unit: Improve Glancing Blow calculation (#26100)
* Core/Unit: Improve Glancing Blow calculation

* Fix minimum reduction of Glancing Blow

* Fix comment

* Fix glancing minimum damage reduction
2021-02-19 18:13:10 +01:00
jackpoz
b84b925063 Core/Unit: Fix crash when exiting a vehicle
Ref #25649
2021-02-06 11:36:56 +01:00
jackpoz
4cc1f85067 Core/Unit: Set stand state on damage only to players 2021-02-06 11:20:32 +01:00
Shauren
ee330be5c8 Build fix
(cherry picked from commit 28d470c50e)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
2021-01-17 17:29:59 +01:00
Giacomo Pozzoni
fc1a0d9368 Core/Unit: Fix movement hiccups in water (#24020)
* Core/Unit: Allow to define Units which can enter water but cannot swim

Allow to define Units which can enter water but cannot swim, i.e. crabs walking at the bottom of a sea.

* Add UNIT_FLAG_SWIMMING to creatures when entering combat

* Fix charmed creatures not entering water

* Always allow Creatures controlled by players to enter water

* Add swimming flag when possessing a unit and remove it properly at the end, even if the creature engaged combat before and after.
When adding/removing UNIT_FLAG_SWIMMING manually calling Creature::RefreshSwimmingFlag(true) might be required.
2021-01-10 10:18:51 +01:00
Sevi
6392d9ac48 Core/Vehicles: add a way to delay the Vehicle despawn Time if its needed.
* New database table `vehicle_template` holds info for despawn delay with option to extend it in the future

(cherry picked from commit c7b10d3c5f)

# Conflicts:
#	src/server/game/Entities/Unit/Unit.cpp
#	src/server/game/Entities/Vehicle/Vehicle.cpp
#	src/server/game/Globals/ObjectMgr.cpp
#	src/server/game/Globals/ObjectMgr.h
2021-01-03 22:10:55 +01:00
Aurelio Arcabascio
4ea64b515a Core/Player: auto-attacked player stands up from sit or sleep state (#25684)
* Fixed Auto Attack bug on sitting player

* Victim now stands during sleep and stand emotes
2021-01-02 19:10:26 +01:00
Ovah
527db2170b Core/Units: do not send power update packets when gaining power via energize spell effects to match retail behavior (#25599)
This fixes possible clientside visual issues where power is being added twice until the next update_object packet is being sent
2020-12-27 00:05:37 +01:00
Ovah
77aa058504 Core/Spells: unify OnSpellCastInterrupt and OnSuccessfulSpellCast hooks into OnSpellCastFinished (#25522)
* added support for calling the hook when completing a channeled spell as well
2020-10-03 00:48:32 +02:00
Ovah
e811b9cdc2 Core/Movement: fix units falling through the ground when hover mode is disengaged (PR #25518) 2020-10-01 04:41:08 +02:00
Shauren
d29274f3a1 Core/Pets: Fixed crash happening when summoning a different pet than one that was unsummoned by summoning a guardian (imp -> infernal -> felhunter)
Closes #25478
2020-09-23 22:37:11 +02:00
Treeston
bb3d3a82d7 Core/Movement: MoveSplineFlag::animId -> animTier, MoveSpline::GetAnimation() -> GetAnimationTier(), dad1876 follow-up 2020-09-08 17:32:35 +02:00
NoName
dad187615d Core/Movement: Corrected Animation Tier handling (PR #24875)
Co-authored-by: Warpten <vertozor@gmail.com>
Co-authored-by: Ovahlord <dreadkiller@gmx.de>
Co-authored-by: Carbenium <carbenium@outlook.com>
2020-09-08 17:12:52 +02:00
Giacomo Pozzoni
ff26027453 Core/Unit: Fix units on vehicles not dismounting on death (#25404)
* Core/Unit: Fix units on vehicles not dismounting on death

Closes #23095
Issue added in 982643cd96

* Remove leftovers from previous tries
2020-09-05 22:07:17 +02:00
Shauren
1e446b021b Core/Players: Directly store PlayerSpell in m_spells, not as pointer
Closes #25402
2020-09-05 18:00:00 +02:00
Treeston
88d446dadf Scripts/Commands: Convert argument parsing of .npc commands
(And I snuck some chat command cleanup in there, more de-cluttering!)
2020-09-04 00:58:23 +02:00