Commit Graph

3778 Commits

Author SHA1 Message Date
Aokromes 61ba477c77 Core/Creature: equipment_id field on creature table is not working correctly, if it's set to 0 the npc still spawn with the equipement. (#23273)
By Malcrom
Closes #16416
2019-05-15 23:12:38 +02:00
jackpoz df7f166e5e Core/Misc: Fix GCC 8 warning 2019-05-11 19:46:23 +02:00
brotalnia 49d0a5bbb6 Core/Spells: Return CheckCast result from CastSpell (#23236)
* Return CheckCast result from CastSpell

* Return cast result from UnitAI methods too.
2019-05-10 18:58:26 +02:00
Wyrserth 49dc8a8e44 Core/Quest: improve source item deletion logic for items that give quests (#23250)
* Core/Quest: improve source item deletion logic for items that give quests.

Prevent deletion of items that aren't supposed to be destroyed (like Demon Scarred Cloak).

* Whoops.
2019-05-10 17:49:46 +02:00
Wyrserth b76bcc836c Core/Achievement: fix mistake related to ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM. (#23252) 2019-05-07 19:49:25 +02:00
Wyrserth 0a25069db4 Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill. (#23249) 2019-05-07 10:45:37 +02:00
Giacomo Pozzoni 06d8f4dc78 Core/Misc: Fix no-pch build 2019-05-07 09:41:44 +02:00
jackpoz 991b2a11bd Core/Misc: Log Map name in asserts 2019-05-06 21:00:59 +02:00
jackpoz a76d01278a Core/Misc: Apply fatigue when flying too
Fix #22856
2019-05-04 19:36:00 +02:00
Killyana fd166025c8 Remove Deprecated code 2019-05-04 16:11:50 +02:00
Giacomo Pozzoni d4414af2d4 Core/Vehicles: Fix multiple vehicle join events on same seat (#23233) 2019-05-03 22:15:30 +02:00
Jozef Dúc 78070163dc Core/Object: Range check vol. 2 (#23226)
* Core/Object: Fix all missing parts for #23062

* Update GameObject.cpp
2019-05-02 21:53:12 +02:00
ccrs 69c15f5ae7 Core/Creature: couple refactors/renaming 2019-05-01 14:08:52 +02:00
ccrs dfa54d3bf4 Core/Object: re-change faction template related logs 2019-04-29 22:48:45 +02:00
ccrs aee26eb467 Core/Misc: standarize a couple logs 2019-04-28 19:41:30 +02:00
jackpoz f45ebe71b0 Core/Misc: Fix *nix build 2019-04-28 18:53:01 +02:00
jackpoz 70fcdc687d Core/Pet: Change assert to error log
Change assert added in 43dec9e4d0 to error log since charmed creatures lose their AI until next map update
2019-04-28 18:47:19 +02:00
jackpoz f26f716714 Core/Commands: Fix .cheat god command letting you die
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff
2019-04-27 14:40:28 +02:00
jackpoz 1c833f28e4 Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon()
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).
2019-04-27 13:57:46 +02:00
Jozef Dúc 32e1de39a2 Core/Object: Range check (#23179)
* Should solve #23062. All credits to @xvwyh

* Remove unused variables

* Remove unused variable

* Cast int32 to uint32

* Remove G3D headers from core header file

* Change door distance

* Update GameObject.cpp

Add newline

* Update GameObject.h

Indentation
2019-04-24 20:39:01 +02:00
jackpoz 16a154c4e8 Core/GameObject: Code cleanup 2019-04-24 20:33:04 +02:00
Killyana 9db64666dc Core/GameObject: Remove summoned gobs properly from the map without effecting other cases
Ref https://github.com/TrinityCore/TrinityCore/commit/0e8e3828f48120629b642d0de1db704fd0bb86cb
Ref #23115
2019-04-24 20:08:07 +02:00
Killyana 21667f97cb Indentation 2019-04-23 16:50:39 +02:00
Killyana 65afe47580 Indentation 2019-04-23 16:49:32 +02:00
Killyana 0e8e3828f4 Core/GameObject: Delete summoned gobs and DestroyForNearbyPlayers gobs spawned with negative spawn time once the gob is deactivated 2019-04-23 16:43:49 +02:00
jackpoz f88a5b12bd Core/Database: Delete gameobject_addon data when deleting a GameObject from the database
Close #23076
2019-04-17 21:01:32 +02:00
Chaouki Dhib 975f1e364a Core/Movement: Add time synchronisation (#18189) 2019-04-15 23:31:25 +02:00
ForesterDev 2a6eef76e2 Core/Social: Separated checks for friend and ignored limits (#23181)
* Core/Conditions: implement CONDITION_GAMEMASTER

* Core/Social: Separated checks for friend and ignored limits

* Prevent duplication of contacts

* Limit values should be included in counters

* Codestyle and comments
2019-04-15 15:25:08 +02:00
Jozef Dúc f221fcdd4b Core/Creatures: Filter out trainer spells that belong to a skill that can never be learned by a player with given class and race combination (#23176)
Closes #23172
2019-04-11 21:06:53 +02:00
PolarCookie 5ed77113b6 Core support for breadcrumb quests (#23157)
* Breadcrumb quests support in core

* To Winterspring! & Starfall

* translating ZenoX92's list, part 1

* Carendin Summons is Blood Elf only

* Breadcrumb to an exclusive group

* translating ZenoX92's list, part 2

* class quests

* breadcrumb trails

* better prevquest check

* less harsh error warnings

* minor optimization

* Rename 9999_99_99_99_world.sql to 2019_04_10_00_world.sql
2019-04-10 12:58:40 +02:00
Jeremy 9fcbd8f15d Core/Movement: Fix some undermap issues with random movement/fear/blink (#22937)
* Core/Movement:
- Only move to point if there is a path that is not a shortcut (which will make the unit move through terrain)
- Added new function to check if there is a vmap floor without search distance
- Units that can fly, are underground but far above the vmap floor will stay underground (bronze drakes in tanaris)
- Don't remove PATHFIND_SHORTCUT from path type in some cases

* Core/Object: Ignore UpdateAllowedPositionZ for flying units.

- This will make flying units go through mountains instead of going to the top and back to the bottom to reach you.

* Core/Object: Revert some changes and let MovePositionToFirstCollision deal with a position without ground

* Missing groundZ change for objects on transport

* use CanFly instead of IsFlying
2019-04-07 20:15:40 +02:00
PolarCookie 73e3fdc8b4 Core: VehicleJoinEvent crash fix (#23136) 2019-04-07 20:04:14 +02:00
Ovah b9e9ccf93c Core/Objects: use the actual collision height of players and creatures to get more accurate liquid status results (#23070) 2019-04-06 17:39:04 +02:00
Killyana c52eb49f71 Core: Remove wrong emotes played in combat
Ref #23152
2019-04-04 15:36:29 +02:00
jackpoz 1d04a3b216 Core/Misc: Fix GCC 8 warnings 2019-03-31 17:34:28 +02:00
sirikfoll dbfc6ce773 Core/GameObject: Properly dismount players on GameObject Use
Closes #23124
2019-03-30 21:30:58 -03:00
Shauren fe0abfe985 Core/PacketIO: Fixed mistake in setting packet value for SMSG_MULTIPLE_MOVES 2019-03-30 15:44:56 +01:00
Shauren c5ab22b6ed Core/PacketIO: Send movement state change packets only once, not for each player whose visibility we enter
Closes #23141
2019-03-29 23:26:51 +01:00
PolarCookie a926a3088d Core/Item: Item Signature (#23119) 2019-03-23 14:34:37 +01:00
Killyana 5f04c829a8 Core/GameObject: Remove summoned game objects from the map after calling SetSpawnedByDefault(false) (#23120)
Closes #23115
2019-03-18 01:04:38 +01:00
Killyana 750be73b99 SAI/GameObject: Despawn the linked trap with the gameobject
Closes #23105
2019-03-09 21:11:21 +01:00
Shauren 9d34739d69 Core/PacketIO: Fixed wrong opcode being sent for stunned creatures 2019-03-08 19:22:34 +01:00
PolarCookie ec3cb05d7f Core/Spell: SpellAura Redux (#22794)
* typo and correction

* spell aura no longer shared between targets

_spellAura isolated

* SPELL_AURA_CONTROL_VEHICLE is not strictly single target spell

Steam Tank Control and Wyrmrest Commander

units can reseat themselves again

* Rename 9999_99_99_99_world.sql to 2019_03_08_00_world.sql
2019-03-08 08:34:16 +01:00
Gustavo 0eacccc2cd Core/Players: Fix logic in CanSeeSpellClickOn (#23090)
Block SpellClick for the npc if there is no entry
2019-03-05 15:06:19 +01:00
ccrs 7fdf9701df Core/Misc: e69570d followup 2019-03-04 16:52:10 +01:00
ccrs e69570dd76 Core/Misc: use/implement/portfrommaster InitWorldState packet definition
WorldPackets::WorldState::InitWorldStates
2019-03-04 16:33:08 +01:00
Sorikoff 34cfa69efd Core/Movement: Allow using run when moving randomly (#23081)
* Allow run when moving randomly
2019-03-03 19:54:07 +01:00
Killyana 8dec9b97e2 Core/GameObject: Set loot state to Not ready when a gob is deactivated (#23072) 2019-03-02 15:05:28 +01:00
Sorikoff dbadb6369c Core/Movement: Allow using walk when chasing v2 (#23073)
* Allow walk when chasing
2019-03-02 15:04:01 +01:00
Gustavo 2dfea54533 Core/Units: Only update height in SetHover if unit is bellow HoverHeight (#23061) 2019-02-23 11:42:20 +01:00