Commit Graph

12661 Commits

Author SHA1 Message Date
Treeston 92e9376e5e Core/Creature: temporary summons are now dynamic flagged (oversight in dynspawn). This fixes issues with vehicle kit resets breaking AI.
Closes #20137 #20138 #20153.
2017-08-21 17:40:47 +02:00
Treeston cac99beffd Scripts/Commands: .npc delete and .gobj delete now work while the specified guid is despawned. Fixes #20145. 2017-08-21 17:07:53 +02:00
Treeston 165bc02889 Scripts/Auchindoun: Fix a super edge case crash bug with GM far teleports during Blackheart's charm phase. Follow-up to d80d7c6. 2017-08-21 16:44:33 +02:00
Keader 76fc9ed635 Core/Scripts: Updated Razorscale to new registers model
* More codestyle fixes
* Ty sirikfoll :)
2017-08-20 22:23:32 -03:00
Keader 203c5f7058 Core/Razorscale: Codestyle Updates
* Removing spelldifficulty_dbc to make portable to master
* Updated to new Spell/Aurascript model
2017-08-20 17:38:47 -03:00
Foereaper 6f4492bc61 Scripts/Naxxramas: Fix Heigan the Unclean eruption event (#20129)
By scheduling the eruption event without cancelling the previously registered eruption events, Heigan's eruption (or dance) would overlap and cause a runaway scenario, where eruptions would not follow a proper timer.

By using Reschedule and not locking the Eruption event to the fighting phase, the dance now works as intended.
2017-08-20 18:16:23 +02:00
Aokromes fe2db07313 Core/Conditions: Rename CONDITION_SOURCE_TYPE_QUEST_ACCEPT to CONDITION_SOURCE_TYPE_QUEST_AVAILABLE
By Malcrom
2017-08-20 12:59:02 +02:00
Aokromes 75951f5472 Core/Misc: Removed obsolete comment 2017-08-20 07:16:07 +02:00
Shoxxo 7754960e39 Core/config: add MonsterSight setting to worldserver.conf.dist
* Updated MonsterSight (What does it)

* Core/Worldserver: Update worldserver.conf.dist

Now it should be corectly ;)

* Relocated and renamed the MonsterSight!
2017-08-19 21:21:39 +02:00
Gustavo 22a7956069 Core/Scripts: More fixes in boss Lich King (#20147)
* Core/Scripts: More fixes in boss Lich King

Fix Valkyr charge spell, they will no longer ignore Z position and become unreachable.
Correct height of Spirit Bomb and added the 3 seconds delay on his explosion.
Set the Trigger inside frostmourne room as active, to avoid problems with reseting the room, e.g: Spirit Bombs not despawning and Wicked Spirits stuck in evade.
Use correct InhabitType for Wicked and Vile Spirits, this avoid a situation where they could spawn falling.
2017-08-17 12:03:56 -03:00
Demonid 7b747848ed Scripts/Icecrown Citadel: Fixed Lord Marrowgar - Coldflame to not ignore resistances (#20146)
Closes #13240
2017-08-15 11:49:34 +02:00
ccrs eb2769996f Core/Movement: 7fff83d675 followup
since MOTION_SLOT_IDLE cannot be expired, signal path done and behave like IdleMotionGenerator
2017-08-12 19:43:37 +02:00
ccrs ee5cbf28bc Core/AI: add missing checks on AssistPlayerInCombatAgainst 2017-08-12 18:19:18 +02:00
ccrs d117a0e4d4 Core/SmatAI: correct MoveInLineOfSight
mistake introduced in 15f2706aca that was masqueraded by other checks in combat start, till recent related commits
2017-08-12 17:57:13 +02:00
ccrs cd4775420a Core/Movement: 7fff83d675 followup
remove home position set from creature PauseMovement, and use it when necessary
change log level on DelayedDelete
2017-08-12 17:35:46 +02:00
sirikfoll e2565c2597 Core/Misc: Remove Whitespaces 2017-08-11 23:06:37 -03:00
ccrs 7fff83d675 Core/Movement: waypoint movement (#20121)
Following the work done in #19361 this is the cleanup and improvement of the related logic of waypoint management.

Ref 28050f3 #18020
(taking the good parts and ignoring the incomplete work)
2017-08-12 01:40:25 +02:00
Gustavo e9cd7af2df Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau) (#19897)
* Core/Scripts: Rewrite Boss Kalecgos (Sunwell Plateau)

Scripted all spells
Corrected behavior of Spectral Blast and Curse of Boundless Agony
Removed wrong wipe behavior
Fix problem where bosses would be stuck with banish
Added Boundaries
Corrected texts
Removed old hacks
Other minor fixes
2017-08-08 22:36:40 -03:00
Treeston 4cf49614e6 Core/Creature: Fix a crash in .npc delete (closes #20124). Also fix an issue breaking vehicles in certain edge case situations. 2017-08-09 00:21:52 +02:00
ccrs 4f43f4d72f Core/Movement: ee2d7c1d53 followup 2017-08-08 20:29:30 +02:00
ccrs 40903dcd65 Core/Movement: PropagateSpeedChange should only be called on the top (current active) movement generator 2017-08-08 19:49:12 +02:00
ccrs ee2d7c1d53 Core/Movement: add new helper that cleans the referenced MovementSlot 2017-08-08 19:35:13 +02:00
Demonid 9fa68855d7 Scripts/ICC: Minor Fixes for Lich King (#20120)
- Fixed Shadow Trap and Defile Targets
- Fixed Shadow Trap Summon Delay and Duration
- Fixed Berserk Timer (15 Minutes)
- Fixed Shadow Trap Despawn when Snowstorm starts
2017-08-08 11:36:46 -03:00
Keader 26b6422ded Revert "Core/Npc: Remove bytes1 once the npc start a combat"
This reverts commit 21b03e7d9b.
2017-08-07 21:55:27 -03:00
Keader d825a06830 Core/Scripts: Razorscale Rewrite (#19828)
#MakeUlduarGreatAgain
2017-08-07 21:36:19 -03:00
Treeston 184c45cfe0 Core/Scripts: dynamic_spawning follow-up, I had forgotten JustRespawned existed.
- Rename JustRespawned to JustAppeared, which better matches its behavior anyway.
- Properly invoke JustAppeared for new (re-)spawns - fixes #20111.
- Fix Thaddius script to work with dynamic_spawning (mostly unrelated to the above) - Feugen/Stalagg should really be a summon group, but I don't have time to fix that right now.
- Fix default value for DynamicEscortNPC to match worldserver.conf.dist.
2017-08-06 16:07:30 +02:00
Necropola ecf5978608 Core/Pet: Fix an issue that was causing lower ranks of pet spells to remain in DB (#20112) 2017-08-06 03:15:04 +02:00
Aokromes 92359de5ef Revert permision change 2017-08-05 09:49:43 +02:00
Necropola 906498e9f4 [3.3.5] Core/Pet: Make pet action bar autocast persist properly (#20110)
Partial revert of of 6c21ddd9b9.
Closes #16211.
2017-08-04 03:52:24 +02:00
Treeston 84590be26d Scripts/InstanceScript: Implement database framework for managing spawn groups based on boss state. (#20103) 2017-08-04 00:23:40 +02:00
Treeston 2644fa703a Core/Unit: Don't apply liquid effects to game masters. 2017-08-03 19:38:15 +02:00
Shauren 6691e41873 Core/Misc: Revert back to using boost::regex, std::wregex doesn't work for name validation
Closes #20094
2017-08-03 00:13:21 +02:00
Treeston 759357049c Scripts/Commands: Fix some quirkiness and potential crashes with live DB modification commands (npc move and npc delete), which are horrible and should be deleted anyway.
Fixes #20104.
2017-08-02 22:05:40 +02:00
Treeston c70b328eda more unneeded checks (follow-up 3b02029) 2017-08-01 18:14:55 +02:00
Treeston 3b02029cb6 remove an unused variable (follow-up fcd6fe0) 2017-08-01 17:58:17 +02:00
Treeston fcd6fe0aac Scripts/Commands: New utility command: .list spawnpoints.
(I just needed it for dynspawn follow-up work, really.)
2017-08-01 03:42:11 +02:00
Aokromes 41721642f7 NoPCH Build fix 2017-07-31 22:56:21 +02:00
r00ty-tc 59db2eeea0 Dynamic Creature/Go spawning:
- True blizzlike creature spawn/respawn behavior - new creature = new object
 - Toggleable spawn groups (with C++/SAI/command options to use them)
 - Custom feature: dynamic spawn rate scaling. Accelerates respawn rate based on players in the zone.
 - Backward compatibility mode (set via group and for summons)
   to support creatures/gos that currently don't work well with this
   (this should be removed once the exceptions are fixed)

Fixes and closes #2858
Tags #8661 as fixable.
Fixes and closes #13787
Fixes #15222.
2017-07-31 21:21:04 +02:00
Shauren d24ce1739a Core/Misc: Util changes
* Move IteratorPair to its own header
* Add AsUnderlyingType function to cast enum value to its underlying type (avoids repeating std::underlying_type everywhere)

(cherry picked from commit fdd9227b23)
2017-07-29 15:04:45 +02:00
Treeston 508c9d2fc1 Core/Chat: Provide a fully-formed protocol for addons to interact with GM commands (#20074)
Send success/fail state, allow interleaving, and indicate end of output. Add framework for supporting non-human-readable output in commands.
2017-07-28 02:45:57 +02:00
Treeston 98aa7806c4 Core/Player: Always set flight state change packets for players, even if their latest MovementInfo doesn't indicate it's needed (the MI might be outdated). Fixes a player flight exploit and closes #20079. 2017-07-25 20:00:13 +02:00
Treeston 7cbb6c101e Scripts/IcecrownCitadel: Prevent players from becoming inaccessible when killed by Lord Marrowgar's Impale spell (the initial damage, not the DoT). Also fix the underlying bug in vehicle logic. 2017-07-25 02:01:32 +02:00
ccrs 1de89579c7 Core/AI: correct Permit level for trigger flagged creatures
This broke several mechanics such as LK hc Frostmourne Room or Rotface's slime, how come no one noticed it? Like really, no one?
ref ce3787f190
2017-07-23 18:01:42 +02:00
Treeston f2f45765e4 Core/Unit: No code change, just updating a comment with insights gleaned from sniffs. 2017-07-23 02:07:18 +02:00
Treeston 28b3469e89 Core/WorldObject: Properly initialize position data for all types when initially creating them. Fixes some issues with PvP objectives not having the correct area ID set on initialization. Closes #20028. 2017-07-23 00:01:11 +02:00
Killyana 21b03e7d9b Core/Npc: Remove bytes1 once the npc start a combat
Closes #16832
By Rushor
2017-07-22 09:09:16 +02:00
Treeston 331e463de8 Core/PlayerAI: Some adjustments:
- Add a 2 second delay before the AI begins using spells. This should provide opportunity for counterplay before that rogue activates cloak and goes on an unstoppable rampage among your healers. (Sorry, guys.)
- Stopped the AI from attacking invalid targets under some conditions. It should now properly leash back and follow the charmer if we try to select an invalid target.
- Stopped the AI from constantly re-creating the follow movement generator (and thus spamming movesplines).
2017-07-21 23:00:14 +02:00
Shauren 1f63554312 Core/Auth: Fixed client getting stuck on login or realm change 2017-07-21 20:34:00 +02:00
Treeston 40c78cac4c Warning fix (c7896f3 follow-up) 2017-07-21 18:12:59 +02:00
Treeston c7896f3102 Core/Unit: For convenience, explicitly redirect CastSpell with nullptr as first argument to the Unit* overloads. No more ->CastSpell((Unit*)nullptr, ...) all over the place! 2017-07-21 18:02:48 +02:00