529cabea68
Core/Map: Save weather, light and music overrides in map to send them to players logging in
2014-03-22 19:40:36 +01:00
6dcd8c8545
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior
Please ensure EventMap is never used with event id set to 0 or those events will never execute.
2014-03-22 14:54:32 +01:00
e40d4e6f16
Scripts/Spells: fix logic fail in q9874
2014-03-22 10:04:43 +01:00
9e99db035f
Core/Misc: Fix some static analysis issues
...
Add some asserts and additional NULL checks as sanity checks.
2014-03-21 22:47:58 +01:00
33316bde38
Merge pull request #11747 from untaught/Trinity1
...
Core/Scripts: Move 'The Defias Traitor' script to SAI
2014-03-21 00:55:49 +01:00
bcf6edd50b
Merge pull request #11749 from untaught/Trinity2
...
Core/Scripts: Move condition for 'npc_marin_noggenfogger' gossip menu op...
2014-03-21 00:55:30 +01:00
9ad8c32e3d
Merge pull request #11757 from untaught/Trinity3
...
Core/Scripts: Move 'npc_deathly_usher' scripts to SAI.
2014-03-21 00:53:55 +01:00
a9121c6038
Merge pull request #11746 from untaught/Trinity0
...
Core/Scripts: Move condition for 'npc_skorn_whitecloud' gossip menu opti...
2014-03-21 00:53:12 +01:00
4c27c83efa
Core/Misc: Fix some static analysis issues
2014-03-20 21:34:05 +01:00
8a9bfbba48
Core/Scripts: Move 'npc_deathly_usher' scripts to SAI.
2014-03-20 20:29:06 +02:00
f59eabdf8f
Core/Scripts: Move condition for 'npc_marin_noggenfogger' gossip menu option to DB and remove 'npc_marin_noggenfogger' script
2014-03-19 18:43:39 +02:00
38c33f687c
Core/Scripts: Move condition for 'npc_skorn_whitecloud' gossip menu option to DB and remove 'npc_skorn_whitecloud' script
2014-03-19 12:12:59 +02:00
4bcbcf53d8
Core/Script: Logical fixes
2014-03-19 10:05:02 +01:00
c31ffd774e
Core/Scripts: Move 'The Defias Traitor' script to SAI
2014-03-18 08:31:23 +02:00
f8938c2092
Merge pull request #11718 from untaught/master
...
Instance Script/Stratholme: Correct logic in Baron Run event and add SAI...
2014-03-16 21:40:35 +01:00
f26a028d97
Core/Misc: Fix some static analysis issues
...
Fix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed.
2014-03-16 14:18:33 +01:00
5f7e0f6929
Instance Script/Stratholme: Correct logic in Baron Run event and add SAI for Ysida Harmon
2014-03-16 08:47:27 +02:00
a1aa4547b3
Scripts/Krikthir the Gatewatcher: Fix EVENT_ANUBAR_CHARGE event not being triggered
...
Fix EVENT_ANUBAR_CHARGE not being triggered due to value 0 being set to the EVENT_ANUBAR_CHARGE enum, even if 0 is a special value for EventMap to specify no event was triggered.
Issue added in a127c0e1a7
2014-03-15 20:08:55 +01:00
e30b471f8e
Scripts/AhnKahet: Fix some uninitialized values
...
Initialize all class fields in the constructor, even if they are set in Reset() and they shouldn't be accessed before Reset() is called.
This fixes 2 Coverity reports.
2014-03-15 20:04:59 +01:00
3b247f6bca
Scripts/ZulGurub/Jeklik: Add missing "break"
2014-03-15 19:45:44 +01:00
ba28b16d2e
Scripts/TheStormPeaks: Possible crash fix
...
Apply safe NULL checks added in 7d881a0739
2014-03-09 17:17:12 +01:00
d357597270
Scripts/Commands: Fix crash in ".kick" command
...
Fix a NULL dereference exception happening when using .kick command caused by a strtok(NULL) call without a previous call to the string to be tokenized.
Issue added in 101cad1f28
2014-03-09 17:09:15 +01:00
38c31711c0
DB/Quest: Good Help is Hard to Find script
...
Good Help is Hard to Find (14069) quest script
2014-03-05 20:27:33 +01:00
3a40d8a887
Core/Player: delete queststatus (weekly/monthly/seasonal) on deleting character thx @Expecto
...
- also rename some prepared statements
Closes #11658
2014-03-02 00:00:39 +01:00
61890bce7c
Scripts/Onyxia Lair: Fix debug assertions about iterators
2014-02-26 21:44:51 +01:00
50d99005a5
Scripts/Ulduar: Fix Algalon the Observer outro phase(fixes kill credit and some achieves).
2014-02-16 02:27:44 +02:00
6907d51b6b
Scripts/Kelthuzad: move spells into spelldifficulty_dbc and cleanup
2014-02-15 23:18:54 +01:00
b72273014f
Core/DB/Achievements:
...
- fixed arena season title achievements and rewards
- added mailtemplate support for `achievement_reward` table
- fixed typo in GetBattleMasterBG which causes achievement reward mail expire in 1 day
Ref #8777
2014-02-10 00:14:29 +01:00
a5a6799b4e
Scripts: Added missing stuff in 1d1aeda86c
2014-02-09 19:15:17 +01:00
1d1aeda86c
Core: Fix build
2014-02-09 19:01:56 +01:00
6688370513
Merge pull request #11457 from MitchesD/krikthir
...
Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimalization
2014-02-09 18:46:26 +01:00
a127c0e1a7
Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimization
2014-02-09 18:41:37 +01:00
aaa4b3a124
Scripts/Eastern Plaguelands: Fix flypath exploit
...
Fix npc id 17209 in Eastern Plaguelands enabling taxi cheat to players just by talking to it.
2014-02-08 17:22:29 +01:00
c9122f9f99
Add goblin mount vendor
2014-02-07 08:17:40 +01:00
b000fdca70
Core/Entities: allow interaction with gameobject questgivers if player can take or return quests
...
Closes #11269
Closes #8898
Closes #10204
Closes #11410
Closes #7053
Closes #6189
Closes #9474
2014-02-06 21:23:18 +01:00
6b4e476111
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
2014-02-01 21:18:28 +01:00
2df3fe3a00
Core/Scripts: Fix quest The Totem of Kar'dash alliance version.
...
Remove some hungarian notation for horde side version.
Closes #11035
2014-02-01 19:07:48 +02:00
224da47952
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
...
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Player/Player.h
src/server/scripts/Spells/spell_dk.cpp
2014-01-31 23:51:07 +01:00
a242662ae6
Core/Spells: Fix DK Ghoul's damage after ad8eb434c0. I misread 'SpellScript::m_damage' for 'SpellScript::damage'.
...
By @joschiwald
2014-01-31 10:37:55 +01:00
856e0933b5
Scripts/HoR: Fix log error
...
Fix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
2014-01-30 21:29:37 +01:00
9316b94786
Fix non pch build
2014-01-30 18:19:53 +01:00
57181aca56
Core/Spells: fix Ancient Hysteria and Time Warp thx @yousefscof and @gigatotem
...
Closes #11018
2014-01-30 18:08:14 +01:00
ad8eb434c0
Core/Misc: Missing changes and get rid of useless method in acd46085d1
2014-01-30 10:28:05 +01:00
acd46085d1
Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscripts
...
Closes #1719
Closes #3186
2014-01-30 02:40:12 +01:00
a7c15e7368
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
2014-01-27 23:13:53 +01:00
166f7d41da
Core/Spells: addition to 96060bf007
2014-01-27 23:01:37 +01:00
55c7cfaf4c
Core/Spells: update judgement spellscript thx @Xanvial
...
Closes #10562
Closes #9477
Closes #9801
2014-01-27 19:50:07 +01:00
df6f300542
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
...
Conflicts:
src/server/scripts/Spells/spell_paladin.cpp
2014-01-27 18:44:07 +01:00
6dc15294e2
Core/Spells: move paladins judgements to spellscripts
2014-01-26 23:56:53 +01:00
7cc4828554
Merge branch 'master' of github.com:TrinityCore/TrinityCore into 4.3.4
...
Conflicts:
src/server/game/Entities/Player/Player.cpp
src/server/game/Entities/Unit/Unit.cpp
src/server/game/Spells/Spell.cpp
src/server/scripts/EasternKingdoms/ZulGurub/boss_jeklik.cpp
src/server/scripts/Spells/spell_paladin.cpp
src/server/scripts/Spells/spell_priest.cpp
src/server/scripts/Spells/spell_shaman.cpp
src/server/scripts/Spells/spell_warrior.cpp
2014-01-26 18:22:06 +01:00
Shauren