Commit Graph

2033 Commits

Author SHA1 Message Date
treeston 677309743a Scripts/UtgardeKeep: Bonus Ingvar the Plunderer fixes to reset behavior. There should no longer be weirdness if a reset happens during the RP phase.
(cherry picked from commit 815f43be7a)
2016-04-02 16:46:13 +02:00
treeston 61d216593c Scripts/UtgardeKeep: Ingvar updates:
- Roar at start of phase two
- Ingvar no longer does a weird move-jump towards his target when resurrecting
- Fixed a duplicate yell on phase one end

(cherry picked from commit c829fc7de4)
2016-04-02 16:46:01 +02:00
Keader 6005b3a5c5 Fix Kinetic Bomb stuck after knockback effect.
(cherry picked from commit 36648d1079)
2016-04-02 15:31:27 +02:00
joschiwald 9a202dfd4a Scripts/ICC/Teleporter: moved gossips to db
(cherry picked from commit ea38a7d95b)
2016-04-02 14:10:19 +02:00
treeston 5fb88c7121 Merge branch '3.3.5-boundaryagain' into 3.3.5-base (PR #16270)
(cherry picked from commit 1050b68899)
2016-03-22 23:37:02 +01:00
treeston e2f2c70ba4 Merge branch '3.3.5-bossboundary' into 3.3.5-base (PR #16089)
(cherry picked from commit 5b8b8c6530)
2016-03-22 22:56:43 +01:00
joschiwald 77e32e3af5 Scripts: Added combat abilities to trash mobs in Ruby Sanctum
Thx @sirikfoll

SAI by @Keader

Closes #16703

(cherry picked from commit ef7a91d193)
2016-03-20 22:23:40 +01:00
Naios 5534915f74 Core/Scripts: Split the huge scriptloader into smaller pieces
* Each subdirectory contains it's own translation unit now
  which is responsible for loading it's directory
* Improves merging & decoupling between 3.3.5 <-> 6.x
* Removes unused Battleground loader
* Ref #15671
2016-02-21 15:36:41 +01:00
joschiwald 3ac2ba721d Core/Gossips: added some sanity checks to prevent duplicate interaction
(cherry picked from commit 8b6954e81b)

Scripts: addition to 8b6954e81b

Closes #16466

(cherry picked from commit b259d5c2bc)
2016-02-06 18:16:11 +01:00
jackpoz 8f13fe9c3b Scripts/ICC: Fix static analysis issue
Fix an issue reported by static analysis

(cherry picked from commit 4191bb868a)
2016-01-20 22:01:17 +01:00
Francesco Borzì 6c3f2b9d9b Merge pull request #16208 from ShinDarth/putricide-fix
[3.3.5] Scripts/ICC: Fixed Professor Putricide
(cherry picked from commit 3e42d83e9c)
2016-01-20 21:56:55 +01:00
Killyana a56f92e889 Script/Creature: Imprisoned Beryl Sorcerer
Add missing emote state
Move the credit quest on the 5th hit instead of the 7th one

(cherry picked from commit 13e509a622)
2016-01-17 14:04:51 +01:00
Golrag 6e832dd92b Scripts/ICC: * Bosses now enter when in aggro range.
* Removed some of the MoveInLineOfSight calls
* Added more AreaTriggerScripts

(cherry picked from commit ce90e30a80)
2016-01-16 12:58:22 +01:00
treeston 8d428e4b6b Scripts/Naxxramas: Instructor Razuvious rework:
- Fix missing yells
- Rearrange existing yells to match live
- Sniffed positions for adds
- Improve add respawn handling
- Make adds not fight the player for control (don't use their spells on their own etc.)
- Update adds' hotbar keys to match live (this will affect other creatures with nonsequential possess keys as well)
- Fix adds' movement when mind controlled, they no longer move automatically when right-clicking (this affects all mind-controlled creatures)
- Blizzlike timers

(cherry picked from commit 54d583b0fb)

# Conflicts:
#	src/server/game/Spells/SpellMgr.cpp
2016-01-16 12:26:13 +01:00
treeston d3ea8c5750 Scripts/Naxxramas: Maexxna cleanup:
- Improved Web Wrap target selection
- Added missing text
- Cleanup of web wrap positioning - two players will never be flung to the same position (25-man)
- Further improvement to web wrap spawn behavior - targetable web wrap now only spawns after the player has finished being flung to the respective position (blizzlike)
- Add additional web wrap positions (sniff)

(cherry picked from commit 5dd6163387)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_maexxna.cpp
2016-01-15 21:09:46 +01:00
jackpoz 2f1bd93c9e Core/Unit: Add Unit::KillSelf() overload
Add Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.

(cherry picked from commit 3267c90102)

# Conflicts:
#	src/server/game/AI/SmartScripts/SmartScript.cpp
2016-01-15 20:34:27 +01:00
MitchesD 43d5d118b2 Core/Misc: fix warning and misc codestyle fixes
(cherry picked from commit 3b90b0368a)
2016-01-15 19:57:34 +01:00
treeston bac8c4376f Scripts/Naxxramas: Thaddius follow-up:
- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)

(cherry picked from commit bf99630399)
2016-01-15 19:54:49 +01:00
Carbenium 0b0b014fad Script/Naxxramas: Fix a -Winconsistent-missing-override warning reported by clang 3.6
(cherry picked from commit f01ef901ef)
2016-01-15 19:45:24 +01:00
tkrokli b1a5b9ac75 Scripts/Thaddius: Coverity scan Control flow issues (MISSING_BREAK)
Coverity scan defects CID 1339315, 1339316 and 1339317:
- CID 1339315: boss_thaddius.cpp: 542
- CID 1339316: boss_thaddius.cpp: 811
- CID 1339317: boss_thaddius.cpp: 398

Added missing break; statements.

(cherry picked from commit 95d6f09243)
2016-01-15 19:44:38 +01:00
treeston 43ae580a47 Scripts/Naxxramas: Complete rewrite of the Thaddius encounter.
(cherry picked from commit 29feae5901)
2016-01-15 19:43:42 +01:00
Vincent-Michael 478cc756eb Update copyright note for 2016
Happy new year (Again new year with idiots ...)
2016-01-01 00:34:25 +01:00
jackpoz baa52438e6 Scripts/EyeOfEternity: Fix crash
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900

(cherry picked from commit 6e296ddaa2)
2015-12-12 03:08:16 +01:00
Vincent-Michael 00b4e8b6cc Scripts: Added missing overrides 2015-11-15 03:38:02 +01:00
Carbenium 230e820898 Core/Creature: Remove duplicate call to LoadCreatureAddons in Creature::Create
* Add error log for duplicated aura entries in creature_(template_)addon

(cherry picked from commit c5f635b689)

Conflicts:
	src/server/game/Entities/Creature/Creature.cpp
	src/server/game/Globals/ObjectMgr.cpp
2015-11-14 04:22:42 +01:00
Killyana 286f0ea6f3 Scripts/ICC: moved saurfang gossips to db
Closes #14904

(cherry picked from commit 7225b7abf1)
2015-11-06 13:17:54 +01:00
MitchesD 81ce5acb34 Core/Scripts: fix build after recent cherry picks 2015-11-06 11:28:35 +01:00
sirikfoll d4b3b1d1d2 DB/CORE Minor change in quest Kick, What Kick? and some codestyle
Remove the line that despawns the 'Apple' npc, this despawn is non-blizzlike and breaks the quest.
Thx Killyana for sql and valuable information

Closes #15480

(cherry picked from commit 22f1d26986)
2015-11-06 11:11:16 +01:00
treeston 6d14c4871f Scripts/Naxxramas: Anub'rekhan encounter cleanup.
- Cleaned up events behavior to use phases instead of weird checks for auras.
- Cleaned up Crypt Guard despawn behavior, they should no longer despawn instantly upon death.
- Moved initial greeting from MoveInLineOfSight hack to proper areatrigger script.
- Fixed Crypt Guard respawn behaviour to prevent pulling them before Anub'rekhan has fully reset.
- Fixed Crypt Guard aggro behaviour to call for help on aggro. This prevents pulling the initial pair of Crypt Guards without engaging the boss.
- Added missing boss emotes.
- Code style cleanup.

(cherry picked from commit 91de0322bb)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_anubrekhan.cpp
2015-11-06 11:07:31 +01:00
treeston b6ac8c577c Scripts/Naxxramas: Faerlina cleanup:
- Move greeting to areatrigger instead of MoveInLineOfSight hack
- Clean up add spawn handling to prevent various glitching with combinations of evade state and add aggro
- Ensure all adds are always pulled alongside the boss and vice versa
- Add missing texts.
- Fix a bug in the core that prevents castable-while-dead spells (such as Widow's Embrace) from appearing on possess bars.

(cherry picked from commit 577fcf356e)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_faerlina.cpp
2015-11-06 10:59:34 +01:00
jackpoz 5f5ac9630c Scripts/Naxxramax: Fix clang warning
(cherry picked from commit da0671f4fe)
2015-11-06 10:56:27 +01:00
Rushor 9483bd9180 Scripts/IcecrownCitadel: Quest 'Blood Quickening' - Add Killcredit in 25ManRaid
closes #15733

(cherry picked from commit c5641a9a58)
2015-11-06 10:35:29 +01:00
treeston a37e6e20c8 Scripts/Naxxramas: Loatheb follow-up:
- Fix Deathbloom (for real this time)

(cherry picked from commit 17fdb1e091)
2015-11-06 09:54:40 +01:00
Naios 0b6f784591 Core/AI: Convert the hardcoded variadic RAND functions into one C++11 variadic template version. 2015-11-01 14:33:31 +01:00
joschiwald 92b08fc74b Scripts/VioletHold: rewrote the whole instance
thanks @MitchesD for help

(cherry picked from commit df21162fe4)
(cherry picked from commit 3a4f54197c)
(cherry picked from commit f50df72820)
(cherry picked from commit 95bae7143f)
(cherry picked from commit 5406f82044)
2015-11-01 13:09:30 +01:00
joschiwald b459b10b0f Core/Scripts: fixed startup errors
Closes #14730

(cherry picked from commit 497aa4425b)

# Conflicts:
#	src/server/scripts/Northrend/Ulduar/Ulduar/boss_flame_leviathan.cpp
2015-10-30 14:01:26 +01:00
treeston 7886fafbdc Heigan cleanup:
- NearTeleportTo hack -> proper spell with DB coordinates
- Add boss emotes
- Some code streamlining using event phases and IN_MILLISECONDS instead of large constants
- Improvement to eruption hitbox and delimiters to match retail layout more closely
- Spell timers adjusted from sniffs

(cherry picked from commit 3e2014a958)
2015-10-30 12:24:26 +01:00
treeston f3b5bdc0b3 Scripts/Naxxramas: Bugfixes to the Noth encounter.
- Added missing raid boss emotes
- Fixed an issue where Noth would stand idly after blinking if his current target stood still
- Fixed some reset edge cases
- Prevent Noth from dying during Balcony phase
- Fix targeting of 25-man Curse of the Plaguebringer (now has 8 targets, down from 10)
- Fix balcony/ground phase durations to be blizzlike
- Fix an issue where summoned mobs would sometimes not be aggroed automatically
- Get rid of ugly millisecond values in favor of seconds times constant
- Moved the chance to yell on kill to the database
- Prevent AoE abilities from hitting Noth during the balcony phase
- General cleanup of events handling
- Generally make @Nayd happy

(cherry picked from commit 3fc1bb1abf)

# Conflicts:
#	src/server/scripts/Northrend/Naxxramas/boss_noth.cpp
2015-10-30 11:46:37 +01:00
treeston dba753b0ef Scripts/Naxxramas: Adjustments to the Loatheb encounter
- Adjusted doom cast timings as per boss mod timers.
- Add Deathbloom's final tick using spellscript
- Move Spores' Fungal Creep cast handling to Loatheb's cpp instead of handling it in SmartAI
- Fungal Creep should also be cast if the spore expires (important for Spore Loser achievement)
- Remove Fungal Creep from players on reset to avoid cheesy strats

(cherry picked from commit ea1c783b84)
2015-10-30 11:42:19 +01:00
treeston 12e90350e4 Script/BoreanTundra: Fix dialog and final waypoint for quest 11570: "Escape from the Winterfin Caverns"
This fixes the following bugs:

Escortee NPC quotes are out of order (see #15396 (comment))
Final escort waypoint is located incorrectly and causes the escorted NPC to drop all the way to the bottom of the ocean before quest completion is awarded.

Closes #15396

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
(cherry picked from commit a83437af3d)
2015-10-20 15:39:42 +02:00
joschiwald 2bc4dea4da Core/Misc: renamed sGossipSelect parameters
(cherry picked from commit ad38c27124)

# Conflicts:
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/Kalimdor/zone_azshara.cpp
2015-10-16 11:56:53 +02:00
joschiwald cf1e80e3d0 Core/Misc: removed some useless map checks 2015-10-04 14:53:05 +02:00
Shauren 3bc3b67a8f Core/Player: Changed ranged weapons to be equipped in main hand slot instead of no longer used ranged slot
Closes #14675
Closes #15296
2015-09-27 00:06:08 +02:00
Shauren 5cf28316ff Merge pull request #15503 from Treeston/3.3.5-patchwerk
Creature/BossAI/Patchwerk: Fix Hateful Strike behavior
(cherry picked from commit ce2aa49715)
2015-09-25 00:09:34 +02:00
treeston 888c4c07b6 Scripts/Naxxramas:
Fixed bugs with Sapphiron encounter:
- Sapphiron will now properly re-engage if the previous attempt ended while he was in flight.
- Sapphiron will now properly be hovering while in the air phase instead of standing idly on the ground.
- Move Frost Resistance achievement check from custom script to spell 60539 (Sapphiron Achievement Check), thanks to @Shauren for the heads up.

(cherry picked from commit a90ae075c9)
2015-09-25 00:07:34 +02:00
jackpoz f2ca107fc8 Scripts/Ulduar: Fix issue reported by static analysis
Coverity defect ID: 1316690

(cherry picked from commit 4cdab0cdcb)
2015-09-25 00:06:30 +02:00
joschiwald 010b2182c1 Scripts/Ulduar: fixed sara get killed by guardians of yogg saron
(cherry picked from commit 2b21fbb58e)
2015-09-24 23:29:23 +02:00
joschiwald a3732aea48 Scripts/Ulduar: fixed hodir kill credit
Closes #15303

(cherry picked from commit 30fc4f9f63)
2015-09-24 22:35:33 +02:00
jackpoz 0fad953852 Scripts/Misc: Replace some unsafe WorldObject* class members in scripts with ObjectGuid
Replace some unsafe WorldObject* class members and derived types in scripts with ObjectGuid.
Code cleanup.

(cherry picked from commit 2f92a2f58e)

Conflicts:
	src/server/scripts/Northrend/Nexus/Nexus/boss_keristrasza.cpp
2015-09-24 22:34:18 +02:00
jackpoz 6193b8a28d Scripts/Misc: Fix possible crash
Fix possible NULL-dereference exception happening in PlayerOrPet checks used in Ulduar and Temple Of Ahn Qiraj

(cherry picked from commit 5f0f152345)
2015-09-24 20:39:42 +02:00