Commit Graph

259 Commits

Author SHA1 Message Date
Spp- 3fac9914be Core: Code cleanup (here and there) 2011-09-05 14:01:50 +02:00
Nay fd5ab97774 Core/Spells: Fix Distract. Closes #155 2011-09-04 01:58:44 +01:00
Chaplain bea649d045 Core: cleanup.
*remove some garbage
*little bit moore const func
*fix process of args in vmap3_extractor
2011-09-01 22:38:32 +03:00
QAston 8e392440cf Core/Spells: Fix a regression of 7f30ac5a95 - spells with TARGET_SELECT_CATEGORY_CHANNEL target type (like mind sear) should be triggered by triggering spell caster 2011-08-26 12:39:50 +02:00
QAston 7f30ac5a95 Core/Spells: Add a generic way of selecting spell explicit targets. Make explicit targets independant of calling convention in core - this makes targets sent to client to be much more blizzlike than before (for example CastSpell(Unit*) won't set TARGET_FLAG_UNIT for spells which are not using explicit unit target) for SMSG_SPELL_START packets. Also remove hacks, which became obsolete with this commit. 2011-08-24 08:08:33 +02:00
Chaplain fb27848510 Core: Clean up here and there.
*replase postfix iterator increment\decrement with prefix in cycles
*replase strlen(*char) != 0 with *char[0] != '\0'
*replase strlen(rStr.c_str()) with rStr.length()
2011-08-23 18:09:08 +03:00
QAston e2d8faea09 Core/Spells: move Cannibalize and Carrion Feeder cast checks to SpellScripts. 2011-08-20 00:30:38 +02:00
tobmaps cd03dadb7f Core/Misc: Minor code cleanup and code style fix 2011-08-20 04:43:01 +07:00
Machiavelli 917ffdffac Core/Spells: More research on SPELL_ATTR6_ONLY_CAST_WHILE_POSSESSED and implement new research (original caster should be charmer or owner) and implement QAston's earlier research (only castable while possessed). 2011-08-18 20:28:07 +02:00
QAston a077a26aa5 Core/Spells: update the core to the changes from 1fb1988d46 . To make your custom code work with those changes simply lookup the value of Targets enum value from prev rev, and update the name in your code. 2011-08-16 19:44:18 +02:00
Nay a39ea8f3e5 Core/Spells: - Apply proper unit flags to summoned minions
- SPELL_AURA_MOD_REPUTATION_GAIN spells (e.g Diplomacy) should increase reputation gained from spells (e.g Commendation Badges)
2011-08-06 17:22:24 +01:00
Spp 1c882084f3 Core: Cosmetic changes in Threat related code (per request) and remove of extra call to SpellMgr singleton inside that singleton 2011-08-04 13:16:09 +02:00
Silinoron 0c2cd78400 Core/Refer-a-Friend: Fix a glitch in the summoning system. Thanks gyullo. 2011-08-03 15:21:08 -07:00
Silinoron 76fe596160 Core/Refer-a-Friend: Finish base work for Refer-a-Friend.
Any testing would be very much appreciated.
2011-08-03 09:28:12 -07:00
Spp e7327e7e94 Core: Fix compile without PCH and fix some warnings 2011-08-03 11:23:08 +02:00
Spp- fcdd4d784f Core/Transport: Minor optimization in LoadTransports (And some cosmetic changes here and there in other files) 2011-08-03 08:18:24 +02:00
Machiavelli ff3c988ee7 Core/Entities: Allow Shaman totems to crit with spells, and add a temp workaround to make Fire Elemental Totem spawn crit with spells also.
Closes #252
Closes #1846
2011-08-01 18:30:00 +02:00
Machiavelli c074be2944 Core/Spells: Small update to TriggeredFlags and fix Glyph of Totem of Wrath with it.
Closes #2458
2011-07-31 23:47:11 +02:00
Machiavelli d4a68025c7 Core/Spells: Fix Shaman talent Storm, Earth, Fire (Earthgrab part) in case of using Earthbind totem trough Call of the Elements etc. 2011-07-31 21:58:27 +02:00
Machiavelli 58f10c74f7 Core/Spells: Change low level bool triggered with bitmask TriggerCastFlags to better manipulate the behaviour of certain triggered spells. 2011-07-31 21:58:25 +02:00
Machiavelli 8ceb780213 Core/Spells: Fix Shaman totem bar exploit that would allow the player to cast any spell when using Call of the Elements etc.
Original patch by 3kids

Closes #2356
2011-07-31 14:12:53 +02:00
QAston 495ead5f7f Revert "Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura)"
This reverts commit 07badd7385.
2011-07-28 23:44:39 +02:00
QAston 07badd7385 Core/Spells: Fix a crash on checking school immunity added to unit manually (not by aura) 2011-07-28 23:41:29 +02:00
QAston 4c8c0ce193 Core/Spells: Use correct spell target in Spell::EffectEnvirinmentalDMG - fixes area damage of spells using this. 2011-07-27 21:23:15 +02:00
QAston 46851c3fda Core/Spells: Drop obsolete code for Demonic Sacrifice. 2011-07-27 20:37:28 +02:00
Shauren b9a6e2333c Core/Spells: Removed implicit casts from SpellImplicitTargetInfo, fixed copypaste mistakes and one crash 2011-07-27 12:35:59 +02:00
QAston b0fe236265 Core: Use new SpellInfo class in core. Sadly, this commit is not compatibile with some of the custom code. To make your code work again you may need to change:
*SpellEntry is now SpellInfo
*GetSpellProto is now GetSpellInfo
*SpellEntry::Effect*[effIndex] is now avalible under SpellInfo.Effects[effIndex].*
*sSpellStore.LookupEntry is no longer valid, use sSpellMgr->GetSpellInfo()
*SpellFunctions from SpellMgr.h like DoSpellStuff(spellId) are now: spellInfo->DoStuff()
*SpellMgr::CalculateEffectValue and similar functions are now avalible in SpellEffectInfo class.
*GET_SPELL macro is removed, code which used it is moved to SpellMgr::LoadDbcDataCorrections
*code which affected dbc data in SpellMgr::LoadSpellCustomAttr is now moved to LoadDbcDataCorrections
2011-07-26 23:09:28 +02:00
insider42 17c2c122da Core/Spells: Fix Glyph of Shadow Word: Death 2011-07-25 01:50:46 +07:00
tobmaps a0f1a5c789 Core/Spells: Removed remaining part of old global cooldown handler 2011-07-23 03:30:43 +07:00
Shauren 74e2d981ac Core/GameObject: Refactored destructible building handling, properly implemented spell effect repair 2011-07-22 21:22:05 +02:00
tobmaps 4c9269cd54 Core/Spells: Fix talent Deep Wounds. Original idea by DrTenma
Closes #395
Closes #954
Closes #1188
2011-07-23 00:10:44 +07:00
tobmaps dd2990e2a7 Core/Spells: Fix Glyph of Scourge Strike
Closes #391
2011-07-21 20:38:13 +07:00
click 7fe3f55b5e Core: Fix non-PCH build + clean up some sporadic warnings 2011-07-18 14:49:08 +02:00
QAston f35d8c9bc4 Core/Spells: Temporary workaround for Summon Eye of Acherus (this time working) 2011-07-16 08:03:36 +02:00
QAston f70875510a Core/Spells: Drop unrelated manaCostPct check from Spell::EffectPowerBurn and use explicit check instead, fixes some power burn spells. 2011-07-13 20:39:17 +02:00
QAston b9413f08b3 Core/Spells: Define and implement attributes SPELL_ATTR1_CANT_BE_REDIRECTED and SPELL_ATTR1_CANT_BE_REFLECTED, fixes some problems with Grounding Totem and Spell Reflection. 2011-07-13 20:14:55 +02:00
QAston 22135f4d91 Core/Spells: Add a temporary workaround for spell Summon Eye of Acherus(51888) - fixes gameobject cast of the spell after recent changes. 2011-07-09 20:25:32 +02:00
Spp- f874ca6342 Compile fix (typo in ceefc8c3d7) 2011-07-08 11:45:18 +02:00
Spp- ceefc8c3d7 Core/Misc: Replace dynamic_cast<XXX*> with proper ToXXX 2011-07-08 11:12:19 +02:00
QAston 99f917552e Forgotten change from 0dc90a2cbb. 2011-07-07 18:04:35 +02:00
QAston 0dc90a2cbb Core/Spells: use spell caster as a target of spells triggered by SPELL_EFFECT_FORCE_CAST 2011-07-07 18:02:59 +02:00
Spp- e3729950b9 Core: Rename GetDispellMask to GetDispelMask 2011-07-06 13:21:39 +02:00
Nay 19cd259113 Core/Spells: Remove utterly wrong delay on GameObject activate spells 2011-07-05 02:58:14 +01:00
Sarjuuk 81d3ca8027 Core/Spells: Fix Warlock T7 4P Bonus 2011-07-04 06:35:15 +07:00
QAston 2bcf63d387 Core/Spells: don't allow spells which hit target only with SPELL_EFFECT_DUMMY to execute spell triggers on that targets, also cleanup related code a bit. 2011-06-26 00:29:12 +02:00
QAston 3137a82c7c Core/Spells: Cleanup in Spell.h:
- Codestyle (fix function naming) and cleanup changes in SpellCastTargets class, also access variables of this class by getters/setters
 - Move IsQuestTameSpell function to SpellMgr.h
 - Move UnitList typedef to Unit.h
Additionally - add missing copyright notice to SpellAuraEffects.h
2011-06-23 13:28:52 +02:00
tobmaps afd524f36b Core/Misc: Some random cleanups and code style fixes 2011-06-20 04:04:20 +07:00
tobmaps 3a8702b8a4 Core/Spells: Fix Victory Rush
Closes #2020
2011-06-18 01:34:17 +07:00
Shauren 50dbb8c8a5 Core/Spells: Fixed spell effect quest complete when quest was already in target's quest log 2011-06-15 20:46:49 +02:00
Imprtat beac21226c Added check quest conditions in effect EffectQuestComplete(16) 2011-06-15 20:24:47 +03:00