Commit Graph

658 Commits

Author SHA1 Message Date
kaelima 394dbf0cdc Core/Misc: Fix a crash in CalendarMgr::AddAction and initialize some wild pointers. 2012-03-02 12:23:16 +01:00
Machiavelli 6bb689b494 Core/Units: Properly update passenger position if vehicle uses waypoint movement. Fixes e.g. Icefang path 2012-03-01 17:06:41 +01:00
kaelima eb1a2a3672 Core/Object:
- Corrected the flag and use of UPDATEFLAG_LOWGUID.
- Send proper positions for objects on transports.
- Rename UPDATEFLAG_HAS_POSITION -> UPDATEFLAG_STATIONARY_POSITION
- Added some comments
2012-02-29 12:43:59 +01:00
Spp d38bc3a178 Core: Rename GetCreatureInfo to GetCreatureTemplate and minor cleanup here and there 2012-02-27 14:58:47 +01:00
QAston a0de042efe Core/Spells: Remove SpellSelectTargetTypes enum - it's not needed anymore. 2012-02-25 14:07:07 +01:00
Shauren 40cda6b095 Copypaste fix 2012-02-23 13:07:51 +01:00
Shauren dc28b92415 Core: Random cleanup + compile fix 2012-02-23 13:01:16 +01:00
Venugh 1cac01b3df Core/Movement: Use SetWalk(true/false) instead of AddUnit/RemoveUnit. 2012-02-23 11:50:58 +01:00
Machiavelli dc91fc1050 Core/Vehicles: Fix a crash in object update packet builder (need to remove UPDATEFLAG_VEHICLE on Unit::RemoveFromWorld) 2012-02-22 21:50:01 +01:00
Shauren dba27e61a3 Core/Unit: Corrected packet structure in Unit::BuildMovementPacket 2012-02-22 20:00:16 +01:00
Machiavelli c9748aaacc Core/Vehicles: Fix a crash in ~Vehicle. Closes #5366 2012-02-22 16:51:56 +01:00
Machiavelli a3f3058499 Core/Vehicles: Remove some wrong/redundant calls to Unit::ExitVehicle. The aura system already handles it in most places.
Also add some documentation on upcoming work on making passenger exit positions work.
2012-02-22 12:26:05 +01:00
QAston f09b5a6bea Core/Db/Conditions:
-Drop condition CONDITION_SPELL_SCRIPT_TARGET, use other condition types instead
-Change CONDITION_SOURCE_TYPE_SPELL_SCRIPT_TARGET to CONDITION_SOURCE_TYPE_SPELL_IMPLICIT_TARGET:
--allow using this condition for more spell implicit target types (not just ENTRY)
--SourceGroup value for this src type is now effMask and it's now required

Core/Spells: Unify the way implicit targets are handled, fully implement some partially implemented target types, fix some minor bugs found on the way, general improvements and cleanup.
2012-02-21 20:17:45 +01:00
Machiavelli 1aceab6b62 Core/Pets: Fix stay command if pet is currently processing spline movement 2012-02-21 10:41:48 +01:00
MrSmite fb39566f1f Core/Pets: Fix bugged reactstate behaviour after spline system implementation.
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
2012-02-21 10:26:14 +01:00
Machiavelli 16818d7548 Core/Conditions: Convert npc_spellclick_spells data to condition system. This implements CONDITION_SOURCE_TYPE_SPELL_CLICK_EVENT (previous CONDITION_SOURCE_TYPE_UNUSED_18). Wiki needs to be updated accordingly. 2012-02-20 23:25:59 +01:00
QAston 9abc47736f Core/Spells: Changes in code related to spell explicit target redirection (cleanups, added target validation, prevent unexpected behaviour in some cases) 2012-02-19 00:40:55 +01:00
click 5411e1ce52 Core: Clean up whitespace and tabs in the base sourcetree 2012-02-18 16:52:08 +01:00
Kandera c517806a23 Scripts/Spells: Convert code from Spell::EffectDummy to spell scripts. 2012-02-18 12:12:49 +01:00
Manuel Carrasco 85e0f2de5e Core/Unit: Small correction to commit 60adf066d9. 2012-02-16 15:08:27 -03:00
Spp 03c34ee507 Fix a lot of warnings 2012-02-16 13:56:28 +01:00
Manuel Carrasco 60adf066d9 Core/Unit: Solved issues with neutral creatures that were being attacked when they should not be.
Thanks to Subv for the tweaks!
2012-02-14 17:51:28 -03:00
Subv d790adefe0 Codestyle: Renamed some variables to fit codestyle
Signed-off-by: Subv <s.v.h21@hotmail.com>
2012-02-12 20:10:09 -05:00
QAston 5365bd25fa Core/Spells: remove some workarounds about transform spells in corpse explosion script. 2012-02-09 23:27:59 +01:00
kaelima e7cd9f0b4c Core/Movement: Don't send heartbeat message only to self on movementflag update. Should solve some recent issues with vehicles. 2012-02-09 13:41:43 +01:00
QAston a27758207f Merge pull request #5096 from devilcoredev/fix_005
Core/AI: Fix a bug on some pets introdouced in commit 14bc551862
2012-02-07 23:30:41 -08:00
Matthew Goff 7a117dd429 Core/Misc:
- Replace emote magic number by enum
- Added all missing defines from AnimationData.dbc. Minor corrections to existing ones. Standardized some naming and updated cpp files as needed.
- Correct a spell used in AQ
Closes #3787
Closes #5095
2012-02-06 01:22:45 +00:00
Giuseppe Montesanto 9a3a6c7641 Fix a bug introdouced in recent commit. 2012-02-05 21:22:01 +01:00
QAston a2494f569e Merge pull request #5013 from PKX/fix_auras
Core/Auras: Fix Pet & Totem aura stacking
2012-02-05 00:14:53 -08:00
QAston 7be73a0667 Merge pull request #5075 from devilcoredev/fix_004
Core/AI: Fix pet and other types of minion pet attack on targets with Crowd Controls.
2012-02-05 00:13:56 -08:00
Subv2112 31615bdc86 Core/Spells: Add a new parameter to Unit::SelectNearbyTarget to allow excluding a certain unit.
closes #4989
2012-02-04 21:21:51 -05:00
QAston 6b12f39b35 Merge pull request #4821 from devilcoredev/fix_001
Core/AuraScript: Add OnDispel and AfterDispel hook to AuraScript
2012-02-04 06:09:57 -08:00
Giuseppe Montesanto 14bc551862 Fix pet/guardian and other types of minion pet attack on targets with Crowd Controls. 2012-02-04 14:59:17 +01:00
Giuseppe Montesanto 271feb587f Add hook on AuraScript called when an aura is dispelled 2012-02-04 13:32:40 +01:00
QAston 92ad375864 Core/Entities: clarify comment added in c7ea952a47 2012-02-03 22:56:42 +01:00
QAston 7e99e5f094 Core/Spells:
- rename SpellInfo::IsAOE to SpellInfo::IsTargetingArea due to ambiguity of old name.
- add IsAffectingArea function to check whenever spell or it's effects are affecting objects in area and use new function to fix problems with hunter flares.
Closes #3310. Thanks to Kaelima and Warpten for research.
2012-02-03 22:24:03 +01:00
QAston aae833a759 Core/Spells: fix GameObject spell cast on enemies, original patch by Svannon, thanks to horn for research. 2012-02-03 20:07:57 +01:00
QAston c7ea952a47 Core/Entities: Rename UNIT_FLAG_OOC_NOT_ATTACKABLE and UNIT_FLAG_PASSIVE to UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC respectively. New names tell much more about what those flags do. 2012-02-03 18:46:05 +01:00
Shocker 08be716ef8 Core/Misc: Rename UNIT_STAT_* enums to UNIT_STATE_* 2012-02-03 19:02:17 +02:00
Souler eef0c61bbf Script/Spells: Solve problems with argent tournament spells
- Including cleanup in spell_generic
2012-02-01 16:02:58 +01:00
Souler 75992143c1 Scripts/Spells: Fix Argent Tournament mount spells:
* Break-Shield
 * Charge
 * Defend (visual)
 * Mounted duel
 * Faction Pennants when riding argent tournament mounts
Closes #4917.
2012-01-30 00:21:42 +01:00
PKX 727133b049 Core/Auras: Fix Pet & Totem aura stacking
Fixes aura staking for Pet, Totem and other spell effects that do not use SPELL_EFFECT_APPLY_AURA

Signed-off-by: PKX <pkx.icehell@gmail.com>
2012-01-27 15:43:21 +01:00
Vlad 0f383e9cdd Core/Movement: properly set mover for possess/vehicles 2012-01-20 05:11:52 +03:00
Kaelima afc0d72761 Merge pull request #4789 from drskull/master
Spirit Hunt
2012-01-17 21:41:47 -08:00
kaelima 819da8af4d Core/Items: Attempt to fix crash in Player::SplitItem caused by 6a44399852.
And some random cleanup
2012-01-18 06:07:30 +01:00
Machiavelli dbbac0bdaa Core/Movement: Implement spline movement subsystem.
Spline movement controls movements of server-side controlled units (monster movement, taxi movement, etc).
Proper implementation of effects such as charge, jump, cyclic movement will rely on it.
However, need improve our states system before.

Technical changes:

* Added linear, catmullrom and bezier3 splines which based on client's algorthims. They can be reused for proper transport position interpolation.
* Precission increased. There are no more position desync issues since client's position calculation formulas used.
* Now possible to move by paths with multiple points, send whole path to client.

--
Original author of research and implementation: SilverIce. Massive kudos.
Original port for Trinity (ref #4629) Chaplain and Venugh
With the following incremental fixes during my review:

- Restore flightmaster end grid pre-loading
- Fix uninitialized Creature::m_path_id
- Add missing trinity_string entries for .movegens command
- Fix a bug in WaypointMovementGenerator that would trigger unexpected pausing at waypoints for various amounts of time

Known issues:
- Errors like WaypointMovementGenerator::LoadPath creature XXX (Entry: YYYYY GUID: ZZZZZZ) doesn't have waypoint path id: 0.
This is caused by bad DB data. This commit didn't "break" it.

Do not forget to re-run CMake before compiling.
2012-01-14 15:36:07 +01:00
dr.skull 1abb447243 Fix Feral Spirit passive spell Spirit Hunt
Now will heal wolfs too.

Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-01-12 13:16:04 +01:00
Giuseppe Montesanto 885e9fda34 Fix the 'Trueshot Aura' on pet 2012-01-11 12:15:44 +01:00
dr.skull d6ff717b74 Fix Shaman T10 Enhancement 4P Bonus
Signed-off-by: dr.skull <dr.skull@centrum.sk>
2012-01-09 14:31:15 +01:00
Shocker 08bcbc89b0 Merge pull request #4229 from devilcoredev/fix_002
Core/Spells: Fix the spell immunity system to be effect-dependent
2012-01-04 13:41:51 -08:00