Commit Graph

104 Commits

Author SHA1 Message Date
azazel 341e6303ef Core:
* add helping methods for manipulating unit's health and use it where applicable
* fix some conversion warnings and cleanup code (formatting, CRLF, tabs to spaces)

--HG--
branch : trunk
2010-08-26 01:20:57 +06:00
Shocker d3c6edeb4a Correct usage of basePoints in various locations
--HG--
branch : trunk
2010-08-25 03:21:22 +03:00
Shocker b2f542530f Fix Guardian Spirit's healing
--HG--
branch : trunk
2010-08-24 07:49:16 +03:00
Shocker 5e92a8e55a Fix accessories for vehicle player mounts (the vendors on Traveler's Tundra Mammoth for example)
--HG--
branch : trunk
2010-08-24 07:19:29 +03:00
John Holiver fcebd3117a Fix Shaman T10 Ele 2P. Big thanks to Dr.Tenma!!!
Fix Warrior T10 Melee 2P.

--HG--
branch : trunk
2010-08-24 01:01:46 -03:00
silinoron 8649bee17f Replace World::getConfig with World::getFloatConfig, World::getIntConfig, and World::getBoolConfig.
Also fix a warning from a previous commit.

--HG--
branch : trunk
2010-08-23 19:56:47 -07:00
silinoron 1d54b8e3d6 Tabs to spaces...
--HG--
branch : trunk
2010-08-23 16:55:37 -07:00
John Holiver 48bfe264d9 Fix Shaman Tier Bonus
* T9  Ele 4P
* T10 Res 4P
* T10 Enh 2P
* Partially, T10 Ele 2P (need some way to send ¨decrease CD¨ msg to client)

--HG--
branch : trunk
2010-08-23 20:41:54 -03:00
silinoron c09528a6bf Fix spellstealing durations when duration of stolen buff is infinite.
Based on patch by Toni.Shocker.
Fixes issue #3550
Fixes issue #3017

--HG--
branch : trunk
2010-08-23 15:10:27 -07:00
silinoron 1691065162 Damage over time spells should not cause spell pushback.
Based on patch by Toni.Shocker.
Fixes issue #3551

--HG--
branch : trunk
2010-08-23 15:06:51 -07:00
silinoron 29daa0bb84 Glyph of Innervate should return 45% of base mana instead of total.
Patch by Toni.Shocker.
Fixes issue #3553

--HG--
branch : trunk
2010-08-23 14:56:48 -07:00
silinoron e581feb551 Pets should inherit owner's hostility status for the purposes of target checking
Based on patch by Toni.Shocker
Fixes issue #3552

--HG--
branch : trunk
2010-08-23 14:46:10 -07:00
John Holiver 181b995e38 Fix Priest T10 Healer 2P Bonus.
Thanks to Arcane.
Expect more tier bonus fixes. :D

--HG--
branch : trunk
2010-08-23 16:09:09 -03:00
silinoron 5cbae843d5 Core/Game: fix all warnings related to converting doubles and floats.
--HG--
branch : trunk
2010-08-22 12:39:39 -07:00
azazel 399e35f8f5 Core:
* fix "warning C4305: 'initializing' : truncation from 'double' to 'float'" warnings
* fix some other warnings here and there

--HG--
branch : trunk
2010-08-22 23:46:40 +06:00
click 670964803f Core: Fix more warnings, add new function sLog.outStaticDebug() that replaces DEBUG_LOG
--HG--
branch : trunk
2010-08-22 01:57:04 +02:00
Spp a136403dee Core: Remove "suggest parentheses around ‘&&’ within ‘||’" and "suggest parentheses around assignment used as truth value" warnings
--HG--
branch : trunk
2010-08-21 21:54:41 +02:00
Spp c15c605a11 Core: Remove "unused variable 'xxx'" warnings
--HG--
branch : trunk
2010-08-21 21:14:35 +02:00
Spp e7856a831c Core: Remove "enumeration value 'xxx' not handled in switch" warnings
--HG--
branch : trunk
2010-08-21 20:55:31 +02:00
QAston 77bd968c63 *Remove some unused containers from Spell class.
--HG--
branch : trunk
2010-08-21 21:00:06 +02:00
Spp c3343638cb Core: Remove lots warnings:
- All "'xxx' will be initialized after 'yyy' when initialized here"
- Some "unused variable"
- Some "enumeration value 'xxx' not handled in switch"

--HG--
branch : trunk
2010-08-21 20:08:47 +02:00
silinoron d58e19385f Fix combustion crits with area of effect spells - patch by moriquendu.
--HG--
branch : trunk
2010-08-19 10:37:20 -07:00
Shauren a693f49bd1 Vehicles: Prohibit entering vehicle in combat only if it is a multi-passenger mount
Scripts/Icecrown Citadel: Changed Bone Spike id and remove teleport z+3 hack, its a vehicle, thx wowgargamel
Scripts/Icecrown Citadel: Fixed typo in variable name, thx Paradox
Scripts/Icecrown Citadel: Added warning emote for Bone Storm

--HG--
branch : trunk
2010-08-19 16:40:47 +02:00
QAston 30bcf8c659 Scripts/Spell: extend SpellScript class: add target aura accessors and functions which prevent various effects of the spell from being executed. Check out SpellScript.h for details
--HG--
branch : trunk
2010-08-19 14:31:31 +02:00
QAston 2ffe785765 Core/Spells: add SPELL_ATTR_CU_IGNORE_ARMOR to the avalible custom attribute list, make some spells use the attribute. Research made with JohnHoliver and Shauren
--HG--
branch : trunk
2010-08-18 19:26:07 +02:00
enjoi e20a541494 Core/Vehicles: Players cannot enter a vehicle when in combat. Fixes issue 1966.
--HG--
branch : trunk
2010-08-18 06:51:59 +01:00
Shauren 30468a106f Moved battleground achievement scripted checks into scripts
Call ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL updates in code
Implemented achievements: Save the Day, Quick Cap, Warsong Expedience

--HG--
branch : trunk
2010-08-13 13:48:59 +02:00
azazel c6b4309f1e * Unsummon pet if direct control spell expire out of visibility range from owner (base on VladimirMangos changes)
* Move repeating code to separate method

--HG--
branch : trunk
2010-08-12 12:14:32 +06:00
silinoron 0963cb3aea Implement a PlayerScript class with a handful of new hooks:
* OnPVPKill
* OnCreatureKill
* OnPlayerKilledByCreature
* OnPlayerLevelChanged
* OnPlayerFreeTalentPointsChanged
* OnPlayerTalentsReset
* More hooks may be added in the future

--HG--
branch : trunk
2010-08-11 19:52:58 -07:00
QAston 617a56ba29 *Implement spell casting on transports (no more out of range error, etc)
*Add MO transports to ObjectAccessor storage
*Add functions Position::RelocateOffset and Position::GetPositionOffsetTo to help offset manipulations - BIG thanks to azazelkon for creating formulas!
*Add function to output debug info for MovementInfo and SpellCastTargets
*Throw ByteBufferException on incorrect packGUID read
*Add rfinish function to finish bytebuffer read.

--HG--
branch : trunk
2010-08-08 20:32:14 +02:00
click 1f80c7b3c0 Sourcefile sleanups -> tabs to spaces, remove whitespace - also update the cleanupscripts very slightly
--HG--
branch : trunk
2010-08-08 19:45:53 +02:00
XTZGZoReX 9083271a2f * Some singleton renames for consistency:
accmgr -> AccountMgr
objmgr -> ObjectMgr
auctionmgr -> sAuctionMgr
spellmgr -> sSpellMgr
CreatureEAI_Mgr -> sEventAIMgr
achievementmgr -> sAchievementMgr
gameeventmgr -> sGameEventMgr
sInstanceSaveManager -> sInstanceSaveMgr
poolhandler -> sPoolMgr

--HG--
branch : trunk
2010-08-08 05:25:45 +02:00
XTZGZoReX 909e332579 * Rename: BattleGround -> Battleground.
--HG--
branch : trunk
2010-08-08 04:37:24 +02:00
XTZGZoReX 946adf469c *** New core <-> script library interface - complete rewrite of the old one.
* Removed the misdesigned on_events script/hooks.
* Lots of related cleanups and assertions.
* The interface is now fully object-oriented.
** Scripts no longer use function pointers.
** Scripts no longer use the general-purpose Script struct for everything.
** Script types are split into separate classes which must be inherited depending on what functionality is desired.
* Several script types have been added to allow extending functionality in a code-only manner (some script types require
  assignment in the recently added ScriptName columns in the database, though).
** SpellHandlerScript: Wrapper around spell scripts (returns new SpellScript objects (`spell_script_names`.`ScriptName`)).
** ServerScript: Allows scripting events that occur in the network layer.
** WorldScript: Allows scripting certain world-global events.
** FormulaScript: Allows hooking and interfering with core formulas.
** *MapScript: Allows hooking different map types (including world, instance, and battleground maps (`instance_template`.`ScriptName`)).
** ItemScript: Allows scripting of items (like the old interface (`item_template`.`ScriptName`)).
** CreatureScript: Allows scripting of creatures/AI (like the old interface (`creature_template`.`ScriptName`)).
** GameObjectScript: Allows scripting of gameobjects (like the old interface (`gameobject_template`.`ScriptName`)).
** AreaTriggerScript: Allows scripting triggered area triggers (like the old interface (`areatrigger_scripts`.`ScriptName`)).
** OutdoorPvPScript: Script which should return OutdoorPvP objects for use by OutdoorPvPMgr (`outdoorpvp_template`.`ScriptName`).
** CommandScript: Allows extending the in-core command table.
** WeatherScript: Allows scripting of weather changes (`game_weather`.`ScriptName`).
** AuctionHouseScript: Allows scripting of auction events.
** ConditionScript: Allows scripting of conditions (`conditions`.`ScriptName`).
** DynamicObjectScript: Allows scripting of dynamicobjects.
** TransportScript: Allows scripting of transport events (`transports`.`ScriptName`).
* OutdoorPvP objects are now created through scripts. This effectively means that they'll need to be moved to scripts
  before the they're functional again.
* The whole idea with this new interface is to allow expanding core functionality without touching core code. If further
  hooks are needed to expand functionality of the core, let us know; we'll add them, if we agree that it is appropriate
  to do so.
*** NOTE: The scripts project will _not_ build before it has been adapted to the new interface.
*** Thanks to everyone who helped out with related preparations and suggestions!

--HG--
branch : trunk
2010-08-06 19:23:43 +02:00
azazel 4fb3098d18 * Add NULL-pointer check to CharmInfo destructor. Closes issue #3287.
* Remove references to AuctionHouseBot files from win project.

--HG--
branch : trunk
2010-08-06 12:28:37 +06:00
click 0caaa3e478 Revert changes done in r0074e32c2f and r4d86e4199a - fixes buildissues ( if()+reinterpret_cast is faster than dynamic_casts btw )
--HG--
branch : trunk
2010-08-06 03:00:39 +02:00
Shauren c94046b065 Make typecasting methods *really* safe and get rid of redundant typeId/Typemask checks, thanks Zor and Machiavelli for help
--HG--
branch : trunk
2010-08-05 17:01:25 +02:00
QAston 96eb7c513f *Some more research about spell target flags - thanks to Zor for info.
--HG--
branch : trunk
2010-08-04 19:16:44 +02:00
azazel 40e16bbbdb Add gender field to SMSG_WHO packet (author: MaS0n)
Fix compile error

--HG--
branch : trunk
2010-08-04 22:12:43 +06:00
Shauren 362ae2d4c6 Fixed pet talents: Guard Dog and Silverback
Removed pre-3.3.0 code for Improved Cower

Closes issue #3198.

--HG--
branch : trunk
2010-08-04 17:49:23 +02:00
QAston 6353e7dd8c *Update movement enums - thanks to Zor for info.
*Add functions for position data streaming.

--HG--
branch : trunk
2010-08-04 14:39:45 +02:00
QAston 846aa12260 *Fix crashy implementation of aura type 305.
--HG--
branch : trunk
2010-08-04 08:21:58 +02:00
QAston e7ee828fe1 *Update spell_bonus_data for Garrote - by svetilo12.
*Fix build.

--HG--
branch : trunk
2010-08-03 06:36:25 +02:00
QAston 12c339f421 *Add missing Bestial wrath and The Beast Withing immunities after client change. Original patch by Visagalis.
*Little typo from prev rev.

--HG--
branch : trunk
2010-08-03 06:16:59 +02:00
QAston c5a9d3b463 *Add m_duringRemoveFromWorld lock to prevent adding single target auras during or after remove from world process.
--HG--
branch : trunk
2010-08-03 06:11:03 +02:00
silinoron 14827321bf Add support for CreatureAI::DamageDealt used in a Zul'Aman script. Thanks joshwhedon.
--HG--
branch : trunk
2010-08-02 14:18:30 -07:00
QAston 2212eb604d *Add helpers for checking auras present on unit by type and spell affect mask
*Add linked SPELL_AURA_PERIODIC_HASTE to shadowform spell - by dr.tenma

--HG--
branch : trunk
2010-08-01 01:22:13 +02:00
QAston 73b481073d *Fix talent Will of the NEcropolis
*Backout unintentional change from ra299f0b248.

--HG--
branch : trunk
2010-07-31 23:39:03 +02:00
thenecromancer 99efabdbd3 Remove crude check in proc system preventing charges drop in proc system for absorbs.
To preserve effect, code must be placed for charge handler to skip procs with 0 damage.
This code is preventing procs that should happen (like Savage Defense, or CCs)

--HG--
branch : trunk
2010-07-31 13:45:00 +02:00
thenecromancer 06caa4a945 Typo in some function usage
--HG--
branch : trunk
2010-07-31 13:40:32 +02:00