Commit Graph

609 Commits

Author SHA1 Message Date
Shocker 08bcbc89b0 Merge pull request #4229 from devilcoredev/fix_002
Core/Spells: Fix the spell immunity system to be effect-dependent
2012-01-04 13:41:51 -08:00
Shocker 91d51d9474 Merge pull request #4244 from Warpten/master
Core/Spells: Fix Earthen Power
2012-01-04 13:31:45 -08:00
Shocker ecb1bdd7c3 Merge pull request #4489 from devilcoredev/fix_001
Core/Achievemens: Fix 'The Undying' and 'The Immortal' achievements
2012-01-04 13:27:43 -08:00
Shocker 0a17ab2e4c Merge pull request #4314 from drskull/master
Core/Spells: Windfury and Flametongue should proc from abilities
2012-01-04 13:25:43 -08:00
Odyssey 1ad6a5fd00 Core/Misc: Remove some engrish from Unit.cpp log messages 2012-01-04 16:35:57 +01:00
Giuseppe Montesanto bf73409f49 Fix 'The Undying' and 'The Immortal' achievements. 2012-01-01 04:34:14 +01:00
kiper 8299627ed9 Update headers for 2012. HAPPY NEW YEAR!!! 2012-01-01 00:32:13 +01:00
megamage e6a3dc679f Fix a crash caused by 0ac431f52d. Close #4418. 2011-12-23 11:09:09 -05:00
megamage 8cf2062c1f Update grid system. Try to fix some crashes and transport passengers (now they are despawned after a while). 2011-12-20 17:07:09 -05:00
Machiavelli 6c03bf9535 Core/Misc: Some random meaningless Engrish to English conversion in a method name because Discovered is too lazy to do it himself. 2011-12-19 22:06:29 +01:00
Shocker d1bb5b21af Merge pull request #4356 from kandera/fix_TotT
Core/Spells: Fix correct targeting for Tricks of the Trade
2011-12-16 10:38:33 -08:00
kandera c961d3fdb5 Core/Spells: Fix correct targeting for Tricks of the Trade 2011-12-16 11:56:02 -05:00
Gigatotem bd90edc806 Core/Items: Deathbringer's Will and Deathbringer's Will (HC) should proc Haste for a Druid not attack power. 2011-12-16 15:24:14 +00:00
Spp ee8ed0247c Fix typo from previous commit 2011-12-15 16:07:06 +01:00
Spp d59c5e627f Fix warnings 2011-12-15 11:12:15 +01:00
Giuseppe Montesanto 72e48ef8b3 Fix immunity system for many spells. 2011-12-14 16:13:10 +01:00
dr.skull d6ebfa993b Core/Spells: issue/3744
Windfury and Flametongue should proc from abilities

Signed-off-by: dr.skull <dr.skull@centrum.sk>
2011-12-13 19:20:51 +01:00
Machiavelli 957cb005f5 Merge pull request #4294 from Warpten/warrior
Core/Spells: Fix Warrior's T10 4P DPS Bonus.
2011-12-12 12:05:05 -08:00
Kapoeira cb5ad13906 Core/Spells: Fix Warrior's T10 4P DPS Bonus. 2011-12-12 14:54:19 -05:00
Kaelima e34eda37c7 Merge pull request #4257 from Warpten/bleed
Core/Spells: Rake's initial damage is a bleeding effect, it should thus ignore armor.
2011-12-12 11:21:00 -08:00
Kapoeira 761c5c9e2f Core/Spells: Rake's initial damage is a bleeding effect, it should thus ignore armor.
So far this is the only example of such a mechanic (3.3.5), so this does not break anything.
2011-12-10 14:50:37 -05:00
kaelima 11fb0beaf0 Core/Misc: Fixed some duplicate checks for player typeid in Unit::Kill and Spell::EffectSummonDeadPet. Also some random cleanup 2011-12-10 13:48:41 +01:00
Kapoeira 5d7003a28b Core/Spells: Fix Earthen Power. 2011-12-10 00:35:33 -05:00
Shocker b05317650b Core/Misc: Small changes after recent pulls 2011-12-08 19:56:50 +02:00
Shocker b59e5079be Merge pull request #4195 from kandera/fix_GlyphsofSuccubus
Core/Spells: Fix Glyph of Succubus (wasn't working at all before)
2011-12-08 09:54:56 -08:00
kandera 18aaeaa6be Core/Spells: Tricks of the Trade (fix entier spell. aggro now removed after buff dissapears, correct buffs are placed on both the rogue and the target, both 15% buff and the second threat modifier buff are working as intended) 2011-12-05 13:56:08 -05:00
kandera 2e116cf217 Core/Spells: Fix Glyph of Succubus (wasn't working at all before) 2011-12-05 06:18:25 -05:00
Chaplain 4d65c1e729 Core/Mechanics: Armor penetration improvement. Revamp calculation of SPELL_AURA_MOD_TARGET_ARMOR_PCT 2011-11-26 21:05:27 +02:00
Shocker 01d44a83e3 Merge pull request #4041 from PKX/remove_obsolete
Remove obsolete code and spell_groups
2011-11-26 10:37:22 -08:00
Shauren 358b33239a Core: Fixed remaining C6246: Local declaration of 'x' hides declaration of the same name in outer scope. from previous commit 2011-11-23 19:17:33 +01:00
PKX 47b7e75149 Core/Spells: Removed some obsolete code
This removes some unused and obsolete code:
- "Test of Faith" now doesn't increase crit anymore;
- same goes for "Renewed Hope" (in addition that code isn't working);
- "Ebon Plague" part was deleted from Unit::SpellDamageBonus but not from Unit::MeleeDamageBonus (in addition this code is not working anymore)
- "Blessing of Sanctuary" was working only on melee damage, plus this is not the way it should be fixed

Signed-off-by: PKX <pkx.icehell@gmail.com>
2011-11-23 15:48:01 +01:00
Machiavelli 8444532746 Core/Units: Second part of SMSG_MOVE_SET_COLLISION_HGT implementation: compute proper collision height according to client formulae and send this to the client when mounting up. 2011-11-22 20:28:10 +01:00
megamage 23186b24e2 Merge pull request #3421 from Chipsi/master
Core/Items: Added case for Darkmoon Card: Madness trinket
2011-11-21 14:12:46 -08:00
Machiavelli a14cbcaa3e Core/Units: Partial implementation of SMSG_MOVE_SET_COLLISION_HGT - send proper character collision height on dismount.
Fixes #2642

NOTE: Still have to properly implement collision height calculation for mounting up.
2011-11-21 22:54:25 +01:00
Machiavelli 32bcee40bf Core/Spells: Fix crash in Glyph of Rake 2011-11-20 16:05:41 +01:00
Machiavelli cab3def3a4 Core/Units: Revert previous 3 commits about Unit::_IsValidAttackTarget and Unit::GetReactionn until some conclusive research can be done 2011-11-20 12:56:14 +01:00
Machiavelli 28d1cc9cfe Core/Units: Fix more issues in Unit::_IsValidAttackTarget. (Documentation on changes compared to the client function included) 2011-11-17 19:05:25 +01:00
Machiavelli 8ea8dd4f3d Core/Units: Replace wrong usage of UNIT_FLAG_PVP_ATTACKABLE with UNIT_FLAG_PLAYER_CONTROLLED in Unit::IsValidAttackTarget, Unit::IsValidAssistTarget and Unit::GetReactionTo. Using 4.1 flags in 3.3.5 doesn't always work out like it should... Also remove now unneeded change from 70b558d
Fixes SPELL_AURA_FORCE_REACTION amongst other things
2011-11-16 23:12:31 +01:00
Machiavelli 70b558dd39 Core/Units: Fix Unit::_IsValidAttackTarget (UNIT_FLAG_OOC_NOT_ATTACKABLE check specifically)
Closes #3172
2011-11-16 21:02:37 +01:00
kaelima 163515341e Core/Spells: Fix Item - Hunter T9 4P Bonus 2011-11-13 05:00:26 +01:00
kaelima 9b7e9a1ee3 Core/Movement:
- Lower movement radius and speed when confused/disoriented.
- Force attackstop when confused or feared. Should fix issue with creatures "teleporting" after fear.

Close #2689
Close #466
Close #3743
2011-11-13 02:36:51 +01:00
tobmaps 3569f01adc Core/Spells: Fixed resist calculations for spells with multiple schools. Thx to Shauren for tips
Closes #3875
2011-11-12 04:40:44 +07:00
tobmaps 4c44085dfa Core/Spells: Fix typo in 922a174683 and drop wrong check that breaks Judgements of the Just talent. Thx to Greymane for pointing out problem
Closes #2377
2011-11-11 19:05:12 +07:00
Bootz f75ec5ba2b Core: Codestyle clean-up
"plr"->player

Note: codestyle methods needs maintained, Player* player.
2011-11-07 11:06:39 -06:00
tobmaps 8fd7720318 Core/Misc: Rename Spell::CalcCastTime to Spell::GetCastTime as it does not calculate anything 2011-11-05 05:33:52 +07:00
megamage 1b8d9ec7b4 Clean up summon/remove gameobject code. 2011-10-31 10:46:39 -04:00
kaelima e16e18da23 Core/Spells: Added safe-checks for places where caster/victim can be null.
And some random cleanup
2011-10-31 01:54:44 +01:00
kaelima d5ece59acd Core/Spells: Fixed possible crash for Decimation
Closes #3750
2011-10-30 23:52:38 +01:00
megamage 0ac431f52d Fix a crash caused by spell 49065. Close #3646. 2011-10-24 16:54:52 -04:00
Shocker 10bca6c268 Merge pull request #3596 from ille/master
use effectMask to calculate mechanicMask in ModSpellDuration

Closes #1599
2011-10-24 10:43:47 -07:00