Core/PacketIO: Updated packet structures to 8.0.1

src/server/game/Server/Packets/GuildPackets.cpp

@@ -63,9 +63,9 @@ WorldPacket const* WorldPackets::Guild::QueryGuildInfoResponse::Write()
 
 WorldPacket const* WorldPackets::Guild::GuildRoster::Write()
 {
-    _worldPacket << NumAccounts;
+    _worldPacket << int32(NumAccounts);
     _worldPacket.AppendPackedTime(CreateDate);
-    _worldPacket << GuildFlags;
+    _worldPacket << int32(GuildFlags);
     _worldPacket << uint32(MemberData.size());
     _worldPacket.WriteBits(WelcomeText.length(), 10);
     _worldPacket.WriteBits(InfoText.length(), 11);
@@ -98,8 +98,8 @@ void WorldPackets::Guild::GuildUpdateMotdText::Read()
 
 WorldPacket const* WorldPackets::Guild::GuildCommandResult::Write()
 {
-    _worldPacket << Result;
-    _worldPacket << Command;
+    _worldPacket << int32(Result);
+    _worldPacket << int32(Command);
 
     _worldPacket.WriteBits(Name.length(), 8);
     _worldPacket.FlushBits();
@@ -127,17 +127,17 @@ WorldPacket const* WorldPackets::Guild::GuildInvite::Write()
     _worldPacket.WriteBits(OldGuildName.length(), 7);
     _worldPacket.FlushBits();
 
-    _worldPacket << InviterVirtualRealmAddress;
-    _worldPacket << GuildVirtualRealmAddress;
+    _worldPacket << uint32(InviterVirtualRealmAddress);
+    _worldPacket << uint32(GuildVirtualRealmAddress);
     _worldPacket << GuildGUID;
-    _worldPacket << OldGuildVirtualRealmAddress;
+    _worldPacket << uint32(OldGuildVirtualRealmAddress);
     _worldPacket << OldGuildGUID;
-    _worldPacket << EmblemStyle;
-    _worldPacket << EmblemColor;
-    _worldPacket << BorderStyle;
-    _worldPacket << BorderColor;
-    _worldPacket << Background;
-    _worldPacket << AchievementPoints;
+    _worldPacket << uint32(EmblemStyle);
+    _worldPacket << uint32(EmblemColor);
+    _worldPacket << uint32(BorderStyle);
+    _worldPacket << uint32(BorderColor);
+    _worldPacket << uint32(Background);
+    _worldPacket << int32(AchievementPoints);
 
     _worldPacket.WriteString(InviterName);
     _worldPacket.WriteString(GuildName);
@@ -148,9 +148,9 @@ WorldPacket const* WorldPackets::Guild::GuildInvite::Write()
 
 ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRosterProfessionData const& rosterProfessionData)
 {
-    data << rosterProfessionData.DbID;
-    data << rosterProfessionData.Rank;
-    data << rosterProfessionData.Step;
+    data << int32(rosterProfessionData.DbID);
+    data << int32(rosterProfessionData.Rank);
+    data << int32(rosterProfessionData.Step);
 
     return data;
 }
@@ -158,20 +158,20 @@ ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRosterProfess
 ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRosterMemberData const& rosterMemberData)
 {
     data << rosterMemberData.Guid;
-    data << rosterMemberData.RankID;
-    data << rosterMemberData.AreaID;
-    data << rosterMemberData.PersonalAchievementPoints;
-    data << rosterMemberData.GuildReputation;
-    data << rosterMemberData.LastSave;
+    data << int32(rosterMemberData.RankID);
+    data << int32(rosterMemberData.AreaID);
+    data << int32(rosterMemberData.PersonalAchievementPoints);
+    data << int32(rosterMemberData.GuildReputation);
+    data << float(rosterMemberData.LastSave);
 
     for (uint8 i = 0; i < 2; i++)
         data << rosterMemberData.Profession[i];
 
-    data << rosterMemberData.VirtualRealmAddress;
-    data << rosterMemberData.Status;
-    data << rosterMemberData.Level;
-    data << rosterMemberData.ClassID;
-    data << rosterMemberData.Gender;
+    data << uint32(rosterMemberData.VirtualRealmAddress);
+    data << uint8(rosterMemberData.Status);
+    data << uint8(rosterMemberData.Level);
+    data << uint8(rosterMemberData.ClassID);
+    data << uint8(rosterMemberData.Gender);
 
     data.WriteBits(rosterMemberData.Name.length(), 6);
     data.WriteBits(rosterMemberData.Note.length(), 8);
@@ -190,7 +190,7 @@ ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRosterMemberD
 WorldPacket const* WorldPackets::Guild::GuildEventPresenceChange::Write()
 {
     _worldPacket << Guid;
-    _worldPacket << VirtualRealmAddress;
+    _worldPacket << uint32(VirtualRealmAddress);
 
     _worldPacket.WriteBits(Name.length(), 6);
     _worldPacket.WriteBit(LoggedOn);
@@ -215,7 +215,7 @@ WorldPacket const* WorldPackets::Guild::GuildEventMotd::Write()
 WorldPacket const* WorldPackets::Guild::GuildEventPlayerJoined::Write()
 {
     _worldPacket << Guid;
-    _worldPacket << VirtualRealmAddress;
+    _worldPacket << uint32(VirtualRealmAddress);
 
     _worldPacket.WriteBits(Name.length(), 6);
     _worldPacket.FlushBits();
@@ -249,9 +249,9 @@ WorldPacket const* WorldPackets::Guild::GuildEventLogQueryResults::Write()
     {
         _worldPacket << entry.PlayerGUID;
         _worldPacket << entry.OtherGUID;
-        _worldPacket << entry.TransactionType;
-        _worldPacket << entry.RankID;
-        _worldPacket << entry.TransactionDate;
+        _worldPacket << uint8(entry.TransactionType);
+        _worldPacket << uint8(entry.RankID);
+        _worldPacket << uint32(entry.TransactionDate);
     }
 
     return &_worldPacket;
@@ -269,12 +269,12 @@ WorldPacket const* WorldPackets::Guild::GuildEventPlayerLeft::Write()
         _worldPacket.FlushBits();
 
         _worldPacket << RemoverGUID;
-        _worldPacket << RemoverVirtualRealmAddress;
+        _worldPacket << uint32(RemoverVirtualRealmAddress);
         _worldPacket.WriteString(RemoverName);
     }
 
     _worldPacket << LeaverGUID;
-    _worldPacket << LeaverVirtualRealmAddress;
+    _worldPacket << uint32(LeaverVirtualRealmAddress);
     _worldPacket.WriteString(LeaverName);
 
     return &_worldPacket;
@@ -282,16 +282,16 @@ WorldPacket const* WorldPackets::Guild::GuildEventPlayerLeft::Write()
 
 WorldPacket const* WorldPackets::Guild::GuildPermissionsQueryResults::Write()
 {
-    _worldPacket << RankID;
-    _worldPacket << WithdrawGoldLimit;
-    _worldPacket << Flags;
-    _worldPacket << NumTabs;
+    _worldPacket << uint32(RankID);
+    _worldPacket << int32(WithdrawGoldLimit);
+    _worldPacket << int32(Flags);
+    _worldPacket << int32(NumTabs);
     _worldPacket << uint32(Tab.size());
 
     for (GuildRankTabPermissions const& tab : Tab)
     {
-        _worldPacket << tab.Flags;
-        _worldPacket << tab.WithdrawItemLimit;
+        _worldPacket << int32(tab.Flags);
+        _worldPacket << int32(tab.WithdrawItemLimit);
     }
 
     return &_worldPacket;
@@ -325,9 +325,9 @@ WorldPacket const* WorldPackets::Guild::GuildEventNewLeader::Write()
     _worldPacket.FlushBits();
 
     _worldPacket << OldLeaderGUID;
-    _worldPacket << OldLeaderVirtualRealmAddress;
+    _worldPacket << uint32(OldLeaderVirtualRealmAddress);
     _worldPacket << NewLeaderGUID;
-    _worldPacket << NewLeaderVirtualRealmAddress;
+    _worldPacket << uint32(NewLeaderVirtualRealmAddress);
 
     _worldPacket.WriteString(OldLeaderName);
     _worldPacket.WriteString(NewLeaderName);
@@ -337,7 +337,7 @@ WorldPacket const* WorldPackets::Guild::GuildEventNewLeader::Write()
 
 WorldPacket const* WorldPackets::Guild::GuildEventTabModified::Write()
 {
-    _worldPacket << Tab;
+    _worldPacket << int32(Tab);
 
     _worldPacket.WriteBits(Name.length(), 7);
     _worldPacket.WriteBits(Icon.length(), 9);
@@ -358,15 +358,15 @@ WorldPacket const* WorldPackets::Guild::GuildEventTabTextChanged::Write()
 
 ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRankData const& rankData)
 {
-    data << rankData.RankID;
-    data << rankData.RankOrder;
-    data << rankData.Flags;
-    data << rankData.WithdrawGoldLimit;
+    data << uint32(rankData.RankID);
+    data << uint32(rankData.RankOrder);
+    data << uint32(rankData.Flags);
+    data << uint32(rankData.WithdrawGoldLimit);
 
     for (uint8 i = 0; i < GUILD_BANK_MAX_TABS; i++)
     {
-        data << rankData.TabFlags[i];
-        data << rankData.TabWithdrawItemLimit[i];
+        data << uint32(rankData.TabFlags[i]);
+        data << uint32(rankData.TabWithdrawItemLimit[i]);
     }
 
     data.WriteBits(rankData.RankName.length(), 7);
@@ -416,7 +416,7 @@ WorldPacket const* WorldPackets::Guild::GuildSendRankChange::Write()
 {
     _worldPacket << Officer;
     _worldPacket << Other;
-    _worldPacket << RankID;
+    _worldPacket << uint32(RankID);
 
     _worldPacket.WriteBit(Promote);
     _worldPacket.FlushBits();
@@ -499,25 +499,25 @@ WorldPacket const* WorldPackets::Guild::GuildPartyState::Write()
     _worldPacket.WriteBit(InGuildParty);
     _worldPacket.FlushBits();
 
-    _worldPacket << NumMembers;
-    _worldPacket << NumRequired;
-    _worldPacket << GuildXPEarnedMult;
+    _worldPacket << int32(NumMembers);
+    _worldPacket << int32(NumRequired);
+    _worldPacket << float(GuildXPEarnedMult);
 
     return &_worldPacket;
 }
 
 ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRewardItem const& rewardItem)
 {
-    data << rewardItem.ItemID;
-    data << rewardItem.Unk4;
+    data << uint32(rewardItem.ItemID);
+    data << uint32(rewardItem.Unk4);
     data << uint32(rewardItem.AchievementsRequired.size());
     data << uint64(rewardItem.RaceMask);
-    data << rewardItem.MinGuildLevel;
-    data << rewardItem.MinGuildRep;
-    data << rewardItem.Cost;
+    data << int32(rewardItem.MinGuildLevel);
+    data << int32(rewardItem.MinGuildRep);
+    data << uint64(rewardItem.Cost);
 
-    for (uint8 i = 0; i < rewardItem.AchievementsRequired.size(); i++)
-        data << rewardItem.AchievementsRequired[i];
+    for (std::size_t i = 0; i < rewardItem.AchievementsRequired.size(); i++)
+        data << uint32(rewardItem.AchievementsRequired[i]);
 
     return data;
 }
@@ -529,7 +529,7 @@ void WorldPackets::Guild::RequestGuildRewardsList::Read()
 
 WorldPacket const* WorldPackets::Guild::GuildRewardList::Write()
 {
-    _worldPacket << Version;
+    _worldPacket << int32(Version);
     _worldPacket << uint32(RewardItems.size());
 
     for (GuildRewardItem const& item : RewardItems)
@@ -592,9 +592,9 @@ void WorldPackets::Guild::GuildBankWithdrawMoney::Read()
 
 WorldPacket const* WorldPackets::Guild::GuildBankQueryResults::Write()
 {
-    _worldPacket << Money;
-    _worldPacket << Tab;
-    _worldPacket << WithdrawalsRemaining;
+    _worldPacket << uint64(Money);
+    _worldPacket << int32(Tab);
+    _worldPacket << int32(WithdrawalsRemaining);
     _worldPacket << uint32(TabInfo.size());
     _worldPacket << uint32(ItemInfo.size());
     _worldPacket.WriteBit(FullUpdate);
@@ -602,7 +602,7 @@ WorldPacket const* WorldPackets::Guild::GuildBankQueryResults::Write()
 
     for (GuildBankTabInfo const& tab : TabInfo)
     {
-        _worldPacket << tab.TabIndex;
+        _worldPacket << int32(tab.TabIndex);
         _worldPacket.WriteBits(tab.Name.length(), 7);
         _worldPacket.WriteBits(tab.Icon.length(), 9);
         _worldPacket.FlushBits();
@@ -613,12 +613,12 @@ WorldPacket const* WorldPackets::Guild::GuildBankQueryResults::Write()
 
     for (GuildBankItemInfo const& item : ItemInfo)
     {
-        _worldPacket << item.Slot;
-        _worldPacket << item.Count;
-        _worldPacket << item.EnchantmentID;
-        _worldPacket << item.Charges;
-        _worldPacket << item.OnUseEnchantmentID;
-        _worldPacket << item.Flags;
+        _worldPacket << int32(item.Slot);
+        _worldPacket << int32(item.Count);
+        _worldPacket << int32(item.EnchantmentID);
+        _worldPacket << int32(item.Charges);
+        _worldPacket << int32(item.OnUseEnchantmentID);
+        _worldPacket << int32(item.Flags);
         _worldPacket << item.Item;
         _worldPacket.WriteBits(item.SocketEnchant.size(), 2);
         _worldPacket.WriteBit(item.Locked);
@@ -658,7 +658,7 @@ void WorldPackets::Guild::GuildBankLogQuery::Read()
 
 WorldPacket const* WorldPackets::Guild::GuildBankLogQueryResults::Write()
 {
-    _worldPacket << Tab;
+    _worldPacket << int32(Tab);
     _worldPacket << uint32(Entry.size());
     _worldPacket.WriteBit(WeeklyBonusMoney.is_initialized());
     _worldPacket.FlushBits();
@@ -666,8 +666,8 @@ WorldPacket const* WorldPackets::Guild::GuildBankLogQueryResults::Write()
     for (GuildBankLogEntry const& logEntry : Entry)
     {
         _worldPacket << logEntry.PlayerGUID;
-        _worldPacket << logEntry.TimeOffset;
-        _worldPacket << logEntry.EntryType;
+        _worldPacket << uint32(logEntry.TimeOffset);
+        _worldPacket << int8(logEntry.EntryType);
 
         _worldPacket.WriteBit(logEntry.Money.is_initialized());
         _worldPacket.WriteBit(logEntry.ItemID.is_initialized());
@@ -676,20 +676,20 @@ WorldPacket const* WorldPackets::Guild::GuildBankLogQueryResults::Write()
         _worldPacket.FlushBits();
 
         if (logEntry.Money.is_initialized())
-            _worldPacket << *logEntry.Money;
+            _worldPacket << uint64(*logEntry.Money);
 
         if (logEntry.ItemID.is_initialized())
-            _worldPacket << *logEntry.ItemID;
+            _worldPacket << int32(*logEntry.ItemID);
 
         if (logEntry.Count.is_initialized())
-            _worldPacket << *logEntry.Count;
+            _worldPacket << int32(*logEntry.Count);
 
         if (logEntry.OtherTab.is_initialized())
-            _worldPacket << *logEntry.OtherTab;
+            _worldPacket << int8(*logEntry.OtherTab);
     }
 
     if (WeeklyBonusMoney)
-        _worldPacket << *WeeklyBonusMoney;
+        _worldPacket << uint64(*WeeklyBonusMoney);
 
     return &_worldPacket;
 }
@@ -701,7 +701,7 @@ void WorldPackets::Guild::GuildBankTextQuery::Read()
 
 WorldPacket const* WorldPackets::Guild::GuildBankTextQueryResult::Write()
 {
-    _worldPacket << Tab;
+    _worldPacket << int32(Tab);
 
     _worldPacket.WriteBits(Text.length(), 14);
     _worldPacket.FlushBits();
@@ -724,13 +724,13 @@ void WorldPackets::Guild::GuildQueryNews::Read()
 
 ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildNewsEvent const& newsEvent)
 {
-    data << newsEvent.Id;
+    data << int32(newsEvent.Id);
     data.AppendPackedTime(newsEvent.CompletedDate);
-    data << newsEvent.Type;
-    data << newsEvent.Flags;
+    data << int32(newsEvent.Type);
+    data << int32(newsEvent.Flags);
 
-    for (uint8 i = 0; i < 2; i++)
-        data << newsEvent.Data[i];
+    for (std::size_t i = 0; i < newsEvent.Data.size(); ++i)
+        data << int32(newsEvent.Data[i]);
 
     data << newsEvent.MemberGuid;
     data << uint32(newsEvent.MemberList.size());